[{"id":1765756,"web_url":"http://patchwork.ozlabs.org/comment/1765756/","msgid":"<20170909071846.GU2735@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-09T07:18:46","subject":"Re: [Qemu-devel] [RFC PATCH qemu 2/4] memory: Prepare for shared\n\tflat views","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Thu, Sep 07, 2017 at 07:20:08PM +1000, Alexey Kardashevskiy wrote:\n> We are going to share flat views and dispatch trees between address\n> spaces. This moves bits around but no change in behaviour is expected\n> here. The following patch will implement sharing.\n> \n> This switches from AddressSpace to AddressSpaceDispatch as in many\n> places this is what is used actually. Also, since multiple address\n> spaces will be sharing a flat view, MemoryRegionSection cannot store\n> the address space pointer, this changes it to AddressSpaceDispatch\n> as well. As a not very obvious result, IOMMUTLBEntry also switched\n> from AddressSpace to AddressSpaceDispatch to make\n> address_space_get_iotlb_entry() work.\n\nSo, mostly this seems to be exposing AddressSpaceDispatch in more\nplaces. It's not obvious to me why that's useful.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"UG7HKDjD\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xq5Kn0fWNz9sBW\n\tfor ;\n\tSat, 9 Sep 2017 17:24:29 +1000 (AEST)","from localhost ([::1]:48514 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqa7v-0000W5-3L\n\tfor incoming@patchwork.ozlabs.org; Sat, 09 Sep 2017 03:24:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58749)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqa7K-0000Vp-U3\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 03:23:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqa7J-0005gB-St\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 03:23:50 -0400","from ozlabs.org ([2401:3900:2:1::2]:44011)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqa7J-0005f4-4O\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 03:23:49 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xq5Jx1fCcz9sBW; Sat, 9 Sep 2017 17:23:45 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1504941825;\n\tbh=p+J2rARH3f+LWutz9UP0qnXFQBYT8pT+JldutZcpmyY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UG7HKDjD7y7vKPsqDec/i1VSr0wcyRSeXeZlxbRn9Q5nuMF3eGMjImtzBW8X1AO74\n\tcUNVkkhGe82NVZzmlFUHTJw5mrqxQLJTAN3SPc5xyX7waX4fUvmVsO/YY1lPQUCWc4\n\t0mqv84qqeG2LT8caz6Ow3QDcnfiylJTLNNj5JaPI=","Date":"Sat, 9 Sep 2017 17:18:46 +1000","From":"David Gibson ","To":"Alexey Kardashevskiy ","Message-ID":"<20170909071846.GU2735@umbus.fritz.box>","References":"<20170907092010.3605-1-aik@ozlabs.ru>\n\t<20170907092010.3605-3-aik@ozlabs.ru>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"hLTC+yGFJlatjToQ\"","Content-Disposition":"inline","In-Reply-To":"<20170907092010.3605-3-aik@ozlabs.ru>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2401:3900:2:1::2","Subject":"Re: [Qemu-devel] [RFC PATCH qemu 2/4] memory: Prepare for shared\n\tflat views","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\tPaolo Bonzini , qemu-devel@nongnu.org,\n\tStefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765923,"web_url":"http://patchwork.ozlabs.org/comment/1765923/","msgid":"","list_archive_url":null,"date":"2017-09-10T09:17:13","subject":"Re: [Qemu-devel] [RFC PATCH qemu 2/4] memory: Prepare for shared\n\tflat views","submitter":{"id":7621,"url":"http://patchwork.ozlabs.org/api/people/7621/","name":"Alexey Kardashevskiy","email":"aik@ozlabs.ru"},"content":"On 09/09/17 17:18, David Gibson wrote:\n> On Thu, Sep 07, 2017 at 07:20:08PM +1000, Alexey Kardashevskiy wrote:\n>> We are going to share flat views and dispatch trees between address\n>> spaces. This moves bits around but no change in behaviour is expected\n>> here. The following patch will implement sharing.\n>>\n>> This switches from AddressSpace to AddressSpaceDispatch as in many\n>> places this is what is used actually. Also, since multiple address\n>> spaces will be sharing a flat view, MemoryRegionSection cannot store\n>> the address space pointer, this changes it to AddressSpaceDispatch\n>> as well. As a not very obvious result, IOMMUTLBEntry also switched\n>> from AddressSpace to AddressSpaceDispatch to make\n>> address_space_get_iotlb_entry() work.\n> \n> So, mostly this seems to be exposing AddressSpaceDispatch in more\n> places. It's not obvious to me why that's useful.\n\n\nIt is mostly for IOMMUs - since dispatch tree and flat view is shared among\naddress spaces, I cannot use address spaces in iommu_ops::translate - too\nambiguous - \"use any attached to this flatview/dispatch\" is just confusing.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ozlabs-ru.20150623.gappssmtp.com\n\theader.i=@ozlabs-ru.20150623.gappssmtp.com\n\theader.b=\"Uza2Lx4L\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqlpH6Rbzz9sDB\n\tfor ;\n\tSun, 10 Sep 2017 19:17:58 +1000 (AEST)","from localhost ([::1]:52186 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqyNF-0004FJ-OS\n\tfor incoming@patchwork.ozlabs.org; Sun, 10 Sep 2017 05:17:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46145)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqyMp-0004El-9i\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 05:17:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqyMl-0006qv-Ad\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 05:17:27 -0400","from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:33500)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dqyMl-0006pL-15\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 05:17:23 -0400","by mail-pg0-x244.google.com with SMTP id i130so1288703pgc.0\n\tfor ; Sun, 10 Sep 2017 02:17:21 -0700 (PDT)","from [192.168.10.22] (124-171-136-142.dyn.iinet.net.au.\n\t[124.171.136.142]) by smtp.googlemail.com with ESMTPSA id\n\th70sm11152736pfc.115.2017.09.10.02.17.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 10 Sep 2017 02:17:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ozlabs-ru.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to;\n\tbh=Wky8h3x5yOhKLuJdg2OV5Uin+I3XVSTXVZm4xW2RfPQ=;\n\tb=Uza2Lx4LDYBLv3biAcoe+evcUQN0QAbjfvYz/nFLEBlM3D9RgoyCMZm76Sp8l0K2jN\n\tlgrRE3M0+W/5b+TzTQHfdGHju219aaZQK/R2075tzPkKEdUAmO3vk2Ox26khfAgMKSI6\n\tFbmevmWBI6YgSKOjq35nmQUiLIKxqu4/T3XM30OrrBNK52ZnZZqDxcb0coeD+gfgeJ0q\n\tvJ3sR7fr0shyUAmBNr9Az96BE8M21wpcYlb6M+7PoaoX1rbWf60UpD1AjCTAkpTCVMKM\n\tBdWnMYqrsfZoG5nIleGFEUiPuAA832PYumaKsmPiuCPLnc8t9MA/3LXywW03i10IHwTP\n\thzzA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to;\n\tbh=Wky8h3x5yOhKLuJdg2OV5Uin+I3XVSTXVZm4xW2RfPQ=;\n\tb=MIFtRTTErGfGrGCV9GhbHNlmDU9zL3dTvbDXG8nkbtJdC1cD8oOV8lgzciVFqG1h4B\n\t5mTi0H3ia2/6kroN16Hoy2OE6cn+Jd1gjLMvV0KDhN+6fL64MobXyjJseJuE8PyQi+jT\n\tSFCidFSpBmuRdRDhjQ5NFpQsHiDfE0I90dMB4nc7Xj2/gvw9sfNWD3ZnOWLH6C3+cYBm\n\tw1FlXSdQJFDYRPfyp0j5gODAjdjCs9yPvrOID59ju20q/oSNPQoGGwfM0+es6j+awyQz\n\tP6+8GtcID/fFS7wXx3lvStbPUEoNH2WT5mCNpPfsLGOrTu9LKZHgD2py7UgcQkaIllAX\n\tA3Kg==","X-Gm-Message-State":"AHPjjUjGVaI5xtbI2DchqgssqsZe3sA6ialDA80wIEdEN7vj1hFomBpd\n\tEMCKLQC4VY1Sb/VU","X-Google-Smtp-Source":"ADKCNb7eHPYeTRpCPylU7wc3sOJRQMyxnhE9kirOAgcXDa4t+4XECTLoAaGAx95CmharVV3dGv1/Mw==","X-Received":"by 10.98.160.131 with SMTP id p3mr8596233pfl.260.1505035040261; \n\tSun, 10 Sep 2017 02:17:20 -0700 (PDT)","To":"David Gibson ","References":"<20170907092010.3605-1-aik@ozlabs.ru>\n\t<20170907092010.3605-3-aik@ozlabs.ru>\n\t<20170909071846.GU2735@umbus.fritz.box>","From":"Alexey Kardashevskiy ","Message-ID":"","Date":"Sun, 10 Sep 2017 19:17:13 +1000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170909071846.GU2735@umbus.fritz.box>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"40Eg9JV9PgJVIMRVBCQrh155abaUlCwBm\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::244","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [RFC PATCH qemu 2/4] memory: Prepare for shared\n\tflat views","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\tPaolo Bonzini , qemu-devel@nongnu.org,\n\tStefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]