[{"id":1764623,"web_url":"http://patchwork.ozlabs.org/comment/1764623/","msgid":"<20170907115503.4b67c33f.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-07T09:55:03","subject":"Re: [Qemu-devel] [PATCH] qemu-iotests: Add missing -machine\n\taccel=qtest","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 7 Sep 2017 10:53:10 +0200\nKevin Wolf wrote:\n\n> A basic set of qemu options is initialised in ./common:\n> \n> export QEMU_OPTIONS=\"-nodefaults -machine accel=qtest\"\n> \n> However, two test cases (172 and 186) overwrite QEMU_OPTIONS and neglect\n> to manually set '-machine accel=qtest'. Add the missing option for 172.\n> 186 probably only copied the code from 172, it doesn't actually need to\n> overwrite QEMU_OPTIONS, so remove that in 186.\n> \n> Signed-off-by: Kevin Wolf \n> ---\n> tests/qemu-iotests/172 | 2 +-\n> tests/qemu-iotests/186 | 6 +++---\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n\nI tested this on top of my change switching the default machine to\n\"tcg:kvm:xen:hax\", and this now passes on x86_64 builds both with and\nwithout tcg.\n\nTested-by: Cornelia Huck \nReviewed-by: Cornelia Huck ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnwnJ4B1rz9t2W\n\tfor ;\n\tThu, 7 Sep 2017 19:55:48 +1000 (AEST)","from localhost ([::1]:39608 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dptXG-0001Nm-OU\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 05:55:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42440)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dptWs-0001NQ-G6\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 05:55:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dptWn-0006QN-Vi\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 05:55:22 -0400","from mx1.redhat.com ([209.132.183.28]:47302)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dptWe-0006M2-0A; Thu, 07 Sep 2017 05:55:08 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E9629C04B31B;\n\tThu, 7 Sep 2017 09:55:06 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3179F5C544;\n\tThu, 7 Sep 2017 09:55:05 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E9629C04B31B","Date":"Thu, 7 Sep 2017 11:55:03 +0200","From":"Cornelia Huck ","To":"Kevin Wolf ","Message-ID":"<20170907115503.4b67c33f.cohuck@redhat.com>","In-Reply-To":"<20170907085310.19353-1-kwolf@redhat.com>","References":"<20170907085310.19353-1-kwolf@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 07 Sep 2017 09:55:07 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] qemu-iotests: Add missing -machine\n\taccel=qtest","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]