[{"id":1764865,"web_url":"http://patchwork.ozlabs.org/comment/1764865/","msgid":"<1e452e84-63ad-b057-4891-750d6d58512a@amsat.org>","list_archive_url":null,"date":"2017-09-07T17:53:35","subject":"Re: [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/07/2017 05:47 AM, Fam Zheng wrote:\n> baum.o already receives the sdl cflags in its per object variable, do\n> the same for brlapi libs to avoid cluttering libs_softmmu.\n> \n> Signed-off-by: Fam Zheng \n\nReviewed-by: Philippe Mathieu-Daudé \n\n> ---\n> chardev/Makefile.objs | 1 +\n> configure | 2 +-\n> 2 files changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/chardev/Makefile.objs b/chardev/Makefile.objs\n> index 52a8127606..d68e1347f9 100644\n> --- a/chardev/Makefile.objs\n> +++ b/chardev/Makefile.objs\n> @@ -20,5 +20,6 @@ chardev-obj-$(CONFIG_WIN32) += char-win-stdio.o\n> common-obj-y += msmouse.o wctablet.o testdev.o\n> common-obj-$(CONFIG_BRLAPI) += baum.o\n> baum.o-cflags := $(SDL_CFLAGS)\n> +baum.o-libs := $(BRLAPI_LIBS)\n> \n> common-obj-$(CONFIG_SPICE) += spice.o\n> diff --git a/configure b/configure\n> index fb7e34a901..d718718cfa 100755\n> --- a/configure\n> +++ b/configure\n> @@ -3106,7 +3106,6 @@ int main( void ) { return brlapi__openConnection (NULL, NULL, NULL); }\n> EOF\n> if compile_prog \"\" \"$brlapi_libs\" ; then\n> brlapi=yes\n> - libs_softmmu=\"$brlapi_libs $libs_softmmu\"\n> else\n> if test \"$brlapi\" = \"yes\" ; then\n> feature_not_found \"brlapi\" \"Install brlapi devel\"\n> @@ -5693,6 +5692,7 @@ if test \"$curl\" = \"yes\" ; then\n> fi\n> if test \"$brlapi\" = \"yes\" ; then\n> echo \"CONFIG_BRLAPI=y\" >> $config_host_mak\n> + echo \"BRLAPI_LIBS=$brlapi_libs\" >> $config_host_mak\n> fi\n> if test \"$bluez\" = \"yes\" ; then\n> echo \"CONFIG_BLUEZ=y\" >> $config_host_mak\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Pdkc4yKh\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp7RN60jfz9t2f\n\tfor ;\n\tFri, 8 Sep 2017 03:56:00 +1000 (AEST)","from localhost ([::1]:41565 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dq11y-0007vy-U8\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 13:55:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58904)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dq0zn-0006rm-EB\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:53:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dq0zi-0008F6-Sg\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:53:43 -0400","from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:37660)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dq0zi-0008Ek-Ow\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:53:38 -0400","by mail-qt0-x241.google.com with SMTP id h21so248097qth.4\n\tfor ; Thu, 07 Sep 2017 10:53:38 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tw31sm160442qtg.48.2017.09.07.10.53.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 07 Sep 2017 10:53:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=aX3bgUXDuzzmwqs1yjIeKlP5qGy/7fyFb4Kssi06A1w=;\n\tb=Pdkc4yKhcCvpNbn8h33+oWWciqzzsLiBDrVTxI0g0VglRp3bojj+qwg/ZvGbjXhtDf\n\txEJ025DmS205V8NwmfBP7CMT30/znP7JUfiFCNOrZVK+ip1EYAag2a3AN86jkNVHacSK\n\tHIIDea77p2fSeT6vSKGyxtA/s4kJWHjSe4TV1XOotfXu7PqFW2msWLw7DFF+zI1nYBEp\n\tcfHcuNJPwci4b1VZOq+0ezaZNN53PHU3pGqSnMIuPUpmz/9hZwiah2ufxQj85jFsnZsd\n\t7NMBySy1LvbNXFTFmKtd9zcLtsrEw23u8Kq4W3k5M0r35aP9EH5FnOrj4QAUe3wNcNmz\n\tUhcQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=aX3bgUXDuzzmwqs1yjIeKlP5qGy/7fyFb4Kssi06A1w=;\n\tb=Pa5SiLrT76SLVuepalVwBNWwprUaCgs3s7YzQdjCTU1Wmxx4DJ21opWSzFuEfnbQNX\n\t6k00pIdv4mHVth0pGUWdr3u0RcYOQp3Vph5xlskSLiWhyFAN99ZgqolXfE6PD6xC0Fo2\n\tidXtxdDWhVDhhs+WqSsFXtivqSo7UogdADNDK4FsNQRzXYVpvWBaBz1c6j+uT1J+f6Tu\n\tfxSSkntt/ChRZVXvSd7qoFi55m+8d683TLgP1hc/Lb8mDRI9TMJJs144a8/KhI/0v796\n\tPDF96lx/mZ0nZnMT4U70lcsfzv3KllNtydcetq5ROo4VG/YBORCUE2Jbu1Nq2M1NP+3w\n\tGGdw==","X-Gm-Message-State":"AHPjjUgzHmtQiFu05m65lgeGRzOx96PLxeejH9rjF6DBeMiPwsaZMbYO\n\tUENKvShBEdVOxw==","X-Google-Smtp-Source":"AOwi7QA1okrwrzKj9beFEAV9vfnr5pFzq9bXvcw4QNHPVQVpYYvtmDa6YRAjytdey161bD0mii8m9g==","X-Received":"by 10.237.59.77 with SMTP id q13mr282377qte.80.1504806818162;\n\tThu, 07 Sep 2017 10:53:38 -0700 (PDT)","To":"Fam Zheng , qemu-devel@nongnu.org","References":"<20170907084700.952-1-famz@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<1e452e84-63ad-b057-4891-750d6d58512a@amsat.org>","Date":"Thu, 7 Sep 2017 14:53:35 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170907084700.952-1-famz@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::241","Subject":"Re: [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini , =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764962,"web_url":"http://patchwork.ozlabs.org/comment/1764962/","msgid":"<2058771615.10526518.1504820481126.JavaMail.zimbra@redhat.com>","list_archive_url":null,"date":"2017-09-07T21:41:21","subject":"Re: [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"----- Original Message -----\n> baum.o already receives the sdl cflags in its per object variable, do\n> the same for brlapi libs to avoid cluttering libs_softmmu.\n> \n> Signed-off-by: Fam Zheng \n\nReviewed-by: Marc-André Lureau \n\n> ---\n> chardev/Makefile.objs | 1 +\n> configure | 2 +-\n> 2 files changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/chardev/Makefile.objs b/chardev/Makefile.objs\n> index 52a8127606..d68e1347f9 100644\n> --- a/chardev/Makefile.objs\n> +++ b/chardev/Makefile.objs\n> @@ -20,5 +20,6 @@ chardev-obj-$(CONFIG_WIN32) += char-win-stdio.o\n> common-obj-y += msmouse.o wctablet.o testdev.o\n> common-obj-$(CONFIG_BRLAPI) += baum.o\n> baum.o-cflags := $(SDL_CFLAGS)\n> +baum.o-libs := $(BRLAPI_LIBS)\n> \n> common-obj-$(CONFIG_SPICE) += spice.o\n> diff --git a/configure b/configure\n> index fb7e34a901..d718718cfa 100755\n> --- a/configure\n> +++ b/configure\n> @@ -3106,7 +3106,6 @@ int main( void ) { return brlapi__openConnection (NULL,\n> NULL, NULL); }\n> EOF\n> if compile_prog \"\" \"$brlapi_libs\" ; then\n> brlapi=yes\n> - libs_softmmu=\"$brlapi_libs $libs_softmmu\"\n> else\n> if test \"$brlapi\" = \"yes\" ; then\n> feature_not_found \"brlapi\" \"Install brlapi devel\"\n> @@ -5693,6 +5692,7 @@ if test \"$curl\" = \"yes\" ; then\n> fi\n> if test \"$brlapi\" = \"yes\" ; then\n> echo \"CONFIG_BRLAPI=y\" >> $config_host_mak\n> + echo \"BRLAPI_LIBS=$brlapi_libs\" >> $config_host_mak\n> fi\n> if test \"$bluez\" = \"yes\" ; then\n> echo \"CONFIG_BLUEZ=y\" >> $config_host_mak\n> --\n> 2.13.5\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mlureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpDS25n4qz9sBW\n\tfor ;\n\tFri, 8 Sep 2017 07:41:53 +1000 (AEST)","from localhost ([::1]:42368 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dq4YZ-0004jh-95\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 17:41:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53508)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dq4YD-0004jI-4R\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 17:41:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dq4Y8-0006Ab-Hi\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 17:41:29 -0400","from mx1.redhat.com ([209.132.183.28]:55372)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dq4Y8-0006A9-Bk\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 17:41:24 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2BB2780473\n\tfor ; Thu, 7 Sep 2017 21:41:23 +0000 (UTC)","from colo-mx.corp.redhat.com\n\t(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 667375D971;\n\tThu, 7 Sep 2017 21:41:21 +0000 (UTC)","from zmail17.collab.prod.int.phx2.redhat.com\n\t(zmail17.collab.prod.int.phx2.redhat.com [10.5.83.19])\n\tby colo-mx.corp.redhat.com (Postfix) with ESMTP id 456481806106;\n\tThu, 7 Sep 2017 21:41:21 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2BB2780473","Date":"Thu, 7 Sep 2017 17:41:21 -0400 (EDT)","From":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","To":"Fam Zheng ","Message-ID":"<2058771615.10526518.1504820481126.JavaMail.zimbra@redhat.com>","In-Reply-To":"<20170907084700.952-1-famz@redhat.com>","References":"<20170907084700.952-1-famz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Originating-IP":"[10.36.112.20, 10.4.195.29]","Thread-Topic":"buildsys: Move brlapi libs to per object","Thread-Index":"Vm7GFtW2FcQV2rbiZZq5k754Q2XJ1w==","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 07 Sep 2017 21:41:23 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765101,"web_url":"http://patchwork.ozlabs.org/comment/1765101/","msgid":"<20170908061427.GD4511@lemon>","list_archive_url":null,"date":"2017-09-08T06:14:27","subject":"Re: [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Thu, 09/07 16:47, Fam Zheng wrote:\n> baum.o already receives the sdl cflags in its per object variable, do\n> the same for brlapi libs to avoid cluttering libs_softmmu.\n> \n> Signed-off-by: Fam Zheng \n\nThanks, I'll send a pull request later.\n\nFam","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpRrC01nBz9sBW\n\tfor ;\n\tFri, 8 Sep 2017 16:15:03 +1000 (AEST)","from localhost ([::1]:43462 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqCZA-0004u7-QD\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 02:15:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34183)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqCYo-0004tv-EZ\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 02:14:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqCYj-0007LU-St\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 02:14:38 -0400","from mx1.redhat.com ([209.132.183.28]:53596)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqCYj-0007L2-Me\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 02:14:33 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C588181DE4\n\tfor ; Fri, 8 Sep 2017 06:14:32 +0000 (UTC)","from localhost (ovpn-12-98.pek2.redhat.com [10.72.12.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 60C905D974;\n\tFri, 8 Sep 2017 06:14:28 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C588181DE4","Date":"Fri, 8 Sep 2017 14:14:27 +0800","From":"Fam Zheng ","To":"qemu-devel@nongnu.org","Message-ID":"<20170908061427.GD4511@lemon>","References":"<20170907084700.952-1-famz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170907084700.952-1-famz@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 08 Sep 2017 06:14:32 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini , =?iso-8859-1?q?Marc-Andr=E9?=\n\tLureau ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]