[{"id":1764611,"web_url":"http://patchwork.ozlabs.org/comment/1764611/","msgid":"<20170907093731.GF2098@work-vm>","list_archive_url":null,"date":"2017-09-07T09:37:32","subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* Fam Zheng (famz@redhat.com) wrote:\n> Signed-off-by: Fam Zheng \n\nOK, I've not actually got a preference as to whether it's\nper-object or not - I don't really see any advantage.\n\nBut since it doesn't look like it'll break it;\n\nReviewed-by: Dr. David Alan Gilbert \n\n> ---\n> configure | 2 +-\n> migration/Makefile.objs | 1 +\n> 2 files changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/configure b/configure\n> index fb7e34a901..470b8a085b 100755\n> --- a/configure\n> +++ b/configure\n> @@ -2818,7 +2818,6 @@ EOF\n> rdma_libs=\"-lrdmacm -libverbs\"\n> if compile_prog \"\" \"$rdma_libs\" ; then\n> rdma=\"yes\"\n> - libs_softmmu=\"$libs_softmmu $rdma_libs\"\n> else\n> if test \"$rdma\" = \"yes\" ; then\n> error_exit \\\n> @@ -6035,6 +6034,7 @@ echo \"CONFIG_TRACE_FILE=$trace_file\" >> $config_host_mak\n> \n> if test \"$rdma\" = \"yes\" ; then\n> echo \"CONFIG_RDMA=y\" >> $config_host_mak\n> + echo \"RDMA_LIBS=$rdma_libs\" >> $config_host_mak\n> fi\n> \n> if test \"$have_rtnetlink\" = \"yes\" ; then\n> diff --git a/migration/Makefile.objs b/migration/Makefile.objs\n> index 1c7770da46..99e038024d 100644\n> --- a/migration/Makefile.objs\n> +++ b/migration/Makefile.objs\n> @@ -11,3 +11,4 @@ common-obj-$(CONFIG_RDMA) += rdma.o\n> \n> common-obj-$(CONFIG_LIVE_BLOCK_MIGRATION) += block.o\n> \n> +rdma.o-libs := $(RDMA_LIBS)\n> -- \n> 2.13.5\n> \n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnwP00sHlz9sNV\n\tfor ;\n\tThu, 7 Sep 2017 19:38:12 +1000 (AEST)","from localhost ([::1]:39576 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dptGE-0004CY-9A\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 05:38:10 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36229)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dptFt-0004CO-3f\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 05:37:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dptFp-0007A7-Ux\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 05:37:49 -0400","from mx1.redhat.com ([209.132.183.28]:54374)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dptFp-00079x-O0\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 05:37:45 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C58DB40431B\n\tfor ; Thu, 7 Sep 2017 09:37:44 +0000 (UTC)","from work-vm (ovpn-117-81.ams2.redhat.com [10.36.117.81])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id A4C455D6A8;\n\tThu, 7 Sep 2017 09:37:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C58DB40431B","Date":"Thu, 7 Sep 2017 10:37:32 +0100","From":"\"Dr. David Alan Gilbert\" ","To":"Fam Zheng ","Message-ID":"<20170907093731.GF2098@work-vm>","References":"<20170907084230.26493-1-famz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170907084230.26493-1-famz@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 07 Sep 2017 09:37:44 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Peter Xu ,\n\tJuan Quintela ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764618,"web_url":"http://patchwork.ozlabs.org/comment/1764618/","msgid":"<20170907094608.GC23040@pxdev.xzpeter.org>","list_archive_url":null,"date":"2017-09-07T09:46:08","subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Thu, Sep 07, 2017 at 04:42:30PM +0800, Fam Zheng wrote:\n> Signed-off-by: Fam Zheng \n\nReviewed-by: Peter Xu \n\n> ---\n> configure | 2 +-\n> migration/Makefile.objs | 1 +\n> 2 files changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/configure b/configure\n> index fb7e34a901..470b8a085b 100755\n> --- a/configure\n> +++ b/configure\n> @@ -2818,7 +2818,6 @@ EOF\n> rdma_libs=\"-lrdmacm -libverbs\"\n> if compile_prog \"\" \"$rdma_libs\" ; then\n> rdma=\"yes\"\n> - libs_softmmu=\"$libs_softmmu $rdma_libs\"\n> else\n> if test \"$rdma\" = \"yes\" ; then\n> error_exit \\\n> @@ -6035,6 +6034,7 @@ echo \"CONFIG_TRACE_FILE=$trace_file\" >> $config_host_mak\n> \n> if test \"$rdma\" = \"yes\" ; then\n> echo \"CONFIG_RDMA=y\" >> $config_host_mak\n> + echo \"RDMA_LIBS=$rdma_libs\" >> $config_host_mak\n> fi\n> \n> if test \"$have_rtnetlink\" = \"yes\" ; then\n> diff --git a/migration/Makefile.objs b/migration/Makefile.objs\n> index 1c7770da46..99e038024d 100644\n> --- a/migration/Makefile.objs\n> +++ b/migration/Makefile.objs\n> @@ -11,3 +11,4 @@ common-obj-$(CONFIG_RDMA) += rdma.o\n> \n> common-obj-$(CONFIG_LIVE_BLOCK_MIGRATION) += block.o\n> \n> +rdma.o-libs := $(RDMA_LIBS)\n> -- \n> 2.13.5\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnwZw0DD7z9t2R\n\tfor ;\n\tThu, 7 Sep 2017 19:46:48 +1000 (AEST)","from localhost ([::1]:39595 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dptOY-0006zr-5K\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 05:46:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39106)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dptO9-0006yL-T1\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 05:46:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dptO5-0002IC-9o\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 05:46:21 -0400","from mx1.redhat.com ([209.132.183.28]:62174)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dptO5-0002HT-3M\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 05:46:17 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id EC977C047B65\n\tfor ; Thu, 7 Sep 2017 09:46:15 +0000 (UTC)","from pxdev.xzpeter.org (ovpn-12-27.pek2.redhat.com [10.72.12.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id C354E5C3FA;\n\tThu, 7 Sep 2017 09:46:10 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com EC977C047B65","Date":"Thu, 7 Sep 2017 17:46:08 +0800","From":"Peter Xu ","To":"Fam Zheng ","Message-ID":"<20170907094608.GC23040@pxdev.xzpeter.org>","References":"<20170907084230.26493-1-famz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170907084230.26493-1-famz@redhat.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 07 Sep 2017 09:46:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Juan Quintela , qemu-devel@nongnu.org,\n\t\"Dr. David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764667,"web_url":"http://patchwork.ozlabs.org/comment/1764667/","msgid":"<20170907113742.GC25123@lemon.lan>","list_archive_url":null,"date":"2017-09-07T11:37:42","subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Thu, 09/07 10:37, Dr. David Alan Gilbert wrote:\n> * Fam Zheng (famz@redhat.com) wrote:\n> > Signed-off-by: Fam Zheng \n> \n> OK, I've not actually got a preference as to whether it's\n> per-object or not - I don't really see any advantage.\n\nThanks for the review. You're right this probably doesn't make a difference\nexcept for a bit more consistency, until we want to make rdma a module (as in\n--enable-modules) like the ones in block layer. The -libs and -cflags variables\nwere initially added just for that.\n\nWhile we are talking about it, is there any reason why that will not be a good\nidea? There are other libraries used by QEMU outside block layer that are\noverdue to be converted to modules, like ui (gtk, sdl, etc.), rdma seems to be a\ncandidate too.\n\nFam","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnz3p1N7Bz9sRY\n\tfor ;\n\tThu, 7 Sep 2017 21:38:28 +1000 (AEST)","from localhost ([::1]:39887 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpv8c-0004bg-KZ\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 07:38:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47308)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpv8F-0004a1-AD\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 07:38:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpv8A-0002KH-6Y\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 07:38:03 -0400","from mx1.redhat.com ([209.132.183.28]:49904)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpv8A-0002Jz-08\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 07:37:58 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3E5D6C047B6D\n\tfor ; Thu, 7 Sep 2017 11:37:56 +0000 (UTC)","from localhost (ovpn-12-63.pek2.redhat.com [10.72.12.63])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 215D295573;\n\tThu, 7 Sep 2017 11:37:43 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3E5D6C047B6D","Date":"Thu, 7 Sep 2017 19:37:42 +0800","From":"Fam Zheng ","To":"\"Dr. David Alan Gilbert\" ","Message-ID":"<20170907113742.GC25123@lemon.lan>","References":"<20170907084230.26493-1-famz@redhat.com>\n\t<20170907093731.GF2098@work-vm>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170907093731.GF2098@work-vm>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 07 Sep 2017 11:37:56 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Peter Xu ,\n\tJuan Quintela ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764678,"web_url":"http://patchwork.ozlabs.org/comment/1764678/","msgid":"<20170907115433.GL2098@work-vm>","list_archive_url":null,"date":"2017-09-07T11:54:34","subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* Fam Zheng (famz@redhat.com) wrote:\n> On Thu, 09/07 10:37, Dr. David Alan Gilbert wrote:\n> > * Fam Zheng (famz@redhat.com) wrote:\n> > > Signed-off-by: Fam Zheng \n> > \n> > OK, I've not actually got a preference as to whether it's\n> > per-object or not - I don't really see any advantage.\n> \n> Thanks for the review. You're right this probably doesn't make a difference\n> except for a bit more consistency, until we want to make rdma a module (as in\n> --enable-modules) like the ones in block layer. The -libs and -cflags variables\n> were initially added just for that.\n> \n> While we are talking about it, is there any reason why that will not be a good\n> idea? There are other libraries used by QEMU outside block layer that are\n> overdue to be converted to modules, like ui (gtk, sdl, etc.), rdma seems to be a\n> candidate too.\n\nI don't think we've ever tried to make the migration code modular;\nit probably wouldn't be impossible to split it out - it's wired\ninto a few places but it should be doable.\n\nDave\n\n> Fam\n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnzRG5Sjbz9t2c\n\tfor ;\n\tThu, 7 Sep 2017 21:55:22 +1000 (AEST)","from localhost ([::1]:39930 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpvOy-0000iP-SD\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 07:55:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52521)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpvOQ-0000fC-Jz\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 07:54:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpvOM-0001N9-0l\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 07:54:46 -0400","from mx1.redhat.com ([209.132.183.28]:45012)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpvOL-0001M2-Ri\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 07:54:41 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D464785550\n\tfor ; Thu, 7 Sep 2017 11:54:40 +0000 (UTC)","from work-vm (ovpn-117-81.ams2.redhat.com [10.36.117.81])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 8214F5D760;\n\tThu, 7 Sep 2017 11:54:36 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D464785550","Date":"Thu, 7 Sep 2017 12:54:34 +0100","From":"\"Dr. David Alan Gilbert\" ","To":"Fam Zheng ","Message-ID":"<20170907115433.GL2098@work-vm>","References":"<20170907084230.26493-1-famz@redhat.com>\n\t<20170907093731.GF2098@work-vm> <20170907113742.GC25123@lemon.lan>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170907113742.GC25123@lemon.lan>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 07 Sep 2017 11:54:40 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Peter Xu ,\n\tJuan Quintela ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764679,"web_url":"http://patchwork.ozlabs.org/comment/1764679/","msgid":"<87pob2bu50.fsf@secure.laptop>","list_archive_url":null,"date":"2017-09-07T11:55:23","subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","submitter":{"id":2643,"url":"http://patchwork.ozlabs.org/api/people/2643/","name":"Juan Quintela","email":"quintela@redhat.com"},"content":"Fam Zheng wrote:\n> Signed-off-by: Fam Zheng \n\nReviewed-by: Juan Quintela \n\n\n> ---\n> configure | 2 +-\n> migration/Makefile.objs | 1 +\n> 2 files changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/configure b/configure\n> index fb7e34a901..470b8a085b 100755\n> --- a/configure\n> +++ b/configure\n> @@ -2818,7 +2818,6 @@ EOF\n> rdma_libs=\"-lrdmacm -libverbs\"\n> if compile_prog \"\" \"$rdma_libs\" ; then\n> rdma=\"yes\"\n> - libs_softmmu=\"$libs_softmmu $rdma_libs\"\n> else\n> if test \"$rdma\" = \"yes\" ; then\n> error_exit \\\n> @@ -6035,6 +6034,7 @@ echo \"CONFIG_TRACE_FILE=$trace_file\" >> $config_host_mak\n> \n> if test \"$rdma\" = \"yes\" ; then\n> echo \"CONFIG_RDMA=y\" >> $config_host_mak\n> + echo \"RDMA_LIBS=$rdma_libs\" >> $config_host_mak\n> fi\n> \n> if test \"$have_rtnetlink\" = \"yes\" ; then\n> diff --git a/migration/Makefile.objs b/migration/Makefile.objs\n> index 1c7770da46..99e038024d 100644\n> --- a/migration/Makefile.objs\n> +++ b/migration/Makefile.objs\n> @@ -11,3 +11,4 @@ common-obj-$(CONFIG_RDMA) += rdma.o\n> \n> common-obj-$(CONFIG_LIVE_BLOCK_MIGRATION) += block.o\n> \n> +rdma.o-libs := $(RDMA_LIBS)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=quintela@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnzSD3KjVz9sRV\n\tfor ;\n\tThu, 7 Sep 2017 21:56:12 +1000 (AEST)","from localhost ([::1]:39935 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpvPm-0001FZ-Je\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 07:56:10 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52850)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpvPF-0001Bu-MO\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 07:55:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpvPB-0001aN-6T\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 07:55:37 -0400","from mx1.redhat.com ([209.132.183.28]:53664)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpvPB-0001Zz-01\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 07:55:33 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 013B5C0587DE\n\tfor ; Thu, 7 Sep 2017 11:55:32 +0000 (UTC)","from localhost (ovpn-116-231.ams2.redhat.com [10.36.116.231])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C8DEF6031F;\n\tThu, 7 Sep 2017 11:55:24 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 013B5C0587DE","From":"Juan Quintela ","To":"Fam Zheng ","In-Reply-To":"<20170907084230.26493-1-famz@redhat.com> (Fam Zheng's message of\n\t\"Thu, 7 Sep 2017 16:42:30 +0800\")","References":"<20170907084230.26493-1-famz@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","Date":"Thu, 07 Sep 2017 13:55:23 +0200","Message-ID":"<87pob2bu50.fsf@secure.laptop>","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tThu, 07 Sep 2017 11:55:32 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"quintela@redhat.com","Cc":"qemu-devel@nongnu.org, Peter Xu ,\n\t\"Dr. David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764686,"web_url":"http://patchwork.ozlabs.org/comment/1764686/","msgid":"<20170907121216.GL30609@redhat.com>","list_archive_url":null,"date":"2017-09-07T12:12:16","subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Thu, Sep 07, 2017 at 07:37:42PM +0800, Fam Zheng wrote:\n> On Thu, 09/07 10:37, Dr. David Alan Gilbert wrote:\n> > * Fam Zheng (famz@redhat.com) wrote:\n> > > Signed-off-by: Fam Zheng \n> > \n> > OK, I've not actually got a preference as to whether it's\n> > per-object or not - I don't really see any advantage.\n> \n> Thanks for the review. You're right this probably doesn't make a difference\n> except for a bit more consistency, until we want to make rdma a module (as in\n> --enable-modules) like the ones in block layer. The -libs and -cflags variables\n> were initially added just for that.\n> \n> While we are talking about it, is there any reason why that will not be a good\n> idea? There are other libraries used by QEMU outside block layer that are\n> overdue to be converted to modules, like ui (gtk, sdl, etc.), rdma seems to be a\n> candidate too.\n\nSince we have per-module flags, it makes sense to use them whereever it is\nreasonable todo so. The global flags should only be needed for things which\nare truely globally used, which is (almost) only glib2.\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnzqz1nXsz9sMN\n\tfor ;\n\tThu, 7 Sep 2017 22:13:19 +1000 (AEST)","from localhost ([::1]:40221 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpvgL-0006JB-7N\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 08:13:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59795)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpvfd-0006DE-3j\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:12:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpvfY-0001b7-4D\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:12:33 -0400","from mx1.redhat.com ([209.132.183.28]:58516)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpvfX-0001aZ-U3\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:12:28 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5554E5F7B2\n\tfor ; Thu, 7 Sep 2017 12:12:26 +0000 (UTC)","from redhat.com (unknown [10.33.36.82])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 56EC54F079;\n\tThu, 7 Sep 2017 12:12:18 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5554E5F7B2","Date":"Thu, 7 Sep 2017 13:12:16 +0100","From":"\"Daniel P. Berrange\" ","To":"Fam Zheng ","Message-ID":"<20170907121216.GL30609@redhat.com>","References":"<20170907084230.26493-1-famz@redhat.com>\n\t<20170907093731.GF2098@work-vm> <20170907113742.GC25123@lemon.lan>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170907113742.GC25123@lemon.lan>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tThu, 07 Sep 2017 12:12:26 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"Juan Quintela ,\n\t\"Dr. David Alan Gilbert\" ,\n\tPeter Xu , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765189,"web_url":"http://patchwork.ozlabs.org/comment/1765189/","msgid":"<20170908092154.GI4511@lemon>","list_archive_url":null,"date":"2017-09-08T09:21:54","subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Thu, 09/07 16:42, Fam Zheng wrote:\n> Signed-off-by: Fam Zheng \n\nI will include this in a coming pull request. Thanks.\n\nFam","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpX4j4pNTz9rxm\n\tfor ;\n\tFri, 8 Sep 2017 19:26:13 +1000 (AEST)","from localhost ([::1]:44079 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqFYB-0004ce-Kl\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 05:26:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54790)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqFUC-0001Xy-9s\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:22:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqFU7-0005HL-RO\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:22:04 -0400","from mx1.redhat.com ([209.132.183.28]:58768)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqFU7-0005Ge-LC\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:21:59 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B734F4E909\n\tfor ; Fri, 8 Sep 2017 09:21:58 +0000 (UTC)","from localhost (ovpn-12-98.pek2.redhat.com [10.72.12.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BF7B9614C0;\n\tFri, 8 Sep 2017 09:21:55 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B734F4E909","Date":"Fri, 8 Sep 2017 17:21:54 +0800","From":"Fam Zheng ","To":"qemu-devel@nongnu.org","Message-ID":"<20170908092154.GI4511@lemon>","References":"<20170907084230.26493-1-famz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170907084230.26493-1-famz@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tFri, 08 Sep 2017 09:21:58 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Dr. David Alan Gilbert\" ,\n\tPeter Xu , Juan Quintela ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]