[{"id":1764858,"web_url":"http://patchwork.ozlabs.org/comment/1764858/","msgid":"<8025c01d-fde7-0031-2360-503bdbe3a21a@amsat.org>","list_archive_url":null,"date":"2017-09-07T17:45:13","subject":"Re: [Qemu-devel] [PATCH 1/9] buildsys: Move gtk/vte cflags/libs to\n\tper object","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/07/2017 05:29 AM, Fam Zheng wrote:\n> Signed-off-by: Fam Zheng <famz@redhat.com>\n> ---\n>   configure        | 3 +--\n>   ui/Makefile.objs | 4 ++++\n>   2 files changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/configure b/configure\n> index b37cd54bda..e27a4bd683 100755\n> --- a/configure\n> +++ b/configure\n> @@ -2437,7 +2437,6 @@ if test \"$gtk\" != \"no\"; then\n>               gtk_cflags=\"$gtk_cflags $x11_cflags\"\n>               gtk_libs=\"$gtk_libs $x11_libs\"\n>           fi\n> -        libs_softmmu=\"$gtk_libs $libs_softmmu\"\n>           gtk=\"yes\"\n>       elif test \"$gtk\" = \"yes\"; then\n>           feature_not_found \"gtk\" \"Install gtk3-devel\"\n> @@ -2678,7 +2677,6 @@ if test \"$vte\" != \"no\"; then\n>           vte_cflags=$($pkg_config --cflags $vtepackage)\n>           vte_libs=$($pkg_config --libs $vtepackage)\n>           vteversion=$($pkg_config --modversion $vtepackage)\n> -        libs_softmmu=\"$vte_libs $libs_softmmu\"\n>           vte=\"yes\"\n>       elif test \"$vte\" = \"yes\"; then\n>           if test \"$gtkabi\" = \"3.0\"; then\n> @@ -5750,6 +5748,7 @@ fi\n>   if test \"$vte\" = \"yes\" ; then\n>     echo \"CONFIG_VTE=y\" >> $config_host_mak\n>     echo \"VTE_CFLAGS=$vte_cflags\" >> $config_host_mak\n> +  echo \"VTE_LIBS=$vte_libs\" >> $config_host_mak\n>   fi\n>   if test \"$virglrenderer\" = \"yes\" ; then\n>     echo \"CONFIG_VIRGL=y\" >> $config_host_mak\n> diff --git a/ui/Makefile.objs b/ui/Makefile.objs\n> index 3369451285..146a8ce062 100644\n> --- a/ui/Makefile.objs\n> +++ b/ui/Makefile.objs\n> @@ -45,6 +45,10 @@ gtk.o-cflags := $(GTK_CFLAGS) $(VTE_CFLAGS)\n>   gtk-egl.o-cflags := $(GTK_CFLAGS) $(VTE_CFLAGS)\n>   gtk-gl-area.o-cflags := $(GTK_CFLAGS) $(VTE_CFLAGS)\n>   \n> +gtk.o-libs := $(GTK_LIBS) $(VTE_LIBS)\n> +gtk-egl.o-libs := $(GTK_LIBS) $(VTE_LIBS)\n> +gtk-gl-area.o-libs := $(GTK_LIBS) $(VTE_LIBS)\n\n$(foreach x, gtk gtk-egl gtk-gl-area, \\\n     $(eval $x.o-libs += $(GTK_LIBS) $(VTE_LIBS)) \\\n     $(eval $x.o-cflags += $(GTK_CFLAGS) $(VTE_CFLAGS)) \\\n)\n\n> +\n>   gtk-egl.o-libs += $(OPENGL_LIBS)\n>   shader.o-libs += $(OPENGL_LIBS)\n>   console-gl.o-libs += $(OPENGL_LIBS)\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Qm5Lap6p\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp7Cg1w8pz9t2M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 03:45:50 +1000 (AEST)","from localhost ([::1]:41533 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dq0s8-00039V-RQ\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 13:45:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55286)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dq0rm-00039D-Sz\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:45:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dq0rh-0004eq-Te\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:45:26 -0400","from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:37552)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dq0rh-0004ed-Oa\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:45:21 -0400","by mail-qt0-x243.google.com with SMTP id h21so236195qth.4\n\tfor <qemu-devel@nongnu.org>; Thu, 07 Sep 2017 10:45:21 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tx189sm92214qkd.70.2017.09.07.10.45.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 07 Sep 2017 10:45:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=9PUusF8hF3Hs/R89j0/98SVZiPzSzh9fCSrUKl1xM2g=;\n\tb=Qm5Lap6pC841rm9NYjHLupuhbtxT97QtAzfDGKNaHZfNp9E8wEavf9+TRcxPCaoMOo\n\trB/y4VA9/VBxBHj/SHyRSXaQPoXquv6E/to2naAdFW4W9MGf4mBfPIH1xvsMH5n8Brw3\n\tS+8uHPtrEj8Pg6JfyVQFQOKGkXQt+hyYYI0cF6qfjC9YVdQcAtmyvXGoHu52EX9YgMiN\n\ttxSgG7S9P+L9B50QBjTgkMR1R98H9eKR3XDMf3f+5bGAKnRkviJTqB/gmU9WrUuDVMha\n\tUvGyxOTyKJqkIXGHv/FFvCNFfGlk4fFMTmH7VT53GjQHJsa+ARmKp6vKMth/Jv4gqmWb\n\tlTHg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=9PUusF8hF3Hs/R89j0/98SVZiPzSzh9fCSrUKl1xM2g=;\n\tb=W2zroBi+vPWu92t/s0JeGNTDAjT+OHoyD5OfbBk8zjns0Wx0dLLIHsvCnsGNhdsjMl\n\tzEqEDZkOUCx6sExgL0JF8clFziQBAyfWvEsqQtdLvwK6FYAxLv47uojs/BYbDAF83pc9\n\tqL5xCIG+BSxUqS3mGW3MwqV25Zyqln2vkEXyiz65g38MY+Fa/M1sJ1PlUyjTsNXIrc7c\n\t/gMDf8q827rJs52Y1osaDHwwE7XLKUyM0sBOho6PEbBUMWu/6fm5IbG0JGSdaxzF/A24\n\tP0S7xKkK0ykUuoDTSmXIANqlawjCLlOxvTC3ZkY131D/XMHERxRYcKno2pB+O8NwuXy+\n\tNoVg==","X-Gm-Message-State":"AHPjjUgYdTz1ltk5BPtWHiceIlDue64wtja2VnvKhRJUUt+NEMRNNk1F\n\t+ynh9rFHS6Z0tg==","X-Google-Smtp-Source":"AOwi7QCmtCn8z6X6al7Yer3Udgg6tsu5BD284IlsKoCnZyD8dtbNZYAJvp4op72mg0XXq00Fx+XOkg==","X-Received":"by 10.200.58.130 with SMTP id x2mr217174qte.174.1504806321180;\n\tThu, 07 Sep 2017 10:45:21 -0700 (PDT)","To":"Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org","References":"<20170907082918.7299-1-famz@redhat.com>\n\t<20170907082918.7299-2-famz@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>","Message-ID":"<8025c01d-fde7-0031-2360-503bdbe3a21a@amsat.org>","Date":"Thu, 7 Sep 2017 14:45:13 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170907082918.7299-2-famz@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::243","Subject":"Re: [Qemu-devel] [PATCH 1/9] buildsys: Move gtk/vte cflags/libs to\n\tper object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Gerd Hoffmann <kraxel@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1764862,"web_url":"http://patchwork.ozlabs.org/comment/1764862/","msgid":"<CAFEAcA9=axe_f4C6wLRxuJC_pvEe_Pt51AfHZEUEkOikB=S+9w@mail.gmail.com>","list_archive_url":null,"date":"2017-09-07T17:50:48","subject":"Re: [Qemu-devel] [PATCH 1/9] buildsys: Move gtk/vte cflags/libs to\n\tper object","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 7 September 2017 at 18:45, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:\n> On 09/07/2017 05:29 AM, Fam Zheng wrote:\n>> diff --git a/ui/Makefile.objs b/ui/Makefile.objs\n>> index 3369451285..146a8ce062 100644\n>> --- a/ui/Makefile.objs\n>> +++ b/ui/Makefile.objs\n>> @@ -45,6 +45,10 @@ gtk.o-cflags := $(GTK_CFLAGS) $(VTE_CFLAGS)\n>>   gtk-egl.o-cflags := $(GTK_CFLAGS) $(VTE_CFLAGS)\n>>   gtk-gl-area.o-cflags := $(GTK_CFLAGS) $(VTE_CFLAGS)\n>>   +gtk.o-libs := $(GTK_LIBS) $(VTE_LIBS)\n>> +gtk-egl.o-libs := $(GTK_LIBS) $(VTE_LIBS)\n>> +gtk-gl-area.o-libs := $(GTK_LIBS) $(VTE_LIBS)\n>\n>\n> $(foreach x, gtk gtk-egl gtk-gl-area, \\\n>     $(eval $x.o-libs += $(GTK_LIBS) $(VTE_LIBS)) \\\n>     $(eval $x.o-cflags += $(GTK_CFLAGS) $(VTE_CFLAGS)) \\\n>\n> )\n\nI think that's worse, personally. Most developers don't\ntouch the makefiles very often and so doing the simple\nstraightforward thing is better. Then it's clearer to\npeople who come along later how they need to add a new\nfile to the makefiles (a surprisingly common question).\n\nthanks\n-- PMM","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Ye7V6IFF\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp7LP2F0jz9t2M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 03:51:41 +1000 (AEST)","from localhost ([::1]:41546 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dq0xn-0005PG-GE\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 13:51:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57886)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <peter.maydell@linaro.org>) id 1dq0xP-0005Op-MD\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:51:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <peter.maydell@linaro.org>) id 1dq0xL-00076O-2E\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:51:15 -0400","from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:44990)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <peter.maydell@linaro.org>)\n\tid 1dq0xK-000768-Qe\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:51:10 -0400","by mail-wm0-x234.google.com with SMTP id 137so678684wmj.1\n\tfor <qemu-devel@nongnu.org>; Thu, 07 Sep 2017 10:51:10 -0700 (PDT)","by 10.223.159.68 with HTTP; Thu, 7 Sep 2017 10:50:48 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=Qwx3Ix3pbf5fYL/XTQS3oE4ssxfdxTpkJ5Wuv28+igs=;\n\tb=Ye7V6IFFwjU+mH4d7pc4R0coi6l/W00fKoD96dda4dK1C1tXMdWnUO1LNqGuX8O3gO\n\tAONtSnAEwbrULHja+j/PD4x4QYOuR2k13RitUJD4t5VvRzJAIe/j0oARtWqlCXDaMtPn\n\tEq+jqluBXx/BXyhNM3zdwdMpcPIHmczk3ESf8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=Qwx3Ix3pbf5fYL/XTQS3oE4ssxfdxTpkJ5Wuv28+igs=;\n\tb=pcloZZySGHp6tEexbJHRFXnbbgcDi4z9GCXPrjeQy4HHmoCb36ebPnmVcINFCTGz96\n\tmBjVzIYzRzvwgo3o4gBefKNBlKhinWO44c27+YMs727alNFBDciJ86u6RxaiKDLDKSRo\n\tize+n4if3akEK9FhXObkcS4y/Pk1IBp90OodnM14tDOffWlL2rbrKGLxmNXGC+A8Z0XL\n\tq8i28Bz4gpogNwFRXOvS2iNMnTSEK69aduoUQKWjP49OFXBiCDnR42I3jeyhg6MN36Be\n\tdjds/4wuwt/awH4D9yTYN4MFrXQTCpR4L2pHXphidRItUTo8Zgbn59p0Eq04onp8K/wW\n\tUztg==","X-Gm-Message-State":"AHPjjUh2ql36P7gp3jCUJyYAsoWhLhqfHrTLyZF+4gYd45hhpqudaqij\n\td13eMPF841IapNkHnvGVfwAPLPqnrPH5","X-Google-Smtp-Source":"AOwi7QAgVn32YSj2I97oTxFZ7NbJUDv8WOzfitijsfOd4WCTF3PBx1M+VUqWKPOKtFaURi14Tg0CtwC5avXg/Lk+3DM=","X-Received":"by 10.28.66.157 with SMTP id k29mr50353wmi.127.1504806669500;\n\tThu, 07 Sep 2017 10:51:09 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<8025c01d-fde7-0031-2360-503bdbe3a21a@amsat.org>","References":"<20170907082918.7299-1-famz@redhat.com>\n\t<20170907082918.7299-2-famz@redhat.com>\n\t<8025c01d-fde7-0031-2360-503bdbe3a21a@amsat.org>","From":"Peter Maydell <peter.maydell@linaro.org>","Date":"Thu, 7 Sep 2017 18:50:48 +0100","Message-ID":"<CAFEAcA9=axe_f4C6wLRxuJC_pvEe_Pt51AfHZEUEkOikB=S+9w@mail.gmail.com>","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::234","Subject":"Re: [Qemu-devel] [PATCH 1/9] buildsys: Move gtk/vte cflags/libs to\n\tper object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Fam Zheng <famz@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>,\n\tGerd Hoffmann <kraxel@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]