[{"id":1764736,"web_url":"http://patchwork.ozlabs.org/comment/1764736/","msgid":"","list_archive_url":null,"date":"2017-09-07T13:37:09","subject":"Re: [Qemu-devel] [PATCH 2/2] docker: Enable features explicitly in\n\ttest-full","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/07/2017 03:11 AM, Fam Zheng wrote:\n> Also avoid \"set -e\".\n> \n> Signed-off-by: Fam Zheng \n> ---\n> tests/docker/test-full | 80 ++++++++++++++++++++++++++++++++++++++++++++++----\n> 1 file changed, 75 insertions(+), 5 deletions(-)\n> \n> diff --git a/tests/docker/test-full b/tests/docker/test-full\n> index 05f0d491d1..bd095ad91b 100755\n> --- a/tests/docker/test-full\n> +++ b/tests/docker/test-full\n> @@ -1,8 +1,8 @@\n> -#!/bin/bash -e\n> +#!/bin/bash\n\nWhen you drop 'set -e'...\n\n> #\n> -# Compile all the targets.\n> +# Compile all the targets with as many features enabled as possible\n> #\n> -# Copyright (c) 2016 Red Hat Inc.\n> +# Copyright 2016, 2017 Red Hat Inc.\n> #\n> # Authors:\n> # Fam Zheng \n> @@ -15,5 +15,75 @@\n> \n> cd \"$BUILD_DIR\"\n\n...then you should explicitly check for failure after commands where you\nreally do not want to continue execution if they failed. I'd write this:\n\ncd \"$BUILD_DIR\" || exit 1\n\nor else use && to chain it to...\n\n> \n> -build_qemu\n> -make check $MAKEFLAGS\n> +build_qemu \\\n> + --enable-attr \\\n\n> + --enable-xfsctl \\\n> +&& make check $MAKEFLAGS\n\nthe rest of your chain.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp26b27MXz9s8J\n\tfor ;\n\tThu, 7 Sep 2017 23:56:07 +1000 (AEST)","from localhost ([::1]:40604 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpxHp-0000eS-DL\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 09:56:05 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34308)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpwzi-0000em-CH\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:37:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpwzd-0004HD-Hl\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:37:22 -0400","from mx1.redhat.com ([209.132.183.28]:35276)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpwzd-0004Gc-94\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:37:17 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3C5D8883CD;\n\tThu, 7 Sep 2017 13:37:16 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7F9FF17D59;\n\tThu, 7 Sep 2017 13:37:11 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3C5D8883CD","To":"Fam Zheng , qemu-devel@nongnu.org","References":"<20170907081158.4063-1-famz@redhat.com>\n\t<20170907081158.4063-3-famz@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Thu, 7 Sep 2017 08:37:09 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170907081158.4063-3-famz@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"67tKXikd0H519PB8JSsOVM68R7bBAq1dL\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 07 Sep 2017 13:37:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 2/2] docker: Enable features explicitly in\n\ttest-full","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764744,"web_url":"http://patchwork.ozlabs.org/comment/1764744/","msgid":"<20170907140420.GE25123@lemon.lan>","list_archive_url":null,"date":"2017-09-07T14:04:20","subject":"Re: [Qemu-devel] [PATCH 2/2] docker: Enable features explicitly in\n\ttest-full","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Thu, 09/07 08:37, Eric Blake wrote:\n> On 09/07/2017 03:11 AM, Fam Zheng wrote:\n> > Also avoid \"set -e\".\n> > \n> > Signed-off-by: Fam Zheng \n> > ---\n> > tests/docker/test-full | 80 ++++++++++++++++++++++++++++++++++++++++++++++----\n> > 1 file changed, 75 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/tests/docker/test-full b/tests/docker/test-full\n> > index 05f0d491d1..bd095ad91b 100755\n> > --- a/tests/docker/test-full\n> > +++ b/tests/docker/test-full\n> > @@ -1,8 +1,8 @@\n> > -#!/bin/bash -e\n> > +#!/bin/bash\n> \n> When you drop 'set -e'...\n> \n> > #\n> > -# Compile all the targets.\n> > +# Compile all the targets with as many features enabled as possible\n> > #\n> > -# Copyright (c) 2016 Red Hat Inc.\n> > +# Copyright 2016, 2017 Red Hat Inc.\n> > #\n> > # Authors:\n> > # Fam Zheng \n> > @@ -15,5 +15,75 @@\n> > \n> > cd \"$BUILD_DIR\"\n> \n> ...then you should explicitly check for failure after commands where you\n> really do not want to continue execution if they failed. I'd write this:\n\nWe can probably tolerate the failure of cd, but it might be better if we are\nstrict on that. Will update.\n\nFam","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp2Js5qkzz9s4s\n\tfor ;\n\tFri, 8 Sep 2017 00:05:01 +1000 (AEST)","from localhost ([::1]:40647 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpxQR-0004to-Sr\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 10:04:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46480)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpxPw-0004tJ-M5\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 10:04:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpxPs-0003bu-4r\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 10:04:28 -0400","from mx1.redhat.com ([209.132.183.28]:41312)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpxPr-0003bH-VI\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 10:04:24 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B6B15267FB;\n\tThu, 7 Sep 2017 14:04:22 +0000 (UTC)","from localhost (ovpn-12-66.pek2.redhat.com [10.72.12.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E66C185F92;\n\tThu, 7 Sep 2017 14:04:21 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B6B15267FB","Date":"Thu, 7 Sep 2017 22:04:20 +0800","From":"Fam Zheng ","To":"Eric Blake ","Message-ID":"<20170907140420.GE25123@lemon.lan>","References":"<20170907081158.4063-1-famz@redhat.com>\n\t<20170907081158.4063-3-famz@redhat.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 07 Sep 2017 14:04:22 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/2] docker: Enable features explicitly in\n\ttest-full","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alex =?iso-8859-1?q?Benn=E9e?= ,\n\tqemu-devel@nongnu.org, Philippe =?iso-8859-1?q?Mathieu-Daud=E9?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]