[{"id":1767004,"web_url":"http://patchwork.ozlabs.org/comment/1767004/","msgid":"<20170912130215.GH17633@redhat.com>","list_archive_url":null,"date":"2017-09-12T13:02:15","subject":"Re: [Qemu-devel] [PATCH v5 2/3] watchdog.h: Drop local redefinition\n\tof actions enum","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Thu, Sep 07, 2017 at 10:05:25AM +0200, Michal Privoznik wrote:\n> We already have enum that enumerates all the actions that a\n> watchdog can take when hitting its timeout: WatchdogAction.\n> Use that instead of inventing our own.\n> \n> Signed-off-by: Michal Privoznik \n> ---\n> hw/watchdog/watchdog.c | 45 ++++++++++++++++++++-------------------------\n> hw/watchdog/wdt_diag288.c | 6 +++---\n> include/sysemu/watchdog.h | 12 ++----------\n> 3 files changed, 25 insertions(+), 38 deletions(-)\n\nReviewed-by: Daniel P. Berrange \n\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs4j22fhyz9rxl\n\tfor ;\n\tTue, 12 Sep 2017 23:03:02 +1000 (AEST)","from localhost ([::1]:35728 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drkqC-0004vq-Gh\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 09:03:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60356)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drkph-0004oy-5t\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:02:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drkpX-0000UG-Tf\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:02:29 -0400","from mx1.redhat.com ([209.132.183.28]:39538)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drkpX-0000Tn-Nh\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:02:19 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B0CA3C04B333\n\tfor ; Tue, 12 Sep 2017 13:02:18 +0000 (UTC)","from redhat.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 067146BF7B;\n\tTue, 12 Sep 2017 13:02:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B0CA3C04B333","Date":"Tue, 12 Sep 2017 14:02:15 +0100","From":"\"Daniel P. Berrange\" ","To":"Michal Privoznik ","Message-ID":"<20170912130215.GH17633@redhat.com>","References":"\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 12 Sep 2017 13:02:18 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 2/3] watchdog.h: Drop local redefinition\n\tof actions enum","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"qemu-devel@nongnu.org, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]