[{"id":1764697,"web_url":"http://patchwork.ozlabs.org/comment/1764697/","msgid":"<877exan0nq.fsf@kamboji.qca.qualcomm.com>","list_archive_url":null,"date":"2017-09-07T12:39:05","subject":"Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it","submitter":{"id":65411,"url":"http://patchwork.ozlabs.org/api/people/65411/","name":"Kalle Valo","email":"kvalo@codeaurora.org"},"content":"Luca Coelho <luca@coelho.fi> writes:\n\n> From: Luca Coelho <luciano.coelho@intel.com>\n>\n> The LEDS_CMD command is only supported in some newer FW versions\n> (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions\n> (such as iwlwifi-8000C-27.ucode).\n>\n> To fix this, check for a new bit in the FW capabilities TLV that tells\n> when the command is supported.\n>\n> Note that the current version of -31.ucode in linux-firmware.git\n> (31.532993.0) does not have this capability bit set, so the LED won't\n> work, even though this version should support it.  But we will update\n> this firmware soon, so it won't be a problem anymore.\n>\n> Fixes: 7089ae634c50 (\"iwlwifi: mvm: use firmware LED command where applicable\")\n> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>\n> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>\n\nLinus, do you want to apply this directly or should we take it via the\nnormal route (wireless-drivers -> net)? If your prefer the latter when\nI'm planning to submit this to Dave in a day or two and expecting it to\nget to your tree in about a week, depending of course what is Dave's\nschedule.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"aLJalv4M\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"R3v0Tttt\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=kvalo@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xp0QM2llFz9s8J\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 22:39:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755334AbdIGMjN (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 08:39:13 -0400","from smtp.codeaurora.org ([198.145.29.96]:53452 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755286AbdIGMjL (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 7 Sep 2017 08:39:11 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 5C0B660241; Thu,  7 Sep 2017 12:39:11 +0000 (UTC)","from potku.adurom.net (a88-114-240-52.elisa-laajakaista.fi\n\t[88.114.240.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: kvalo@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id E683660241;\n\tThu,  7 Sep 2017 12:39:07 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504787951;\n\tbh=MVC83bgDouFd8gfkQaKY6InaF/AmEQNvp0TuO6pM4rE=;\n\th=From:To:Cc:Subject:References:Date:In-Reply-To:From;\n\tb=aLJalv4MM4jjx9a3TjuUmAT0+QayEaliHQMTHpq/FksBFIk7XVi9PjjJNjCL24Ekb\n\tQZX8Quc7cApUgGgkKzwFsvC/5c1f/1Jk0xB3jxK2QYocQv/cfNPNFd3bYzRIDDbQJ5\n\tOHwwlC8yElJmqKOZU0MCzoEa09GgUIVeTIcVMjlc=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504787950;\n\tbh=MVC83bgDouFd8gfkQaKY6InaF/AmEQNvp0TuO6pM4rE=;\n\th=From:To:Cc:Subject:References:Date:In-Reply-To:From;\n\tb=R3v0TtttVvCT64IQCm8UJlA1PF27pPov+12xVxm2I7TMkgQluxdcBHp+XKH8KOfPj\n\tjhlO6q+Mp3h67//GXSHDzSj3otqDKs23Vw3nKQvxXkW5lXSCRn/ssMwIrwtuKeBhiD\n\tn67JuvlrdQ3O67Lo5ezYJuOhoNog3DHEcPXJAkOU="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org E683660241","From":"Kalle Valo <kvalo@codeaurora.org>","To":"torvalds@linux-foundation.org, Luca Coelho <luca@coelho.fi>","Cc":"linux-wireless@vger.kernel.org, johannes@sipsolutions.net,\n\tlinux-kernel@vger.kernel.org, akpm@linux-foundation.org,\n\tnetdev@vger.kernel.org, davem@davemloft.net,\n\temmanuel.grumbach@intel.com, Luca Coelho <luciano.coelho@intel.com>","Subject":"Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it","References":"<CA+55aFxjHSW7v4Ttu7mGPkxdGpR-WtVoxDT5qtwxUC-Dge5a5A@mail.gmail.com>\n\t<20170907075152.4522-1-luca@coelho.fi>","Date":"Thu, 07 Sep 2017 15:39:05 +0300","In-Reply-To":"<20170907075152.4522-1-luca@coelho.fi> (Luca Coelho's message of\n\t\"Thu, 7 Sep 2017 10:51:52 +0300\")","Message-ID":"<877exan0nq.fsf@kamboji.qca.qualcomm.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764803,"web_url":"http://patchwork.ozlabs.org/comment/1764803/","msgid":"<CA+55aFyeEwg7vd8FPHqG+4d7KbJ6ke4NDwhd+8y=_auRApyvmw@mail.gmail.com>","list_archive_url":null,"date":"2017-09-07T16:13:00","subject":"Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it","submitter":{"id":97,"url":"http://patchwork.ozlabs.org/api/people/97/","name":"Linus Torvalds","email":"torvalds@linux-foundation.org"},"content":"On Thu, Sep 7, 2017 at 5:39 AM, Kalle Valo <kvalo@codeaurora.org> wrote:\n>\n> Linus, do you want to apply this directly or should we take it via the\n> normal route (wireless-drivers -> net)? If your prefer the latter when\n> I'm planning to submit this to Dave in a day or two and expecting it to\n> get to your tree in about a week, depending of course what is Dave's\n> schedule.\n\nSince we have a workaround for the problem, let's just go through the\nregular channels. As long as I get the fix through David before the\nmerge window closes, I'm happy.\n\n              Linus","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"pt5feDK2\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xp58p53W6z9s78\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  8 Sep 2017 02:13:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755422AbdIGQND (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 12:13:03 -0400","from mail-io0-f175.google.com ([209.85.223.175]:36124 \"EHLO\n\tmail-io0-f175.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754958AbdIGQNB (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 7 Sep 2017 12:13:01 -0400","by mail-io0-f175.google.com with SMTP id d16so368212ioj.3;\n\tThu, 07 Sep 2017 09:13:01 -0700 (PDT)","by 10.107.147.86 with HTTP; Thu, 7 Sep 2017 09:13:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=vv8HZ2sczkTXS44s1MGFhGP0M09cMmqovNTrUsh7xPw=;\n\tb=pt5feDK2FVuLDd5FXyb0VUJOziMuetWyD1PFRvRCeB0V8e2W24dcvGxsmCrW+Xf2hH\n\t3hMkNUMvYpscOa4bndmv/uvFjz34dZmDAgdUkHPrd4EqwPV9WHIb87GyS5bHVvPxhuOM\n\t7BinJ/SnxeVwH0GUDevJyhWsrcfRl7njhfLMg6oOgVCisMHfJSrru3qqVLPDdXA3cZL/\n\tuIpkFE9kafZR9nVZeHRLu8A3xsxRgcNemYC0tj5PwtpzLOHB2eVER7wSNIJZIyO500YP\n\tlSOPxIoA1Fq9XCNVjHyugOVnn5eUq3/CUK+jLsbxDZTXyE5pbuu68o4utYQ5W0/JDBfo\n\t37NA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=vv8HZ2sczkTXS44s1MGFhGP0M09cMmqovNTrUsh7xPw=;\n\tb=c5mwoIPq+dEnw4VgxNLTTPjiMS6IoSZzDVf9RwYORH8pJMgi7CHoRKsKlFGIEZ62td\n\tZ9RMCWRWRZ6emoZascJnRg3+1+7Vplx0DMVM3V22NgZHjR+m5Sn0XBiJaZdTv3adE5Lv\n\tr8yAYWemR1HfSXXbj11Qo4QVJIaGH0JgHtPs0LfE8xEOx4jd7ZA3h3jo+6sfP4fO2fti\n\tU0wwEXUPcsAw7BJUP3vKee1TIyR04s4HQlkfXoyaoOzmOqR7TfIDhF6g4rPsIgSXJxnB\n\tzohl38R92fKmIDtUmhn7ZNFpbAhOmgocCdyrrOMIjfTQLlUACBybVwArBRSVSgJ6iw4p\n\tVhyw==","X-Gm-Message-State":"AHPjjUjzdi9AeNkpLRB7gLrSIKIkknnO/UhKO6xxpIuk7DjvWP1tklut\n\tyfIX7/7/0RzBMl52vNQ6NYxUSDFdmw==","X-Google-Smtp-Source":"AOwi7QBoNFWO48J1CDyPr5X3JpKdNV2DzX8qDCUW+dsabx8EU1txsFEZBIIBm9Wy4KdpXFp3iLS3lLc0ZtC4qEywGGs=","X-Received":"by 10.107.169.91 with SMTP id s88mr3574084ioe.179.1504800780916; \n\tThu, 07 Sep 2017 09:13:00 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<877exan0nq.fsf@kamboji.qca.qualcomm.com>","References":"<CA+55aFxjHSW7v4Ttu7mGPkxdGpR-WtVoxDT5qtwxUC-Dge5a5A@mail.gmail.com>\n\t<20170907075152.4522-1-luca@coelho.fi>\n\t<877exan0nq.fsf@kamboji.qca.qualcomm.com>","From":"Linus Torvalds <torvalds@linux-foundation.org>","Date":"Thu, 7 Sep 2017 09:13:00 -0700","X-Google-Sender-Auth":"6RZ9WGVGaeiYnAwWLzo_cCR-V6Y","Message-ID":"<CA+55aFyeEwg7vd8FPHqG+4d7KbJ6ke4NDwhd+8y=_auRApyvmw@mail.gmail.com>","Subject":"Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it","To":"Kalle Valo <kvalo@codeaurora.org>","Cc":"Luca Coelho <luca@coelho.fi>,\n\tLinux Wireless List <linux-wireless@vger.kernel.org>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tLinux Kernel Mailing List <linux-kernel@vger.kernel.org>,\n\tAndrew Morton <akpm@linux-foundation.org>,\n\tNetwork Development <netdev@vger.kernel.org>,\n\tDavid Miller <davem@davemloft.net>,\n\tEmmanuel Grumbach <emmanuel.grumbach@intel.com>,\n\tLuca Coelho <luciano.coelho@intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764827,"web_url":"http://patchwork.ozlabs.org/comment/1764827/","msgid":"<8760culb38.fsf@kamboji.qca.qualcomm.com>","list_archive_url":null,"date":"2017-09-07T16:36:43","subject":"Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it","submitter":{"id":65411,"url":"http://patchwork.ozlabs.org/api/people/65411/","name":"Kalle Valo","email":"kvalo@codeaurora.org"},"content":"Linus Torvalds <torvalds@linux-foundation.org> writes:\n\n> On Thu, Sep 7, 2017 at 5:39 AM, Kalle Valo <kvalo@codeaurora.org> wrote:\n>>\n>> Linus, do you want to apply this directly or should we take it via the\n>> normal route (wireless-drivers -> net)? If your prefer the latter when\n>> I'm planning to submit this to Dave in a day or two and expecting it to\n>> get to your tree in about a week, depending of course what is Dave's\n>> schedule.\n>\n> Since we have a workaround for the problem, let's just go through the\n> regular channels. As long as I get the fix through David before the\n> merge window closes, I'm happy.\n\nOk, I'll aim to send the pull request to Dave tomorrow.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"ObnJWS5E\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"ct0Hc1kC\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=kvalo@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xp5hQ6wyfz9s78\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  8 Sep 2017 02:37:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752460AbdIGQg5 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 12:36:57 -0400","from smtp.codeaurora.org ([198.145.29.96]:50294 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751666AbdIGQgz (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 7 Sep 2017 12:36:55 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 2A84260B69; Thu,  7 Sep 2017 16:36:53 +0000 (UTC)","from potku.adurom.net (a88-114-240-52.elisa-laajakaista.fi\n\t[88.114.240.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: kvalo@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 66E9360A09;\n\tThu,  7 Sep 2017 16:36:46 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504802214;\n\tbh=19xWx9+6kU/22LcqrN+XqnTQVMLq6go4ZUgMPcfc4Q0=;\n\th=From:To:Cc:Subject:References:Date:In-Reply-To:From;\n\tb=ObnJWS5EbiTQBK/s/+SR4QZ4LCmBKkg9eIu4DZX8DdAuZ9KKeCVf5nNzPNbp8WcTN\n\tWzhOB0K503RY3lziM5OvotXM/kUYJLEKvYUc+nY0t2dazGPBUYfVVF0g0NmL4xrSf8\n\tUdFgf22Z05mGTb3coFKZCRx0P5xyIYuaPowwX9qY=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504802208;\n\tbh=19xWx9+6kU/22LcqrN+XqnTQVMLq6go4ZUgMPcfc4Q0=;\n\th=From:To:Cc:Subject:References:Date:In-Reply-To:From;\n\tb=ct0Hc1kCIYLKRfcdoNHlzwXsjISLgkqRkqiX2wrp6I+Fd+JX25yeB42mM0QKP+gpc\n\tHZIuLGTtmNji891qd5vrVpomKr/1a6Zlnz0LQV2NYO0y9ApVEFog2+zqtjB+xGKUId\n\tQB7B0zTfmWrtthZq3E3O8r6l22+PXH7hRDsJi8Y0="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org 66E9360A09","From":"Kalle Valo <kvalo@codeaurora.org>","To":"Linus Torvalds <torvalds@linux-foundation.org>","Cc":"Luca Coelho <luca@coelho.fi>,\n\tLinux Wireless List <linux-wireless@vger.kernel.org>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tLinux Kernel Mailing List <linux-kernel@vger.kernel.org>,\n\tAndrew Morton <akpm@linux-foundation.org>,\n\tNetwork Development <netdev@vger.kernel.org>,\n\tDavid Miller <davem@davemloft.net>,\n\tEmmanuel Grumbach <emmanuel.grumbach@intel.com>,\n\tLuca Coelho <luciano.coelho@intel.com>","Subject":"Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it","References":"<CA+55aFxjHSW7v4Ttu7mGPkxdGpR-WtVoxDT5qtwxUC-Dge5a5A@mail.gmail.com>\n\t<20170907075152.4522-1-luca@coelho.fi>\n\t<877exan0nq.fsf@kamboji.qca.qualcomm.com>\n\t<CA+55aFyeEwg7vd8FPHqG+4d7KbJ6ke4NDwhd+8y=_auRApyvmw@mail.gmail.com>","Date":"Thu, 07 Sep 2017 19:36:43 +0300","In-Reply-To":"<CA+55aFyeEwg7vd8FPHqG+4d7KbJ6ke4NDwhd+8y=_auRApyvmw@mail.gmail.com>\n\t(Linus Torvalds's message of \"Thu, 7 Sep 2017 09:13:00 -0700\")","Message-ID":"<8760culb38.fsf@kamboji.qca.qualcomm.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764830,"web_url":"http://patchwork.ozlabs.org/comment/1764830/","msgid":"<20170907164027.2C5926073D@smtp.codeaurora.org>","list_archive_url":null,"date":"2017-09-07T16:40:27","subject":"Re: iwlwifi: mvm: only send LEDS_CMD when the FW supports it","submitter":{"id":65411,"url":"http://patchwork.ozlabs.org/api/people/65411/","name":"Kalle Valo","email":"kvalo@codeaurora.org"},"content":"Luciano Coelho <luca@coelho.fi> wrote:\n\n> From: Luca Coelho <luciano.coelho@intel.com>\n> \n> The LEDS_CMD command is only supported in some newer FW versions\n> (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions\n> (such as iwlwifi-8000C-27.ucode).\n> \n> To fix this, check for a new bit in the FW capabilities TLV that tells\n> when the command is supported.\n> \n> Note that the current version of -31.ucode in linux-firmware.git\n> (31.532993.0) does not have this capability bit set, so the LED won't\n> work, even though this version should support it.  But we will update\n> this firmware soon, so it won't be a problem anymore.\n> \n> Fixes: 7089ae634c50 (\"iwlwifi: mvm: use firmware LED command where applicable\")\n> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>\n> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>\n\nPatch applied to wireless-drivers.git, thanks.\n\n2eabc84d2f8e iwlwifi: mvm: only send LEDS_CMD when the FW supports it","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"AKMPkfQJ\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"YD08uzQd\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=kvalo@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xp5mS3Hylz9s8J\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  8 Sep 2017 02:40:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754477AbdIGQk3 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 12:40:29 -0400","from smtp.codeaurora.org ([198.145.29.96]:33548 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753640AbdIGQk1 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 7 Sep 2017 12:40:27 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 2C5926073D; Thu,  7 Sep 2017 16:40:27 +0000 (UTC)","from potku.adurom.net (a88-114-240-52.elisa-laajakaista.fi\n\t[88.114.240.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: kvalo@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 7EF7C601CF;\n\tThu,  7 Sep 2017 16:40:24 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504802427;\n\tbh=lQBRhwrtBo2c7WwC2cyRDwNWawQIk7SHrTRaFoPqfdc=;\n\th=Subject:From:In-Reply-To:References:To:Cc:Date:From;\n\tb=AKMPkfQJ0jsDfR3YhOQVMh3zxZQJPFcmdXBIN8n7IZiNdEys3ugHwT6gDYkvqCQ0a\n\tBGXquwFhOoMDUGiNdye+Zph1W9lzNaF8HA5f2nHm5dliA1O08pdWSSEknVdKxnxaOL\n\tF7vsRfYCl2otpEKXxePlf1HXnv82PVG5HFq+zTKw=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504802426;\n\tbh=lQBRhwrtBo2c7WwC2cyRDwNWawQIk7SHrTRaFoPqfdc=;\n\th=Subject:From:In-Reply-To:References:To:Cc:From;\n\tb=YD08uzQd9aYBoMb8RiDVcMFLKp1mRKhjcNkmsx2ntvzrc3xUZ88u1XgNh/8j5j+Jm\n\tXK4724qQLZikksF5NNriupeTic8at7ImP8HDAl5Mqp5fgkJ4n4Dg08VnN1bRlb0FUW\n\thLVc6FCBkleZ6FZU3Oip4H7BVcX8crsdwOLrQ6H4="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no\n\tautolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7EF7C601CF","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","Subject":"Re: iwlwifi: mvm: only send LEDS_CMD when the FW supports it","From":"Kalle Valo <kvalo@codeaurora.org>","In-Reply-To":"<20170907075152.4522-1-luca@coelho.fi>","References":"<20170907075152.4522-1-luca@coelho.fi>","To":"Luciano Coelho <luca@coelho.fi>","Cc":"torvalds@linux-foundation.org, linux-wireless@vger.kernel.org,\n\tjohannes@sipsolutions.net, linux-kernel@vger.kernel.org,\n\takpm@linux-foundation.org, netdev@vger.kernel.org,\n\tdavem@davemloft.net, emmanuel.grumbach@intel.com,\n\tLuca Coelho <luciano.coelho@intel.com>","User-Agent":"pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12","Message-Id":"<20170907164027.2C5926073D@smtp.codeaurora.org>","Date":"Thu,  7 Sep 2017 16:40:27 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]