[{"id":1766809,"web_url":"http://patchwork.ozlabs.org/comment/1766809/","msgid":"<CACRpkdbezH6GcyZi8FgWhL-9zuDrrQJgfy+mhhvGQwLWr4kO0A@mail.gmail.com>","list_archive_url":null,"date":"2017-09-12T09:27:08","subject":"Re: [PATCH 1/2] pinctrl: sprd: check for allocation failure","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Thu, Sep 7, 2017 at 9:29 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:\n\n> devm_pinctrl_get() could fail with ERR_PTR(-ENOMEM) so I have added a\n> check for that.  I also reversed the other IS_ERR() test because it was\n> a little confusing to test one way and then the opposite a couple lines\n> later.\n>\n> Fixes: 41d32cfce1ae (\"pinctrl: sprd: Add Spreadtrum pin control driver\")\n> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n\nPatch applied for fixes.\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<linux-gpio-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"LtkJ6w8F\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrzw03FJ0z9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 19:27:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751330AbdILJ1K (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 12 Sep 2017 05:27:10 -0400","from mail-io0-f181.google.com ([209.85.223.181]:34041 \"EHLO\n\tmail-io0-f181.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751253AbdILJ1J (ORCPT\n\t<rfc822; linux-gpio@vger.kernel.org>); Tue, 12 Sep 2017 05:27:09 -0400","by mail-io0-f181.google.com with SMTP id v36so30136049ioi.1\n\tfor <linux-gpio@vger.kernel.org>;\n\tTue, 12 Sep 2017 02:27:09 -0700 (PDT)","by 10.79.164.78 with HTTP; Tue, 12 Sep 2017 02:27:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=3j3imslJqv8N6mGb2Vs2GxZaOFmxqBqCr3NfGVnxFhQ=;\n\tb=LtkJ6w8FXSQyPe98cES1sVP6TfewTZiUIpmQU7/lnEqZG1etce3tt43bEK5wGnZRst\n\tjzWaqIT5YC3k3/Ud0NoTNM89NTLkClzjknUdaofWcQWuTqKT1vxsR7mnPYDzrUlH3ZBo\n\t7cDims8rlxn1MRVmupB4T26pH7DtAYpj/PZ4o=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=3j3imslJqv8N6mGb2Vs2GxZaOFmxqBqCr3NfGVnxFhQ=;\n\tb=WuXnJVWIaV8wBoZ8KuA4rPl/LfJbFxv3VGydHQ1+gmS1qruoqxMOjHuv/HXPi1Gaub\n\tV9HQN1Fq/HxM8osBqjgiKjDOMbm6auG82jrUrFbqkjZ+lj7LRP8BS6phGUs8HCAfkZZ2\n\tdbalanCW4ASmYeiRaCE3nZT5TtaT15q/BBv5ysrJaN89Qr5soLqLRLao75nj3faTXo2a\n\tvpP4gs+DSJGwWR95nvQqb/3Eq8OO17Z9fMMIpKUl4ji39erjDk7dR/X9uAu64BdO4FVi\n\tmWH+vfjKOXk1bjmVpsVRt5Pgp7WKN0gGQn5/uW3pp2ztMmPMjbjRAlMAILbmi+33YJ0g\n\tXUqw==","X-Gm-Message-State":"AHPjjUgYaU2vtrJ0PPq3JV3EFeX79i7vM8NLRxfaW7kwNDmgmOF47NI0\n\tbflC4TJeDDMwmLT9qNAJfp20LZRyYIh1","X-Google-Smtp-Source":"AOwi7QAQh1vqMIoLwd7J0xAkVATLy9fODlwQPYvx1xBSioz7TmMINL0fQoNoWuSWEP3H/D23mQVKPdY5LvchV12pMbM=","X-Received":"by 10.107.139.215 with SMTP id\n\tn206mr19674894iod.155.1505208429287; \n\tTue, 12 Sep 2017 02:27:09 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170907072926.56oqezwk4r72yjgt@mwanda>","References":"<20170907072926.56oqezwk4r72yjgt@mwanda>","From":"Linus Walleij <linus.walleij@linaro.org>","Date":"Tue, 12 Sep 2017 11:27:08 +0200","Message-ID":"<CACRpkdbezH6GcyZi8FgWhL-9zuDrrQJgfy+mhhvGQwLWr4kO0A@mail.gmail.com>","Subject":"Re: [PATCH 1/2] pinctrl: sprd: check for allocation failure","To":"Dan Carpenter <dan.carpenter@oracle.com>","Cc":"Baolin Wang <baolin.wang@spreadtrum.com>,\n\t\"linux-gpio@vger.kernel.org\" <linux-gpio@vger.kernel.org>,\n\tkernel-janitors@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-gpio.vger.kernel.org>","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]