[{"id":1764746,"web_url":"http://patchwork.ozlabs.org/comment/1764746/","msgid":"<20170907141048.GJ11248@lunn.ch>","list_archive_url":null,"date":"2017-09-07T14:10:48","subject":"Re: [PATCH net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Thu, Sep 07, 2017 at 07:11:26AM +0000, Nisar.Sayed@microchip.com wrote:\n> From: Nisar Sayed \n> \n> Allow EEPROM write for less than MAX_EEPROM_SIZE\n> \n> Signed-off-by: Nisar Sayed \n> ---\n> drivers/net/usb/lan78xx.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c\n> index baf91c7..94ef943 100644\n> --- a/drivers/net/usb/lan78xx.c\n> +++ b/drivers/net/usb/lan78xx.c\n> @@ -1299,6 +1299,10 @@ static int lan78xx_ethtool_set_eeprom(struct net_device *netdev,\n\nstatic int lan78xx_ethtool_set_eeprom(struct net_device *netdev,\n struct ethtool_eeprom *ee, u8 *data)\n{\n struct lan78xx_net *dev = netdev_priv(netdev);\n\n\n /* Allow entire eeprom update only */\n if ((ee->magic == LAN78XX_EEPROM_MAGIC) &&\n (ee->offset == 0) &&\n (ee->len == 512) &&\n (data[0] == EEPROM_INDICATOR))\n return lan78xx_write_raw_eeprom(dev, ee->offset, ee->len, data);\n else if ((ee->magic == LAN78XX_OTP_MAGIC) &&\n> \t\t (ee->len == 512) &&\n> \t\t (data[0] == OTP_INDICATOR_1))\n> \t\tret = lan78xx_write_raw_otp(dev, ee->offset, ee->len, data);\n> +\telse if ((ee->magic == LAN78XX_EEPROM_MAGIC) &&\n> +\t\t (ee->offset >= 0 && ee->offset < MAX_EEPROM_SIZE) &&\n> +\t\t (ee->len > 0 && (ee->offset + ee->len) <= MAX_EEPROM_SIZE))\n> +\t\tret = lan78xx_write_raw_eeprom(dev, ee->offset, ee->len, data);\n> \n> \tusb_autopm_put_interface(dev->intf);\n\nHi Nisar\n\nYou should explain why this change cannot be folded into the first if\nstatement.\n\n\tAndrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xp2Rf34Gmz9s9Y\n\tfor ;\n\tFri, 8 Sep 2017 00:10:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932083AbdIGOKw (ORCPT );\n\tThu, 7 Sep 2017 10:10:52 -0400","from vps0.lunn.ch ([178.209.37.122]:59594 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1754005AbdIGOKv (ORCPT );\n\tThu, 7 Sep 2017 10:10:51 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dpxW4-0003q9-Gd; Thu, 07 Sep 2017 16:10:48 +0200"],"Date":"Thu, 7 Sep 2017 16:10:48 +0200","From":"Andrew Lunn ","To":"Nisar.Sayed@microchip.com","Cc":"davem@davemloft.net, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","Message-ID":"<20170907141048.GJ11248@lunn.ch>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]