[{"id":1768269,"web_url":"http://patchwork.ozlabs.org/comment/1768269/","msgid":"<1505351529.3761.1.camel@russell.cc>","date":"2017-09-14T01:12:09","subject":"Re: [PATCH 2/2] powerpc/powernv: Rework EEH initialization on\n\tpowernv","submitter":{"id":67478,"url":"http://patchwork.ozlabs.org/api/people/67478/","name":"Russell Currey","email":"ruscur@russell.cc"},"content":"On Thu, 2017-09-07 at 16:35 +1000, Benjamin Herrenschmidt wrote:\n> Remove the post_init callback which is only used\n> by powernv, we can just call it explicitly from\n> the powernv code.\n> \n> This partially kills the ability to \"disable\" eeh at\n> runtime via debugfs as this was calling that same\n> callback again, but this is both unused and broken\n> in several ways. If we want to revive it, we need\n> to create a dedicated enable/disable callback on the\n> backend that does the right thing.\n> \n> Let the bulk of eeh initialize normally at\n> core_initcall() like it does on pseries by removing\n> the hack in eeh_init() that delays it.\n> \n> Instead we make sure our eeh->probe cleanly bails\n> out of the PEs haven't been created yet and we force\n> a re-probe where we used to call eeh_init() again.\n> \n> Signed-off-by: Benjamin Herrenschmidt \n\nAcked-by: Russell Currey ","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt10d0bFWz9s4q\n\tfor ;\n\tThu, 14 Sep 2017 11:19:45 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xt10c6VTjzDqpb\n\tfor ;\n\tThu, 14 Sep 2017 11:19:44 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xt0z06Th6zDql1\n\tfor ;\n\tThu, 14 Sep 2017 11:18:20 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\tby bilbo.ozlabs.org (Postfix) with ESMTP id 3xt0z05gmzz8t79\n\tfor ;\n\tThu, 14 Sep 2017 11:18:20 +1000 (AEST)","by ozlabs.org (Postfix)\n\tid 3xt0z05Jttz9t3k; Thu, 14 Sep 2017 11:18:20 +1000 (AEST)","from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt0z02m4mz9ryv\n\tfor ; Thu, 14 Sep 2017 11:18:20 +1000 (AEST)","from compute6.internal (compute6.nyi.internal [10.202.2.46])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 3C4F820E80;\n\tWed, 13 Sep 2017 21:12:12 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute6.internal (MEProxy); Wed, 13 Sep 2017 21:12:12 -0400","from snap.ozlabs.ibm.com (unknown [122.99.82.10])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 1EE59244B4;\n\tWed, 13 Sep 2017 21:12:10 -0400 (EDT)"],"Authentication-Results":["ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"Itizvny0\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"Itizvny0\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"Itizvny0\"; dkim-atps=neutral","ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=russell.cc\n\t(client-ip=66.111.4.27; helo=out3-smtp.messagingengine.com;\n\tenvelope-from=ruscur@russell.cc; receiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"Itizvny0\"; dkim-atps=neutral"],"X-Greylist":"delayed 382 seconds by postgrey-1.36 at bilbo;\n\tThu, 14 Sep 2017 11:18:20 AEST","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=\n\tfm1; bh=xt90iinvm5bIR7l85OGOE9xGQQ/nN3cbNHeWD+T6O14=; b=Itizvny0\n\toZC+UE1w9uXvL6f3uJamH0ddywvOluhbjShjQ5nkmKiaTPe/TRRybYFByZFmw2fZ\n\t/YGTafmGmg5I6+aq+ZvtW9A+6+taQsyvRttVTSJouEohTBhndiDSAd1PrQHmsavO\n\tCUdoevKjoVGmtp5fxYYy5RNA7gpKvXjDuyDWz10b5qY1jtnDTYPkP2K38ba5O0Sp\n\t1+rCTId9B/qbn9l9dDcI9RoOFc/ChcTdEKllK+8sKUc8R9WLRbmYYVZTryC+g/jY\n\tf2SG340tifNkG4AZ9vcTW6B6jEY0PbG7n8q7BQ5ynpCpfOsv6yfrPMXbgb+xZUH2\n\t4VxQ47ktTG5J4Q==","X-ME-Sender":"","X-Sasl-enc":"nQLGfvU7OfZFocg/Yas8Jg4cLjmp8Qt6YGk8PggcGGVj 1505351531","Message-ID":"<1505351529.3761.1.camel@russell.cc>","Subject":"Re: [PATCH 2/2] powerpc/powernv: Rework EEH initialization on\n\tpowernv","From":"Russell Currey ","To":"Benjamin Herrenschmidt ,\n\tlinuxppc-dev@ozlabs.org","Date":"Thu, 14 Sep 2017 11:12:09 +1000","In-Reply-To":"<1504766144.12628.15.camel@kernel.crashing.org>","References":"<1504766144.12628.15.camel@kernel.crashing.org>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1776233,"web_url":"http://patchwork.ozlabs.org/comment/1776233/","msgid":"<3y2Df70nk9z9tXs@ozlabs.org>","date":"2017-09-27T10:32:15","subject":"Re: [2/2] powerpc/powernv: Rework EEH initialization on powernv","submitter":{"id":69509,"url":"http://patchwork.ozlabs.org/api/people/69509/","name":"Michael Ellerman","email":"patch-notifications@ellerman.id.au"},"content":"On Thu, 2017-09-07 at 06:35:44 UTC, Benjamin Herrenschmidt wrote:\n> Remove the post_init callback which is only used\n> by powernv, we can just call it explicitly from\n> the powernv code.\n> \n> This partially kills the ability to \"disable\" eeh at\n> runtime via debugfs as this was calling that same\n> callback again, but this is both unused and broken\n> in several ways. If we want to revive it, we need\n> to create a dedicated enable/disable callback on the\n> backend that does the right thing.\n> \n> Let the bulk of eeh initialize normally at\n> core_initcall() like it does on pseries by removing\n> the hack in eeh_init() that delays it.\n> \n> Instead we make sure our eeh->probe cleanly bails\n> out of the PEs haven't been created yet and we force\n> a re-probe where we used to call eeh_init() again.\n> \n> Signed-off-by: Benjamin Herrenschmidt \n> Acked-by: Russell Currey \n\nPatch 2 applied to powerpc next, thanks.\n\nhttps://git.kernel.org/powerpc/c/b9fde58db7e5738cacb740b0ec5479\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Dgf5JzWz9tXf\n\tfor ;\n\tWed, 27 Sep 2017 20:33:34 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y2Dgf4KLFzDsQS\n\tfor ;\n\tWed, 27 Sep 2017 20:33:34 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y2Df71ZqTzDqNm\n\tfor ;\n\tWed, 27 Sep 2017 20:32:15 +1000 (AEST)","by ozlabs.org (Postfix)\n\tid 3y2Df70zPLz9tXf; Wed, 27 Sep 2017 20:32:15 +1000 (AEST)","by ozlabs.org (Postfix, from userid 1034)\n\tid 3y2Df70nk9z9tXs; Wed, 27 Sep 2017 20:32:15 +1000 (AEST)"],"X-powerpc-patch-notification":"thanks","X-powerpc-patch-commit":"b9fde58db7e5738cacb740b0ec547933fe314fbe","In-Reply-To":"<1504766144.12628.15.camel@kernel.crashing.org>","To":"Benjamin Herrenschmidt ,\n\tlinuxppc-dev@ozlabs.org","From":"Michael Ellerman ","Subject":"Re: [2/2] powerpc/powernv: Rework EEH initialization on powernv","Message-Id":"<3y2Df70nk9z9tXs@ozlabs.org>","Date":"Wed, 27 Sep 2017 20:32:15 +1000 (AEST)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Russell Currey ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]