[{"id":1774139,"web_url":"http://patchwork.ozlabs.org/comment/1774139/","msgid":"<4596376b-607d-46f5-1c57-d8e8791cf57b@mind.be>","list_archive_url":null,"date":"2017-09-24T11:53:55","subject":"Re: [Buildroot] [PATCH v2] pkg-download: remove explicit\n\tPKG_VERSION from github helper","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"On 07-09-17 08:31, Marcin Nowakowski wrote:\n> Currently it is always required to add package version as an argument to\n> the github helper. Since the version is always defined as PKG_VERSION,\n> drop this argument and generate it automatically inside the helper\n> routine.\n> \n> The github helper function is extended to support both 2 and 3 argument\n> variants (ie. either use the provided package version argument or\n> automatically substitute with PKG_VERSION if not available), which can\n> make the transition of the package files easier as well allows using the\n> 3-argument variant outside of package definitions.\n> \n> Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>\n\n\n Applied to master, thanks. I extended the text in the manual a little bit to\ncover the case where you do have to use the third argument.\n\n Next step is a mass update removing the third argument.\n\n Regards,\n Arnout\n\n\n> ---\n> Changes:\n>   v3\n>     - v2 has an errorenous trailing ')'\n>   v2\n>     - update docs to include optional version argument\n>     - use $(or $foo,...) instead of $(if $foo,$foo,...)\n> ---\n>  docs/manual/adding-packages-tips.txt | 4 +++-\n>  package/pkg-download.mk              | 4 ++--\n>  2 files changed, 5 insertions(+), 3 deletions(-)\n> \n> diff --git a/docs/manual/adding-packages-tips.txt b/docs/manual/adding-packages-tips.txt\n> index 19577fa..8caf2b9 100644\n> --- a/docs/manual/adding-packages-tips.txt\n> +++ b/docs/manual/adding-packages-tips.txt\n> @@ -138,7 +138,7 @@ past, the 'github' helper function should be used as shown below.\n>  ------------------------\n>  # Use a tag or a full commit ID\n>  FOO_VERSION = v1.0\n> -FOO_SITE = $(call github,<user>,<package>,$(FOO_VERSION))\n> +FOO_SITE = $(call github,<user>,<package>[,<version>])\n>  ------------------------\n>  \n>  .Notes\n> @@ -147,6 +147,8 @@ FOO_SITE = $(call github,<user>,<package>,$(FOO_VERSION))\n>    Buildroot (e.g.: +foo-f6fb6654af62045239caed5950bc6c7971965e60.tar.gz+),\n>    so it is not necessary to specify it in the +.mk+ file.\n>  - When using a commit ID as version, you should use the full 40 hex characters.\n> +- +version+ parameter is optional and should only be specified if anything\n> +  other than FOO_VERSION needs to be used\n>  \n>  If the package you wish to add does have a release section on GitHub, the\n>  maintainer may have uploaded a release tarball, or the release may just point\n> diff --git a/package/pkg-download.mk b/package/pkg-download.mk\n> index fbbc2d7..7489fca 100644\n> --- a/package/pkg-download.mk\n> +++ b/package/pkg-download.mk\n> @@ -52,8 +52,8 @@ notdomain = $(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$\n>  # default domainseparator is /, specify alternative value as first argument\n>  domainseparator = $(if $(1),$(1),/)\n>  \n> -# github(user,package,version): returns site of GitHub repository\n> -github = https://github.com/$(1)/$(2)/archive/$(3)\n> +# github(user,package[,version]): returns site of GitHub repository\n> +github = https://github.com/$(1)/$(2)/archive/$(or $(3),$($(call UPPERCASE,$(pkgname))_VERSION))\n>  \n>  # Expressly do not check hashes for those files\n>  # Exported variables default to immediately expanded in some versions of\n>","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0QcX34RWz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 24 Sep 2017 21:54:36 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B79C78839A;\n\tSun, 24 Sep 2017 11:54:33 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hZS-2teg6Ea7; Sun, 24 Sep 2017 11:54:31 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3CA4C88380;\n\tSun, 24 Sep 2017 11:54:31 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6ED941C0021\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 24 Sep 2017 11:54:30 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6A63688B89\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 24 Sep 2017 11:54:30 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BKwtDcB4rT7I for <buildroot@lists.busybox.net>;\n\tSun, 24 Sep 2017 11:54:29 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0FA9288B82\n\tfor <buildroot@buildroot.org>; Sun, 24 Sep 2017 11:54:28 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tSun, 24 Sep 2017 13:53:57 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"Marcin Nowakowski <marcin.nowakowski@imgtec.com>,\n\t<buildroot@buildroot.org>","References":"<1504765866-7138-1-git-send-email-marcin.nowakowski@imgtec.com>","From":"Arnout Vandecappelle <arnout@mind.be>","Organization":"Essensium/Mind","Message-ID":"<4596376b-607d-46f5-1c57-d8e8791cf57b@mind.be>","Date":"Sun, 24 Sep 2017 13:53:55 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504765866-7138-1-git-send-email-marcin.nowakowski@imgtec.com>","Content-Language":"en-GB","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Subject":"Re: [Buildroot] [PATCH v2] pkg-download: remove explicit\n\tPKG_VERSION from github helper","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}},{"id":1777912,"web_url":"http://patchwork.ozlabs.org/comment/1777912/","msgid":"<87o9psfgq6.fsf@dell.be.48ers.dk>","list_archive_url":null,"date":"2017-09-30T13:39:29","subject":"Re: [Buildroot] [PATCH v2] pkg-download: remove explicit\n\tPKG_VERSION from github helper","submitter":{"id":42365,"url":"http://patchwork.ozlabs.org/api/people/42365/","name":"Peter Korsgaard","email":"peter@korsgaard.com"},"content":">>>>> \"Arnout\" == Arnout Vandecappelle <arnout@mind.be> writes:\n\n > On 07-09-17 08:31, Marcin Nowakowski wrote:\n >> Currently it is always required to add package version as an argument to\n >> the github helper. Since the version is always defined as PKG_VERSION,\n >> drop this argument and generate it automatically inside the helper\n >> routine.\n >> \n >> The github helper function is extended to support both 2 and 3 argument\n >> variants (ie. either use the provided package version argument or\n >> automatically substitute with PKG_VERSION if not available), which can\n >> make the transition of the package files easier as well allows using the\n >> 3-argument variant outside of package definitions.\n >> \n >> Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>\n\n\n >  Applied to master, thanks. I extended the text in the manual a little bit to\n > cover the case where you do have to use the third argument.\n\n >  Next step is a mass update removing the third argument.\n\nHave you tested this? It doesn't seem to work for me UNLESS I use\n\nFOO_SITE := $(call github,user,product)\n\nInstead of the normal FOO_SITE = to get it expanded right away. I guess\npkgname gets expanded too late.\n\nE.G. if I drop the explicit version argument from librtlsdr:\n\nLIBRTLSDR_SITE = $(call github,steve-m,librtlsdr)\n\n\nmake BR2_BACKUP_SITE='' librtlsdr-source\n>>> librtlsdr v0.5.3 Downloading\n--2017-09-30 15:36:00--  https://github.com/steve-m/librtlsdr/archive//librtlsdr-v0.5.3.tar.gz\nResolving github.com (github.com)... 192.30.253.112, 192.30.253.113\nConnecting to github.com (github.com)|192.30.253.112|:443... connected.\nHTTP request sent, awaiting response... 302 Found\nLocation: https://codeload.github.com/steve-m/librtlsdr/tar.gz/librtlsdr-v0.5.3 [following]\n--2017-09-30 15:36:00--  https://codeload.github.com/steve-m/librtlsdr/tar.gz/librtlsdr-v0.5.3\nResolving codeload.github.com (codeload.github.com)... 192.30.253.120, 192.30.253.121\nConnecting to codeload.github.com (codeload.github.com)|192.30.253.120|:443... connected.\nHTTP request sent, awaiting response... 404 Not Found\n2017-09-30 15:36:01 ERROR 404: Not Found.\n\npackage/pkg-generic.mk:146: recipe for target '/home/peko/source/buildroot/output-rpi/build/librtlsdr-v0.5.3/.stamp_downloaded' failed\n\nNotice the missing version between archive and the file name.\n\n\nWith LIBRTLSDR_SITE := $(call github,steve-m,librtlsdr) I get:\n\nmake BR2_BACKUP_SITE='' librtlsdr-source\n>>> librtlsdr v0.5.3 Downloading\n--2017-09-30 15:38:20--  https://github.com/steve-m/librtlsdr/archive/v0.5.3/librtlsdr-v0.5.3.tar.gz\nResolving github.com (github.com)... 192.30.253.113, 192.30.253.112\nConnecting to github.com (github.com)|192.30.253.113|:443... connected.\nHTTP request sent, awaiting response... 302 Found\nLocation: https://codeload.github.com/steve-m/librtlsdr/tar.gz/v0.5.3 [following]\n--2017-09-30 15:38:21--  https://codeload.github.com/steve-m/librtlsdr/tar.gz/v0.5.3\nResolving codeload.github.com (codeload.github.com)... 192.30.253.121, 192.30.253.120\nConnecting to codeload.github.com (codeload.github.com)|192.30.253.121|:443... connected.\nHTTP request sent, awaiting response... 200 OK\nLength: unspecified [application/x-gzip]\nSaving to: ‘/home/peko/source/buildroot/output-rpi/build/.librtlsdr-v0.5.3.tar.gz.CsUtgo/output’\n\n/home/peko/source/buildroot/output-rpi/build/.librtlsdr-     [  <=>                                                                                                                             ] 114.66K   374KB/s    in 0.3s\n\n2017-09-30 15:38:22 (374 KB/s) - ‘/home/peko/source/buildroot/output-rpi/build/.librtlsdr-v0.5.3.tar.gz.CsUtgo/output’ saved [117414]\n\nlibrtlsdr-v0.5.3.tar.gz: OK (sha256: 98fb5c34ac94d6f2235a0bb41a08f8bed7949e1d1b91ea57a7c1110191ea58de)\n\n\nI'm not sure how to fix it inside the github wrapper though.","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jNFcQABa\"; dkim-atps=neutral"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y48g46dPKz9t6f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 30 Sep 2017 23:39:44 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id EFF61886E9;\n\tSat, 30 Sep 2017 13:39:39 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iEx51yHNV4ZM; Sat, 30 Sep 2017 13:39:36 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A8B668862C;\n\tSat, 30 Sep 2017 13:39:36 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7E8661C03DA\n\tfor <buildroot@lists.busybox.net>;\n\tSat, 30 Sep 2017 13:39:35 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 79F5584705\n\tfor <buildroot@lists.busybox.net>;\n\tSat, 30 Sep 2017 13:39:35 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PmDtMExcO_op for <buildroot@lists.busybox.net>;\n\tSat, 30 Sep 2017 13:39:33 +0000 (UTC)","from mail-wm0-f48.google.com (mail-wm0-f48.google.com\n\t[74.125.82.48])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 2F41384702\n\tfor <buildroot@buildroot.org>; Sat, 30 Sep 2017 13:39:33 +0000 (UTC)","by mail-wm0-f48.google.com with SMTP id u138so3554530wmu.4\n\tfor <buildroot@buildroot.org>; Sat, 30 Sep 2017 06:39:33 -0700 (PDT)","from dell.be.48ers.dk (d51a5bc31.access.telenet.be.\n\t[81.165.188.49]) by smtp.gmail.com with ESMTPSA id\n\t58sm5813159edt.75.2017.09.30.06.39.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 30 Sep 2017 06:39:30 -0700 (PDT)","from peko by dell.be.48ers.dk with local (Exim 4.88)\n\t(envelope-from <peter@korsgaard.com>)\n\tid 1dyHzN-0000Ha-Bz; Sat, 30 Sep 2017 15:39:29 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:references:date:in-reply-to:message-id\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=VbbXt4Z7iZ9pVOwdEwxC2IzL3MZA4SnPRX8evk6sI2E=;\n\tb=jNFcQABa8dNQGHHyJiGxynpw4xitidiT8Sf4CY/9BqtiaT6eG+j7nuvQ7Z5o2qeBM3\n\tvhqPRKf9DpY0l9VJTmQ9MFWhGtNgB52bHz5O26ROQcDCROH3ue7ATUpUiSd9BSGdULf6\n\tuX7l5Js8VVLwIpB7NzijBtQdnjDNoSovCgE9nomVjs6rK3lQ/d1wDI+P1I7lDr5aLTQd\n\tuy9iebj70CY04aTbxMOuoU371gJgp3Zil6E9ZP5pB3s911Wl+U2/IaE9hq30V5Tgp8Eq\n\tEWYohnac1kQxJim7lrqZ69EsSweWwioPyuHdPcDlFjtcHe22DcwiVijP7hCpTi5/rOa8\n\tLUWw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:references:date\n\t:in-reply-to:message-id:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=VbbXt4Z7iZ9pVOwdEwxC2IzL3MZA4SnPRX8evk6sI2E=;\n\tb=XIQY5AIiUxizPn21pMmywrbxypI/X7X3AOOBxLlhpRPo7x/3BweWeBsD5vON40NKtn\n\t02dzlxh5GtCp7EU5EybU2vh6RwDGRzJ9nNmw+ai8h7WRf074///81DMdkLMzzDwGdu6x\n\ta2VCoGTTQZXCoGqEcDygta/Tyg/U9r13wed9FEnUVrCR9UnI7K7MYbYtBDB0mwoey9dW\n\tT2WWUkCTXs/JVMxrsJDDyg2Th+Smh/wqlLRoYQs2IxjH9kE2L0S0CL5X8pBfAaltpuB9\n\tp3E4FbE2pEKOIcDdiHZD9O/BcedbwCaYROpK8me/0F6gHjS2RVmDKcCTh9WhMQmBWtLD\n\t0l+g==","X-Gm-Message-State":"AHPjjUiOrdGxqBEkFPu4hacIrSYRQH1eZ/sZvaD22ynBjliRh4m1TbFZ\n\tkeUe9oUURGkoz0rOZwfQQro=","X-Google-Smtp-Source":"AOwi7QD6v6mXZWatd+lMhvT7f0nNBOeZSHiac7Ky0Ze/hRyN/8NN5xYK3x35lS5Shev8EosjHSI3LA==","X-Received":"by 10.80.135.29 with SMTP id i29mr13620635edb.31.1506778771450; \n\tSat, 30 Sep 2017 06:39:31 -0700 (PDT)","From":"Peter Korsgaard <peter@korsgaard.com>","To":"Arnout Vandecappelle <arnout@mind.be>","References":"<1504765866-7138-1-git-send-email-marcin.nowakowski@imgtec.com>\n\t<4596376b-607d-46f5-1c57-d8e8791cf57b@mind.be>","Date":"Sat, 30 Sep 2017 15:39:29 +0200","In-Reply-To":"<4596376b-607d-46f5-1c57-d8e8791cf57b@mind.be> (Arnout\n\tVandecappelle's message of \"Sun, 24 Sep 2017 13:53:55 +0200\")","Message-ID":"<87o9psfgq6.fsf@dell.be.48ers.dk>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)","MIME-Version":"1.0","Cc":"Marcin Nowakowski <marcin.nowakowski@imgtec.com>, buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v2] pkg-download: remove explicit\n\tPKG_VERSION from github helper","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}},{"id":1777928,"web_url":"http://patchwork.ozlabs.org/comment/1777928/","msgid":"<01885726-bcc2-5930-5076-6882bf199c8a@mind.be>","list_archive_url":null,"date":"2017-09-30T17:16:17","subject":"Re: [Buildroot] [PATCH v2] pkg-download: remove explicit\n\tPKG_VERSION from github helper","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"On 30-09-17 15:39, Peter Korsgaard wrote:\n>>>>>> \"Arnout\" == Arnout Vandecappelle <arnout@mind.be> writes:\n> \n>  > On 07-09-17 08:31, Marcin Nowakowski wrote:\n>  >> Currently it is always required to add package version as an argument to\n>  >> the github helper. Since the version is always defined as PKG_VERSION,\n>  >> drop this argument and generate it automatically inside the helper\n>  >> routine.\n>  >> \n>  >> The github helper function is extended to support both 2 and 3 argument\n>  >> variants (ie. either use the provided package version argument or\n>  >> automatically substitute with PKG_VERSION if not available), which can\n>  >> make the transition of the package files easier as well allows using the\n>  >> 3-argument variant outside of package definitions.\n>  >> \n>  >> Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>\n> \n> \n>  >  Applied to master, thanks. I extended the text in the manual a little bit to\n>  > cover the case where you do have to use the third argument.\n> \n>  >  Next step is a mass update removing the third argument.\n> \n> Have you tested this? It doesn't seem to work for me UNLESS I use\n> \n> FOO_SITE := $(call github,user,product)\n> \n> Instead of the normal FOO_SITE = to get it expanded right away. I guess\n> pkgname gets expanded too late.\n\n Gah, my fault. I had written to use $(PKG) instead of $(pkgname) in v1 of the\npatch, but didn't double-check in v2. Hm, reading back my comment, I wasn't very\nexplicit about it apparently.\n\n Regards,\n Arnout","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y4FTs2nwBz9t2m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun,  1 Oct 2017 04:17:05 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B699285DCA;\n\tSat, 30 Sep 2017 17:16:57 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WMoGaJbBCto5; Sat, 30 Sep 2017 17:16:54 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2222E852B7;\n\tSat, 30 Sep 2017 17:16:54 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8C7BB1BF218\n\tfor <buildroot@lists.busybox.net>;\n\tSat, 30 Sep 2017 17:16:52 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 855FA852B7\n\tfor <buildroot@lists.busybox.net>;\n\tSat, 30 Sep 2017 17:16:52 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EwGM1HTFJcHZ for <buildroot@lists.busybox.net>;\n\tSat, 30 Sep 2017 17:16:51 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1185685165\n\tfor <buildroot@buildroot.org>; Sat, 30 Sep 2017 17:16:50 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tSat, 30 Sep 2017 19:16:19 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"Peter Korsgaard <peter@korsgaard.com>","References":"<1504765866-7138-1-git-send-email-marcin.nowakowski@imgtec.com>\n\t<4596376b-607d-46f5-1c57-d8e8791cf57b@mind.be>\n\t<87o9psfgq6.fsf@dell.be.48ers.dk>","From":"Arnout Vandecappelle <arnout@mind.be>","Organization":"Essensium/Mind","Message-ID":"<01885726-bcc2-5930-5076-6882bf199c8a@mind.be>","Date":"Sat, 30 Sep 2017 19:16:17 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<87o9psfgq6.fsf@dell.be.48ers.dk>","Content-Language":"en-GB","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Cc":"Marcin Nowakowski <marcin.nowakowski@imgtec.com>, buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v2] pkg-download: remove explicit\n\tPKG_VERSION from github helper","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}}]