[{"id":1764647,"web_url":"http://patchwork.ozlabs.org/comment/1764647/","msgid":"","list_archive_url":null,"date":"2017-09-07T10:58:57","subject":"Re: [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT\n\tbindings","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"Hi Vladimir,\n\nOn Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov\n wrote:\n> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a\n> supported board.\n>\n> Signed-off-by: Vladimir Barinov \n\nThanks for your patch!\n\n> --- a/Documentation/devicetree/bindings/arm/shmobile.txt\n> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt\n> @@ -85,6 +85,7 @@ Boards:\n> - Lager (RTP0RC7790SEB00010S)\n> compatible = \"renesas,lager\", \"renesas,r8a7790\"\n> - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))\n> + M3ULCB Kingfisher (SBEV-RCAR-KF-M03)\n\nAs the Kingfisher is an extension board (and you added the same board part\nnumber to the H3ULCB section in patch 02/18), shouldn't it have its own\ncompatible value \"shimafuji,kingfisher\" instead?\n\nThen this can be used in ulcb-kf.dtsi:\n\n compatible = \"shimafuji,kingfisher\";\n\nand appended (overridden, as there's no /append-property/ directive in dtc\nyet?) in the board files, e.g. r8a7796-m3ulcb-kf.dts:\n\n compatible = \"shimafuji,kingfisher\", \"renesas,m3ulcb\", \"renesas,r8a7796\";\n\nDoes that make sense?\n\n> compatible = \"renesas,m3ulcb\", \"renesas,r8a7796\";\n> - Marzen (R0P7779A00010S)\n> compatible = \"renesas,marzen\", \"renesas,r8a7779\"\n\nGr{oetje,eeting}s,\n\n Geert\n\n--\nGeert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n\nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like that.\n -- Linus Torvalds\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"NhqvLcY9\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnyBH3s0xz9s9Y\n\tfor ;\n\tThu, 7 Sep 2017 20:59:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755078AbdIGK7A (ORCPT\n\t);\n\tThu, 7 Sep 2017 06:59:00 -0400","from mail-pf0-f195.google.com ([209.85.192.195]:37508 \"EHLO\n\tmail-pf0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755059AbdIGK66 (ORCPT\n\t); Thu, 7 Sep 2017 06:58:58 -0400","by mail-pf0-f195.google.com with SMTP id a2so4350981pfj.4;\n\tThu, 07 Sep 2017 03:58:58 -0700 (PDT)","by 10.100.160.9 with HTTP; Thu, 7 Sep 2017 03:58:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=YrMUWFLZulw6Ti10mK/BSwVCZw9nSp3ZVrJIEnDlbjY=;\n\tb=NhqvLcY9Qa0ayhKvgos3tZ9NwJJa1IBYqYwV07NSm0is28K6E6jDNhpUa+bjxXDqYB\n\tVkvFjPNjA0Q+i1uI4ISUfjAoxbarAzM1lDZasOTOJ86uwLYCn88I7hrdvEgYIJ8bFCno\n\tWqn7nrJhbNDpergrnudppSvG+LTn0xexnp+x3NGhqNfaFzMRFNM+8sItm7EmiEuyoHEE\n\tafst45ezkOJl6Via34udOJ1AtxgVfUSGW/6pwDM9W0OKJySp/xMHJcSmKL8UCqSvFsyO\n\t7qIEfR1ynMOovrhiV+P7qWDCv7stskmDda68Jxfnt3Uj+djTEXqQlXhwR1ER+dCWaHXq\n\tJhHQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=YrMUWFLZulw6Ti10mK/BSwVCZw9nSp3ZVrJIEnDlbjY=;\n\tb=JkVG2c65Ws6tS/YGogH22BsgeK1XMravw7mEp7IW2Y9sZArr7fZqyNeIn1eZZkysQM\n\tCBJco0Sm+etK12mZcSol5uI2MCx4Cc1xtIlnGcfWaFHO0LN3XV5hsKapw4csbJezIAJv\n\tGDe+qKyqcSIBa7FKgqEgSTtps1bzzb86lFa4zLLm0zf5URypzXkF+I8527DmqOBOUcFD\n\tKnSo0XwXzfA6RR5ZvkyqIlNTcAuUslMaCnpu5ggXvViGGyFBkWICcvjT3GNJ9b9kA6vs\n\tNbWLly5c9vlzR9IcNBv0FkCsAwa/GBPYtHhpTM0UO9S1lvbD9g9aE8WfEcuLbQUCFK46\n\trVYQ==","X-Gm-Message-State":"AHPjjUj8fSKfZ72TYYt7bIxbKGYEQFC3/3RctiSWTkrsz8b9xJTAySQl\n\tjBiJ5HOnIRMjB0zg6v1gl/lUuFHjnQ==","X-Google-Smtp-Source":"ADKCNb6NWODYf0eZRXVRApJ5DZW/YXrH5icbT7dD2RU2c9AxoFybz3s47UEJuudNHaVBClRleJAJkNkpl7XOpH2UQSo=","X-Received":"by 10.99.190.77 with SMTP id g13mr2289866pgo.433.1504781937558; \n\tThu, 07 Sep 2017 03:58:57 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504737303-22874-1-git-send-email-vladimir.barinov@cogentembedded.com>","References":"<1504737267-22829-1-git-send-email-vladimir.barinov@cogentembedded.com>\n\t<1504737303-22874-1-git-send-email-vladimir.barinov@cogentembedded.com>","From":"Geert Uytterhoeven ","Date":"Thu, 7 Sep 2017 12:58:57 +0200","X-Google-Sender-Auth":"Dtym1CAefAHdEUM-tWyguonaz0g","Message-ID":"","Subject":"Re: [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT\n\tbindings","To":"Vladimir Barinov ","Cc":"Simon Horman , Magnus Damm , \n\tRob Herring , Mark Rutland ,\n\tCatalin Marinas ,\n\tWill Deacon ,\n\t\"devicetree@vger.kernel.org\" ,\n\tLinux-Renesas ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1765116,"web_url":"http://patchwork.ozlabs.org/comment/1765116/","msgid":"","list_archive_url":null,"date":"2017-09-08T07:05:40","subject":"Re: [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT\n\tbindings","submitter":{"id":47871,"url":"http://patchwork.ozlabs.org/api/people/47871/","name":"Vladimir Barinov","email":"vladimir.barinov@cogentembedded.com"},"content":"Hi Geert,\n\nOn 07.09.2017 13:58, Geert Uytterhoeven wrote:\n> Hi Vladimir,\n>\n> On Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov\n> wrote:\n>> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a\n>> supported board.\n>>\n>> Signed-off-by: Vladimir Barinov \n> Thanks for your patch!\n>\n>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt\n>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt\n>> @@ -85,6 +85,7 @@ Boards:\n>> - Lager (RTP0RC7790SEB00010S)\n>> compatible = \"renesas,lager\", \"renesas,r8a7790\"\n>> - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))\n>> + M3ULCB Kingfisher (SBEV-RCAR-KF-M03)\n> As the Kingfisher is an extension board (and you added the same board part\n> number to the H3ULCB section in patch 02/18), shouldn't it have its own\n> compatible value \"shimafuji,kingfisher\" instead?\nThank you for this suggestion.\n\nThis looks very meaningful for boards differentiation.\n\n> Then this can be used in ulcb-kf.dtsi:\n>\n> compatible = \"shimafuji,kingfisher\";\n>\n> and appended (overridden, as there's no /append-property/ directive in dtc\n> yet?) in the board files, e.g. r8a7796-m3ulcb-kf.dts:\n>\n> compatible = \"shimafuji,kingfisher\", \"renesas,m3ulcb\", \"renesas,r8a7796\";\n>\n> Does that make sense?\nYes.\nI will rework this in V2 patchset according to your suggestion.\n\n>\n>> compatible = \"renesas,m3ulcb\", \"renesas,r8a7796\";\n>> - Marzen (R0P7779A00010S)\n>> compatible = \"renesas,marzen\", \"renesas,r8a7779\"\n> Gr{oetje,eeting}s,\n>\n> Geert\n>\n> --\n> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n>\n> In personal conversations with technical people, I call myself a hacker. But\n> when I'm talking to journalists I just say \"programmer\" or something like that.\n> -- Linus Torvalds","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=cogentembedded-com.20150623.gappssmtp.com\n\theader.i=@cogentembedded-com.20150623.gappssmtp.com\n\theader.b=\"lohMKUBU\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpSyg1Wfpz9sDB\n\tfor ;\n\tFri, 8 Sep 2017 17:05:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754287AbdIHHFp (ORCPT\n\t);\n\tFri, 8 Sep 2017 03:05:45 -0400","from mail-lf0-f50.google.com ([209.85.215.50]:36866 \"EHLO\n\tmail-lf0-f50.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753222AbdIHHFo (ORCPT\n\t); Fri, 8 Sep 2017 03:05:44 -0400","by mail-lf0-f50.google.com with SMTP id 80so3648250lfy.4\n\tfor ;\n\tFri, 08 Sep 2017 00:05:44 -0700 (PDT)","from [192.168.0.107] ([78.25.110.240])\n\tby smtp.googlemail.com with ESMTPSA id\n\tg65sm188066ljb.86.2017.09.08.00.05.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 00:05:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cogentembedded-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=ZvXPeRboMAUFTfROMl6DJarW8CWwePDikqcrI7Ox8cs=;\n\tb=lohMKUBU2N05VGP3f2uMJ07lDxXK8+lSgGk7AZvisg0vDSwlByJIOwvJmLzC9mo98f\n\tLfEORd/NuHhk9QxTqUD8F+G2uNfJlHtONvTLDLo58yPTCuF8fvW0tEH9JkYed07LokFB\n\t3RdYOkW/WNkg3uNC7wv6WciVxFj2pAHyJaw9ADZ2yPXzH8E/dQx7gg0rGhdsdOU86PpH\n\tJbMCD+t/LkUIEWWVzVkAqFb4dZ/8BlVfkA9r8T+gvwJtt9eApZw/SGBrz6G2+MmmV7hM\n\tmTww+X4E0cF6sVr7uoSaWJoUc2PPUAaiVB1lgm+9O1qZbYwDdhX8x7aWIVDv2T+s10Lg\n\t/8zg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=ZvXPeRboMAUFTfROMl6DJarW8CWwePDikqcrI7Ox8cs=;\n\tb=atynAeyzXCDCT/fSWrFSu7pvjqBnwiQe8tVz73Zg5kP9QFg0D3MGA0kqWwEEI5JcfO\n\tb2KkIiY3CUmEAv5+dsgjuzlRalv9bsPI3OWeeAarxS/c5sNkKXgcO10GuiBlUar4kFbR\n\tooGBjiEtD58WjH3xXswuylx2GbMvmbXz6vKe0XzKBozN0D7ycT03vy/cZ5X7udsWfKVp\n\trpy4TQjZWqPjHuNHvdWttf9kgu7Oqg6cmB6UXW6gqYFYEZXbUppVOSDu/QQae0ejGMnt\n\tKZN989p7wmdUns+VH7yCoYN0c+Fa06OmjeD2Ncw8eaSKQyJXDPzG84X+2JO10KWSgNHI\n\tfjAQ==","X-Gm-Message-State":"AHPjjUhQIfnHILFrdyoqLTTGQL1oWmEzwTxO1Fl6NRUTyLLkxwI7GWSt\n\tFk7zkFgm+wnlP7ar6OI=","X-Google-Smtp-Source":"AOwi7QAZVF3YpRFR52gX5JV9dpgvyFod5tS62KUp2eI5Do4jZmthpS3fxkQ6IHCfkPuM0kb5fEVNCg==","X-Received":"by 10.46.68.66 with SMTP id r63mr650790lja.145.1504854343159;\n\tFri, 08 Sep 2017 00:05:43 -0700 (PDT)","Subject":"Re: [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT\n\tbindings","To":"Geert Uytterhoeven ","References":"<1504737267-22829-1-git-send-email-vladimir.barinov@cogentembedded.com>\n\t<1504737303-22874-1-git-send-email-vladimir.barinov@cogentembedded.com>\n\t","Cc":"Simon Horman , Magnus Damm , \n\tRob Herring , Mark Rutland ,\n\tCatalin Marinas ,\n\tWill Deacon ,\n\t\"devicetree@vger.kernel.org\" ,\n\tLinux-Renesas ","From":"Vladimir Barinov ","Message-ID":"","Date":"Fri, 8 Sep 2017 10:05:40 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.4.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]