[{"id":1764807,"web_url":"http://patchwork.ozlabs.org/comment/1764807/","msgid":"<20170907161539.GA2973@scaer>","list_archive_url":null,"date":"2017-09-07T16:15:39","subject":"Re: [Buildroot] [PATCH 2/4] package/tvheadend: bump version,\n\tadd optional dependencies to opus & x265","submitter":{"id":13903,"url":"http://patchwork.ozlabs.org/api/people/13903/","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"content":"Bernd, All,\n\nOn 2017-09-06 22:49 +0200, Bernd Kuhls spake thusly:\n> This bump\n> https://github.com/tvheadend/tvheadend/compare/54e63e3f9af8fdc0d23f61f3cda7fa7b246c1732...303f418e1ac2bb3078f7a974b69f04ab6a56c636\n> updated the transcoding support already present:\n> https://github.com/tvheadend/tvheadend/commit/014bb9505e1d7eb6e37e10931dd89ab3b1a0dc01\n> \n> To avoid these build errors\n> \n> src/transcoding/codec/codecs/libs/libx26x.c:105:18: fatal error: x264.h: No such file or directory\n> #include \n> \n> src/transcoding/codec/codecs/libs/libx26x.c:213:18: fatal error: x265.h: No such file or directory\n> #include \n> \n> src/transcoding/codec/codecs/libs/libopus.c:23:31: fatal error: opus/opus_defines.h: No such file or directory\n> #include \n> \n> we need to add dependency handling already with this patch and keep the\n> hard dependency x264 as minimum codec for transcoding but we now need\n> to enable BR2_PACKAGE_FFMPEG_GPL to enable x264-support also in ffmpeg.\n> \n> Signed-off-by: Bernd Kuhls \n> ---\n> package/tvheadend/Config.in | 1 +\n> package/tvheadend/tvheadend.hash | 2 +-\n> package/tvheadend/tvheadend.mk | 24 ++++++++++++++++++++----\n> 3 files changed, 22 insertions(+), 5 deletions(-)\n> \n> diff --git a/package/tvheadend/Config.in b/package/tvheadend/Config.in\n> index 191593eab..56a3b385d 100644\n> --- a/package/tvheadend/Config.in\n> +++ b/package/tvheadend/Config.in\n> @@ -31,6 +31,7 @@ config BR2_PACKAGE_TVHEADEND_TRANSCODING\n> \tbool \"transcoding support\"\n> \tselect BR2_PACKAGE_FFMPEG\n> \tselect BR2_PACKAGE_FFMPEG_AVRESAMPLE\n> +\tselect BR2_PACKAGE_FFMPEG_GPL # needed for x264 support\n\nNAK. If we have an option to enable/disable GPL-licensed codecs, it is\nto leave the option to the user to enable/disable them.\n\nWe do not want to automatically force that option. Such an option must\nonly be available as a user-selected option.\n\nHowever, we've started to remove similar options, like the recently\ndropped Qt license.\n\nInstead, I would try to simply remove that option altogether. Instead,\nadd the GPL license to the license list in the .mk, when such-licensed\ncodecs are enabled.\n\nAfter all, ffmpeg is not the only package whose licening terms change\ndepending on the set of options enabled for that package.\n\nRegards,\nYann E. MORIN.\n\n> \tselect BR2_PACKAGE_FFMPEG_SWSCALE\n> \tselect BR2_PACKAGE_LIBVPX if !BR2_bfin # libvpx\n> \tselect BR2_PACKAGE_X264\n> diff --git a/package/tvheadend/tvheadend.hash b/package/tvheadend/tvheadend.hash\n> index 3154b3276..a33b0a5e5 100644\n> --- a/package/tvheadend/tvheadend.hash\n> +++ b/package/tvheadend/tvheadend.hash\n> @@ -1,2 +1,2 @@\n> # Locally computed\n> -sha256 1994e379c798b118243e70f7fa38064a9b288d6e38b9ced0e8ad465f5d2e8fd9 tvheadend-54e63e3f9af8fdc0d23f61f3cda7fa7b246c1732.tar.gz\n> +sha256 00f67fbf9d8cfea7da90f469b36a8205fb9a38727c4cc5022f4ee5fd322459d3 tvheadend-303f418e1ac2bb3078f7a974b69f04ab6a56c636.tar.gz\n> diff --git a/package/tvheadend/tvheadend.mk b/package/tvheadend/tvheadend.mk\n> index b1c1fcaf7..4722cb006 100644\n> --- a/package/tvheadend/tvheadend.mk\n> +++ b/package/tvheadend/tvheadend.mk\n> @@ -4,7 +4,7 @@\n> #\n> ################################################################################\n> \n> -TVHEADEND_VERSION = 54e63e3f9af8fdc0d23f61f3cda7fa7b246c1732\n> +TVHEADEND_VERSION = 303f418e1ac2bb3078f7a974b69f04ab6a56c636\n> TVHEADEND_SITE = $(call github,tvheadend,tvheadend,$(TVHEADEND_VERSION))\n> TVHEADEND_LICENSE = GPL-3.0+\n> TVHEADEND_LICENSE_FILES = LICENSE.md\n> @@ -27,10 +27,26 @@ TVHEADEND_CONF_OPTS += --disable-dbus-1\n> endif\n> \n> ifeq ($(BR2_PACKAGE_TVHEADEND_TRANSCODING),y)\n> -TVHEADEND_DEPENDENCIES += ffmpeg\n> -TVHEADEND_CONF_OPTS += --enable-libav\n> +TVHEADEND_CONF_OPTS += --enable-libav --enable-libx264\n> +TVHEADEND_DEPENDENCIES += ffmpeg x264\n> +ifeq ($(BR2_PACKAGE_OPUS),y)\n> +TVHEADEND_CONF_OPTS += --enable-libopus\n> +TVHEADEND_DEPENDENCIES += opus\n> else\n> -TVHEADEND_CONF_OPTS += --disable-libav\n> +TVHEADEND_CONF_OPTS += --disable-libopus\n> +endif\n> +ifeq ($(BR2_PACKAGE_X265),y)\n> +TVHEADEND_CONF_OPTS += --enable-libx265\n> +TVHEADEND_DEPENDENCIES += x265\n> +else\n> +TVHEADEND_CONF_OPTS += --disable-libx265\n> +endif\n> +else\n> +TVHEADEND_CONF_OPTS += \\\n> +\t--disable-libav \\\n> +\t--disable-libopus \\\n> +\t--disable-libx264 \\\n> +\t--disable-libx265\n> endif\n> \n> ifeq ($(BR2_PACKAGE_LIBDVBCSA),y)\n> -- \n> 2.11.0\n> \n> _______________________________________________\n> buildroot mailing list\n> buildroot@busybox.net\n> http://lists.busybox.net/mailman/listinfo/buildroot","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CvtYzz1d\"; dkim-atps=neutral"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp5Cq6hTcz9sQl\n\tfor ;\n\tFri, 8 Sep 2017 02:15:51 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DFB8589F0E;\n\tThu, 7 Sep 2017 16:15:49 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nSCX6-OLFy5q; Thu, 7 Sep 2017 16:15:49 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DA7E589F05;\n\tThu, 7 Sep 2017 16:15:48 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 117261C3EC6\n\tfor ;\n\tThu, 7 Sep 2017 16:15:47 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0A29987B66\n\tfor ;\n\tThu, 7 Sep 2017 16:15:47 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YywHs7SlTE87 for ;\n\tThu, 7 Sep 2017 16:15:45 +0000 (UTC)","from mail-wr0-f173.google.com (mail-wr0-f173.google.com\n\t[209.85.128.173])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id CE41A87B62\n\tfor ; Thu, 7 Sep 2017 16:15:44 +0000 (UTC)","by mail-wr0-f173.google.com with SMTP id m18so376814wrm.2\n\tfor ; Thu, 07 Sep 2017 09:15:44 -0700 (PDT)","from ymorin.is-a-geek.org\n\t(2a01cb0886107300a556795e0851f8aa.ipv6.abo.wanadoo.fr.\n\t[2a01:cb08:8610:7300:a556:795e:851:f8aa])\n\tby smtp.gmail.com with ESMTPSA id 14sm15117wrw.21.2017.09.07.09.15.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 07 Sep 2017 09:15:41 -0700 (PDT)","by ymorin.is-a-geek.org (sSMTP sendmail emulation);\n\tThu, 07 Sep 2017 18:15:39 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=klZcBwJ6LYd2tUktIUwqtDrxDdyrtl3l3nsCgFPoOh4=;\n\tb=CvtYzz1dSj3qOhWMVwuthmFkpPfsZFwI16wziLY4DG+1O5Wd+HDrmphywohRSeRh6B\n\tCWundEjpbUV6nYI4jeXehmQQajhplkzPwQyEd2Cdrjr5fOXmHUbh2Wf4rAVBoK/jrrbm\n\tPeDKtmQM7i0MUW4g34t61Rh7L7SV+niCKRIlAYVwt5JWXlIhy3TXw8PrncEqQnNOaUQD\n\t/ZpkOQ1l60eGAa2AIJNskgVdGMPlOyBQWDvBpxu7VmvdEnhRd+4FOYo3rQHTgp01QOoQ\n\t+ZXGfPx4gzF2GTOEf8mpg8xNzLxSp/yZoJiQwbM8ZfynmD6rxavu3JrXDPaPY2bN6LXT\n\t2oaw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=klZcBwJ6LYd2tUktIUwqtDrxDdyrtl3l3nsCgFPoOh4=;\n\tb=lLIrWBhLDklsAKbMsV52nAhsoWNLqTOxCx1Nvubh1dY/k1zDWfC66hZN46E3u2eLjj\n\tdWTBqok5hAIXKZqoSR8wWXvzN5gWNl4kB8DLxbrwz+JqP7FBqfWEnaV5Rvb2FfDeiUVf\n\tPeQ0OY6lB80gyqpTd1CNgl7Pc6TXJU+hM03k9IGxlfO8zFhFNvjJiGavx9ZfWsK5Zr4f\n\t+rxbocN9PYiEkA+QHe8W5LFufwU1c/EPOE0nFDbK0c0zsJvFsqDCDOzFuoMyBuXGl/4c\n\tb9QlUrUHyrKdNW2pPFpLZrmyTUNblNVnOGaXiYUWWOMGGk9DliKXimVGEuU4y0N+cRIL\n\tkp1Q==","X-Gm-Message-State":"AHPjjUjCoeAlnw47uadux39ExwWWpy4vCwDUZin/rrcXQfdCAGGBajgE\n\t8DS4Pr57d9CQpg==","X-Google-Smtp-Source":"ADKCNb7V97MLDsvtdyRJ0fY373BIb4XKQbigSr9tiNOKfM1/jZupG9LVyvrPBHatxACye9RMcoN1KA==","X-Received":"by 10.223.170.68 with SMTP id q4mr2246307wrd.201.1504800943069; \n\tThu, 07 Sep 2017 09:15:43 -0700 (PDT)","Date":"Thu, 7 Sep 2017 18:15:39 +0200","From":"\"Yann E. MORIN\" ","To":"Bernd Kuhls ","Message-ID":"<20170907161539.GA2973@scaer>","References":"<20170906204908.30036-1-bernd.kuhls@t-online.de>\n\t<20170906204908.30036-2-bernd.kuhls@t-online.de>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170906204908.30036-2-bernd.kuhls@t-online.de>","User-Agent":"Mutt/1.5.22 (2013-10-16)","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 2/4] package/tvheadend: bump version,\n\tadd optional dependencies to opus & x265","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1771368,"web_url":"http://patchwork.ozlabs.org/comment/1771368/","msgid":"","list_archive_url":null,"date":"2017-09-19T20:32:59","subject":"Re: [Buildroot] [PATCH 2/4] package/tvheadend: bump version,\n\tadd optional dependencies to opus & x265","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"On 07-09-17 18:15, Yann E. MORIN wrote:\n> Bernd, All,\n> \n> On 2017-09-06 22:49 +0200, Bernd Kuhls spake thusly:\n[snip]\n>> @@ -31,6 +31,7 @@ config BR2_PACKAGE_TVHEADEND_TRANSCODING\n>> \tbool \"transcoding support\"\n>> \tselect BR2_PACKAGE_FFMPEG\n>> \tselect BR2_PACKAGE_FFMPEG_AVRESAMPLE\n>> +\tselect BR2_PACKAGE_FFMPEG_GPL # needed for x264 support\n> \n> NAK. If we have an option to enable/disable GPL-licensed codecs, it is\n> to leave the option to the user to enable/disable them.\n> \n> We do not want to automatically force that option. Such an option must\n> only be available as a user-selected option.\n\n The situation is quite different here. The option BR2_PACKAGE_FFMPEG_GPL exists\nbecause we don't have suboptions for every possible codec in ffmpeg, and because\nffmpeg's configure script has a corresponding option.\n\n However, in this case the user has an explicit option\nBR2_PACKAGE_TVHEADEND_TRANSCODING that controls whether or not the GPL codecs of\nffmpeg are included. To top things off, tvheadend already is GPL-3.0+, so the\npoint is kind of moot.\n\n Therefore, I've applied the entire series to master.\n\n> However, we've started to remove similar options, like the recently\n> dropped Qt license.\n> \n> Instead, I would try to simply remove that option altogether. Instead,\n> add the GPL license to the license list in the .mk, when such-licensed\n> codecs are enabled.\n> \n> After all, ffmpeg is not the only package whose licening terms change\n> depending on the set of options enabled for that package.\n\n Since we don't have individual options for every ffmpeg codec, such an approach\nwouldn't be possible. In addition, since ffmpeg configure has the --enable-gpl\nand --enable-nonfree options, I think it makes sense to keep them.\n\n Regards,\n Arnout\n\n[snip]","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxZMk3JBCz9s81\n\tfor ;\n\tWed, 20 Sep 2017 06:33:38 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1499C87FA5;\n\tTue, 19 Sep 2017 20:33:36 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kB8WWc5UjUST; Tue, 19 Sep 2017 20:33:34 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B706188710;\n\tTue, 19 Sep 2017 20:33:34 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 089071C0F41\n\tfor ;\n\tTue, 19 Sep 2017 20:33:33 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F2F4A87FA5\n\tfor ;\n\tTue, 19 Sep 2017 20:33:32 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tqknBBNpJsMu for ;\n\tTue, 19 Sep 2017 20:33:32 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 22BCD88680\n\tfor ; Tue, 19 Sep 2017 20:33:32 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tTue, 19 Sep 2017 22:33:01 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"\"Yann E. MORIN\" , Bernd Kuhls\n\t","References":"<20170906204908.30036-1-bernd.kuhls@t-online.de>\n\t<20170906204908.30036-2-bernd.kuhls@t-online.de>\n\t<20170907161539.GA2973@scaer>","From":"Arnout Vandecappelle ","Organization":"Essensium/Mind","Message-ID":"","Date":"Tue, 19 Sep 2017 22:32:59 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170907161539.GA2973@scaer>","Content-Language":"en-GB","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 2/4] package/tvheadend: bump version,\n\tadd optional dependencies to opus & x265","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]