[{"id":1764361,"web_url":"http://patchwork.ozlabs.org/comment/1764361/","msgid":"<20170906204102.GA25558@flamenco>","list_archive_url":null,"date":"2017-09-06T20:41:02","subject":"Re: [Qemu-devel] [RFC 2/6] plugin: add initial plugin support","submitter":{"id":65690,"url":"http://patchwork.ozlabs.org/api/people/65690/","name":"Emilio Cota","email":"cota@braap.org"},"content":"On Wed, Sep 06, 2017 at 16:28:44 -0400, Emilio G. Cota wrote:\n> --- /dev/null\n> +++ b/plugin.c\n> @@ -0,0 +1,519 @@\n(snip)\n> + /*\n> + * @lock protects the struct as well as ctx->uninstalling.\n> + * The lock must be acquired by all API ops. Since some API ops\n> + * call plugin code repeatedly (e.g. vcpu_for_each), we keep\n> + * a counter to allow for recursive acquisitions.\n> + */\n> + QemuMutex lock;\n\nThis comment is outdated. The lock is not recursive anymore (it used to be).\n\n\t\tE.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=braap.org header.i=@braap.org\n\theader.b=\"kSQtGger\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"sknyBkVG\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnb8r5rNMz9t2v\n\tfor ;\n\tThu, 7 Sep 2017 06:41:32 +1000 (AEST)","from localhost ([::1]:37716 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dph8c-0000vp-Mq\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 16:41:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56483)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dph8I-0000vU-Pf\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 16:41:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dph8D-00082t-TO\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 16:41:10 -0400","from out1-smtp.messagingengine.com ([66.111.4.25]:55745)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dph8D-00082Z-P7\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 16:41:05 -0400","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 70289217BB;\n\tWed, 6 Sep 2017 16:41:02 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute4.internal (MEProxy); Wed, 06 Sep 2017 16:41:03 -0400","from localhost (flamenco.cs.columbia.edu [128.59.20.216])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id A4C7A249FA;\n\tWed, 6 Sep 2017 16:41:02 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=mesmtp; bh=6+b/ml6MHttNLU5FSvcRDXkl1Yy8MBkJYwTnZh\n\tzafXM=; b=kSQtGgerrbei8vXzllVxvj6QGIr41M90h9N26tOHi0s3jCaDYphd8E\n\tY/ftf3n+itDTCxTRSc81PyZ3LXABOFBaayBq3+rTh2RE3YOdEoEJyXIBHMMaMM7l\n\tLljEYXleJywABG0Yr+3JUV6DKTZZzYlmJcvxqoB5t+KrCDD1ulDDs=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=6+b/ml6MHttNLU5FSv\n\tcRDXkl1Yy8MBkJYwTnZhzafXM=; b=sknyBkVGgpU6EncBrG94Iq6h4MR71tQHHt\n\th3klKWCy+1Wfs6sIZtCRbhuAiE81JQMw6iFeowAd7q6IVo2l6TwgDRuPcgL0CBxo\n\tFmAtXnmMk940YbwZKUPRjv75mwKX1s8G32DXXTaDbH+whFpk+y6hK2U9IfGuu07c\n\t4afmkD7O9+BNUQ+ShnLt0hA4rSDE/xVsrQPi6IxPzvsp6OjetK4atueB/0bx4plr\n\tnI4Ew9R251tqNQG/4hFTLtZNBQwCQ5tYuvK2H6vRbZH6KO5JHoUJ+0fbKCDGJhfV\n\tz/eYAJj/OUQsOeSujb9H+F08nNGdpYp1oYRQa5wqqzVomD16N//Q=="],"X-ME-Sender":"","X-Sasl-enc":"3FJbNDSgbd+KIVQekaO6crU8alGOTj6SaZDpIDJC41f7 1504730462","Date":"Wed, 6 Sep 2017 16:41:02 -0400","From":"\"Emilio G. Cota\" ","To":"qemu-devel@nongnu.org","Message-ID":"<20170906204102.GA25558@flamenco>","References":"<1504729728-23279-1-git-send-email-cota@braap.org>\n\t<1504729728-23279-3-git-send-email-cota@braap.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504729728-23279-3-git-send-email-cota@braap.org>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"66.111.4.25","Subject":"Re: [Qemu-devel] [RFC 2/6] plugin: add initial plugin support","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?iso-8859-1?q?Llu=EDs?= Vilanova ,\n\tStefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775143,"web_url":"http://patchwork.ozlabs.org/comment/1775143/","msgid":"<56622fe7-22cf-4a41-01e0-8e64cbef412f@redhat.com>","list_archive_url":null,"date":"2017-09-26T04:27:01","subject":"Re: [Qemu-devel] [RFC 2/6] plugin: add initial plugin support","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 06.09.2017 22:28, Emilio G. Cota wrote:\n[...]\n> diff --git a/plugin.c b/plugin.c\n> new file mode 100644\n> index 0000000..3cd19df\n> --- /dev/null\n> +++ b/plugin.c\n> @@ -0,0 +1,519 @@\n> +/* plugin.c - QEMU Plugin interface\n> + *\n> + * Copyright (C) 2017, Emilio G. Cota \n> + *\n> + * License: GNU GPL, version 2 or later.\n> + * See the COPYING file in the top-level directory.\n> + */\n\nIf you introduce new .c files, please add some sentences with a proper\ndescription in the header with some very high level description about\nwhat the code in the file is supposed to be doing. Just reading \"plugin\ninterface\" is not really very helpful when trying to understand new code.\n\n Thanks,\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Sbs4rcyz9t49\n\tfor ;\n\tTue, 26 Sep 2017 14:27:36 +1000 (AEST)","from localhost ([::1]:45552 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwhT0-0005mc-Iv\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 00:27:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45633)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwhSg-0005lJ-MF\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 00:27:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwhSd-0004hd-Ir\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 00:27:10 -0400","from mx1.redhat.com ([209.132.183.28]:36900)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwhSd-0004hI-C8\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 00:27:07 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4707761472;\n\tTue, 26 Sep 2017 04:27:06 +0000 (UTC)","from [10.36.116.28] (ovpn-116-28.ams2.redhat.com [10.36.116.28])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 2675E71C3A;\n\tTue, 26 Sep 2017 04:27:03 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4707761472","To":"\"Emilio G. Cota\" , qemu-devel@nongnu.org","References":"<1504729728-23279-1-git-send-email-cota@braap.org>\n\t<1504729728-23279-3-git-send-email-cota@braap.org>","From":"Thomas Huth ","Message-ID":"<56622fe7-22cf-4a41-01e0-8e64cbef412f@redhat.com>","Date":"Tue, 26 Sep 2017 06:27:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504729728-23279-3-git-send-email-cota@braap.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 26 Sep 2017 04:27:06 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [RFC 2/6] plugin: add initial plugin support","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Llu=C3=ADs_Vilanova?= ,\n\tStefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]