[{"id":1764387,"web_url":"http://patchwork.ozlabs.org/comment/1764387/","msgid":"<20170906212056.GC25558@flamenco>","list_archive_url":null,"date":"2017-09-06T21:20:56","subject":"Re: [Qemu-devel] [PATCH v4 03/20] instrument: Add generic library\n\tloader","submitter":{"id":65690,"url":"http://patchwork.ozlabs.org/api/people/65690/","name":"Emilio Cota","email":"cota@braap.org"},"content":"On Wed, Sep 06, 2017 at 20:34:48 +0300, Lluís Vilanova wrote:\n> Signed-off-by: Lluís Vilanova \n> ---\n(snip)\n> diff --git a/configure b/configure\n> index 80dcc91c98..05bd7b1950 100755\n> --- a/configure\n> +++ b/configure\n> @@ -6034,6 +6034,8 @@ fi\n> echo \"CONFIG_TRACE_FILE=$trace_file\" >> $config_host_mak\n> \n> if test \"$instrument\" = \"yes\"; then\n> + LDFLAGS=\"-rdynamic $LDFLAGS\" # limit symbols available to clients\n\n-rdynamic exports all objects to the instrumenters, not the other way around.\nYou can see it with nm(1).\n\nBTW I'm using ebf447b5b from your qemu-dbi repo. Is that the same as this\npatchset? It doesn't compile with --enable-instrument:\n$ make\n CC x86_64-linux-user/instrument/trace.o\n/data/src/qemu2/instrument/trace.c:12:30: fatal error: qemu-instr/trace.h: No such file or directory\ncompilation terminated.\n/data/src/qemu2/rules.mak:66: recipe for target 'instrument/trace.o' failed\nmake[1]: *** [instrument/trace.o] Error 1\nMakefile:326: recipe for target 'subdir-x86_64-linux-user' failed\nmake: *** [subdir-x86_64-linux-user] Error 2\n\n\t\tEmilio","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=braap.org header.i=@braap.org\n\theader.b=\"CD7xbBGz\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"N5GselJR\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnc3b2nWxz9s7f\n\tfor ;\n\tThu, 7 Sep 2017 07:22:03 +1000 (AEST)","from localhost ([::1]:37820 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dphlp-0003aB-FD\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 17:22:01 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35732)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dphkr-0003In-O1\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 17:21:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dphko-0004HY-JH\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 17:21:01 -0400","from out1-smtp.messagingengine.com ([66.111.4.25]:50295)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dphko-0004GC-D2\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 17:20:58 -0400","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 7244421AF4;\n\tWed, 6 Sep 2017 17:20:57 -0400 (EDT)","from frontend1 ([10.202.2.160])\n\tby compute4.internal (MEProxy); Wed, 06 Sep 2017 17:20:57 -0400","from localhost (flamenco.cs.columbia.edu [128.59.20.216])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 216C07F9A8;\n\tWed, 6 Sep 2017 17:20:57 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=9aIHI6Qe/as61Dl\n\tijq6mpNfM91JNTL93U8K63KBsge0=; b=CD7xbBGzT0u5xhV8uD4alZnc8shJvZ5\n\tHk2yy/ch6Dm5t+vSYbCY+pPwnUJcStG1gtvKQfooEGZ8Jv+vOC7iwywwLcSBaKQZ\n\tddAmC0+2jMEuIW9wvmZpWB7aUnzBGQwXRKKYUYmA78mE4TBC1h33loqcrlcJrJRh\n\trw24ADpINmPU=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=\n\tfm1; bh=9aIHI6Qe/as61Dlijq6mpNfM91JNTL93U8K63KBsge0=; b=N5GselJR\n\t3RddcoPxwma0RqUvVBoUZY1b+0UgxxPAe4Rf22AK1iLGTCTs3I8WPpYbO5eXYh9M\n\tIHEorTXJ6AyHNuddVvkC+XEIYNCX+Liaq+eQBiG7x+rH2gKdaYfwKVP+YA9mWqf9\n\ts+2lkT7acGLMP/mmCGKpF5lHU++oLnlWYGztXoCebvaD9c6wGqksTcH9FPDx/ttg\n\trHn24r6RoYvZTO5Mgu82Y9wp+FpvyBJctGy3Zoukb1CS6pBCuXxddZUdaqjyi7Qr\n\te/g/fVup/UShe9emXMJgHh/UgUi/0updLSy7wX0wNTngWsTDqgO1y40/N3ThbUHv\n\tBjkbBb/LqGtsCw=="],"X-ME-Sender":"","X-Sasl-enc":"5E2qJEGacprVWhzJPQf/rdEs58XSOFQtgPb82CWIsg/J 1504732857","Date":"Wed, 6 Sep 2017 17:20:56 -0400","From":"\"Emilio G. Cota\" ","To":"=?iso-8859-1?q?Llu=EDs?= Vilanova ","Message-ID":"<20170906212056.GC25558@flamenco>","References":"<150471856141.24907.274176769201097378.stgit@frigg.lan>\n\t<150471928780.24907.14047559834166839201.stgit@frigg.lan>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<150471928780.24907.14047559834166839201.stgit@frigg.lan>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"66.111.4.25","Subject":"Re: [Qemu-devel] [PATCH v4 03/20] instrument: Add generic library\n\tloader","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765979,"web_url":"http://patchwork.ozlabs.org/comment/1765979/","msgid":"<87fubuzc0r.fsf@frigg.lan>","list_archive_url":null,"date":"2017-09-10T17:41:56","subject":"Re: [Qemu-devel] [PATCH v4 03/20] instrument: Add generic library\n\tloader","submitter":{"id":9099,"url":"http://patchwork.ozlabs.org/api/people/9099/","name":"Lluís Vilanova","email":"vilanova@ac.upc.edu"},"content":"Emilio G Cota writes:\n\n> On Wed, Sep 06, 2017 at 20:34:48 +0300, Lluís Vilanova wrote:\n>> Signed-off-by: Lluís Vilanova \n>> ---\n> (snip)\n>> diff --git a/configure b/configure\n>> index 80dcc91c98..05bd7b1950 100755\n>> --- a/configure\n>> +++ b/configure\n>> @@ -6034,6 +6034,8 @@ fi\n>> echo \"CONFIG_TRACE_FILE=$trace_file\" >> $config_host_mak\n>> \n>> if test \"$instrument\" = \"yes\"; then\n>> + LDFLAGS=\"-rdynamic $LDFLAGS\" # limit symbols available to clients\n\n> -rdynamic exports all objects to the instrumenters, not the other way around.\n> You can see it with nm(1).\n\nI'll send a minor fix for this in next version.\n\n\n> BTW I'm using ebf447b5b from your qemu-dbi repo. Is that the same as this\n> patchset? It doesn't compile with --enable-instrument:\n> $ make\n> CC x86_64-linux-user/instrument/trace.o\n> /data/src/qemu2/instrument/trace.c:12:30: fatal error: qemu-instr/trace.h: No such file or directory\n> compilation terminated.\n> /data/src/qemu2/rules.mak:66: recipe for target 'instrument/trace.o' failed\n> make[1]: *** [instrument/trace.o] Error 1\n> Makefile:326: recipe for target 'subdir-x86_64-linux-user' failed\n> make: *** [subdir-x86_64-linux-user] Error 2\n\nNo, I started using a separate branch to keep the old patches around in the\nmeantime.\n\n\n> \t\tEmilio\n\n\nLluis","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqz0c4ZhGz9s7c\n\tfor ;\n\tMon, 11 Sep 2017 03:42:40 +1000 (AEST)","from localhost ([::1]:53760 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dr6Fi-00025O-Po\n\tfor incoming@patchwork.ozlabs.org; Sun, 10 Sep 2017 13:42:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60915)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dr6FF-00022g-2q\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 13:42:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dr6FC-0002a2-0g\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 13:42:09 -0400","from roura.ac.upc.es ([147.83.33.10]:55584)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dr6FB-0002Zs-LY\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 13:42:05 -0400","from correu-2.ac.upc.es (correu-2.ac.upc.es [147.83.30.92])\n\tby roura.ac.upc.es (8.13.8/8.13.8) with ESMTP id v8AHg3Ta021708;\n\tSun, 10 Sep 2017 19:42:03 +0200","from localhost (unknown [132.68.137.153])\n\tby correu-2.ac.upc.es (Postfix) with ESMTPSA id 9206917A6;\n\tSun, 10 Sep 2017 19:41:57 +0200 (CEST)"],"From":"=?utf-8?q?Llu=C3=ADs_Vilanova?= ","To":"\"Emilio G. Cota\" ","References":"<150471856141.24907.274176769201097378.stgit@frigg.lan>\n\t<150471928780.24907.14047559834166839201.stgit@frigg.lan>\n\t<20170906212056.GC25558@flamenco>","Mail-Followup-To":"\"Emilio G. Cota\" , qemu-devel@nongnu.org, \n\tEric Blake ,\n\tStefan Hajnoczi ","Date":"Sun, 10 Sep 2017 20:41:56 +0300","In-Reply-To":"<20170906212056.GC25558@flamenco> (Emilio G. Cota's message of\n\t\"Wed, 6 Sep 2017 17:20:56 -0400\")","Message-ID":"<87fubuzc0r.fsf@frigg.lan>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]","X-Received-From":"147.83.33.10","Subject":"Re: [Qemu-devel] [PATCH v4 03/20] instrument: Add generic library\n\tloader","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]