[{"id":1766066,"web_url":"http://patchwork.ozlabs.org/comment/1766066/","msgid":"","list_archive_url":null,"date":"2017-09-11T06:17:52","subject":"Re: [U-Boot] [PATCH v1] drivers: ahci: write upper 32 bits for clb\n\tand fis registers","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 6 September 2017 at 10:59, Suneel Garapati wrote:\n> If 64-bit capability is supported, commandlistbase and fis base\n> should be split as lower32 and upper32. upper32 should be\n> written to PORT_(LST/FIS)_ADDR_HI.\n>\n> Signed-off-by: Suneel Garapati \n> ---\n>\n> Changes v1:\n> - add macro definitions for LOWER32, UPPER32\n>\n>\n> drivers/ata/ahci.c | 14 ++++++++++++--\n> include/ahci.h | 1 +\n> 2 files changed, 13 insertions(+), 2 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"kj5onDnO\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"KCJZt1Va\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrHvd6NzWz9s7g\n\tfor ;\n\tMon, 11 Sep 2017 16:24:29 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 9AFFAC21D82; Mon, 11 Sep 2017 06:20:37 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id CB420C21E0A;\n\tMon, 11 Sep 2017 06:19:41 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D464BC21E74; Mon, 11 Sep 2017 06:18:18 +0000 (UTC)","from mail-qk0-f181.google.com (mail-qk0-f181.google.com\n\t[209.85.220.181])\n\tby lists.denx.de (Postfix) with ESMTPS id A39BAC21E0F\n\tfor ; Mon, 11 Sep 2017 06:18:14 +0000 (UTC)","by mail-qk0-f181.google.com with SMTP id a128so16602972qkc.5\n\tfor ; Sun, 10 Sep 2017 23:18:14 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 10 Sep 2017 23:17:52 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=DuANLQdvzpZVqTOvTDYD4PJMpDnckohoO5SLr3jCiCE=;\n\tb=kj5onDnOi03IWfcciTz2HTRFyOH/hhINqatZv3RI+wTlmE9gRPu9EP+VQJHhXB7VnV\n\tosKeZqqoyQdACoae9N1tfjr9dNYV5WXZWONEDVHtnMNLD4xTSacB8EmRAKN09CRMCXgZ\n\tO+Yp22g+MyP883vmcksu05851u+CQ5ub5vqd2NsBB/5b6w5c3T2pYTUZRf99rfnMKONW\n\t5Mi1ByoqiNq/IduMZlTXs43hESbxBEru5w3/jzzGqG9hKH+e5+123DBPmHv38hXxk6eb\n\tVAqgUMPUm2sHfdbE+x0TyjkW1j0rj0iC8l7VTMvNruDWKDKBxDQTQQBf2ukJgMzMnDSB\n\trCwQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=DuANLQdvzpZVqTOvTDYD4PJMpDnckohoO5SLr3jCiCE=;\n\tb=KCJZt1ValhffsXX582qHp9hMDF0lLs8PXDw5r3p7YeKxUyO1FuZPDxbjWvQ/QkwWJa\n\tN388s+YXDPoq+EDuCGZ/JsLWy6NgbbkfV8/emtC2P+FpZW7kLKEbExMu/E+RYNkzpJ36\n\toLZ2Sv4cvwIRIRz3OmxjmQlrvPP1hXCrq4lqs="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=DuANLQdvzpZVqTOvTDYD4PJMpDnckohoO5SLr3jCiCE=;\n\tb=pjhbvcutgXCNCiYfT6dc03n0C+Hg/INh7OVmSfIQzqgTs64RW4VpP3Qbknr4taR3sh\n\tfmZxirgvif9VQWHIBXaZDCYkCGtT2PRxpsloI3k+vMIesqtJ2+jlqGnrlmPNoIElqOuF\n\tCD68Tmv13p9TTedaUOtlguy5W93KWwagN30MtM4HNbwOl5OImVoAZ2/n9YD9TcOKFwTd\n\t6N1MK0S8H4PBsTwVGYl9bKNIVfnwiVAzK0vawvq+bGp4Li4brFvmnKoG/8fzmBMGbfd4\n\tUpklerZVtGKPtWez+IGrdXIWBCVwqn4fw+/c2AFB7+kbO7NuCg/wamn51TZ1fVGjMFFf\n\t0D0Q==","X-Gm-Message-State":"AHPjjUiBI4EzpyUK1H0bMyIuyNJt5t1ugNB2fjD8Ui73FlU5HCOU7HQQ\n\t2aM8WAVirjHk1vHEGVf8B4142uY4QCmgupCXeUyE2g==","X-Google-Smtp-Source":"AOwi7QAuxfDS3LYLhKsO9iQmYlBtW27UlRQAKKZAF3R3nXsao6HitPRj7+zW3pj1jadwVMg6jYhkkXcqUWw4Sq3IjtQ=","X-Received":"by 10.55.33.216 with SMTP id f85mr14573656qki.176.1505110693379; \n\tSun, 10 Sep 2017 23:18:13 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504717175-11844-1-git-send-email-suneelglinux@gmail.com>","References":"<1504717175-11844-1-git-send-email-suneelglinux@gmail.com>","From":"Simon Glass ","Date":"Mon, 11 Sep 2017 00:17:52 -0600","X-Google-Sender-Auth":"yeDjVX6T7zcCijHpei9Z5WsVe0I","Message-ID":"","To":"Suneel Garapati ","Cc":"U-Boot Mailing List ,\n\tMichal Simek ","Subject":"Re: [U-Boot] [PATCH v1] drivers: ahci: write upper 32 bits for clb\n\tand fis registers","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1767878,"web_url":"http://patchwork.ozlabs.org/comment/1767878/","msgid":"<20170913132346.GA7728@bill-the-cat>","list_archive_url":null,"date":"2017-09-13T13:23:46","subject":"Re: [U-Boot] [U-Boot,\n\tv1] drivers: ahci: write upper 32 bits for clb and fis registers","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Wed, Sep 06, 2017 at 09:59:35AM -0700, Suneel Garapati wrote:\n\n> If 64-bit capability is supported, commandlistbase and fis base\n> should be split as lower32 and upper32. upper32 should be\n> written to PORT_(LST/FIS)_ADDR_HI.\n> \n> Signed-off-by: Suneel Garapati \n> Reviewed-by: Simon Glass \n> ---\n> \n> Changes v1:\n> - add macro definitions for LOWER32, UPPER32\n\nThis introduces warnings on 32bit platforms:\nIn file included from /home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/fsl_lbc.h:465:0,\n from /home/trini/work/u-boot/u-boot/include/mpc86xx.h:10,\n from /home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/ppc.h:20,\n from /home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/u-boot.h:19,\n from /home/trini/work/u-boot/u-boot/include/image.h:42,\n from /home/trini/work/u-boot/u-boot/include/common.h:36,\n from /home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:12:\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c: In function ‘ahci_port_start’:\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:31:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define UPPER32(val) (u32)(((u64)(val) & 0xFFFFFFFF00000000ULL) >> 32)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:3: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:33: note: in expansion of macro ‘UPPER32’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:31:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define UPPER32(val) (u32)(((u64)(val) & 0xFFFFFFFF00000000ULL) >> 32)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:3: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/swab.h:86:2: note: in expansion of macro ‘___swab32’\n ___swab32((x)) : \\\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:33: note: in expansion of macro ‘UPPER32’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:31:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define UPPER32(val) (u32)(((u64)(val) & 0xFFFFFFFF00000000ULL) >> 32)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:3: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/swab.h:86:2: note: in expansion of macro ‘___swab32’\n ___swab32((x)) : \\\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:33: note: in expansion of macro ‘UPPER32’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:31:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define UPPER32(val) (u32)(((u64)(val) & 0xFFFFFFFF00000000ULL) >> 32)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:3: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/swab.h:86:2: note: in expansion of macro ‘___swab32’\n ___swab32((x)) : \\\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:33: note: in expansion of macro ‘UPPER32’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:31:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define UPPER32(val) (u32)(((u64)(val) & 0xFFFFFFFF00000000ULL) >> 32)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:3: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/swab.h:86:2: note: in expansion of macro ‘___swab32’\n ___swab32((x)) : \\\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:33: note: in expansion of macro ‘UPPER32’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:31:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define UPPER32(val) (u32)(((u64)(val) & 0xFFFFFFFF00000000ULL) >> 32)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:3: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:614:33: note: in expansion of macro ‘UPPER32’\n writel_with_flush(cpu_to_le32(UPPER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:30:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define LOWER32(val) (u32)((u64)(val) & 0xFFFFFFFF)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:2: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:32: note: in expansion of macro ‘LOWER32’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:30:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define LOWER32(val) (u32)((u64)(val) & 0xFFFFFFFF)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:2: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/swab.h:86:2: note: in expansion of macro ‘___swab32’\n ___swab32((x)) : \\\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:32: note: in expansion of macro ‘LOWER32’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:30:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define LOWER32(val) (u32)((u64)(val) & 0xFFFFFFFF)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:2: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/swab.h:86:2: note: in expansion of macro ‘___swab32’\n ___swab32((x)) : \\\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:32: note: in expansion of macro ‘LOWER32’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:30:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define LOWER32(val) (u32)((u64)(val) & 0xFFFFFFFF)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:2: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/swab.h:86:2: note: in expansion of macro ‘___swab32’\n ___swab32((x)) : \\\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:32: note: in expansion of macro ‘LOWER32’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:30:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define LOWER32(val) (u32)((u64)(val) & 0xFFFFFFFF)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:2: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/swab.h:86:2: note: in expansion of macro ‘___swab32’\n ___swab32((x)) : \\\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:32: note: in expansion of macro ‘LOWER32’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:30:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\n #define LOWER32(val) (u32)((u64)(val) & 0xFFFFFFFF)\n ^\n/home/trini/work/u-boot/u-boot/arch/powerpc/include/asm/io.h:34:57: note: in definition of macro ‘writel’\n #define writel(b,addr) out_le32((volatile u32 *)(addr),(b))\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:2: note: in expansion of macro ‘writel_with_flush’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/big_endian.h:34:43: note: in expansion of macro ‘__swab32’\n #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))\n ^\n/home/trini/work/u-boot/u-boot/include/linux/byteorder/generic.h:89:21: note: in expansion of macro ‘__cpu_to_le32’\n #define cpu_to_le32 __cpu_to_le32\n ^\n/home/trini/work/u-boot/u-boot/drivers/ata/ahci.c:616:32: note: in expansion of macro ‘LOWER32’\n writel_with_flush(cpu_to_le32(LOWER32(pp->cmd_slot)),\n ^\n\nTry building for ls1021aqds_sdcard_qspi for example. Thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"IcfpNVcU\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsj6r0rZPz9sPs\n\tfor ;\n\tWed, 13 Sep 2017 23:24:03 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 96348C222EC; Wed, 13 Sep 2017 13:23:58 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E15B7C21D8C;\n\tWed, 13 Sep 2017 13:23:52 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7C9EDC21D8C; Wed, 13 Sep 2017 13:23:51 +0000 (UTC)","from mail-yw0-f182.google.com (mail-yw0-f182.google.com\n\t[209.85.161.182])\n\tby lists.denx.de (Postfix) with ESMTPS id BB8DBC21C5C\n\tfor ; Wed, 13 Sep 2017 13:23:50 +0000 (UTC)","by mail-yw0-f182.google.com with SMTP id r85so501541ywg.1\n\tfor ; Wed, 13 Sep 2017 06:23:50 -0700 (PDT)","from bill-the-cat ([2606:a000:140b:dc:1d69:83c5:25c8:1ebc])\n\tby smtp.gmail.com with ESMTPSA id\n\tx8sm4838493ywi.107.2017.09.13.06.23.48\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tWed, 13 Sep 2017 06:23:48 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=Ob909ly8fCDwRPofyStVXTXXc9ejYZ/j6M8mjj+/O9Q=;\n\tb=IcfpNVcUM4Oa1zEqgFO8TAjWUhXHNGVvV7fyLRJBuLp1jTqpnJbK9Ds1uAOfiwolNs\n\tsrbt6/FTYE+B7UCO2XmGJtQv6rqdVsMaL+ZFJWvpfiWfxxnMgAI9XvwJl0gpZUoTG+A1\n\tmyZr/T1FzIUEDqzE4vPwviYnFgOdYrJyfFzsw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Ob909ly8fCDwRPofyStVXTXXc9ejYZ/j6M8mjj+/O9Q=;\n\tb=BrSBQqI1wNBYM+JvvF9GONYesmviy5qno6m/Xyp19/VprH7xrJeyGkeaH/KwK5wlBW\n\tv+v1sl76sZkIkiVct+5E8IpSXyTTAVefxVF7A9s+s4VEhHVg9VSTlH9f8pErkaZmYIov\n\tYuHaxIicIA5EyNorUcU1uRuP41sLseKvY9ZKq0+KONehMdk+VN0VZI7U4eMOWdXrzpPe\n\tGQhe9Gn+FpGWT28/DFRZzTK1byai6dnD7HJh6NQhdlWPXoa/DLtLGS5kj0a+SiK2xZnB\n\t/K/2Y9J19tWVhrxRIXkAq5lHY6gLa1OXrN3qgpfYrWFXeGz6NfY3AlxmM+pJYhI08dvY\n\tb2Dg==","X-Gm-Message-State":"AHPjjUhyMy/rPGwroD1B0H9RznW3aECTE3L1+2uPE4rVMNUsK3ofEM8K\n\tsTJeFUpyUghTMo/8","X-Google-Smtp-Source":"ADKCNb6QKOa3Nb0Er/YC7iGcN+tqeLDdqEeH4uWsIzvpvLaLpU5joKsvZUzAn7a2kzRenUj9mUOVyA==","X-Received":"by 10.129.233.12 with SMTP id d12mr15152226ywm.213.1505309029400;\n\tWed, 13 Sep 2017 06:23:49 -0700 (PDT)","Date":"Wed, 13 Sep 2017 09:23:46 -0400","From":"Tom Rini ","To":"Suneel Garapati ","Message-ID":"<20170913132346.GA7728@bill-the-cat>","References":"<1504717175-11844-1-git-send-email-suneelglinux@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<1504717175-11844-1-git-send-email-suneelglinux@gmail.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"u-boot@lists.denx.de, Michal Simek ","Subject":"Re: [U-Boot] [U-Boot,\n\tv1] drivers: ahci: write upper 32 bits for clb and fis registers","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============7314312073800527408==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]