[{"id":1764259,"web_url":"http://patchwork.ozlabs.org/comment/1764259/","msgid":"<8260b33b-504b-8b7e-44d0-b8699f33ab74@oracle.com>","list_archive_url":null,"date":"2017-09-06T16:48:46","subject":"Re: [PATCH net v2] rds: Fix incorrect statistics counting","submitter":{"id":65180,"url":"http://patchwork.ozlabs.org/api/people/65180/","name":"Santosh Shilimkar","email":"santosh.shilimkar@oracle.com"},"content":"On 9/6/2017 9:35 AM, Håkon Bugge wrote:\n> In rds_send_xmit() there is logic to batch the sends. However, if\n> another thread has acquired the lock and has incremented the send_gen,\n> it is considered a race and we yield. The code incrementing the\n> s_send_lock_queue_raced statistics counter did not count this event\n> correctly.\n> \n> This commit counts the race condition correctly.\n> \n> Changes from v1:\n> - Removed check for *someone_on_xmit()*\n> - Fixed incorrect indentation\n> \n> Signed-off-by: Håkon Bugge \n> Reviewed-by: Knut Omang \n> ---\n\nThanks for the update.\nAcked-by: Santosh Shilimkar ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnV0R5kTFz9t2r\n\tfor ;\n\tThu, 7 Sep 2017 02:48:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755583AbdIFQsu (ORCPT );\n\tWed, 6 Sep 2017 12:48:50 -0400","from aserp1040.oracle.com ([141.146.126.69]:42586 \"EHLO\n\taserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753966AbdIFQss (ORCPT\n\t); Wed, 6 Sep 2017 12:48:48 -0400","from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v86GmESg018932\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Wed, 6 Sep 2017 16:48:15 GMT","from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v86GmE2E000422\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Wed, 6 Sep 2017 16:48:14 GMT","from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v86GmD3s021020; \n\tWed, 6 Sep 2017 16:48:13 GMT","from [10.209.243.219] (/10.209.243.219)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Wed, 06 Sep 2017 09:48:13 -0700"],"Subject":"Re: [PATCH net v2] rds: Fix incorrect statistics counting","To":"=?utf-8?q?H=C3=A5kon_Bugge?= ,\n\t\"David S . Miller\" ","Cc":"netdev@vger.kernel.org, linux-rdma@vger.kernel.org,\n\trds-devel@oss.oracle.com, linux-kernel@vger.kernel.org,\n\tknut.omang@oracle.com","References":"<20170906163551.20387-1-Haakon.Bugge@oracle.com>","From":"Santosh Shilimkar ","Organization":"Oracle Corporation","Message-ID":"<8260b33b-504b-8b7e-44d0-b8699f33ab74@oracle.com>","Date":"Wed, 6 Sep 2017 09:48:46 -0700","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170906163551.20387-1-Haakon.Bugge@oracle.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-Source-IP":"aserv0022.oracle.com [141.146.126.234]","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765053,"web_url":"http://patchwork.ozlabs.org/comment/1765053/","msgid":"<20170907.200733.1562967291105061977.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-08T03:07:33","subject":"Re: [PATCH net v2] rds: Fix incorrect statistics counting","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Håkon Bugge \nDate: Wed, 6 Sep 2017 18:35:51 +0200\n\n> In rds_send_xmit() there is logic to batch the sends. However, if\n> another thread has acquired the lock and has incremented the send_gen,\n> it is considered a race and we yield. The code incrementing the\n> s_send_lock_queue_raced statistics counter did not count this event\n> correctly.\n> \n> This commit counts the race condition correctly.\n> \n> Changes from v1:\n> - Removed check for *someone_on_xmit()*\n> - Fixed incorrect indentation\n> \n> Signed-off-by: Håkon Bugge \n> Reviewed-by: Knut Omang \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpMh31hwhz9sMN\n\tfor ;\n\tFri, 8 Sep 2017 13:07:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932190AbdIHDHf convert rfc822-to-8bit (ORCPT\n\t);\n\tThu, 7 Sep 2017 23:07:35 -0400","from shards.monkeyblade.net ([184.105.139.130]:41704 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753867AbdIHDHe (ORCPT\n\t); Thu, 7 Sep 2017 23:07:34 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id CF6B513534D77;\n\tThu, 7 Sep 2017 20:07:33 -0700 (PDT)"],"Date":"Thu, 07 Sep 2017 20:07:33 -0700 (PDT)","Message-Id":"<20170907.200733.1562967291105061977.davem@davemloft.net>","To":"Haakon.Bugge@oracle.com","Cc":"santosh.shilimkar@oracle.com, netdev@vger.kernel.org,\n\tlinux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,\n\tlinux-kernel@vger.kernel.org, knut.omang@oracle.com","Subject":"Re: [PATCH net v2] rds: Fix incorrect statistics counting","From":"David Miller ","In-Reply-To":"<20170906163551.20387-1-Haakon.Bugge@oracle.com>","References":"<20170906163551.20387-1-Haakon.Bugge@oracle.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=iso-8859-1","Content-Transfer-Encoding":"8BIT","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 07 Sep 2017 20:07:34 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]