[{"id":1764325,"web_url":"http://patchwork.ozlabs.org/comment/1764325/","msgid":"<001c01d32748$20b94e20$622bea60$@ovn.org>","list_archive_url":null,"date":"2017-09-06T19:41:25","subject":"Re: [ovs-dev] [PATCH] dpif-netdev: Avoid side-effect in argument\n\tof\tatomic_store_relaxed().","submitter":{"id":72181,"url":"http://patchwork.ozlabs.org/api/people/72181/","name":"Alin-Gabriel Serdean","email":"aserdean@ovn.org"},"content":"Thanks a lot for fixing this!\n\nAcked-by: Alin Serdean \n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of Ben Pfaff\n> Sent: Wednesday, September 6, 2017 6:58 PM\n> To: dev@openvswitch.org\n> Cc: Ben Pfaff ; Alin Serdean \n> Subject: [ovs-dev] [PATCH] dpif-netdev: Avoid side-effect in argument of\n> atomic_store_relaxed().\n> \n> Some of the implementations of atomic_store_relaxed() evaluate their first\n> argument more than once, so arguments with side effects cause strange\n> behavior. This fixes a problem observed on 64-bit Windows.\n> \n> Reported-by: Alin Serdean \n> Signed-off-by: Ben Pfaff \n> ---\n> lib/dpif-netdev.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index\n> 071ec141f1d1..0ceef9d82914 100644\n> --- a/lib/dpif-netdev.c\n> +++ b/lib/dpif-netdev.c\n> @@ -3201,8 +3201,8 @@ static void\n> dp_netdev_rxq_set_intrvl_cycles(struct dp_netdev_rxq *rx,\n> unsigned long long cycles) {\n> - atomic_store_relaxed(&rx->cycles_intrvl[rx->intrvl_idx++\n> - % PMD_RXQ_INTERVAL_MAX],\ncycles);\n> + unsigned int idx = rx->intrvl_idx++ % PMD_RXQ_INTERVAL_MAX;\n> + atomic_store_relaxed(&rx->cycles_intrvl[idx], cycles);\n> }\n> \n> static uint64_t\n> --\n> 2.10.2\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnYqd5mKSz9s8J\n\tfor ;\n\tThu, 7 Sep 2017 05:41:32 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id C7F73AA6;\n\tWed, 6 Sep 2017 19:41:29 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 9FE6898C\n\tfor ; Wed, 6 Sep 2017 19:41:28 +0000 (UTC)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0A5DA271\n\tfor ; Wed, 6 Sep 2017 19:41:27 +0000 (UTC)","from cloudbasealin (unknown [79.114.121.216])\n\t(Authenticated sender: aserdean@ovn.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id BAD14C5A53;\n\tWed, 6 Sep 2017 21:41:25 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"79.114.121.216","From":"","To":"\"'Ben Pfaff'\" ,\n\t","References":"<20170906155745.1031-1-blp@ovn.org>","In-Reply-To":"<20170906155745.1031-1-blp@ovn.org>","Date":"Wed, 6 Sep 2017 22:41:25 +0300","Message-ID":"<001c01d32748$20b94e20$622bea60$@ovn.org>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 16.0","Thread-Index":"AQHTJyjw2GDvfOU7EEeC2tzoM/u41qKoQbSQ","Content-Language":"ro","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"'Alin Serdean' ","Subject":"Re: [ovs-dev] [PATCH] dpif-netdev: Avoid side-effect in argument\n\tof\tatomic_store_relaxed().","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1764359,"web_url":"http://patchwork.ozlabs.org/comment/1764359/","msgid":"<40AE967E-62B5-4107-BAA0-8FFB738BC2C0@vmware.com>","list_archive_url":null,"date":"2017-09-06T20:40:01","subject":"Re: [ovs-dev] [PATCH] dpif-netdev: Avoid side-effect in argument of\n\tatomic_store_relaxed().","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"On 9/6/17, 8:57 AM, \"ovs-dev-bounces@openvswitch.org on behalf of Ben Pfaff\" wrote:\n\n Some of the implementations of atomic_store_relaxed() evaluate their\n first argument more than once, so arguments with side effects cause\n strange behavior. This fixes a problem observed on 64-bit Windows.\n\nAcked-by: Darrell Ball \n \n Reported-by: Alin Serdean \n Signed-off-by: Ben Pfaff \n ---\n lib/dpif-netdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n \n diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\n index 071ec141f1d1..0ceef9d82914 100644\n --- a/lib/dpif-netdev.c\n +++ b/lib/dpif-netdev.c\n @@ -3201,8 +3201,8 @@ static void\n dp_netdev_rxq_set_intrvl_cycles(struct dp_netdev_rxq *rx,\n unsigned long long cycles)\n {\n - atomic_store_relaxed(&rx->cycles_intrvl[rx->intrvl_idx++\n - % PMD_RXQ_INTERVAL_MAX], cycles);\n + unsigned int idx = rx->intrvl_idx++ % PMD_RXQ_INTERVAL_MAX;\n + atomic_store_relaxed(&rx->cycles_intrvl[idx], cycles);\n }\n \n static uint64_t\n -- \n 2.10.2\n \n _______________________________________________\n dev mailing list\n dev@openvswitch.org\n https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=dbPiJUxk4mmv_rFKdPUGAFvYi0T-dlJbVYyuRzb0gtQ&s=pwkvuvnWKzBBebzMnL_KG-Hkl2YICM8ZeyhU_f984Sg&e=","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"dc/DB1nc\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnb7G0ptRz9t2r\n\tfor ;\n\tThu, 7 Sep 2017 06:40:10 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id DBE3CA49;\n\tWed, 6 Sep 2017 20:40:06 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 24DD994F\n\tfor ; Wed, 6 Sep 2017 20:40:05 +0000 (UTC)","from NAM01-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam01on0054.outbound.protection.outlook.com [104.47.32.54])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0974F1E2\n\tfor ; Wed, 6 Sep 2017 20:40:03 +0000 (UTC)","from BLUPR05MB611.namprd05.prod.outlook.com (10.141.204.27) by\n\tBLUPR05MB595.namprd05.prod.outlook.com (10.141.203.150) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.35.3; Wed, 6 Sep 2017 20:40:01 +0000","from BLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) by\n\tBLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) with mapi id\n\t15.20.0035.010; Wed, 6 Sep 2017 20:40:01 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=ROp+mcaJ9u+d05ChKV0A88AOAVRyhdC4rMq0zsXZHyc=;\n\tb=dc/DB1ncYwH3x1x+MLFoBx6oOyjCeLdvBiTRbhC3GVfhw9gqaeo+zw6sM4MAIyQfn6bjg7ZxGDUaajIEDsY0PbFrX2mZ+VNlh5m//NKsa98Y1E7NfOikofY4HLSmf5y89osqXxx6W93pyEVHu/8l6b9BtXjTk06PQoae7xULFhI=","From":"Darrell Ball ","To":"Ben Pfaff , \"dev@openvswitch.org\" ","Thread-Topic":"[ovs-dev] [PATCH] dpif-netdev: Avoid side-effect in argument of\n\tatomic_store_relaxed().","Thread-Index":"AQHTJ1BPXeUt7LgVr0awJIYVwYtudw==","Date":"Wed, 6 Sep 2017 20:40:01 +0000","Message-ID":"<40AE967E-62B5-4107-BAA0-8FFB738BC2C0@vmware.com>","References":"<20170906155745.1031-1-blp@ovn.org>","In-Reply-To":"<20170906155745.1031-1-blp@ovn.org>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.23.0.170610","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"dc/DB1nc\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[96.90.255.131]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BLUPR05MB595;\n\t20:NUul4JUcRt3ii5Zx5t8rT3qHurLs1ZEgk/Mqgpq221RIHxsAXwzTEMRDdlYMVCdihhZAzJfpUi50HlAzqqfXNqjWQeqVP7ysz2/AqF0SJbMZoXTvC2gzqPs+OR4+GEAIiB1LR5DdUQCQRw1S6ST5jPoBM1TgyKUIjuOeQFQnavo=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"cab7b2a4-e3e2-43c1-de00-08d4f567725e","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR05MB595; ","x-ms-traffictypediagnostic":"BLUPR05MB595:","x-exchange-antispam-report-test":"UriScan:(10436049006162)(216315784871565);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR05MB595; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR05MB595; ","x-forefront-prvs":"0422860ED4","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(979002)(6009001)(377454003)(199003)(24454002)(189002)(966005)(2906002)(2900100001)(25786009)(3280700002)(66066001)(36756003)(14454004)(53546010)(189998001)(2501003)(4326008)(50986999)(76176999)(54356999)(102836003)(478600001)(33656002)(106356001)(3660700001)(101416001)(6116002)(3846002)(5660300001)(105586002)(8676002)(81156014)(81166006)(7736002)(305945005)(8936002)(229853002)(68736007)(6486002)(2950100002)(6506006)(77096006)(99286003)(6512007)(82746002)(53936002)(6306002)(83506001)(4001350100001)(83716003)(6246003)(97736004)(86362001)(575784001)(6436002)(969003)(989001)(999001)(1009001)(1019001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR05MB595;\n\tH:BLUPR05MB611.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<2E08D101C5BDE64DAB9F7AE93E82D600@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"06 Sep 2017 20:40:01.4401\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR05MB595","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"Alin Serdean ","Subject":"Re: [ovs-dev] [PATCH] dpif-netdev: Avoid side-effect in argument of\n\tatomic_store_relaxed().","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1765981,"web_url":"http://patchwork.ozlabs.org/comment/1765981/","msgid":"<20170910174600.GZ6175@ovn.org>","list_archive_url":null,"date":"2017-09-10T17:46:00","subject":"Re: [ovs-dev] [PATCH] dpif-netdev: Avoid side-effect in argument of\n\tatomic_store_relaxed().","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"Thanks Alin and Darrell, I applied this to master. I don't think it\nneeds any backports.\n\nOn Wed, Sep 06, 2017 at 10:41:25PM +0300, aserdean@ovn.org wrote:\n> Thanks a lot for fixing this!\n> \n> Acked-by: Alin Serdean \n> \n> > -----Original Message-----\n> > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> > bounces@openvswitch.org] On Behalf Of Ben Pfaff\n> > Sent: Wednesday, September 6, 2017 6:58 PM\n> > To: dev@openvswitch.org\n> > Cc: Ben Pfaff ; Alin Serdean \n> > Subject: [ovs-dev] [PATCH] dpif-netdev: Avoid side-effect in argument of\n> > atomic_store_relaxed().\n> > \n> > Some of the implementations of atomic_store_relaxed() evaluate their first\n> > argument more than once, so arguments with side effects cause strange\n> > behavior. This fixes a problem observed on 64-bit Windows.\n> > \n> > Reported-by: Alin Serdean \n> > Signed-off-by: Ben Pfaff \n> > ---\n> > lib/dpif-netdev.c | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index\n> > 071ec141f1d1..0ceef9d82914 100644\n> > --- a/lib/dpif-netdev.c\n> > +++ b/lib/dpif-netdev.c\n> > @@ -3201,8 +3201,8 @@ static void\n> > dp_netdev_rxq_set_intrvl_cycles(struct dp_netdev_rxq *rx,\n> > unsigned long long cycles) {\n> > - atomic_store_relaxed(&rx->cycles_intrvl[rx->intrvl_idx++\n> > - % PMD_RXQ_INTERVAL_MAX],\n> cycles);\n> > + unsigned int idx = rx->intrvl_idx++ % PMD_RXQ_INTERVAL_MAX;\n> > + atomic_store_relaxed(&rx->cycles_intrvl[idx], cycles);\n> > }\n> > \n> > static uint64_t\n> > --\n> > 2.10.2\n> > \n> > _______________________________________________\n> > dev mailing list\n> > dev@openvswitch.org\n> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqz4h5WQvz9s03\n\tfor ;\n\tMon, 11 Sep 2017 03:46:12 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 7D214AB8;\n\tSun, 10 Sep 2017 17:46:10 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 1856B957\n\tfor ; Sun, 10 Sep 2017 17:46:10 +0000 (UTC)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 90BFE180\n\tfor ; Sun, 10 Sep 2017 17:46:09 +0000 (UTC)","from ovn.org (173-228-112-34.dsl.dynamic.fusionbroadband.com\n\t[173.228.112.34]) (Authenticated sender: blp@ovn.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 2839DFB8AC;\n\tSun, 10 Sep 2017 19:46:05 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"173.228.112.34","Date":"Sun, 10 Sep 2017 10:46:00 -0700","From":"Ben Pfaff ","To":"aserdean@ovn.org, Darrell Ball ","Message-ID":"<20170910174600.GZ6175@ovn.org>","References":"<20170906155745.1031-1-blp@ovn.org>\n\t<001c01d32748$20b94e20$622bea60$@ovn.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<001c01d32748$20b94e20$622bea60$@ovn.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH] dpif-netdev: Avoid side-effect in argument of\n\tatomic_store_relaxed().","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]