[{"id":1764216,"web_url":"http://patchwork.ozlabs.org/comment/1764216/","msgid":"<0d0a6c13-e188-f0fa-c51a-cf5cd885af13@canonical.com>","list_archive_url":null,"date":"2017-09-06T15:53:57","subject":"ACK: [trusty CVE-2016-7097 v2 1/1] posix_acl: Clear SGID bit when\n\tsetting file permissions","submitter":{"id":71419,"url":"http://patchwork.ozlabs.org/api/people/71419/","name":"Kleber Sacilotto de Souza","email":"kleber.souza@canonical.com"},"content":"On 09/06/17 17:51, Juerg Haefliger wrote:\n> From: Jan Kara \n> \n> commit 073931017b49d9458aa351605b43a7e34598caef upstream.\n> \n> When file permissions are modified via chmod(2) and the user is not in\n> the owning group or capable of CAP_FSETID, the setgid bit is cleared in\n> inode_change_ok(). Setting a POSIX ACL via setxattr(2) sets the file\n> permissions as well as the new ACL, but doesn't clear the setgid bit in\n> a similar way; this allows to bypass the check in chmod(2). Fix that.\n> \n> References: CVE-2016-7097\n> Reviewed-by: Christoph Hellwig \n> Reviewed-by: Jeff Layton \n> Signed-off-by: Jan Kara \n> Signed-off-by: Andreas Gruenbacher \n> [bwh: Backported to 3.16:\n> - Drop changes to orangefs\n> - Adjust context\n> - Update ext3 as well]\n> Signed-off-by: Ben Hutchings \n> \n> CVE-2016-7097\n> \n> (backported from f2ba3e2310b3967720b83126db8684c69ce41894 3.16.y)\n> [juergh: Backported to 3.13:\n> - Drop changes to ceph\n> - Update generic_acl.c as well\n> - In gfs2, jfs, and xfs, take care to avoid leaking the allocated ACL if\n> posix_acl_update_mode() determines it's not needed]\n> Signed-off-by: Juerg Haefliger \n\nAcked-by: Kleber Sacilotto de Souza \n\n> ---\n> fs/9p/acl.c | 40 +++++++++++++++++-----------------------\n> fs/btrfs/acl.c | 6 ++----\n> fs/ext2/acl.c | 12 ++++--------\n> fs/ext3/acl.c | 12 ++++--------\n> fs/ext4/acl.c | 12 ++++--------\n> fs/f2fs/acl.c | 6 ++----\n> fs/generic_acl.c | 15 ++++++++-------\n> fs/gfs2/acl.c | 16 +++++++---------\n> fs/hfsplus/posix_acl.c | 4 ++--\n> fs/jffs2/acl.c | 9 ++++-----\n> fs/jfs/xattr.c | 6 ++++--\n> fs/ocfs2/acl.c | 9 +++------\n> fs/posix_acl.c | 31 +++++++++++++++++++++++++++++++\n> fs/reiserfs/xattr_acl.c | 8 ++------\n> fs/xfs/xfs_acl.c | 17 +++++++----------\n> include/linux/posix_acl.h | 1 +\n> 16 files changed, 102 insertions(+), 102 deletions(-)\n> \n> diff --git a/fs/9p/acl.c b/fs/9p/acl.c\n> index 7af425f53bee..9686c1f17653 100644\n> --- a/fs/9p/acl.c\n> +++ b/fs/9p/acl.c\n> @@ -320,32 +320,26 @@ static int v9fs_xattr_set_acl(struct dentry *dentry, const char *name,\n> \tcase ACL_TYPE_ACCESS:\n> \t\tname = POSIX_ACL_XATTR_ACCESS;\n> \t\tif (acl) {\n> -\t\t\tumode_t mode = inode->i_mode;\n> -\t\t\tretval = posix_acl_equiv_mode(acl, &mode);\n> -\t\t\tif (retval < 0)\n> +\t\t\tstruct iattr iattr;\n> +\n> +\t\t\tretval = posix_acl_update_mode(inode, &iattr.ia_mode, &acl);\n> +\t\t\tif (retval)\n> \t\t\t\tgoto err_out;\n> -\t\t\telse {\n> -\t\t\t\tstruct iattr iattr;\n> -\t\t\t\tif (retval == 0) {\n> -\t\t\t\t\t/*\n> -\t\t\t\t\t * ACL can be represented\n> -\t\t\t\t\t * by the mode bits. So don't\n> -\t\t\t\t\t * update ACL.\n> -\t\t\t\t\t */\n> -\t\t\t\t\tacl = NULL;\n> -\t\t\t\t\tvalue = NULL;\n> -\t\t\t\t\tsize = 0;\n> -\t\t\t\t}\n> -\t\t\t\t/* Updte the mode bits */\n> -\t\t\t\tiattr.ia_mode = ((mode & S_IALLUGO) |\n> -\t\t\t\t\t\t (inode->i_mode & ~S_IALLUGO));\n> -\t\t\t\tiattr.ia_valid = ATTR_MODE;\n> -\t\t\t\t/* FIXME should we update ctime ?\n> -\t\t\t\t * What is the following setxattr update the\n> -\t\t\t\t * mode ?\n> +\t\t\tif (!acl) {\n> +\t\t\t\t/*\n> +\t\t\t\t * ACL can be represented\n> +\t\t\t\t * by the mode bits. So don't\n> +\t\t\t\t * update ACL.\n> \t\t\t\t */\n> -\t\t\t\tv9fs_vfs_setattr_dotl(dentry, &iattr);\n> +\t\t\t\tvalue = NULL;\n> +\t\t\t\tsize = 0;\n> \t\t\t}\n> +\t\t\tiattr.ia_valid = ATTR_MODE;\n> +\t\t\t/* FIXME should we update ctime ?\n> +\t\t\t * What is the following setxattr update the\n> +\t\t\t * mode ?\n> +\t\t\t */\n> +\t\t\tv9fs_vfs_setattr_dotl(dentry, &iattr);\n> \t\t}\n> \t\tbreak;\n> \tcase ACL_TYPE_DEFAULT:\n> diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c\n> index 0890c83643e9..d6d53e5e7945 100644\n> --- a/fs/btrfs/acl.c\n> +++ b/fs/btrfs/acl.c\n> @@ -118,11 +118,9 @@ static int btrfs_set_acl(struct btrfs_trans_handle *trans,\n> \tcase ACL_TYPE_ACCESS:\n> \t\tname = POSIX_ACL_XATTR_ACCESS;\n> \t\tif (acl) {\n> -\t\t\tret = posix_acl_equiv_mode(acl, &inode->i_mode);\n> -\t\t\tif (ret < 0)\n> +\t\t\tret = posix_acl_update_mode(inode, &inode->i_mode, &acl);\n> +\t\t\tif (ret)\n> \t\t\t\treturn ret;\n> -\t\t\tif (ret == 0)\n> -\t\t\t\tacl = NULL;\n> \t\t}\n> \t\tret = 0;\n> \t\tbreak;\n> diff --git a/fs/ext2/acl.c b/fs/ext2/acl.c\n> index 110b6b371a4e..48c3c2d7d261 100644\n> --- a/fs/ext2/acl.c\n> +++ b/fs/ext2/acl.c\n> @@ -206,15 +206,11 @@ ext2_set_acl(struct inode *inode, int type, struct posix_acl *acl)\n> \t\tcase ACL_TYPE_ACCESS:\n> \t\t\tname_index = EXT2_XATTR_INDEX_POSIX_ACL_ACCESS;\n> \t\t\tif (acl) {\n> -\t\t\t\terror = posix_acl_equiv_mode(acl, &inode->i_mode);\n> -\t\t\t\tif (error < 0)\n> +\t\t\t\terror = posix_acl_update_mode(inode, &inode->i_mode, &acl);\n> +\t\t\t\tif (error)\n> \t\t\t\t\treturn error;\n> -\t\t\t\telse {\n> -\t\t\t\t\tinode->i_ctime = CURRENT_TIME_SEC;\n> -\t\t\t\t\tmark_inode_dirty(inode);\n> -\t\t\t\t\tif (error == 0)\n> -\t\t\t\t\t\tacl = NULL;\n> -\t\t\t\t}\n> +\t\t\t\tinode->i_ctime = CURRENT_TIME_SEC;\n> +\t\t\t\tmark_inode_dirty(inode);\n> \t\t\t}\n> \t\t\tbreak;\n> \n> diff --git a/fs/ext3/acl.c b/fs/ext3/acl.c\n> index dbb5ad59a7fc..bb2f60a62d82 100644\n> --- a/fs/ext3/acl.c\n> +++ b/fs/ext3/acl.c\n> @@ -205,15 +205,11 @@ ext3_set_acl(handle_t *handle, struct inode *inode, int type,\n> \t\tcase ACL_TYPE_ACCESS:\n> \t\t\tname_index = EXT3_XATTR_INDEX_POSIX_ACL_ACCESS;\n> \t\t\tif (acl) {\n> -\t\t\t\terror = posix_acl_equiv_mode(acl, &inode->i_mode);\n> -\t\t\t\tif (error < 0)\n> +\t\t\t\terror = posix_acl_update_mode(inode, &inode->i_mode, &acl);\n> +\t\t\t\tif (error)\n> \t\t\t\t\treturn error;\n> -\t\t\t\telse {\n> -\t\t\t\t\tinode->i_ctime = CURRENT_TIME_SEC;\n> -\t\t\t\t\text3_mark_inode_dirty(handle, inode);\n> -\t\t\t\t\tif (error == 0)\n> -\t\t\t\t\t\tacl = NULL;\n> -\t\t\t\t}\n> +\t\t\t\tinode->i_ctime = CURRENT_TIME_SEC;\n> +\t\t\t\text3_mark_inode_dirty(handle, inode);\n> \t\t\t}\n> \t\t\tbreak;\n> \n> diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c\n> index 39a54a0e9fe4..c844f1bfb451 100644\n> --- a/fs/ext4/acl.c\n> +++ b/fs/ext4/acl.c\n> @@ -211,15 +211,11 @@ ext4_set_acl(handle_t *handle, struct inode *inode, int type,\n> \tcase ACL_TYPE_ACCESS:\n> \t\tname_index = EXT4_XATTR_INDEX_POSIX_ACL_ACCESS;\n> \t\tif (acl) {\n> -\t\t\terror = posix_acl_equiv_mode(acl, &inode->i_mode);\n> -\t\t\tif (error < 0)\n> +\t\t\terror = posix_acl_update_mode(inode, &inode->i_mode, &acl);\n> +\t\t\tif (error)\n> \t\t\t\treturn error;\n> -\t\t\telse {\n> -\t\t\t\tinode->i_ctime = ext4_current_time(inode);\n> -\t\t\t\text4_mark_inode_dirty(handle, inode);\n> -\t\t\t\tif (error == 0)\n> -\t\t\t\t\tacl = NULL;\n> -\t\t\t}\n> +\t\t\tinode->i_ctime = ext4_current_time(inode);\n> +\t\t\text4_mark_inode_dirty(handle, inode);\n> \t\t}\n> \t\tbreak;\n> \n> diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c\n> index d0fc287efeff..0eb2d66827ad 100644\n> --- a/fs/f2fs/acl.c\n> +++ b/fs/f2fs/acl.c\n> @@ -224,12 +224,10 @@ static int f2fs_set_acl(struct inode *inode, int type,\n> \tcase ACL_TYPE_ACCESS:\n> \t\tname_index = F2FS_XATTR_INDEX_POSIX_ACL_ACCESS;\n> \t\tif (acl) {\n> -\t\t\terror = posix_acl_equiv_mode(acl, &inode->i_mode);\n> -\t\t\tif (error < 0)\n> +\t\t\terror = posix_acl_update_mode(inode, &inode->i_mode, &acl);\n> +\t\t\tif (error)\n> \t\t\t\treturn error;\n> \t\t\tset_acl_inode(fi, inode->i_mode);\n> -\t\t\tif (error == 0)\n> -\t\t\t\tacl = NULL;\n> \t\t}\n> \t\tbreak;\n> \n> diff --git a/fs/generic_acl.c b/fs/generic_acl.c\n> index b3f3676796d3..67319f168b42 100644\n> --- a/fs/generic_acl.c\n> +++ b/fs/generic_acl.c\n> @@ -86,16 +86,17 @@ generic_acl_set(struct dentry *dentry, const char *name, const void *value,\n> \t\tif (error)\n> \t\t\tgoto failed;\n> \t\tswitch (type) {\n> -\t\tcase ACL_TYPE_ACCESS:\n> -\t\t\terror = posix_acl_equiv_mode(acl, &inode->i_mode);\n> -\t\t\tif (error < 0)\n> +\t\tcase ACL_TYPE_ACCESS: {\n> +\t\t\tstruct posix_acl *saved_acl = acl;\n> +\n> +\t\t\terror = posix_acl_update_mode(inode, &inode->i_mode, &acl);\n> +\t\t\tif (acl == NULL)\n> +\t\t\t\tposix_acl_release(saved_acl);\n> +\t\t\tif (error)\n> \t\t\t\tgoto failed;\n> \t\t\tinode->i_ctime = CURRENT_TIME;\n> -\t\t\tif (error == 0) {\n> -\t\t\t\tposix_acl_release(acl);\n> -\t\t\t\tacl = NULL;\n> -\t\t\t}\n> \t\t\tbreak;\n> +\t\t}\n> \t\tcase ACL_TYPE_DEFAULT:\n> \t\t\tif (!S_ISDIR(inode->i_mode)) {\n> \t\t\t\terror = -EINVAL;\n> diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c\n> index f69ac0af5496..015809a066b5 100644\n> --- a/fs/gfs2/acl.c\n> +++ b/fs/gfs2/acl.c\n> @@ -267,16 +267,14 @@ static int gfs2_xattr_system_set(struct dentry *dentry, const char *name,\n> \t\tgoto out_release;\n> \n> \tif (type == ACL_TYPE_ACCESS) {\n> -\t\tumode_t mode = inode->i_mode;\n> -\t\terror = posix_acl_equiv_mode(acl, &mode);\n> +\t\tstruct posix_acl *saved_acl = acl;\n> +\t\tumode_t mode;\n> \n> -\t\tif (error <= 0) {\n> -\t\t\tposix_acl_release(acl);\n> -\t\t\tacl = NULL;\n> -\n> -\t\t\tif (error < 0)\n> -\t\t\t\treturn error;\n> -\t\t}\n> +\t\terror = posix_acl_update_mode(inode, &mode, &acl);\n> +\t\tif (error || acl == NULL)\n> +\t\t\tposix_acl_release(saved_acl);\n> +\t\tif (error)\n> +\t\t\treturn error;\n> \n> \t\terror = gfs2_set_mode(inode, mode);\n> \t\tif (error)\n> diff --git a/fs/hfsplus/posix_acl.c b/fs/hfsplus/posix_acl.c\n> index b609cc14c72e..9f7cc491ffb1 100644\n> --- a/fs/hfsplus/posix_acl.c\n> +++ b/fs/hfsplus/posix_acl.c\n> @@ -72,8 +72,8 @@ static int hfsplus_set_posix_acl(struct inode *inode,\n> \tcase ACL_TYPE_ACCESS:\n> \t\txattr_name = POSIX_ACL_XATTR_ACCESS;\n> \t\tif (acl) {\n> -\t\t\terr = posix_acl_equiv_mode(acl, &inode->i_mode);\n> -\t\t\tif (err < 0)\n> +\t\t\terr = posix_acl_update_mode(inode, &inode->i_mode, &acl);\n> +\t\t\tif (err)\n> \t\t\t\treturn err;\n> \t\t}\n> \t\terr = 0;\n> diff --git a/fs/jffs2/acl.c b/fs/jffs2/acl.c\n> index 223283c30111..9335b8d3cf52 100644\n> --- a/fs/jffs2/acl.c\n> +++ b/fs/jffs2/acl.c\n> @@ -243,9 +243,10 @@ static int jffs2_set_acl(struct inode *inode, int type, struct posix_acl *acl)\n> \tcase ACL_TYPE_ACCESS:\n> \t\txprefix = JFFS2_XPREFIX_ACL_ACCESS;\n> \t\tif (acl) {\n> -\t\t\tumode_t mode = inode->i_mode;\n> -\t\t\trc = posix_acl_equiv_mode(acl, &mode);\n> -\t\t\tif (rc < 0)\n> +\t\t\tumode_t mode;\n> +\n> +\t\t\trc = posix_acl_update_mode(inode, &mode, &acl);\n> +\t\t\tif (rc)\n> \t\t\t\treturn rc;\n> \t\t\tif (inode->i_mode != mode) {\n> \t\t\t\tstruct iattr attr;\n> @@ -257,8 +258,6 @@ static int jffs2_set_acl(struct inode *inode, int type, struct posix_acl *acl)\n> \t\t\t\tif (rc < 0)\n> \t\t\t\t\treturn rc;\n> \t\t\t}\n> -\t\t\tif (rc == 0)\n> -\t\t\t\tacl = NULL;\n> \t\t}\n> \t\tbreak;\n> \tcase ACL_TYPE_DEFAULT:\n> diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c\n> index d3472f4cd530..6910662a8bf5 100644\n> --- a/fs/jfs/xattr.c\n> +++ b/fs/jfs/xattr.c\n> @@ -693,9 +693,11 @@ static int can_set_system_xattr(struct inode *inode, const char *name,\n> \t\t\treturn rc;\n> \t\t}\n> \t\tif (acl) {\n> -\t\t\trc = posix_acl_equiv_mode(acl, &inode->i_mode);\n> +\t\t\tstruct posix_acl *dummy = acl;\n> +\n> +\t\t\trc = posix_acl_update_mode(inode, &inode->i_mode, &dummy);\n> \t\t\tposix_acl_release(acl);\n> -\t\t\tif (rc < 0) {\n> +\t\t\tif (rc) {\n> \t\t\t\tprintk(KERN_ERR\n> \t\t\t\t \"posix_acl_equiv_mode returned %d\\n\",\n> \t\t\t\t rc);\n> diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c\n> index b4f788e0ca31..b16bb5c70bc8 100644\n> --- a/fs/ocfs2/acl.c\n> +++ b/fs/ocfs2/acl.c\n> @@ -270,14 +270,11 @@ static int ocfs2_set_acl(handle_t *handle,\n> \tcase ACL_TYPE_ACCESS:\n> \t\tname_index = OCFS2_XATTR_INDEX_POSIX_ACL_ACCESS;\n> \t\tif (acl) {\n> -\t\t\tumode_t mode = inode->i_mode;\n> -\t\t\tret = posix_acl_equiv_mode(acl, &mode);\n> -\t\t\tif (ret < 0)\n> +\t\t\tumode_t mode;\n> +\t\t\tret = posix_acl_update_mode(inode, &mode, &acl);\n> +\t\t\tif (ret)\n> \t\t\t\treturn ret;\n> \t\t\telse {\n> -\t\t\t\tif (ret == 0)\n> -\t\t\t\t\tacl = NULL;\n> -\n> \t\t\t\tret = ocfs2_acl_set_mode(inode, di_bh,\n> \t\t\t\t\t\t\t handle, mode);\n> \t\t\t\tif (ret)\n> diff --git a/fs/posix_acl.c b/fs/posix_acl.c\n> index 3542f1f814e2..7a82cf1601d5 100644\n> --- a/fs/posix_acl.c\n> +++ b/fs/posix_acl.c\n> @@ -407,6 +407,37 @@ posix_acl_create(struct posix_acl **acl, gfp_t gfp, umode_t *mode_p)\n> }\n> EXPORT_SYMBOL(posix_acl_create);\n> \n> +/**\n> + * posix_acl_update_mode - update mode in set_acl\n> + *\n> + * Update the file mode when setting an ACL: compute the new file permission\n> + * bits based on the ACL. In addition, if the ACL is equivalent to the new\n> + * file mode, set *acl to NULL to indicate that no ACL should be set.\n> + *\n> + * As with chmod, clear the setgit bit if the caller is not in the owning group\n> + * or capable of CAP_FSETID (see inode_change_ok).\n> + *\n> + * Called from set_acl inode operations.\n> + */\n> +int posix_acl_update_mode(struct inode *inode, umode_t *mode_p,\n> +\t\t\t struct posix_acl **acl)\n> +{\n> +\tumode_t mode = inode->i_mode;\n> +\tint error;\n> +\n> +\terror = posix_acl_equiv_mode(*acl, &mode);\n> +\tif (error < 0)\n> +\t\treturn error;\n> +\tif (error == 0)\n> +\t\t*acl = NULL;\n> +\tif (!in_group_p(inode->i_gid) &&\n> +\t !capable_wrt_inode_uidgid(inode, CAP_FSETID))\n> +\t\tmode &= ~S_ISGID;\n> +\t*mode_p = mode;\n> +\treturn 0;\n> +}\n> +EXPORT_SYMBOL(posix_acl_update_mode);\n> +\n> int\n> posix_acl_chmod(struct posix_acl **acl, gfp_t gfp, umode_t mode)\n> {\n> diff --git a/fs/reiserfs/xattr_acl.c b/fs/reiserfs/xattr_acl.c\n> index 06c04f73da65..a86ad7ec7957 100644\n> --- a/fs/reiserfs/xattr_acl.c\n> +++ b/fs/reiserfs/xattr_acl.c\n> @@ -288,13 +288,9 @@ reiserfs_set_acl(struct reiserfs_transaction_handle *th, struct inode *inode,\n> \tcase ACL_TYPE_ACCESS:\n> \t\tname = POSIX_ACL_XATTR_ACCESS;\n> \t\tif (acl) {\n> -\t\t\terror = posix_acl_equiv_mode(acl, &inode->i_mode);\n> -\t\t\tif (error < 0)\n> +\t\t\terror = posix_acl_update_mode(inode, &inode->i_mode, &acl);\n> +\t\t\tif (error)\n> \t\t\t\treturn error;\n> -\t\t\telse {\n> -\t\t\t\tif (error == 0)\n> -\t\t\t\t\tacl = NULL;\n> -\t\t\t}\n> \t\t}\n> \t\tbreak;\n> \tcase ACL_TYPE_DEFAULT:\n> diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c\n> index 370eb3e121d1..89ac0522b38d 100644\n> --- a/fs/xfs/xfs_acl.c\n> +++ b/fs/xfs/xfs_acl.c\n> @@ -402,17 +402,14 @@ xfs_xattr_acl_set(struct dentry *dentry, const char *name,\n> \t\tgoto out_release;\n> \n> \tif (type == ACL_TYPE_ACCESS) {\n> -\t\tumode_t mode = inode->i_mode;\n> -\t\terror = posix_acl_equiv_mode(acl, &mode);\n> -\n> -\t\tif (error <= 0) {\n> -\t\t\tposix_acl_release(acl);\n> -\t\t\tacl = NULL;\n> -\n> -\t\t\tif (error < 0)\n> -\t\t\t\treturn error;\n> -\t\t}\n> +\t\tstruct posix_acl *saved_acl = acl;\n> +\t\tumode_t mode;\n> \n> +\t\terror = posix_acl_update_mode(inode, &mode, &acl);\n> +\t\tif (error || acl == NULL)\n> +\t\t\tposix_acl_release(saved_acl);\n> +\t\tif (error)\n> +\t\t\treturn error;\n> \t\terror = xfs_set_mode(inode, mode);\n> \t\tif (error)\n> \t\t\tgoto out_release;\n> diff --git a/include/linux/posix_acl.h b/include/linux/posix_acl.h\n> index 7931efe71175..2ae0bba45f12 100644\n> --- a/include/linux/posix_acl.h\n> +++ b/include/linux/posix_acl.h\n> @@ -90,6 +90,7 @@ extern struct posix_acl *posix_acl_from_mode(umode_t, gfp_t);\n> extern int posix_acl_equiv_mode(const struct posix_acl *, umode_t *);\n> extern int posix_acl_create(struct posix_acl **, gfp_t, umode_t *);\n> extern int posix_acl_chmod(struct posix_acl **, gfp_t, umode_t);\n> +extern int posix_acl_update_mode(struct inode *, umode_t *, struct posix_acl **);\n> \n> extern struct posix_acl *get_posix_acl(struct inode *, int);\n> extern int set_posix_acl(struct inode *, int, struct posix_acl *);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnSnD0Fqkz9sNV;\n\tThu, 7 Sep 2017 01:54:08 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpceS-0003b0-IK; Wed, 06 Sep 2017 15:54:04 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpceP-0003aN-SU\n\tfor kernel-team@lists.ubuntu.com; Wed, 06 Sep 2017 15:54:01 +0000","from mail-wr0-f198.google.com ([209.85.128.198])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpceP-0001Aj-JZ\n\tfor kernel-team@lists.ubuntu.com; Wed, 06 Sep 2017 15:54:01 +0000","by mail-wr0-f198.google.com with SMTP id b9so7919163wra.3\n\tfor ;\n\tWed, 06 Sep 2017 08:54:01 -0700 (PDT)","from [192.168.0.8] (ip5f5bd015.dynamic.kabel-deutschland.de.\n\t[95.91.208.21]) by smtp.gmail.com with ESMTPSA id\n\tl50sm106011eda.50.2017.09.06.08.53.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 06 Sep 2017 08:53:59 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=UMCnJRqyihwD9nJ7edyyFk0B1TF7ugiQXbCunYRS6As=;\n\tb=ethA1gAcs/0ZYy01XmvH7a1s7+tX4AuHRHsxj9Nkp0gX8QRS/4gjj0NlgigRy7nV1+\n\tyMoMcn0ny/lFExqJTF6XIsC/O4IlNnAdPwSO6mHl1ythBtRGoPLXFbiM25iDHaA04xdb\n\t0Ps6/gTFjVERA/bPwNOL68jYN2DuTcP9+/VNGWuRFadjgkv0CBV2dhg5+/BkDFzPKt31\n\tISWjXB/FAjwgQRzIPxZoc0TxOQXZqhci0v0fWUZgJaD41vTd35dLmXH+F55oGOeeZwqc\n\tqk0gJET5P5+FTDamL36EROZhckewiyrsTLtQrG03cL8WUUsTxEVnAn+nrLVtIZcL4C0i\n\t8Pxg==","X-Gm-Message-State":"AHPjjUgCIcW5qnutl4uca8Zk4qFWv1lemCZTc1XskLZoXPX2vcDtd3/3\n\tLJttBR1fQHZpHyq4WlO8JfyKwPec2qg3UIdr8QUWMF45RmDryqKY9A74diJ9d6dMKyQ/VZnO4Mt\n\twZ9nDViBZpRLQNOdJkx9bwLIn6d+CWrgn","X-Received":["by 10.80.195.91 with SMTP id q27mr170452edb.144.1504713240624;\n\tWed, 06 Sep 2017 08:54:00 -0700 (PDT)","by 10.80.195.91 with SMTP id q27mr170437edb.144.1504713240172;\n\tWed, 06 Sep 2017 08:54:00 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb7BRhId+/wM9IFO2IHuigRna0J8ByfnI3a2MC7hJE1PQirJaHXzSzFPq/EZqrr9q1lixTWqqA==","Subject":"ACK: [trusty CVE-2016-7097 v2 1/1] posix_acl: Clear SGID bit when\n\tsetting file permissions","To":"Juerg Haefliger ,\n\tkernel-team@lists.ubuntu.com","References":"<20170906085453.22382-1-juerg.haefliger@canonical.com>\n\t<20170906155115.24400-1-juerg.haefliger@canonical.com>\n\t<20170906155115.24400-2-juerg.haefliger@canonical.com>","From":"Kleber Souza ","Message-ID":"<0d0a6c13-e188-f0fa-c51a-cf5cd885af13@canonical.com>","Date":"Wed, 6 Sep 2017 17:53:57 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170906155115.24400-2-juerg.haefliger@canonical.com>","Content-Language":"en-US","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1764230,"web_url":"http://patchwork.ozlabs.org/comment/1764230/","msgid":"<20170906161741.cjknrnaytiea5b4f@calabresa>","list_archive_url":null,"date":"2017-09-06T16:17:42","subject":"ACK: [trusty CVE-2016-7097 v2 1/1] posix_acl: Clear SGID bit when\n\tsetting file permissions","submitter":{"id":70574,"url":"http://patchwork.ozlabs.org/api/people/70574/","name":"Thadeu Lima de Souza Cascardo","email":"cascardo@canonical.com"},"content":"Acked-by: Thadeu Lima de Souza Cascardo ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnTJd46zLz9s7F;\n\tThu, 7 Sep 2017 02:17:53 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpd1R-00061z-Fm; Wed, 06 Sep 2017 16:17:49 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpd1P-00061m-9z\n\tfor kernel-team@lists.ubuntu.com; Wed, 06 Sep 2017 16:17:47 +0000","from 1.general.cascardo.us.vpn ([10.172.70.58] helo=calabresa)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpd1O-0002St-IE; Wed, 06 Sep 2017 16:17:47 +0000"],"Date":"Wed, 6 Sep 2017 13:17:42 -0300","From":"Thadeu Lima de Souza Cascardo ","To":"Juerg Haefliger ","Subject":"ACK: [trusty CVE-2016-7097 v2 1/1] posix_acl: Clear SGID bit when\n\tsetting file permissions","Message-ID":"<20170906161741.cjknrnaytiea5b4f@calabresa>","References":"<20170906085453.22382-1-juerg.haefliger@canonical.com>\n\t<20170906155115.24400-1-juerg.haefliger@canonical.com>\n\t<20170906155115.24400-2-juerg.haefliger@canonical.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170906155115.24400-2-juerg.haefliger@canonical.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel-team@lists.ubuntu.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1764235,"web_url":"http://patchwork.ozlabs.org/comment/1764235/","msgid":"<858d17c6-8888-0cf5-d352-d3e3ac147e07@canonical.com>","list_archive_url":null,"date":"2017-09-06T16:19:52","subject":"APPLIED: [trusty CVE-2016-7097 v2 1/1] posix_acl: Clear SGID bit\n\twhen setting file permissions","submitter":{"id":71419,"url":"http://patchwork.ozlabs.org/api/people/71419/","name":"Kleber Sacilotto de Souza","email":"kleber.souza@canonical.com"},"content":"Applied to trusty/master-next branch. Thanks.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnTM31vy9z9s7c;\n\tThu, 7 Sep 2017 02:19:59 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpd3U-0006CA-92; Wed, 06 Sep 2017 16:19:56 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpd3T-0006C3-9J\n\tfor kernel-team@lists.ubuntu.com; Wed, 06 Sep 2017 16:19:55 +0000","from mail-wr0-f198.google.com ([209.85.128.198])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpd3T-0002VL-24\n\tfor kernel-team@lists.ubuntu.com; Wed, 06 Sep 2017 16:19:55 +0000","by mail-wr0-f198.google.com with SMTP id b9so7984431wra.3\n\tfor ;\n\tWed, 06 Sep 2017 09:19:55 -0700 (PDT)","from [192.168.0.8] (ip5f5bd015.dynamic.kabel-deutschland.de.\n\t[95.91.208.21]) by smtp.gmail.com with ESMTPSA id\n\tw12sm1526691edb.11.2017.09.06.09.19.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 06 Sep 2017 09:19:53 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=+gEGoJyqD03JW2xAT1GWEuKon3IBpN8wxoVyrjnm60k=;\n\tb=Mdh2X+bz2Ktdqalpwf89b31sjIj/Y0rdIuE/BSNzPaN4n9kquJe6Huj+fknL7mVTIx\n\t2zll9UZmfDIjmfnf5xC7joTJ+cCKGocpFKbQbB8LzG3XEvj7/ZO2qjY5gwqK2Yngrhg8\n\tbFBvX4XJht13S9suokciMNvzoq+arAPPFEApGPNgI9dymoTeCjAUh6dxIXhfREh3xKa0\n\t6SppJBgWyqnO1nuB+GroY2igERfsyWx0p61rcbf4J0Wr7qsGuxx2Bg7a+aApbDmYpppp\n\tVhg/r+qQQTaCHBhkdYUKjGuQs8Us3HIyFEhJbIueQQ5iBdVOcr2gkwVCf93HtCFhDig9\n\tNG8Q==","X-Gm-Message-State":"AHPjjUjbReevyt/DzzvEMKURgIZk/XajRMQU7tEj4ld6yIjJ90ipQIHy\n\t9jSysA0J6UFpsw/bDUsRUERUnB9BST2LVEUPVMFfZ6BL9WuNC3NDv7EtQ4HZbRsDRvcoZl5LbaN\n\tyt+LeDy1agJijKJQaANb309iIrBvaYlKg","X-Received":["by 10.80.195.206 with SMTP id i14mr209844edf.272.1504714794379; \n\tWed, 06 Sep 2017 09:19:54 -0700 (PDT)","by 10.80.195.206 with SMTP id i14mr209836edf.272.1504714794171; \n\tWed, 06 Sep 2017 09:19:54 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb4sSNRN+xHzYfI4XqXmLyk6uk2KfsQPseFWFtZyxlz/w0M9OGWq0OyipaAjl4AL7Cawne36AA==","Subject":"APPLIED: [trusty CVE-2016-7097 v2 1/1] posix_acl: Clear SGID bit\n\twhen setting file permissions","To":"Juerg Haefliger ,\n\tkernel-team@lists.ubuntu.com","References":"<20170906085453.22382-1-juerg.haefliger@canonical.com>\n\t<20170906155115.24400-1-juerg.haefliger@canonical.com>\n\t<20170906155115.24400-2-juerg.haefliger@canonical.com>","From":"Kleber Souza ","Message-ID":"<858d17c6-8888-0cf5-d352-d3e3ac147e07@canonical.com>","Date":"Wed, 6 Sep 2017 18:19:52 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170906155115.24400-2-juerg.haefliger@canonical.com>","Content-Language":"en-US","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]