[{"id":1765260,"web_url":"http://patchwork.ozlabs.org/comment/1765260/","msgid":"<20170908112549.GA12917@altlinux.org>","list_archive_url":null,"date":"2017-09-08T11:25:49","subject":"Re: Add fcntl sealing interfaces from Linux 3.17 to\n\tbits/fcntl-linux.h","submitter":{"id":16038,"url":"http://patchwork.ozlabs.org/api/people/16038/","name":"Dmitry V. Levin","email":"ldv@altlinux.org"},"content":"On Wed, Sep 06, 2017 at 03:30:47PM +0000, Joseph Myers wrote:\n> While reviewing Linux 4.13 for glibc header changes needed, I noticed\n> that bits/fcntl-linux.h was missing F_ADD_SEALS etc. from Linux 3.17.\n> \n> I didn't find any discussion indicating this omission is deliberate.\n> Now, these interfaces can only be used with file descriptors created\n> with memfd_create, and we don't have a memfd_create wrapper in glibc\n> (a patch was submitted in October 2014, albeit without documentation /\n> tests, and discussions continued over the next few months, but without\n> consensus on whether to add the interface - and we still lack any\n> general consensus on syscall wrappers), but I don't think that's a\n> reason to exclude the constants from bits/fcntl-linux.h (especially as\n> the header does not look compatible with simultaneously including\n> linux/fcntl.h).\n> \n> (Some of those 2014/2015 discussions raised concerns about difficulty\n> using the memfd_create / sealing interface, but those seem to me more\n> like a question of whether it should be part of the OS-independent GNU\n> API - in my view, even fairly specialized syscalls ought to have\n> wrappers added to glibc if not obsolescent, but there may be cases\n> where we only want to include them in the Linux-specific API and\n> anything in the OS-independent GNU API should be different - rather\n> than being relevant to whether constants for use with fcntl should\n> appear in headers.)\n> \n> 2017-09-06 Joseph Myers \n> \n> \t* sysdeps/unix/sysv/linux/bits/fcntl-linux.h [__USE_GNU]\n> \t(F_ADD_SEALS): New macro.\n> \t[__USE_GNU] (F_GET_SEALS): Likewise.\n> \t[__USE_GNU] (F_SEAL_SEAL): Likewise.\n> \t[__USE_GNU] (F_SEAL_SHRINK): Likewise.\n> \t[__USE_GNU] (F_SEAL_GROW): Likewise.\n> \t[__USE_GNU] (F_SEAL_WRITE): Likewise.\n\nI think the change itself is OK.\n\nWith regards to the changelog entry formatting,\nI wonder why a more compact form is not used here, e.g.\n\n\t* sysdeps/unix/sysv/linux/bits/fcntl-linux.h [__USE_GNU] (F_ADD_SEALS,\n\tF_GET_SEALS, F_SEAL_SEAL, F_SEAL_SHRINK, F_SEAL_GROW, F_SEAL_WRITE):\n\tNew macros.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84378-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"fjas/T5m\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpZkx1k4Dz9s83\n\tfor ;\n\tFri, 8 Sep 2017 21:26:01 +1000 (AEST)","(qmail 23108 invoked by alias); 8 Sep 2017 11:25:55 -0000","(qmail 23095 invoked by uid 89); 8 Sep 2017 11:25:54 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:subject:message-id:references\n\t:mime-version:content-type:in-reply-to; q=dns; s=default; b=vS3g\n\tLWuJOqgV+vDR334BfVOO/n3KMLM2jny6A5hTEi0RTnn5/sPs8c+c/BWqIbanoIN9\n\tMxTZJQEJfkHhL7K8YKklUefEIU3ynCT2fa93BpXfAcSfDenlM93g+5THi4OcPQnq\n\tJm92RHNrYodDojh3lHGMBwelesWABPStDw6ypL8=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:subject:message-id:references\n\t:mime-version:content-type:in-reply-to; s=default; bh=nM6LamkUWA\n\tloE9H9MEJLuoAYY6w=; b=fjas/T5mYpdJdoej1SSnN0+Td0jWXAp7wDd7lWrnlL\n\thWT+PN5mq2/TXM0JJd5S0xIbe2t9hCPZnWIlHQKJAqKVaDvlyvyocmjtyovo3IWN\n\tiZLcgmeelQiLEwS0Lr7JswQb73mYsNwfjUUAIJRYBCX4/Aj+nwn616A9DMdrfQXv\n\tQ=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.3 required=5.0 tests=AWL, BAYES_00,\n\tRP_MATCHES_RCVD, SPF_PASS,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=H*c:application","X-HELO":"vmicros1.altlinux.org","Date":"Fri, 8 Sep 2017 14:25:49 +0300","From":"\"Dmitry V. Levin\" ","To":"libc-alpha@sourceware.org","Subject":"Re: Add fcntl sealing interfaces from Linux 3.17 to\n\tbits/fcntl-linux.h","Message-ID":"<20170908112549.GA12917@altlinux.org>","Mail-Followup-To":"libc-alpha@sourceware.org","References":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"sm4nu43k4a2Rpi4c\"","Content-Disposition":"inline","In-Reply-To":""}},{"id":1765486,"web_url":"http://patchwork.ozlabs.org/comment/1765486/","msgid":"","list_archive_url":null,"date":"2017-09-08T16:16:05","subject":"Re: Add fcntl sealing interfaces from Linux 3.17 to\n\tbits/fcntl-linux.h","submitter":{"id":4349,"url":"http://patchwork.ozlabs.org/api/people/4349/","name":"Joseph Myers","email":"joseph@codesourcery.com"},"content":"On Fri, 8 Sep 2017, Dmitry V. Levin wrote:\n\n> With regards to the changelog entry formatting,\n> I wonder why a more compact form is not used here, e.g.\n> \n> \t* sysdeps/unix/sysv/linux/bits/fcntl-linux.h [__USE_GNU] (F_ADD_SEALS,\n> \tF_GET_SEALS, F_SEAL_SEAL, F_SEAL_SHRINK, F_SEAL_GROW, F_SEAL_WRITE):\n> \tNew macros.\n\nglibc tends to use the \"Likewise.\" style more than is required by the GNU \nCoding Standards; I'm not sure why. (The above sort of list of symbols \nshould close parentheses at the end of each line and then reopen at the \nstart of the next line when continuing the list.)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84385-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"vi8xdOKl\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpj9z2FH2z9s7p\n\tfor ;\n\tSat, 9 Sep 2017 02:16:23 +1000 (AEST)","(qmail 104294 invoked by alias); 8 Sep 2017 16:16:17 -0000","(qmail 104265 invoked by uid 89); 8 Sep 2017 16:16:15 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; q=dns; s=default; b=ldRfd\n\thdNHmu/zWW31SWNs+btnnZpaKPx0IA4LceMHQ9bPIGnZLz792XSBjgngzxt3XeZH\n\tNOyDZrM68k+kETvf8bLxKslPIYu6KNXTZMmsF5KymF97B1qEuuVRDlmBqGG5A/KM\n\tYk1Ru9jR/ngr2Rgc7kpYks/zfkzgmT9tLkKHDQ=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; s=default; bh=LECGNEmyquA\n\tsH9JnozCpwXGTspI=; b=vi8xdOKlRkdp6zjPJQrLDfrPZ2FsQZXoKkom5R6vjwv\n\tUG2UpenCW+Qe9kbnWwnGTFB7wnqQEvhgxBOdHW920NuwP1Q5rpcL+8aYhQvx6T0L\n\toAee55uaOST2KjXCoOKTqfUnlXcKsZBDgUaUkTJW9OtEkfi4riL+UB5CWiqmZzz8\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.0 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE, SPF_PASS,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=reopen","X-HELO":"relay1.mentorg.com","Date":"Fri, 8 Sep 2017 16:16:05 +0000","From":"Joseph Myers ","To":"\"Dmitry V. Levin\" ","CC":"","Subject":"Re: Add fcntl sealing interfaces from Linux 3.17 to\n\tbits/fcntl-linux.h","In-Reply-To":"<20170908112549.GA12917@altlinux.org>","Message-ID":"","References":"\n\t<20170908112549.GA12917@altlinux.org>","User-Agent":"Alpine 2.20 (DEB 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"US-ASCII\"","X-ClientProxiedBy":"svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To\n\tsvr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)"}},{"id":1765522,"web_url":"http://patchwork.ozlabs.org/comment/1765522/","msgid":"<93814ac5-f4b8-251c-2c21-d93dcf00cf3e@cs.ucla.edu>","list_archive_url":null,"date":"2017-09-08T17:00:31","subject":"Re: Add fcntl sealing interfaces from Linux 3.17 to\n\tbits/fcntl-linux.h","submitter":{"id":4434,"url":"http://patchwork.ozlabs.org/api/people/4434/","name":"Paul Eggert","email":"eggert@CS.UCLA.EDU"},"content":"On 09/08/2017 09:16 AM, Joseph Myers wrote:\n> glibc tends to use the \"Likewise.\" style more than is required by the GNU\n> Coding Standards; I'm not sure why.\n\nIt's inertia. As I recall the GNU Coding Standards formerly recommended \n\"Likewise\", and they still have a circa-1998 example using it \n(unnecessarily, I might add). This was before they extended ChangeLog \nformat to make \"Likewise\" largely unnecessary.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84390-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"dYFU8gTE\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpk9552Mzz9ryv\n\tfor ;\n\tSat, 9 Sep 2017 03:00:41 +1000 (AEST)","(qmail 109132 invoked by alias); 8 Sep 2017 17:00:35 -0000","(qmail 109102 invoked by uid 89); 8 Sep 2017 17:00:34 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=QtrvEFSHQIMsDngl\n\tYtFmp+Mckzx1ipmG8HA0FCSHAQU2gZnIxCuuVpKP58lGWQGlGjO03mkIshkbd4Zx\n\tYQ68dIJ8yoZpiV2SwZEx+ZzFa6fZ/UTYTmuspGveECq0ucvECNElnOdii5vIM2ZJ\n\t7Fxtn2lwAUn4oHubsYOXDJzOE7U=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=GGw2ZboNdyA0RHuhudpY58\n\tqaGD4=; b=dYFU8gTE2zOfYWM06L6dvq+4fDoNSZz0wVlPUCcUZlhAXIo670WU8v\n\tXg813dQtKzR5rgr9axQsEzvqtKxcO0fowv92MIAl1EKc5My4zWUMXBrhax6SsiFE\n\tlDgLGzAx83jQ0lgikj07Nnq6ROXRcbob8H/wvaCiDwtdBrc6g87S8=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.1 required=5.0 tests=AWL, BAYES_00,\n\tRP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"zimbra.cs.ucla.edu","Subject":"Re: Add fcntl sealing interfaces from Linux 3.17 to\n\tbits/fcntl-linux.h","To":"Joseph Myers , \"Dmitry V. Levin\"\n\t","Cc":"libc-alpha@sourceware.org","References":"\n\t<20170908112549.GA12917@altlinux.org>\n\t","From":"Paul Eggert ","Message-ID":"<93814ac5-f4b8-251c-2c21-d93dcf00cf3e@cs.ucla.edu>","Date":"Fri, 8 Sep 2017 10:00:31 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit"}}]