[{"id":1764414,"web_url":"http://patchwork.ozlabs.org/comment/1764414/","msgid":"<20170906222448.GA21183@flamenco>","list_archive_url":null,"date":"2017-09-06T22:24:48","subject":"Re: [Qemu-devel] [PATCH] trace: Immediately apply per-vCPU state\n\tchanges if a vCPU is being created","submitter":{"id":65690,"url":"http://patchwork.ozlabs.org/api/people/65690/","name":"Emilio Cota","email":"cota@braap.org"},"content":"On Wed, Sep 06, 2017 at 18:27:10 +0300, Lluís Vilanova wrote:\n> Right now, function trace_event_set_vcpu_state_dynamic() asynchronously enables\n> events in the case a vCPU is executing TCG code. If the vCPU is being created\n> this makes some events like \"guest_cpu_enter\" to not be traced.\n> \n> Signed-off-by: Lluís Vilanova \n> ---\n> trace/control-target.c | 19 ++++++++++++-------\n> 1 file changed, 12 insertions(+), 7 deletions(-)\n> \n> diff --git a/trace/control-target.c b/trace/control-target.c\n> index 4e36101997..0056da6a46 100644\n> --- a/trace/control-target.c\n> +++ b/trace/control-target.c\n> @@ -88,13 +88,18 @@ void trace_event_set_vcpu_state_dynamic(CPUState *vcpu,\n> clear_bit(vcpu_id, vcpu->trace_dstate_delayed);\n> (*ev->dstate)--;\n> }\n> - /*\n> - * Delay changes until next TB; we want all TBs to be built from a\n> - * single set of dstate values to ensure consistency of generated\n> - * tracing code.\n> - */\n> - async_run_on_cpu(vcpu, trace_event_synchronize_vcpu_state_dynamic,\n> - RUN_ON_CPU_NULL);\n> + if (vcpu->created) {\n> + /*\n> + * Delay changes until next TB; we want all TBs to be built from a\n> + * single set of dstate values to ensure consistency of generated\n> + * tracing code.\n> + */\n> + async_run_on_cpu(vcpu, trace_event_synchronize_vcpu_state_dynamic,\n> + RUN_ON_CPU_NULL);\n> + } else {\n> + run_on_cpu_data ignored;\n> + trace_event_synchronize_vcpu_state_dynamic(vcpu, ignored);\n\nI'd prefer RUN_ON_CPU_NULL here instead of the ignored param.\nOther than that,\n\nReviewed-by: Emilio G. Cota \n\n\t\tE.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=braap.org header.i=@braap.org\n\theader.b=\"WlrXex+U\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"nTmt2XCx\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xndSm0by0z9s82\n\tfor ;\n\tThu, 7 Sep 2017 08:25:24 +1000 (AEST)","from localhost ([::1]:37971 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpil7-000332-GJ\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 18:25:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49261)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpikh-00032i-5b\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 18:24:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpikc-0002fb-Ds\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 18:24:55 -0400","from out1-smtp.messagingengine.com ([66.111.4.25]:41671)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpikc-0002fI-7B\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 18:24:50 -0400","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id A9891212BB;\n\tWed, 6 Sep 2017 18:24:48 -0400 (EDT)","from frontend1 ([10.202.2.160])\n\tby compute4.internal (MEProxy); Wed, 06 Sep 2017 18:24:48 -0400","from localhost (flamenco.cs.columbia.edu [128.59.20.216])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 5A6EE7E101;\n\tWed, 6 Sep 2017 18:24:48 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=S8vYqoQGIQhVps8\n\tkkYgsQN5UofgHjSYGRkl+ztzRSkY=; b=WlrXex+UVEkF8ggtAb0+oTAJUdhzse0\n\tPgIe2AQk8Sd1Xel2j1iC4pAhTrW6J29pCLLzJaPJp0yPUnG71eJeeJLkRs5vksRn\n\tDH2+MIaMMu9IDIH3godJt+F12gpbasITAjRgmv8gtcOKrbCAlsd17/KChrC/B12m\n\tQx+C6jlF4LXs=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=\n\tfm1; bh=S8vYqoQGIQhVps8kkYgsQN5UofgHjSYGRkl+ztzRSkY=; b=nTmt2XCx\n\t1yb/3BPa7IieLai/aeYOzlyBWz4cEf0Xf3FF1W0QOL0weHcPqpjX/S5/f58xOdRA\n\tcQObpYrgR9dbrZkThCqKtdktkJH89w5HlU0JvhtwbdGLSwjZyhS7upLetuNI93Rn\n\tDQmjUxmlhUMMzrCPo3PArhO+NVajBSxLpIc9IY9yJ8Hty4dVBCgi2T/6LOmpShQ6\n\tjE2kym1WoPyZzywWmVag4BlXDDJuqKu/cPD+qqMTZm3d4gzGESWpdOsz4oc819oL\n\t9K5+r6Pu5Wj0jC536KQ0H6lSnb4kA6ulYgjDdRhLpdjVacVWTrzBk5hG1V0Z6xKC\n\tY3oYDhVxENL+/A=="],"X-ME-Sender":"","X-Sasl-enc":"PXneN0kKXjeK4R9YiUlu/dANRcboeTTHDK5c+X11CtUm 1504736688","Date":"Wed, 6 Sep 2017 18:24:48 -0400","From":"\"Emilio G. Cota\" ","To":"=?iso-8859-1?q?Llu=EDs?= Vilanova ","Message-ID":"<20170906222448.GA21183@flamenco>","References":"<150471163020.18882.9386672218918089445.stgit@frigg.lan>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<150471163020.18882.9386672218918089445.stgit@frigg.lan>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"66.111.4.25","Subject":"Re: [Qemu-devel] [PATCH] trace: Immediately apply per-vCPU state\n\tchanges if a vCPU is being created","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"stefanha@gmail.com, qemu-devel@nongnu.org,\n\tStefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]