[{"id":1764692,"web_url":"http://patchwork.ozlabs.org/comment/1764692/","msgid":"","list_archive_url":null,"date":"2017-09-07T12:26:21","subject":"Re: [Qemu-devel] [PULL 0/5] NBD patches for 2017-09-06","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 6 September 2017 at 16:21, Eric Blake wrote:\n> The following changes since commit b07d1c2f5607489d4d4a6a65ce36a3e896ac065e:\n>\n> Revert \"kvm: use DIV_ROUND_UP\" (2017-09-05 18:55:40 +0100)\n>\n> are available in the git repository at:\n>\n> git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-09-06\n>\n> for you to fetch changes up to 030fa7f6f950f5c8963f1dee8e6bb7387ed86a99:\n>\n> nbd: Use new qio_channel_*_all() functions (2017-09-06 10:11:54 -0500)\n>\n> ----------------------------------------------------------------\n> nbd patches for 2017-09-06\n>\n> - Daniel P. Berrange: [0/2] Fix / skip recent iotests with LUKS driver\n> - Eric Blake: [0/3] nbd: Use common read/write-all qio functions\n>\n> ----------------------------------------------------------------\n> Daniel P. Berrange (2):\n> iotests: rewrite 192 to use _launch_qemu to fix LUKS support\n> iotests: blacklist 194 with the luks driver\n>\n> Eric Blake (3):\n> io: Yield rather than wait when already in coroutine\n> io: Add new qio_channel_read{, v}_all_eof functions\n> nbd: Use new qio_channel_*_all() functions\n\nI get an error in test-aio-multithread (clang, linux, x86-64):\n GTESTER tests/test-aio-multithread\n**\nERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-aio-multithread.c:368:test_multi_fair_mutex:\nassertion failed (counter == atomic_counter): (532693 == 532694)\nGTester: last random seed: R02Sa68ef1eb4822359eb869642ff26180df\n\nSeems to be very intermittent, though -- I haven't been able\nto reproduce it, even with loading the box up with a\ncompile job at the same time.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"UXbNIwG1\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp08J0PjRz9s81\n\tfor ;\n\tThu, 7 Sep 2017 22:27:28 +1000 (AEST)","from localhost ([::1]:40272 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpvu2-0002hO-4l\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 08:27:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36286)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpvtR-0002dh-Ql\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:26:54 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpvtM-0007Ka-TV\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:26:49 -0400","from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:34281)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpvtM-0007Jw-Mw\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:26:44 -0400","by mail-wm0-x229.google.com with SMTP id 137so33565006wmj.1\n\tfor ; Thu, 07 Sep 2017 05:26:43 -0700 (PDT)","by 10.223.159.68 with HTTP; Thu, 7 Sep 2017 05:26:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=GDPLny4h1D/0ClHePVAtyaHC0x5uhSPuWYmZ1jONysw=;\n\tb=UXbNIwG1b/Yx+hADSwN+UY0nUEFzQmbqF9XjNVIsy9B1+MHbqOSOKtziXekcASNkht\n\tHq96W5JJMcgboLfgRgd0mQeGRL6jIp49rNbFPHjpJFoSDpgwNvSQN4Z8ZKiuMjgIqdcR\n\t3PRlQKn24VsNh7zEgxtuL6vaufMaU0LQuDMQg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=GDPLny4h1D/0ClHePVAtyaHC0x5uhSPuWYmZ1jONysw=;\n\tb=AqPkmFDRiekpDIWLVP4usm9bk91ox/CUx++Xq4u6Z4vHO2ixR+GDJzoBHhoclLFGHV\n\tIKPte6nXfLbxxtc9CJYyL/z+RLvI1XWrMV4idvTFLmtrsN0G4Jlgac9nq+HHAmI4Zsa5\n\tgHqA+Ztmme/B9exbiSbLKcCWjlgg+PLqhcd4flfm5fpniy/W76NqIFyKQEHO+wuXcz2e\n\tnuTlACOS1Y1GVgwq0UbHkOzPSBtsiqdNzEx8YnnugOgfZE1QxUWGwd+2/1kHIV0Tqh/T\n\tHlDBH/TJTFXWk+GSdqtGsw1Z6gQKd35KDTthQIEp+DAskVoSarIw3MoiPWffJ93+GKgD\n\tfmbQ==","X-Gm-Message-State":"AHPjjUi41B6+IC8Cx2N90YpsyYwIekHIM+W0zFVJqmP5I45X4jMsnaSi\n\thmsRq+CIDzFwvmu24zXRbLHhZiZUAMKO","X-Google-Smtp-Source":"ADKCNb69IVYb2xGQICRKLF6yd8zyOwX7oznatmi9t4oXStW6AF7/7LwNCDQNnu6vVa8DQKRmjYaFz8ctS7lO7NNSiU0=","X-Received":"by 10.28.142.81 with SMTP id q78mr584512wmd.136.1504787202217;\n\tThu, 07 Sep 2017 05:26:42 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170906152111.16958-1-eblake@redhat.com>","References":"<20170906152111.16958-1-eblake@redhat.com>","From":"Peter Maydell ","Date":"Thu, 7 Sep 2017 13:26:21 +0100","Message-ID":"","To":"Eric Blake ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::229","Subject":"Re: [Qemu-devel] [PULL 0/5] NBD patches for 2017-09-06","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764739,"web_url":"http://patchwork.ozlabs.org/comment/1764739/","msgid":"<20170907135332.GO30609@redhat.com>","list_archive_url":null,"date":"2017-09-07T13:53:32","subject":"Re: [Qemu-devel] [PULL 0/5] NBD patches for 2017-09-06","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Thu, Sep 07, 2017 at 08:48:15AM -0500, Eric Blake wrote:\n> On 09/07/2017 07:26 AM, Peter Maydell wrote:\n> > On 6 September 2017 at 16:21, Eric Blake wrote:\n> >> The following changes since commit b07d1c2f5607489d4d4a6a65ce36a3e896ac065e:\n> >>\n> >> Revert \"kvm: use DIV_ROUND_UP\" (2017-09-05 18:55:40 +0100)\n> >>\n> >> are available in the git repository at:\n> >>\n> >> git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-09-06\n> >>\n> >> for you to fetch changes up to 030fa7f6f950f5c8963f1dee8e6bb7387ed86a99:\n> >>\n> >> nbd: Use new qio_channel_*_all() functions (2017-09-06 10:11:54 -0500)\n> >>\n> \n> > I get an error in test-aio-multithread (clang, linux, x86-64):\n> > GTESTER tests/test-aio-multithread\n> > **\n> > ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-aio-multithread.c:368:test_multi_fair_mutex:\n> > assertion failed (counter == atomic_counter): (532693 == 532694)\n> > GTester: last random seed: R02Sa68ef1eb4822359eb869642ff26180df\n> \n> I wonder if that is a rare but pre-existing bug, as I don't see any use\n> of qio_channel in test-aio-multithread, and therefore no obvious way\n> that this series would be the cause of the intermittent failure.\n\nAgreed. Even if there was use of QIOChannel, there is certainly no use\nof the qio_channel_read|write_all functions that are being changed\nin this series, since they've only just been added to QEMU and are only\nused in the test suite and your final NBD patch here. So I think this\nmust be a pre-existing race condition.\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp28k5SBlz9s8J\n\tfor ;\n\tThu, 7 Sep 2017 23:57:58 +1000 (AEST)","from localhost ([::1]:40617 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpxJc-0001y2-Ro\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 09:57:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41762)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpxFb-0007gJ-Pi\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:53:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpxFS-0001KT-Az\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:53:47 -0400","from mx1.redhat.com ([209.132.183.28]:44624)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpxFS-0001Ji-4U\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:53:38 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2012DC0587ED;\n\tThu, 7 Sep 2017 13:53:37 +0000 (UTC)","from redhat.com (unknown [10.33.36.82])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id AC03A6062F;\n\tThu, 7 Sep 2017 13:53:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2012DC0587ED","Date":"Thu, 7 Sep 2017 14:53:32 +0100","From":"\"Daniel P. Berrange\" ","To":"Eric Blake ","Message-ID":"<20170907135332.GO30609@redhat.com>","References":"<20170906152111.16958-1-eblake@redhat.com>\n\t\n\t<5ba61e49-3b84-46a4-2978-d42d3457f21b@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<5ba61e49-3b84-46a4-2978-d42d3457f21b@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tThu, 07 Sep 2017 13:53:37 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PULL 0/5] NBD patches for 2017-09-06","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"Peter Maydell ,\n\tQEMU Developers ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764740,"web_url":"http://patchwork.ozlabs.org/comment/1764740/","msgid":"<5ba61e49-3b84-46a4-2978-d42d3457f21b@redhat.com>","list_archive_url":null,"date":"2017-09-07T13:48:15","subject":"Re: [Qemu-devel] [PULL 0/5] NBD patches for 2017-09-06","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/07/2017 07:26 AM, Peter Maydell wrote:\n> On 6 September 2017 at 16:21, Eric Blake wrote:\n>> The following changes since commit b07d1c2f5607489d4d4a6a65ce36a3e896ac065e:\n>>\n>> Revert \"kvm: use DIV_ROUND_UP\" (2017-09-05 18:55:40 +0100)\n>>\n>> are available in the git repository at:\n>>\n>> git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-09-06\n>>\n>> for you to fetch changes up to 030fa7f6f950f5c8963f1dee8e6bb7387ed86a99:\n>>\n>> nbd: Use new qio_channel_*_all() functions (2017-09-06 10:11:54 -0500)\n>>\n\n> I get an error in test-aio-multithread (clang, linux, x86-64):\n> GTESTER tests/test-aio-multithread\n> **\n> ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-aio-multithread.c:368:test_multi_fair_mutex:\n> assertion failed (counter == atomic_counter): (532693 == 532694)\n> GTester: last random seed: R02Sa68ef1eb4822359eb869642ff26180df\n\nI wonder if that is a rare but pre-existing bug, as I don't see any use\nof qio_channel in test-aio-multithread, and therefore no obvious way\nthat this series would be the cause of the intermittent failure.\n\n> \n> Seems to be very intermittent, though -- I haven't been able\n> to reproduce it, even with loading the box up with a\n> compile job at the same time.\n\nPaolo, this appears to be your area of expertise.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp28m679Wz9s8J\n\tfor ;\n\tThu, 7 Sep 2017 23:58:00 +1000 (AEST)","from localhost ([::1]:40618 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpxJf-0001zn-0l\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 09:57:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39356)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpxAP-0002G3-On\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:48:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpxAL-0004hN-0X\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:48:25 -0400","from mx1.redhat.com ([209.132.183.28]:59036)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpxAK-0004gX-OH\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:48:20 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BA99D356CE;\n\tThu, 7 Sep 2017 13:48:19 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id ED78960603;\n\tThu, 7 Sep 2017 13:48:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BA99D356CE","To":"Peter Maydell ","References":"<20170906152111.16958-1-eblake@redhat.com>\n\t","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<5ba61e49-3b84-46a4-2978-d42d3457f21b@redhat.com>","Date":"Thu, 7 Sep 2017 08:48:15 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"aBKHrlulvwoUrTFnShvHTCKIo7p4QL8mo\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 07 Sep 2017 13:48:19 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PULL 0/5] NBD patches for 2017-09-06","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764866,"web_url":"http://patchwork.ozlabs.org/comment/1764866/","msgid":"","list_archive_url":null,"date":"2017-09-07T17:56:10","subject":"Re: [Qemu-devel] [PULL 0/5] NBD patches for 2017-09-06","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 7 September 2017 at 14:53, Daniel P. Berrange wrote:\n> On Thu, Sep 07, 2017 at 08:48:15AM -0500, Eric Blake wrote:\n>> On 09/07/2017 07:26 AM, Peter Maydell wrote:\n>> > On 6 September 2017 at 16:21, Eric Blake wrote:\n>> >> The following changes since commit b07d1c2f5607489d4d4a6a65ce36a3e896ac065e:\n>> >>\n>> >> Revert \"kvm: use DIV_ROUND_UP\" (2017-09-05 18:55:40 +0100)\n>> >>\n>> >> are available in the git repository at:\n>> >>\n>> >> git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-09-06\n>> >>\n>> >> for you to fetch changes up to 030fa7f6f950f5c8963f1dee8e6bb7387ed86a99:\n>> >>\n>> >> nbd: Use new qio_channel_*_all() functions (2017-09-06 10:11:54 -0500)\n>> >>\n>>\n>> > I get an error in test-aio-multithread (clang, linux, x86-64):\n>> > GTESTER tests/test-aio-multithread\n>> > **\n>> > ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-aio-multithread.c:368:test_multi_fair_mutex:\n>> > assertion failed (counter == atomic_counter): (532693 == 532694)\n>> > GTester: last random seed: R02Sa68ef1eb4822359eb869642ff26180df\n>>\n>> I wonder if that is a rare but pre-existing bug, as I don't see any use\n>> of qio_channel in test-aio-multithread, and therefore no obvious way\n>> that this series would be the cause of the intermittent failure.\n>\n> Agreed. Even if there was use of QIOChannel, there is certainly no use\n> of the qio_channel_read|write_all functions that are being changed\n> in this series, since they've only just been added to QEMU and are only\n> used in the test suite and your final NBD patch here. So I think this\n> must be a pre-existing race condition.\n\nOK. I've applied the pullreq.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"a7nQvR0k\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp7Sx1hKnz9t2f\n\tfor ;\n\tFri, 8 Sep 2017 03:57:21 +1000 (AEST)","from localhost ([::1]:41569 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dq13H-0000aR-Ak\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 13:57:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60428)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dq12b-0000R3-Ed\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:56:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dq12W-0001If-Ma\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:56:37 -0400","from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]:36137)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dq12W-0001IG-Fi\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:56:32 -0400","by mail-wr0-x236.google.com with SMTP id o42so791982wrb.3\n\tfor ; Thu, 07 Sep 2017 10:56:32 -0700 (PDT)","by 10.223.159.68 with HTTP; Thu, 7 Sep 2017 10:56:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=ufBsN1wYF2frf2EOr9G96O79MK3wAKwF4v4nNMo5ya8=;\n\tb=a7nQvR0kYS0VfQFo6XNr6CyB6piQsL2NIyBl4QIWaUu/ACJ7k0GzSKcVGvmn3KB8IE\n\tOtB9M9GfE+uDCzx/uuWZATSQvHNMfsbde1GzA+HmSivYEleBOufqPEQrBWxSroZYLykf\n\tQxSDchreazUisP05CXIztwA2UghunAlV0+d9w=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ufBsN1wYF2frf2EOr9G96O79MK3wAKwF4v4nNMo5ya8=;\n\tb=BA5K15Sy+oUaz2bBGSWdc29bUubT40tJmuFOhyu+GfgfUdN49vG1oIpf17TLKbB6BA\n\txK3803EPuz2opNtFlrOJfQZW3i1m2fzNizLzrjJGb6dfho5zhhNqwxKAGRhug6zco3op\n\t49+oRTtY2NI3+2DzlvFnpenXOfBM+GI+CL31HRpsgewwzk0Deo/Js7ZELwTMjsAevzDK\n\tkexRLYK4Fm/+cNoPVvuaDMqU/TAZXWQej4w64hee9lGjoauj/jqzl3fjhTGSWwUFKW7N\n\t4HZjFZI4762pTSmvs2doTtuYsZi6udohq5KI/65uIjefYptFJMoT1fKGLZFVJ0pqkSrD\n\tFhYA==","X-Gm-Message-State":"AHPjjUiTzQmYdeMMqx0tFz6ZscljRycznzeB9THXh7pdrHowNEOH75Rb\n\tq0zwpV4m/Ur66KeCUZ0KxhexNlXvOw40","X-Google-Smtp-Source":"ADKCNb4+CYq8afHYFGLdCfO+1r4GqVzAUoTwnPjPVsUt7ac6HDIL0WY90DqOC2W/fhrzbPyCkixSUEvuMuqtx8bdVN0=","X-Received":"by 10.223.187.211 with SMTP id z19mr93509wrg.97.1504806991116;\n\tThu, 07 Sep 2017 10:56:31 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170907135332.GO30609@redhat.com>","References":"<20170906152111.16958-1-eblake@redhat.com>\n\t\n\t<5ba61e49-3b84-46a4-2978-d42d3457f21b@redhat.com>\n\t<20170907135332.GO30609@redhat.com>","From":"Peter Maydell ","Date":"Thu, 7 Sep 2017 18:56:10 +0100","Message-ID":"","To":"\"Daniel P. Berrange\" ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::236","Subject":"Re: [Qemu-devel] [PULL 0/5] NBD patches for 2017-09-06","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]