[{"id":1765052,"web_url":"http://patchwork.ozlabs.org/comment/1765052/","msgid":"<20170907.200430.192546025684691135.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-08T03:04:30","subject":"Re: [PATCH] isdn: isdnloop: fix logic error in isdnloop_sendbuf","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Arnd Bergmann \nDate: Wed, 6 Sep 2017 15:38:58 +0200\n\n> gcc-7 found an ancient bug in the loop driver, leading to a condition that\n> is always false, meaning we ignore the contents of 'card->flags' here:\n> \n> drivers/isdn/isdnloop/isdnloop.c:412:37: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context]\n> \n> This changes the braces in the expression to ensure we actually\n> compare the flag bits, rather than comparing a constant. As Joe Perches\n> pointed out, an earlier patch of mine incorrectly assumed this was a\n> false-positive warning.\n> \n> Cc: Joe Perches \n> Link: https://patchwork.kernel.org/patch/9840289/\n> Signed-off-by: Arnd Bergmann \n\nApplied, thank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpMcW4FyGz9sQl\n\tfor ;\n\tFri, 8 Sep 2017 13:04:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753937AbdIHDEc (ORCPT );\n\tThu, 7 Sep 2017 23:04:32 -0400","from shards.monkeyblade.net ([184.105.139.130]:41636 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752110AbdIHDEb (ORCPT\n\t); Thu, 7 Sep 2017 23:04:31 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id EF76E134B12A0;\n\tThu, 7 Sep 2017 20:04:30 -0700 (PDT)"],"Date":"Thu, 07 Sep 2017 20:04:30 -0700 (PDT)","Message-Id":"<20170907.200430.192546025684691135.davem@davemloft.net>","To":"arnd@arndb.de","Cc":"isdn@linux-pingi.de, joe@perches.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] isdn: isdnloop: fix logic error in isdnloop_sendbuf","From":"David Miller ","In-Reply-To":"<20170906133928.3152020-1-arnd@arndb.de>","References":"<20170906133928.3152020-1-arnd@arndb.de>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 07 Sep 2017 20:04:31 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]