[{"id":1764152,"web_url":"http://patchwork.ozlabs.org/comment/1764152/","msgid":"<1086506784.5774276.1504708288722.JavaMail.zimbra@redhat.com>","list_archive_url":null,"date":"2017-09-06T14:31:28","subject":"Re: [ovs-dev] [PATCH v4] ovn: Check for known logical switch port\n\ttypes.","submitter":{"id":67850,"url":"http://patchwork.ozlabs.org/api/people/67850/","name":"Lance Richardson","email":"lrichard@redhat.com"},"content":"> From: \"Mark Michelson\" \n> To: dev@openvswitch.org\n> Sent: Wednesday, September 6, 2017 9:38:40 AM\n> Subject: [ovs-dev] [PATCH v4] ovn: Check for known logical switch port types.\n> \n> OVN is lenient with the types of logical switch ports. Maybe too\n> lenient. This patch attempts to solve this problem on two fronts:\n> \n> 1) In ovn-nbctl, if you attempt to set the port type to an unknown\n> type, the command will not end up setting the type.\n> 2) In northd, when copying the port type from the northbound database to\n> the corresponding port-binding in the southbound database, a warning\n> will be issued if the port is of an unknown type.\n> \n> Signed-off-by: Mark Michelson \n> ---\n> v4:\n> * Fixed failing ovn-controller-vtep test that attempted to\n> set a switch port type to \"void\"\n> v3:\n> * OVN_NB_LSP_TYPES declaration is static\n> * northd will not copy unknown port types to southbound DB\n> * re-ordered port types in OVN_NB_LSP_TYPES\n> v2:\n> * Used ARRAY_SIZE to calculate length of OVN_NB_LSP_TYPES\n> v1:\n> * Initial patch\n> ---\n\nLGTM.\n\nAcked-by: Lance Richardson ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lrichard@redhat.com"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnQxy4zMsz9t4t\n\tfor ;\n\tThu, 7 Sep 2017 00:31:34 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 82C72B93;\n\tWed, 6 Sep 2017 14:31:32 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 54101B59\n\tfor ; Wed, 6 Sep 2017 14:31:31 +0000 (UTC)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id E8437447\n\tfor ; Wed, 6 Sep 2017 14:31:30 +0000 (UTC)","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F0276356DC\n\tfor ; Wed, 6 Sep 2017 14:31:29 +0000 (UTC)","from colo-mx.corp.redhat.com\n\t(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 8E0456B57C;\n\tWed, 6 Sep 2017 14:31:29 +0000 (UTC)","from zmail26.collab.prod.int.phx2.redhat.com\n\t(zmail26.collab.prod.int.phx2.redhat.com [10.5.83.33])\n\tby colo-mx.corp.redhat.com (Postfix) with ESMTP id 7F38A180884F;\n\tWed, 6 Sep 2017 14:31:29 +0000 (UTC)"],"X-Greylist":["domain auto-whitelisted by SQLgrey-1.7.6","Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 06 Sep 2017 14:31:30 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com F0276356DC","Date":"Wed, 6 Sep 2017 10:31:28 -0400 (EDT)","From":"Lance Richardson ","To":"Mark Michelson ","Message-ID":"<1086506784.5774276.1504708288722.JavaMail.zimbra@redhat.com>","In-Reply-To":"<20170906133840.17572-1-mmichels@redhat.com>","References":"<20170906133840.17572-1-mmichels@redhat.com>","MIME-Version":"1.0","X-Originating-IP":"[10.10.122.220, 10.4.195.19]","Thread-Topic":"Check for known logical switch port types.","Thread-Index":"hJtuFl1rn9yGZM0EG7ThYMmZL7zUSg==","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH v4] ovn: Check for known logical switch port\n\ttypes.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1797495,"web_url":"http://patchwork.ozlabs.org/comment/1797495/","msgid":"<20171101213236.GM27530@ovn.org>","list_archive_url":null,"date":"2017-11-01T21:32:36","subject":"Re: [ovs-dev] [PATCH v4] ovn: Check for known logical switch port\n\ttypes.","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Wed, Sep 06, 2017 at 10:31:28AM -0400, Lance Richardson wrote:\n> > From: \"Mark Michelson\" \n> > To: dev@openvswitch.org\n> > Sent: Wednesday, September 6, 2017 9:38:40 AM\n> > Subject: [ovs-dev] [PATCH v4] ovn: Check for known logical switch port types.\n> > \n> > OVN is lenient with the types of logical switch ports. Maybe too\n> > lenient. This patch attempts to solve this problem on two fronts:\n> > \n> > 1) In ovn-nbctl, if you attempt to set the port type to an unknown\n> > type, the command will not end up setting the type.\n> > 2) In northd, when copying the port type from the northbound database to\n> > the corresponding port-binding in the southbound database, a warning\n> > will be issued if the port is of an unknown type.\n> > \n> > Signed-off-by: Mark Michelson \n> > ---\n> > v4:\n> > * Fixed failing ovn-controller-vtep test that attempted to\n> > set a switch port type to \"void\"\n> > v3:\n> > * OVN_NB_LSP_TYPES declaration is static\n> > * northd will not copy unknown port types to southbound DB\n> > * re-ordered port types in OVN_NB_LSP_TYPES\n> > v2:\n> > * Used ARRAY_SIZE to calculate length of OVN_NB_LSP_TYPES\n> > v1:\n> > * Initial patch\n> > ---\n> \n> LGTM.\n> \n> Acked-by: Lance Richardson \n\nThanks Mark and Lance.\n\nI applied this to master. I changed the VLOG_WARN in ovn-northd.c to\nVLOG_WARN_RL, so that it gets rate-limited, but I otherwise left it as\nis.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yS1f80r9Lz9t6l\n\tfor ;\n\tThu, 2 Nov 2017 08:32:47 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 13D09D31;\n\tWed, 1 Nov 2017 21:32:45 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 0615CD26\n\tfor ; Wed, 1 Nov 2017 21:32:44 +0000 (UTC)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 70DE147D\n\tfor ; Wed, 1 Nov 2017 21:32:43 +0000 (UTC)","from ovn.org (unknown [208.91.3.26])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 777DF41C084;\n\tWed, 1 Nov 2017 22:32:39 +0100 (CET)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.3.26","Date":"Wed, 1 Nov 2017 14:32:36 -0700","From":"Ben Pfaff ","To":"Lance Richardson ","Message-ID":"<20171101213236.GM27530@ovn.org>","References":"<20170906133840.17572-1-mmichels@redhat.com>\n\t<1086506784.5774276.1504708288722.JavaMail.zimbra@redhat.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1086506784.5774276.1504708288722.JavaMail.zimbra@redhat.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH v4] ovn: Check for known logical switch port\n\ttypes.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]