[{"id":1764666,"web_url":"http://patchwork.ozlabs.org/comment/1764666/","msgid":"<87o9qmn3kr.fsf@kamboji.qca.qualcomm.com>","list_archive_url":null,"date":"2017-09-07T11:36:05","subject":"Re: [PATCH] ath10: mark PM functions as __maybe_unused","submitter":{"id":8605,"url":"http://patchwork.ozlabs.org/api/people/8605/","name":"Kalle Valo","email":"kvalo@qca.qualcomm.com"},"content":"Arnd Bergmann writes:\n\n> When CONFIG_PM_SLEEP is disabled, we get a compile-time\n> warning:\n>\n> drivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' defined but not used [-Werror=unused-function]\n> static int ath10k_pci_pm_resume(struct device *dev)\n> ^~~~~~~~~~~~~~~~~~~~\n> drivers/net/wireless/ath/ath10k/pci.c:3401:12: error: 'ath10k_pci_pm_suspend' defined but not used [-Werror=unused-function]\n> static int ath10k_pci_pm_suspend(struct device *dev)\n>\n> Rather than fixing the #ifdef, this just marks both functions\n> as __maybe_unused, which is a more robust way to do this.\n>\n> Fixes: 32faa3f0ee50 (\"ath10k: add the PCI PM core suspend/resume ops\")\n> Signed-off-by: Arnd Bergmann \n\nThanks. But the title should have \"ath10k:\", I'll fix that.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=qca.qualcomm.com header.i=@qca.qualcomm.com\n\theader.b=\"GunaMy7j\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnz1L56MTz9sRY\n\tfor ;\n\tThu, 7 Sep 2017 21:36:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755219AbdIGLgL (ORCPT );\n\tThu, 7 Sep 2017 07:36:11 -0400","from alexa-out.qualcomm.com ([129.46.98.28]:25249 \"EHLO\n\talexa-out-lv-02.qualcomm.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1755092AbdIGLgJ (ORCPT\n\t); Thu, 7 Sep 2017 07:36:09 -0400","from ironmsg02-r-new.qualcomm.com (HELO ironmsg02-R.qualcomm.com)\n\t([10.53.140.106])\n\tby alexa-out-lv-02.qualcomm.com with ESMTP; 07 Sep 2017 04:36:08 -0700","from nasanexm01g.na.qualcomm.com ([10.85.0.33])\n\tby ironmsg02-R.qualcomm.com with ESMTP/TLS/RC4-SHA;\n\t07 Sep 2017 04:36:08 -0700","from euamsexm01a.eu.qualcomm.com (10.251.127.40) by\n\tNASANEXM01G.na.qualcomm.com (10.85.0.33) with Microsoft SMTP Server\n\t(TLS) id 15.0.1293.2; Thu, 7 Sep 2017 04:36:06 -0700","from euamsexm01a.eu.qualcomm.com ([10.251.127.40]) by\n\teuamsexm01a.eu.qualcomm.com ([10.251.127.40]) with mapi id\n\t15.00.1293.002; Thu, 7 Sep 2017 13:36:05 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple;\n\td=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt;\n\ts=qcdkim; t=1504784169; x=1536320169;\n\th=from:to:cc:subject:date:message-id:references:\n\tin-reply-to:content-transfer-encoding:mime-version;\n\tbh=gu0GaPQBuhn1sIGRMxzuHLsAv9qCKr+EM2lKZavz/ds=;\n\tb=GunaMy7jkbDQfNmfU5AYZSEg482WcSptDP2jJ4vWbC/VuTyzgRHM6gqA\n\t+nK1RD5muNEXJmTPO8Rrbq+moyYfzQyDUqwWuZBIjpYU3DhPwt8WUpy2z\n\t+rsz069LgmpJFcIHNZI/lwj8P4Zi+jrz52EMyllsXVOHgojIA70iaPo7W k=;","X-IronPort-AV":["E=Sophos;i=\"5.42,358,1500966000\"; d=\"scan'208\";a=\"4884522\"","E=McAfee;i=\"5900,7806,8646\"; a=\"1029190679\""],"X-MGA-submission":"MDEXkvIFVyEX3doTRrrwQqRqhg6Gd7Xs5Sr3PNvAwPVqKZNyne4OqMY7x1DuPLpOlUeBDHxjlOCy9k8YQDp4KI9QFg+zmweewijNy0CwLiyBW9gjjbDPa+rnk3kEKH6ojcyXpD3FQnqQEGG4pIpbucLa","From":"Kalle Valo ","To":"Arnd Bergmann ","CC":"Colin Ian King ,\n\t\"bartosz.markowski@tieto.com\" ,\n\tGovind Singh ,\n\t\"Ryan Hsu\" ,\n\tSrinivas Kandagatla ,\n\tRajkumar Manoharan ,\n\tAshok Raj Nagarajan ,\n\tBen Greear ,\n\t\"ath10k@lists.infradead.org\" ,\n\t\"linux-wireless@vger.kernel.org\" ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Subject":"Re: [PATCH] ath10: mark PM functions as __maybe_unused","Thread-Topic":"[PATCH] ath10: mark PM functions as __maybe_unused","Thread-Index":"AQHTJw/1Nh/jAszSbUuiSym3ueAQgw==","Date":"Thu, 7 Sep 2017 11:36:05 +0000","Message-ID":"<87o9qmn3kr.fsf@kamboji.qca.qualcomm.com>","References":"<20170906125904.2588620-1-arnd@arndb.de>","In-Reply-To":"<20170906125904.2588620-1-arnd@arndb.de> (Arnd Bergmann's\n\tmessage of \"Wed, 6 Sep 2017 14:58:53 +0200\")","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-exchange-messagesentrepresentingtype":"1","x-ms-exchange-transport-fromentityheader":"Hosted","x-originating-ip":"[10.251.52.12]","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1772904,"web_url":"http://patchwork.ozlabs.org/comment/1772904/","msgid":"<87poak853p.fsf@kamboji.qca.qualcomm.com>","list_archive_url":null,"date":"2017-09-21T15:05:15","subject":"Re: [PATCH] ath10: mark PM functions as __maybe_unused","submitter":{"id":8605,"url":"http://patchwork.ozlabs.org/api/people/8605/","name":"Kalle Valo","email":"kvalo@qca.qualcomm.com"},"content":"Arnd Bergmann writes:\n\n> When CONFIG_PM_SLEEP is disabled, we get a compile-time\n> warning:\n>\n> drivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' defined but not used [-Werror=unused-function]\n> static int ath10k_pci_pm_resume(struct device *dev)\n> ^~~~~~~~~~~~~~~~~~~~\n> drivers/net/wireless/ath/ath10k/pci.c:3401:12: error: 'ath10k_pci_pm_suspend' defined but not used [-Werror=unused-function]\n> static int ath10k_pci_pm_suspend(struct device *dev)\n>\n> Rather than fixing the #ifdef, this just marks both functions\n> as __maybe_unused, which is a more robust way to do this.\n>\n> Fixes: 32faa3f0ee50 (\"ath10k: add the PCI PM core suspend/resume ops\")\n> Signed-off-by: Arnd Bergmann \n\nApplied to ath-current branch in ath.git, thanks.\n\n(Having problems with my patchwork script so sending this manually)","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=qca.qualcomm.com header.i=@qca.qualcomm.com\n\theader.b=\"jHq0zvz9\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyg0K5XSkz9t3v\n\tfor ;\n\tFri, 22 Sep 2017 01:05:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751826AbdIUPFW (ORCPT );\n\tThu, 21 Sep 2017 11:05:22 -0400","from sabertooth02.qualcomm.com ([65.197.215.38]:41588 \"EHLO\n\tsabertooth02.qualcomm.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1751793AbdIUPFU (ORCPT\n\t); Thu, 21 Sep 2017 11:05:20 -0400","from unknown (HELO Ironmsg04-L.qualcomm.com) ([10.53.140.111])\n\tby sabertooth02.qualcomm.com with ESMTP; 21 Sep 2017 08:05:19 -0700","from nasanexm01d.na.qualcomm.com ([10.85.0.84])\n\tby Ironmsg04-L.qualcomm.com with ESMTP/TLS/AES256-SHA;\n\t21 Sep 2017 08:05:18 -0700","from euamsexm01a.eu.qualcomm.com (10.251.127.40) by\n\tNASANEXM01D.na.qualcomm.com (10.85.0.84) with Microsoft SMTP Server\n\t(TLS) id 15.0.1293.2; Thu, 21 Sep 2017 08:05:17 -0700","from euamsexm01a.eu.qualcomm.com ([10.251.127.40]) by\n\teuamsexm01a.eu.qualcomm.com ([10.251.127.40]) with mapi id\n\t15.00.1293.002; Thu, 21 Sep 2017 17:05:15 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple;\n\td=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt;\n\ts=qcdkim; t=1506006320; x=1537542320;\n\th=from:to:cc:subject:date:message-id:references:\n\tin-reply-to:content-transfer-encoding:mime-version;\n\tbh=FzN8WDYs4kk455dLiEEavQcZh/s0dLzwbKfUDeUZkdA=;\n\tb=jHq0zvz99CRRMm6MdCi4lQgD+D3x/Czx0YBNkFbuPiWVOqoFaHb5RGSR\n\tCNkL3RwgD7jp9u82+yPmoCYegYPFsvxByVPqk+Vx0wK2Fe/TzgGEVodg5\n\tNUTcSEeIB4yvbtq8AAjsWxj8FIYqimE54e0u6Ei9eeL56vfl8DgqTbX9o 0=;","X-IronPort-AV":["E=Sophos;i=\"5.42,425,1500966000\"; d=\"scan'208\";a=\"116084477\"","E=McAfee;i=\"5900,7806,8660\"; a=\"1427748160\""],"X-MGA-submission":"MDGervkvrJeRIzjwOchRKGFXTB4Y3jYWMvDG+7BpTDnR38V09gg17t5UqpNR3H7XcuuOpr+M8/hNZ5lcuZX8bBbW/jYnyDrihS9TPdebVM+sZnWA3BaoHz90972JaZvmIC05eOWU3dbxfcljKmOOQLwG","From":"Kalle Valo ","To":"Arnd Bergmann ","CC":"Govind Singh ,\n\tRyan Hsu ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"linux-wireless@vger.kernel.org\" ,\n\tRajkumar Manoharan ,\n\t\"ath10k@lists.infradead.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tSrinivas Kandagatla ,\n\tColin Ian King ,\n\tBen Greear ,\n\tAshok Raj Nagarajan ,\n\t\"bartosz.markowski@tieto.com\" ","Subject":"Re: [PATCH] ath10: mark PM functions as __maybe_unused","Thread-Topic":"[PATCH] ath10: mark PM functions as __maybe_unused","Thread-Index":"AQHTJ84nQlu/+469V0SQ92Z6DQDMsA==","Date":"Thu, 21 Sep 2017 15:05:15 +0000","Message-ID":"<87poak853p.fsf@kamboji.qca.qualcomm.com>","References":"<20170906125904.2588620-1-arnd@arndb.de>","In-Reply-To":"<20170906125904.2588620-1-arnd@arndb.de> (Arnd Bergmann's\n\tmessage of \"Wed, 6 Sep 2017 14:58:53 +0200\")","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-exchange-messagesentrepresentingtype":"1","x-ms-exchange-transport-fromentityheader":"Hosted","x-originating-ip":"[10.251.52.12]","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]