[{"id":1764084,"web_url":"http://patchwork.ozlabs.org/comment/1764084/","msgid":"<20170906125410.ebi4ip7phfjramhu@sapphire.tkos.co.il>","list_archive_url":null,"date":"2017-09-06T12:54:10","subject":"Re: [Buildroot] Add package Prosody","submitter":{"id":1458,"url":"http://patchwork.ozlabs.org/api/people/1458/","name":"Baruch Siach","email":"baruch@tkos.co.il"},"content":"Hi Dushara,\n\nOn Wed, Sep 06, 2017 at 10:47:35PM +1000, Dushara Jayasinghe wrote:\n> Ok... take 2\n\nNot needed. Your first attempt was seen on the list.\n\nhttp://lists.busybox.net/pipermail/buildroot/2017-September/201770.html\n\n> This is my first post the BR mailing list so please treat it\n> as a request for comments.\n> \n> I've created a BR package for Prosody, which I've tested on a\n> raspberry pi and was able to successfully register with an IM\n> client.\n> \n> Thank you.\n\nPlease send patches inline, not as attachments. Using 'git send-email' for \nthat should make it easier for you.\n\nbaruch","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnNnp4YBHz9sBd\n\tfor ;\n\tWed, 6 Sep 2017 22:54:22 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C164D89A59;\n\tWed, 6 Sep 2017 12:54:19 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JqK65ZpJY5bP; Wed, 6 Sep 2017 12:54:18 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 05D4D89A61;\n\tWed, 6 Sep 2017 12:54:18 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id D8B4D1CEB4B\n\tfor ;\n\tWed, 6 Sep 2017 12:54:16 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CD4E88255A\n\tfor ;\n\tWed, 6 Sep 2017 12:54:16 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eA3IJN8vPDSb for ;\n\tWed, 6 Sep 2017 12:54:14 +0000 (UTC)","from mx.tkos.co.il (guitar.tcltek.co.il [192.115.133.116])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id BA46782423\n\tfor ; Wed, 6 Sep 2017 12:54:14 +0000 (UTC)","from sapphire.tkos.co.il (unknown [10.0.4.3])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx.tkos.co.il (Postfix) with ESMTPS id 0DA7E4402AD;\n\tWed, 6 Sep 2017 15:54:12 +0300 (IDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Wed, 6 Sep 2017 15:54:10 +0300","From":"Baruch Siach ","To":"Dushara Jayasinghe ","Message-ID":"<20170906125410.ebi4ip7phfjramhu@sapphire.tkos.co.il>","References":"<20170906124735.GA31394@debian>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170906124735.GA31394@debian>","User-Agent":"NeoMutt/20170609 (1.8.3)","Cc":"buildroot@busybox.net, prosody-users@googlegroups.com","Subject":"Re: [Buildroot] Add package Prosody","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1764095,"web_url":"http://patchwork.ozlabs.org/comment/1764095/","msgid":"<20170906130204.GA31626@debian>","list_archive_url":null,"date":"2017-09-06T13:02:04","subject":"Re: [Buildroot] Add package Prosody","submitter":{"id":72308,"url":"http://patchwork.ozlabs.org/api/people/72308/","name":"Dushara Jayasinghe","email":"nidujay@gmail.com"},"content":"> Not needed. Your first attempt was seen on the list.\n \nOk sorry about the noise\n\n> Please send patches inline, not as attachments. Using 'git send-email' for \n> that should make it easier for you.\n> \nOk. I'll look it up. Thanks\n\nDushara","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rEBBPKE5\"; dkim-atps=neutral"],"Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnNyz6JgNz9sBd\n\tfor ;\n\tWed, 6 Sep 2017 23:02:19 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D89DC81111;\n\tWed, 6 Sep 2017 13:02:17 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KJjk-_3drCzS; Wed, 6 Sep 2017 13:02:17 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6319585008;\n\tWed, 6 Sep 2017 13:02:17 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0886B1C0CF8\n\tfor ;\n\tWed, 6 Sep 2017 13:02:16 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 01DD28861D\n\tfor ;\n\tWed, 6 Sep 2017 13:02:16 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Vaa1Wu0AlwLk for ;\n\tWed, 6 Sep 2017 13:02:15 +0000 (UTC)","from mail-pg0-f47.google.com (mail-pg0-f47.google.com\n\t[74.125.83.47])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 8EA468806B\n\tfor ; Wed, 6 Sep 2017 13:02:15 +0000 (UTC)","by mail-pg0-f47.google.com with SMTP id 63so6037119pgc.1\n\tfor ; Wed, 06 Sep 2017 06:02:15 -0700 (PDT)","from debian (124-170-16-137.dyn.iinet.net.au. [124.170.16.137])\n\tby smtp.gmail.com with ESMTPSA id\n\tm9sm3033825pgt.49.2017.09.06.06.02.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 06 Sep 2017 06:02:14 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=tTRewL/icWp4OqAV+jeCm4ypPU3B7U8W2rDHhPTyDrc=;\n\tb=rEBBPKE5P8LG0EBtB7kX4U4aUZezzCcH41SeIV7k/V4ZVhe0roii3f9pE5cnGfdzY2\n\tvBw9p8sQ/ALprQpL2CAks7Eghr2LucZ7sV76Itq9KmyamQHAs14PepbcB/tZTE/yfH7n\n\tvQZp0xkunl1K8dCE/BQR/n5OMx56/z+4bRusfg6ZHPXyrz4ANfK53gZxQJgF2joWjB/j\n\tMbfwqphnO679giWzPfNxU0BwV7/zIg5+kJm07CciDTjq+Te3eFoknqcBc1xozf5gh/gM\n\tgoCUo/Ap41WDFlmFOOKYnhJPvRpVtW0SAyS69PcEZN7Ubd3l1D7O6XO1trvtTBl1rpZV\n\tzzKQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=tTRewL/icWp4OqAV+jeCm4ypPU3B7U8W2rDHhPTyDrc=;\n\tb=houKvNhyoDyqpuWPqy3JbNIq1APJyYMF2DVOomMB/OkmRaZq91d49d9lXwPqPrhyYF\n\tCBtgQp40b4Oj8pAM+EwwHZh9w1oSXr2sS043yYENKxb6hOyo4tBz17z4XeLss1WzQju/\n\t2a928Jo3MB0F4c1zyvHpkBVFPkYJpiUBFGBmImDz0bzNLV66sYT8DJTokfnp+p3ZntCT\n\t4dAuB9Gla0r0x0bT6q3FXwUoxlnu6/wERdByP6lGL4LaVxVqzZgVIaHf5q+Q8YRXc07t\n\t+o3u6bDTVKiSTk1SaBgMdt5DqfcUJ6a3gvn/xnry/ME2NDHY2eo6TbAvZEZiN3ReQEEp\n\tubgA==","X-Gm-Message-State":"AHPjjUipau4WfHBnkRUhr1zCD5mhtY0gKJgaaEuvubGXK1dRbACu3/lg\n\tcCaAN+JNIVpXZQ==","X-Google-Smtp-Source":"ADKCNb6h1O69pofgj/+80vwa2/cS+BJ6klfWs4lCRpRsrsN7fxACvHo9WJfDGzTdDYFvC6Km1idG5g==","X-Received":"by 10.99.112.20 with SMTP id l20mr7865456pgc.210.1504702935168; \n\tWed, 06 Sep 2017 06:02:15 -0700 (PDT)","Date":"Wed, 6 Sep 2017 23:02:04 +1000","From":"Dushara Jayasinghe ","To":"Baruch Siach ","Message-ID":"<20170906130204.GA31626@debian>","References":"<20170906124735.GA31394@debian>\n\t<20170906125410.ebi4ip7phfjramhu@sapphire.tkos.co.il>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170906125410.ebi4ip7phfjramhu@sapphire.tkos.co.il>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Cc":"buildroot@busybox.net, prosody-users@googlegroups.com","Subject":"Re: [Buildroot] Add package Prosody","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1764336,"web_url":"http://patchwork.ozlabs.org/comment/1764336/","msgid":"<20170906215712.51cefb0e@windsurf.lan>","list_archive_url":null,"date":"2017-09-06T19:57:12","subject":"Re: [Buildroot] Add package Prosody","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Wed, 6 Sep 2017 15:54:10 +0300, Baruch Siach wrote:\n\n> On Wed, Sep 06, 2017 at 10:47:35PM +1000, Dushara Jayasinghe wrote:\n> > Ok... take 2 \n> \n> Not needed. Your first attempt was seen on the list.\n> \n> http://lists.busybox.net/pipermail/buildroot/2017-September/201770.html\n> \n> > This is my first post the BR mailing list so please treat it\n> > as a request for comments.\n> > \n> > I've created a BR package for Prosody, which I've tested on a\n> > raspberry pi and was able to successfully register with an IM\n> > client.\n> > \n> > Thank you. \n> \n> Please send patches inline, not as attachments. Using 'git send-email' for \n> that should make it easier for you.\n\nLet me rephrase what Baruch wanted to say here:\n\nThanks a lot for your contribution! It's great to see new people\nusing Buildroot and contributing to it.\n\nHowever, in order to ease the review process, we like to receive\npatches inline and not as attachments. Indeed, this allows us to simply\nhit \"reply\" and comment on each part of the patch. This is a very\ntypical review process used in the open-source community. In order to\nsend patches inline, we recommend you to use \"git send-email\" as e-mail\nclients very often rewrap text and therefore make patches unusable.\n\nFrom a quick look to your package, here are a few comments:\n\n * Adding an entry to the DEVELOPERS would be needed, so that you get\n notified when there are build problems with your package.\n\n * Adding a prosody.hash file is also mandatory, so that Buildroot can\n check the integrity of the downloaded tarball.\n\n * Do you really need Lua 5.1 specifically? Other versions of Lua, or\n LuaJIT are not suitable ?\n\n * We don't have any BR2_PACKAGE_LIBID option in Buildroot, so this\n looks like a bug in your package.\n\n * You select lots of Lua packages in Config.in, but you do not depend\n on them in prosody.mk. You do not even depend on lua in prosody.mk,\n which means you have no guarantee that all those packages will be\n built before Prosody. You should clarify if those packages are build\n dependencies or runtime dependencies.\n\n * The license information should be more specific than MIT/X11. Is it\n MIT *or* X11, or a combination of both MIT code and X11 code ? If\n so, which part is under which license ?\n\n * Why do you install prosody to staging ? It doesn't seems like\n Prosody is a library. If that's correct, then installing to staging\n is not very useful.\n\nCould you look into those comments, and send an updated version of your\ncontribution, using git send-email ?\n\nThanks a lot!\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnZ9q2TSWz9sCZ\n\tfor ;\n\tThu, 7 Sep 2017 05:57:19 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3BE6189A6D;\n\tWed, 6 Sep 2017 19:57:17 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bZV5lAXw4rrI; Wed, 6 Sep 2017 19:57:16 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 772C189A6F;\n\tWed, 6 Sep 2017 19:57:16 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 662061BFB44\n\tfor ;\n\tWed, 6 Sep 2017 19:57:15 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6080B8887A\n\tfor ;\n\tWed, 6 Sep 2017 19:57:15 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id oEZHZtg+AqqP for ;\n\tWed, 6 Sep 2017 19:57:14 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 11C9B846D3\n\tfor ; Wed, 6 Sep 2017 19:57:13 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid D7D74209D4; Wed, 6 Sep 2017 21:57:11 +0200 (CEST)","from windsurf.lan (LFbn-1-15130-153.w86-206.abo.wanadoo.fr\n\t[86.206.236.153])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id AB92420868;\n\tWed, 6 Sep 2017 21:57:11 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Wed, 6 Sep 2017 21:57:12 +0200","From":"Thomas Petazzoni ","To":"Dushara Jayasinghe ","Message-ID":"<20170906215712.51cefb0e@windsurf.lan>","In-Reply-To":"<20170906125410.ebi4ip7phfjramhu@sapphire.tkos.co.il>","References":"<20170906124735.GA31394@debian>\n\t<20170906125410.ebi4ip7phfjramhu@sapphire.tkos.co.il>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"buildroot@busybox.net, prosody-users@googlegroups.com","Subject":"Re: [Buildroot] Add package Prosody","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]