[{"id":1764406,"web_url":"http://patchwork.ozlabs.org/comment/1764406/","msgid":"","list_archive_url":null,"date":"2017-09-06T21:51:14","subject":"Re: [PATCH nf] netfilter: core: remove erroneous warn_on","submitter":{"id":67270,"url":"http://patchwork.ozlabs.org/api/people/67270/","name":"Aaron Conole","email":"aconole@bytheb.org"},"content":"Florian Westphal writes:\n\n> kernel test robot reported:\n>\n> WARNING: CPU: 0 PID: 1244 at net/netfilter/core.c:218 __nf_hook_entries_try_shrink+0x49/0xcd\n> [..]\n>\n> After allowing batching in nf_unregister_net_hooks its possible that an earlier\n> call to __nf_hook_entries_try_shrink already compacted the list.\n> If this happens we don't need to do anything.\n>\n> Fixes: d3ad2c17b4047 (\"netfilter: core: batch nf_unregister_net_hooks synchronize_net calls\")\n> Reported-by: kernel test robot \n> Signed-off-by: Florian Westphal \n> ---\n\n\nAcked-by: Aaron Conole \n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=bytheb-org.20150623.gappssmtp.com\n\theader.i=@bytheb-org.20150623.gappssmtp.com\n\theader.b=\"h+CVX7mc\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xncjN02PRz9s8J\n\tfor ;\n\tThu, 7 Sep 2017 07:51:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752856AbdIFVvT (ORCPT );\n\tWed, 6 Sep 2017 17:51:19 -0400","from mail-qk0-f194.google.com ([209.85.220.194]:33988 \"EHLO\n\tmail-qk0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752501AbdIFVvS (ORCPT\n\t);\n\tWed, 6 Sep 2017 17:51:18 -0400","by mail-qk0-f194.google.com with SMTP id d70so4596190qkc.1\n\tfor ;\n\tWed, 06 Sep 2017 14:51:18 -0700 (PDT)","from dhcp-25-97.bos.redhat.com (nat-pool-bos-t.redhat.com.\n\t[66.187.233.206]) by smtp.gmail.com with ESMTPSA id\n\tf48sm625092qtc.49.2017.09.06.14.51.15\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 06 Sep 2017 14:51:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=bytheb-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:references:date:in-reply-to:message-id\n\t:user-agent:mime-version;\n\tbh=Et7uYgud4lEDCJF6kgJ74TM6hlKDtXMfDR8BNRXZrok=;\n\tb=h+CVX7mc8ex/XrsBvV6nGxhNEj4PIavoFKJ4Svb2wWMVm+pL7IfiGFH6CmMjEfXVXV\n\tOu0hiSEpQGxd317UFl3T/GXJguEBUFuwymlUKh5PC30C5Firhf8hFWmBtwhcsftXRCXo\n\tZAzgHEG2TZXEFnjnGrc5JLXJMGM5O9eogS5bcbmNRb1ldT4CKJsv4ADZfBzPMO+cI9pD\n\ttztpE6Vc1Miu1HFnZyBdkNK/U0HyZu4QfW/ff3hJoSZbbfTP0GJvc1HqZbv7gs948rCH\n\tdd9r+GVB2k27prtN9KgKihfWWWeU1Ty4rcakwv5PUedpqVBKt8CH58wPz6Lci6TC37bt\n\t4+Hg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:user-agent:mime-version;\n\tbh=Et7uYgud4lEDCJF6kgJ74TM6hlKDtXMfDR8BNRXZrok=;\n\tb=Kj5LUEW599WlqPUBw52GC5j8B8FmCbPKzccaxdyUzs0kWb/pklijrBP9VOseZhrKRJ\n\tWxPKcP21BmAP0ntbbJElTm1rqhFCLJQxcHBV0dbHT7mqwQWKplkLCOJSoBYDaM7DZJfd\n\tFVUZgjEWgTMbHsQfjueUZGs97RL9BXLjNXl8g/yd1DP7Ifvu3PE9VBnDdunj4qA9NdvF\n\tw7n77p3wkkff/QSnpWNzFdHDwu5EYsp0xqCz8s9QlNfQ0kuyePKnXXPTUPKCBZ7IaYu1\n\t2933Yxw2KfV74rlMEuxpZF6mI2ISZt0MsPtPl+LezEDHERzPSakRTZxVPVKWG5FxN7xa\n\tfXuQ==","X-Gm-Message-State":"AHPjjUgmUd/gL1G4dqM3QH4IiF4cL3T6XMEomZIDIlCOed/YFNOBjRBE\n\t/solNgb+3eGRGSctLSw=","X-Google-Smtp-Source":"ADKCNb5Cerk5Ux8/G5jWnvLPrj+0UwQQsmcOVoykTW/4il52NRBwtTnolk1hCQucG+jJdBTcG8YGNw==","X-Received":"by 10.55.104.131 with SMTP id d125mr786694qkc.37.1504734677116; \n\tWed, 06 Sep 2017 14:51:17 -0700 (PDT)","From":"Aaron Conole ","To":"Florian Westphal ","Cc":"","Subject":"Re: [PATCH nf] netfilter: core: remove erroneous warn_on","References":"<20170906124757.13934-1-fw@strlen.de>","Date":"Wed, 06 Sep 2017 17:51:14 -0400","In-Reply-To":"<20170906124757.13934-1-fw@strlen.de> (Florian Westphal's\n\tmessage of \"Wed, 6 Sep 2017 14:47:57 +0200\")","Message-ID":"","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}},{"id":1765283,"web_url":"http://patchwork.ozlabs.org/comment/1765283/","msgid":"<20170908120432.GA14839@salvia>","list_archive_url":null,"date":"2017-09-08T12:04:32","subject":"Re: [PATCH nf] netfilter: core: remove erroneous warn_on","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Wed, Sep 06, 2017 at 02:47:57PM +0200, Florian Westphal wrote:\n> kernel test robot reported:\n> \n> WARNING: CPU: 0 PID: 1244 at net/netfilter/core.c:218 __nf_hook_entries_try_shrink+0x49/0xcd\n> [..]\n> \n> After allowing batching in nf_unregister_net_hooks its possible that an earlier\n> call to __nf_hook_entries_try_shrink already compacted the list.\n> If this happens we don't need to do anything.\n\nApplied, thanks.\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpbbt5BJNz9t3V\n\tfor ;\n\tFri, 8 Sep 2017 22:04:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754560AbdIHME5 (ORCPT );\n\tFri, 8 Sep 2017 08:04:57 -0400","from ganesha.gnumonks.org ([213.95.27.120]:34623 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753407AbdIHME5 (ORCPT\n\t);\n\tFri, 8 Sep 2017 08:04:57 -0400","from 129.166.216.87.static.jazztel.es ([87.216.166.129]\n\thelo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dqI1R-0003cp-NK; Fri, 08 Sep 2017 14:04:35 +0200"],"Date":"Fri, 8 Sep 2017 14:04:32 +0200","From":"Pablo Neira Ayuso ","To":"Florian Westphal ","Cc":"netfilter-devel@vger.kernel.org","Subject":"Re: [PATCH nf] netfilter: core: remove erroneous warn_on","Message-ID":"<20170908120432.GA14839@salvia>","References":"<20170906124757.13934-1-fw@strlen.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170906124757.13934-1-fw@strlen.de>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Score":"-2.9 (--)","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]