[{"id":1765051,"web_url":"http://patchwork.ozlabs.org/comment/1765051/","msgid":"<20170907.200305.1453658712948209622.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-08T03:03:05","subject":"Re: [PATCH net] udp: drop head states only when all skb references\n\tare gone","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Paolo Abeni \nDate: Wed, 6 Sep 2017 14:44:36 +0200\n\n> After commit 0ddf3fb2c43d (\"udp: preserve skb->dst if required\n> for IP options processing\") we clear the skb head state as soon\n> as the skb carrying them is first processed.\n> \n> Since the same skb can be processed several times when MSG_PEEK\n> is used, we can end up lacking the required head states, and\n> eventually oopsing.\n> \n> Fix this clearing the skb head state only when processing the\n> last skb reference.\n> \n> Reported-by: Eric Dumazet \n> Fixes: 0ddf3fb2c43d (\"udp: preserve skb->dst if required for IP options processing\")\n> Signed-off-by: Paolo Abeni \n\nApplied and queued up for -stable, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpMZk0LL8z9sMN\n\tfor ;\n\tFri, 8 Sep 2017 13:03:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753857AbdIHDDI (ORCPT );\n\tThu, 7 Sep 2017 23:03:08 -0400","from shards.monkeyblade.net ([184.105.139.130]:41612 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753132AbdIHDDH (ORCPT\n\t); Thu, 7 Sep 2017 23:03:07 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id CBC6713428607;\n\tThu, 7 Sep 2017 20:03:06 -0700 (PDT)"],"Date":"Thu, 07 Sep 2017 20:03:05 -0700 (PDT)","Message-Id":"<20170907.200305.1453658712948209622.davem@davemloft.net>","To":"pabeni@redhat.com","Cc":"netdev@vger.kernel.org, edumazet@google.com, hannes@stressinduktion.org","Subject":"Re: [PATCH net] udp: drop head states only when all skb references\n\tare gone","From":"David Miller ","In-Reply-To":"<1d0596e2a1926e7c0e8c7f691ef42c713daa3396.1504701206.git.pabeni@redhat.com>","References":"<1504631927.15310.47.camel@edumazet-glaptop3.roam.corp.google.com>\n\t<1d0596e2a1926e7c0e8c7f691ef42c713daa3396.1504701206.git.pabeni@redhat.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 07 Sep 2017 20:03:07 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]