[{"id":1764271,"web_url":"http://patchwork.ozlabs.org/comment/1764271/","msgid":"","list_archive_url":null,"date":"2017-09-06T17:24:37","subject":"Re: [PATCH v6 3/3] Bluetooth: btqcomsmd: retrieve BD address from DT\n\tproperty","submitter":{"id":384,"url":"http://patchwork.ozlabs.org/api/people/384/","name":"Marcel Holtmann","email":"marcel@holtmann.org"},"content":"Hi Loic,\n\n> Retrieve BD address from the local-bd-address property.\n> This address must be unique and is usually added in the DT\n> by the bootloader which has access to the provisioned data.\n> \n> Signed-off-by: Loic Poulain \n> ---\n> v2: Set device as unconfigured if default address detected\n> Add warning if BD addr retrieved from DT\n> v3: if no addr retrieved from DT, unconditionally set\n> the invalid BD addr flag.\n> swap and set bdaddr in the platform probe\n> v4: Add dt-bindings documentation\n> split patch in two parts (setup, dt prop)\n> use local-bd-address name instead of local-mac-address\n> v5: remove 2/3 merged in bluetooth-next tree\n> Add bluetooth.txt for common BT bindings\n> expect local-bd-address in little-endian format\n> v6: use of_property_read_u8_array instead of of_get_property\n> \n> drivers/bluetooth/btqcomsmd.c | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c\n> index bd810d0..b5716f0 100644\n> --- a/drivers/bluetooth/btqcomsmd.c\n> +++ b/drivers/bluetooth/btqcomsmd.c\n> @@ -15,6 +15,8 @@\n> #include \n> #include \n> #include \n> +#include \n> +\n> #include \n> #include \n> \n> @@ -156,6 +158,15 @@ static int btqcomsmd_probe(struct platform_device *pdev)\n> \tif (IS_ERR(btq->cmd_channel))\n> \t\treturn PTR_ERR(btq->cmd_channel);\n> \n> +\t/* The local-bd-address property is usually injected by the\n> +\t * bootloader which has access to the allocated BD address.\n> +\t */\n> +\tif (!of_property_read_u8_array(pdev->dev.of_node, \"local-bd-address\",\n> +\t\t\t\t (u8 *)&btq->bdaddr, sizeof(bdaddr_t))) {\n> +\t\tBT_INFO(\"BD address %pMR retrieved from device-tree\",\n> +\t\t\t&btq->bdaddr);\n> +\t}\n\nany reason you are not using bt_dev_info here? I think it would be important to print the device information prefix.\n\nOtherwise the patch set looks good to me. However I would prefer if we get an ack from Rob.\n\nRegards\n\nMarcel\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnVnk1yrlz9t3Z\n\tfor ;\n\tThu, 7 Sep 2017 03:24:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932489AbdIFRYk convert rfc822-to-8bit (ORCPT\n\t);\n\tWed, 6 Sep 2017 13:24:40 -0400","from coyote.holtmann.net ([212.227.132.17]:56488 \"EHLO\n\tmail.holtmann.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932130AbdIFRYk (ORCPT\n\t); Wed, 6 Sep 2017 13:24:40 -0400","from marcel-macpro.fritz.box (p4FF9F7CE.dip0.t-ipconnect.de\n\t[79.249.247.206])\n\tby mail.holtmann.org (Postfix) with ESMTPSA id 993BDCF2B8;\n\tWed, 6 Sep 2017 19:30:01 +0200 (CEST)"],"Content-Type":"text/plain; charset=us-ascii","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","Subject":"Re: [PATCH v6 3/3] Bluetooth: btqcomsmd: retrieve BD address from DT\n\tproperty","From":"Marcel Holtmann ","In-Reply-To":"<1504699898-28011-3-git-send-email-loic.poulain@linaro.org>","Date":"Wed, 6 Sep 2017 19:24:37 +0200","Cc":"Rob Herring , Johan Hedberg ,\n\tBluez mailing list ,\n\tlinux-arm-msm@vger.kernel.org, devicetree ,\n\tbjorn.andersson@linaro.org","Content-Transfer-Encoding":"8BIT","Message-Id":"","References":"<1504699898-28011-1-git-send-email-loic.poulain@linaro.org>\n\t<1504699898-28011-3-git-send-email-loic.poulain@linaro.org>","To":"Loic Poulain ","X-Mailer":"Apple Mail (2.3273)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1764431,"web_url":"http://patchwork.ozlabs.org/comment/1764431/","msgid":"<20170906232610.GG1165@minitux>","list_archive_url":null,"date":"2017-09-06T23:26:10","subject":"Re: [PATCH v6 1/3] dt-bindings: net: document Bluetooth bindings in\n\tone place","submitter":{"id":68398,"url":"http://patchwork.ozlabs.org/api/people/68398/","name":"Bjorn Andersson","email":"bjorn.andersson@linaro.org"},"content":"On Wed 06 Sep 05:11 PDT 2017, Loic Poulain wrote:\n\n> In the same way as Ethernet, gather the Bluetooth related bindings in\n> one file. Introduce the bluetooth-bd-address property which can be used\n> to store the assigned BD address.\n> \n> Signed-off-by: Loic Poulain \n> ---\n> v2: Set device as unconfigured if default address detected\n> Add warning if BD addr retrieved from DT\n> v3: if no addr retrieved from DT, unconditionally set\n> the invalid BD addr flag.\n> swap and set bdaddr in the platform probe\n> v4: Add dt-bindings documentation\n> split patch in two parts (setup, dt prop)\n> use local-bd-address name instead of local-mac-address\n> v5: remove 2/3 merged in bluetooth-next tree\n> Add bluetooth.txt for common BT bindings\n> expect local-bd-address in little-endian format\n> v6: use of_property_read_u8_array instead of of_get_property\n> \n> Documentation/devicetree/bindings/net/bluetooth.txt | 5 +++++\n> 1 file changed, 5 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/net/bluetooth.txt\n> \n> diff --git a/Documentation/devicetree/bindings/net/bluetooth.txt b/Documentation/devicetree/bindings/net/bluetooth.txt\n> new file mode 100644\n> index 0000000..94797df\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/net/bluetooth.txt\n> @@ -0,0 +1,5 @@\n> +The following properties are common to the Bluetooth controllers:\n> +\n> +- local-bd-address: array of 6 bytes, specifies the BD address that was\n> + uniquely assigned to the Bluetooth device, formatted with least significant\n> + byte first (little-endian).\n\nIs there a good reason for making this little endian?\n\nSure it's only going to be read and written by computers, but for anyone\nreading the generated DT it sure looks like the values are reversed.\n\nRegards,\nBjorn\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Ztd/EVs5\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnfpw5Bkgz9t2r\n\tfor ;\n\tThu, 7 Sep 2017 09:26:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753106AbdIFX0P (ORCPT\n\t);\n\tWed, 6 Sep 2017 19:26:15 -0400","from mail-pg0-f46.google.com ([74.125.83.46]:34740 \"EHLO\n\tmail-pg0-f46.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750800AbdIFX0O (ORCPT\n\t); Wed, 6 Sep 2017 19:26:14 -0400","by mail-pg0-f46.google.com with SMTP id q68so1942133pgq.1\n\tfor ;\n\tWed, 06 Sep 2017 16:26:14 -0700 (PDT)","from minitux (ip68-111-217-79.sd.sd.cox.net. [68.111.217.79])\n\tby smtp.gmail.com with ESMTPSA id\n\tb1sm885195pgn.55.2017.09.06.16.26.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 06 Sep 2017 16:26:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=QokVcupQLDQecEwtYXscAEGcIrzL80H8bAbdKijV1ZA=;\n\tb=Ztd/EVs5NXeFrAKynV50vTRLU+Ps48DBOFQrb0k9A8FAc9ro7lsKh19iGVnMy5sAOc\n\ti+Trazac2O4nJ8GX8h+DkDxyRGsMh1uge4o5Tk1nhHGPQyEAj9VRFXMrl7J9W4EvH6BW\n\tcFX69VN2KpVrHchI2lL94s5BoVeSH9xNufiPI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=QokVcupQLDQecEwtYXscAEGcIrzL80H8bAbdKijV1ZA=;\n\tb=D30bvIQzJnG/frim+F3OqqACmclzB/z4JgQKWoORVORIsJJxh0YBD73TDK4yujl0xg\n\tXIBHLNdfK2eL9grfEY8Y44doKN/0UEMFk5Io7LtVWNF1MQHALQYU5YWgYLcfcoinMU6w\n\t6L06bonJpiGAWMl2Ze8ygGxvztK5zTZPH3J0nl3YN3hhDKDw3Y2uz5SgHfdmfIoGGfZ3\n\tMFa3Bgzr8SG7Y4X4SvyfKZZTFjXe+5CpEZkMwKUI7kQNvAGbEtRbPwnoAkJR+nnppvIl\n\tTejGeWcBHbHC61WrdjQ6ziE02kASdevA6KAWFNJhAcDkz5PGTOlS7wzt+l2TNKd/WVxL\n\tDU3w==","X-Gm-Message-State":"AHPjjUjyj53NEgEoPcVL3WjIq4ODwABlw67QAM6D9bJEtccf87i+NFJZ\n\tDJ48zZ9ZE8W+SoX0","X-Google-Smtp-Source":"ADKCNb5DRSXYyxUM2oJM/El1cJfnHp908sG1WabjDGd2/d21lorokKDVMXZPZ4n4sFsYzOwqif3eRQ==","X-Received":"by 10.99.147.75 with SMTP id w11mr815514pgm.308.1504740373614;\n\tWed, 06 Sep 2017 16:26:13 -0700 (PDT)","Date":"Wed, 6 Sep 2017 16:26:10 -0700","From":"Bjorn Andersson ","To":"Loic Poulain ","Cc":"marcel@holtmann.org, robh+dt@kernel.org, johan.hedberg@gmail.com,\n\tlinux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH v6 1/3] dt-bindings: net: document Bluetooth bindings in\n\tone place","Message-ID":"<20170906232610.GG1165@minitux>","References":"<1504699898-28011-1-git-send-email-loic.poulain@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504699898-28011-1-git-send-email-loic.poulain@linaro.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1764528,"web_url":"http://patchwork.ozlabs.org/comment/1764528/","msgid":"<41A0C162-4AC5-4969-813D-9E2C7F5D5031@holtmann.org>","list_archive_url":null,"date":"2017-09-07T06:14:32","subject":"Re: [PATCH v6 1/3] dt-bindings: net: document Bluetooth bindings in\n\tone place","submitter":{"id":384,"url":"http://patchwork.ozlabs.org/api/people/384/","name":"Marcel Holtmann","email":"marcel@holtmann.org"},"content":"Hi Bjorn,\n\n>> In the same way as Ethernet, gather the Bluetooth related bindings in\n>> one file. Introduce the bluetooth-bd-address property which can be used\n>> to store the assigned BD address.\n>> \n>> Signed-off-by: Loic Poulain \n>> ---\n>> v2: Set device as unconfigured if default address detected\n>> Add warning if BD addr retrieved from DT\n>> v3: if no addr retrieved from DT, unconditionally set\n>> the invalid BD addr flag.\n>> swap and set bdaddr in the platform probe\n>> v4: Add dt-bindings documentation\n>> split patch in two parts (setup, dt prop)\n>> use local-bd-address name instead of local-mac-address\n>> v5: remove 2/3 merged in bluetooth-next tree\n>> Add bluetooth.txt for common BT bindings\n>> expect local-bd-address in little-endian format\n>> v6: use of_property_read_u8_array instead of of_get_property\n>> \n>> Documentation/devicetree/bindings/net/bluetooth.txt | 5 +++++\n>> 1 file changed, 5 insertions(+)\n>> create mode 100644 Documentation/devicetree/bindings/net/bluetooth.txt\n>> \n>> diff --git a/Documentation/devicetree/bindings/net/bluetooth.txt b/Documentation/devicetree/bindings/net/bluetooth.txt\n>> new file mode 100644\n>> index 0000000..94797df\n>> --- /dev/null\n>> +++ b/Documentation/devicetree/bindings/net/bluetooth.txt\n>> @@ -0,0 +1,5 @@\n>> +The following properties are common to the Bluetooth controllers:\n>> +\n>> +- local-bd-address: array of 6 bytes, specifies the BD address that was\n>> + uniquely assigned to the Bluetooth device, formatted with least significant\n>> + byte first (little-endian).\n> \n> Is there a good reason for making this little endian?\n> \n> Sure it's only going to be read and written by computers, but for anyone\n> reading the generated DT it sure looks like the values are reversed.\n\nthe Bluetooth spec has a string notation and defines how it is packed as 6 octet binary.\n\n\"On the baseband level the BD_ADDR is represented as 48 bits. On the Link Layer the public and random device address are represented as 48-bit addresses.\"\n\n\"On the UI level the Bluetooth address shall be represented as 12 hexadecimal characters, possibly divided into sub-parts separated by ‘:’ (e.g., ‘000C3E3A4B69’ or ‘00:0C:3E:3A:4B:69’). On the UI level any number shall have the MSB -> LSB (from left to right) ‘natural’ ordering.”\n\nHowever on the wire level it is LSB -> MSB. See our ba2str function.\n\nint str2ba(const char *str, bdaddr_t *ba)\n{\n\tint i;\n\t\n\tfor (i = 5; i >= 0; i--, str += 3)\n\t\tba->b[i] = strtol(str, NULL, 16);\n\n\treturn 0;\n}\n\nI would prefer the boot loader actually providing the BD Address in the correct byte order as the protocol expects and not yet another form. The string representation is just for reference since that is what most people have seen so far.\n\nRegards\n\nMarcel\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnqt52TyPz9t2M\n\tfor ;\n\tThu, 7 Sep 2017 16:14:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751055AbdIGGOf convert rfc822-to-8bit (ORCPT\n\t);\n\tThu, 7 Sep 2017 02:14:35 -0400","from coyote.holtmann.net ([212.227.132.17]:57435 \"EHLO\n\tmail.holtmann.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750742AbdIGGOf (ORCPT\n\t); Thu, 7 Sep 2017 02:14:35 -0400","from marcel-macpro.fritz.box (p4FF9F7CE.dip0.t-ipconnect.de\n\t[79.249.247.206])\n\tby mail.holtmann.org (Postfix) with ESMTPSA id E5255CF2C0;\n\tThu, 7 Sep 2017 08:19:56 +0200 (CEST)"],"Content-Type":"text/plain; charset=utf-8","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","Subject":"Re: [PATCH v6 1/3] dt-bindings: net: document Bluetooth bindings in\n\tone place","From":"Marcel Holtmann ","In-Reply-To":"<20170906232610.GG1165@minitux>","Date":"Thu, 7 Sep 2017 08:14:32 +0200","Cc":"Loic Poulain , Rob Herring ,\n\tJohan Hedberg ,\n\tBluez mailing list ,\n\tlinux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org","Content-Transfer-Encoding":"8BIT","Message-Id":"<41A0C162-4AC5-4969-813D-9E2C7F5D5031@holtmann.org>","References":"<1504699898-28011-1-git-send-email-loic.poulain@linaro.org>\n\t<20170906232610.GG1165@minitux>","To":"Bjorn Andersson ","X-Mailer":"Apple Mail (2.3273)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1765237,"web_url":"http://patchwork.ozlabs.org/comment/1765237/","msgid":"<61944931-B998-4349-A2B1-CAF6D5DD070C@holtmann.org>","list_archive_url":null,"date":"2017-09-08T10:57:40","subject":"Re: [PATCH v6 3/3] Bluetooth: btqcomsmd: retrieve BD address from DT\n\tproperty","submitter":{"id":384,"url":"http://patchwork.ozlabs.org/api/people/384/","name":"Marcel Holtmann","email":"marcel@holtmann.org"},"content":"Hi Loic,\n\n> > + /* The local-bd-address property is usually injected by the\n> > + * bootloader which has access to the allocated BD address.\n> > + */\n> > + if (!of_property_read_u8_array(pdev->dev.of_node, \"local-bd-address\",\n> > + (u8 *)&btq->bdaddr, sizeof(bdaddr_t))) {\n> > + BT_INFO(\"BD address %pMR retrieved from device-tree\",\n> > + &btq->bdaddr);\n> > + }\n> \n> any reason you are not using bt_dev_info here? I think it would be important to print the device information prefix.\n> \n> Yes, hdev does not have any allocated name/number before being registered.\n> I can move this after hci_register_dev if you prefer.\n\nif that is possible, then that would be good.\n\nRegards\n\nMarcel\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpZ6L4z8Sz9s7G\n\tfor ;\n\tFri, 8 Sep 2017 20:57:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752679AbdIHK5o convert rfc822-to-8bit (ORCPT\n\t);\n\tFri, 8 Sep 2017 06:57:44 -0400","from coyote.holtmann.net ([212.227.132.17]:42444 \"EHLO\n\tmail.holtmann.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752524AbdIHK5n (ORCPT\n\t); Fri, 8 Sep 2017 06:57:43 -0400","from marcel-macpro.fritz.box (p4FF9F7CE.dip0.t-ipconnect.de\n\t[79.249.247.206])\n\tby mail.holtmann.org (Postfix) with ESMTPSA id 3C0BECF30D;\n\tFri, 8 Sep 2017 13:03:05 +0200 (CEST)"],"Content-Type":"text/plain; charset=us-ascii","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","Subject":"Re: [PATCH v6 3/3] Bluetooth: btqcomsmd: retrieve BD address from DT\n\tproperty","From":"Marcel Holtmann ","In-Reply-To":"","Date":"Fri, 8 Sep 2017 12:57:40 +0200","Cc":"Rob Herring , Johan Hedberg ,\n\tBluez mailing list ,\n\tlinux-arm-msm@vger.kernel.org, devicetree ,\n\tBjorn Andersson ","Content-Transfer-Encoding":"8BIT","Message-Id":"<61944931-B998-4349-A2B1-CAF6D5DD070C@holtmann.org>","References":"<1504699898-28011-1-git-send-email-loic.poulain@linaro.org>\n\t<1504699898-28011-3-git-send-email-loic.poulain@linaro.org>\n\t\n\t","To":"Loic Poulain ","X-Mailer":"Apple Mail (2.3273)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]