[{"id":1764135,"web_url":"http://patchwork.ozlabs.org/comment/1764135/","msgid":"<20170906141125.GT15510@redhat.com>","list_archive_url":null,"date":"2017-09-06T14:11:25","subject":"Re: [Qemu-devel] [PATCH v7 08/22] qio: Create new\n\tqio_channel_{readv, writev}_all","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Wed, Sep 06, 2017 at 09:03:40AM -0500, Eric Blake wrote:\n> On 09/06/2017 06:51 AM, Juan Quintela wrote:\n> > The functions waits until it is able to write the full iov.\n> > \n> > Signed-off-by: Juan Quintela \n> > \n> > --\n> > \n> > Add tests.\n> > \n> > fix reader to check for len == 0.\n> > \n> > make reader wait on G_IO_IN (dave)\n> > change tests to make sure that all combinations of call work with all backends\n> \n> Since Dan's patch to add qio_channel_readv_all has already landed,\n> shouldn't this patch just be rebased to add the tests? Or is it also\n> fixing some bugs?\n\nI don't think this patch is needed at all from the QIO pov now - the test\nscript changes don't add any extra coverage compared to what merged.\n\nIOW, only needs the migration/ bit of the patch\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnQWw02JNz9t3Z\n\tfor ;\n\tThu, 7 Sep 2017 00:12:28 +1000 (AEST)","from localhost ([::1]:36312 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpb46-0003lr-3G\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 10:12:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53793)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpb3H-0003gC-VG\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:11:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpb3D-0005UT-Tg\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:11:35 -0400","from mx1.redhat.com ([209.132.183.28]:44336)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpb3D-0005TW-NN\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:11:31 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D4265356D3\n\tfor ; Wed, 6 Sep 2017 14:11:30 +0000 (UTC)","from redhat.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id E38EE5E1A5;\n\tWed, 6 Sep 2017 14:11:27 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D4265356D3","Date":"Wed, 6 Sep 2017 15:11:25 +0100","From":"\"Daniel P. Berrange\" ","To":"Eric Blake ","Message-ID":"<20170906141125.GT15510@redhat.com>","References":"<20170906115143.27451-1-quintela@redhat.com>\n\t<20170906115143.27451-9-quintela@redhat.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 06 Sep 2017 14:11:30 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 08/22] qio: Create new\n\tqio_channel_{readv, writev}_all","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"lvivier@redhat.com, peterx@redhat.com, qemu-devel@nongnu.org,\n\tdgilbert@redhat.com, Juan Quintela ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764139,"web_url":"http://patchwork.ozlabs.org/comment/1764139/","msgid":"","list_archive_url":null,"date":"2017-09-06T14:03:40","subject":"Re: [Qemu-devel] [PATCH v7 08/22] qio: Create new\n\tqio_channel_{readv, writev}_all","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/06/2017 06:51 AM, Juan Quintela wrote:\n> The functions waits until it is able to write the full iov.\n> \n> Signed-off-by: Juan Quintela \n> \n> --\n> \n> Add tests.\n> \n> fix reader to check for len == 0.\n> \n> make reader wait on G_IO_IN (dave)\n> change tests to make sure that all combinations of call work with all backends\n\nSince Dan's patch to add qio_channel_readv_all has already landed,\nshouldn't this patch just be rebased to add the tests? Or is it also\nfixing some bugs?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnQfl1ZHTz9s7f\n\tfor ;\n\tThu, 7 Sep 2017 00:18:23 +1000 (AEST)","from localhost ([::1]:36338 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpb9p-0000mD-9D\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 10:18:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50409)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpavp-00066J-3J\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:04:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpavo-0001Lx-8l\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:03:53 -0400","from mx1.redhat.com ([209.132.183.28]:36630)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpavo-0001LP-0K\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:03:52 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 069FD7E428\n\tfor ; Wed, 6 Sep 2017 14:03:51 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 658446E1E1;\n\tWed, 6 Sep 2017 14:03:41 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 069FD7E428","To":"Juan Quintela , qemu-devel@nongnu.org","References":"<20170906115143.27451-1-quintela@redhat.com>\n\t<20170906115143.27451-9-quintela@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Wed, 6 Sep 2017 09:03:40 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170906115143.27451-9-quintela@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"tTJtjQPB0ljHd9CsgsMSVfW5cN24uhO9s\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 06 Sep 2017 14:03:51 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v7 08/22] qio: Create new\n\tqio_channel_{readv, writev}_all","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]