[{"id":1765535,"web_url":"http://patchwork.ozlabs.org/comment/1765535/","msgid":"<20170908172258.GE2836@work-vm>","list_archive_url":null,"date":"2017-09-08T17:22:58","subject":"Re: [Qemu-devel] [PATCH v7 13/22] migration: Split\n\tmigration_fd_process_incoming","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* Juan Quintela (quintela@redhat.com) wrote:\n> We need that on later patches.\n> \n> Signed-off-by: Juan Quintela \n> Reviewed-by: Dr. David Alan Gilbert \n> Reviewed-by: Peter Xu \n> Reviewed-by: Daniel P. Berrange \n\nI think this could also go into current qemu?\n\nDave\n\n> ---\n> migration/migration.c | 14 ++++++++++++--\n> 1 file changed, 12 insertions(+), 2 deletions(-)\n> \n> diff --git a/migration/migration.c b/migration/migration.c\n> index 9fec880a58..18bd24a14c 100644\n> --- a/migration/migration.c\n> +++ b/migration/migration.c\n> @@ -372,9 +372,8 @@ static void process_incoming_migration_co(void *opaque)\n> qemu_bh_schedule(mis->bh);\n> }\n> \n> -void migration_fd_process_incoming(QEMUFile *f)\n> +static void migration_incoming_setup(QEMUFile *f)\n> {\n> - Coroutine *co = qemu_coroutine_create(process_incoming_migration_co, NULL);\n> MigrationIncomingState *mis = migration_incoming_get_current();\n> \n> if (multifd_load_setup() != 0) {\n> @@ -387,9 +386,20 @@ void migration_fd_process_incoming(QEMUFile *f)\n> mis->from_src_file = f;\n> }\n> qemu_file_set_blocking(f, false);\n> +}\n> +\n> +static void migration_incoming_process(void)\n> +{\n> + Coroutine *co = qemu_coroutine_create(process_incoming_migration_co, NULL);\n> qemu_coroutine_enter(co);\n> }\n> \n> +void migration_fd_process_incoming(QEMUFile *f)\n> +{\n> + migration_incoming_setup(f);\n> + migration_incoming_process();\n> +}\n> +\n> void migration_ioc_process_incoming(QIOChannel *ioc)\n> {\n> MigrationIncomingState *mis = migration_incoming_get_current();\n> -- \n> 2.13.5\n> \n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpkgh5Wsgz9s8J\n\tfor ;\n\tSat, 9 Sep 2017 03:23:44 +1000 (AEST)","from localhost ([::1]:46597 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqN0I-00075c-Sh\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 13:23:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33378)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqMzn-00073o-J5\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 13:23:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqMzi-0007i2-Kz\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 13:23:11 -0400","from mx1.redhat.com ([209.132.183.28]:44360)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqMzi-0007h9-EZ\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 13:23:06 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 31A674A6E7\n\tfor ; Fri, 8 Sep 2017 17:23:05 +0000 (UTC)","from work-vm (ovpn-116-125.ams2.redhat.com [10.36.116.125])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 52C24619C3;\n\tFri, 8 Sep 2017 17:23:01 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 31A674A6E7","Date":"Fri, 8 Sep 2017 18:22:58 +0100","From":"\"Dr. David Alan Gilbert\" ","To":"Juan Quintela ","Message-ID":"<20170908172258.GE2836@work-vm>","References":"<20170906115143.27451-1-quintela@redhat.com>\n\t<20170906115143.27451-14-quintela@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170906115143.27451-14-quintela@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tFri, 08 Sep 2017 17:23:05 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 13/22] migration: Split\n\tmigration_fd_process_incoming","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lvivier@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]