[{"id":1764314,"web_url":"http://patchwork.ozlabs.org/comment/1764314/","msgid":"<20170906190408.GH2215@work-vm>","list_archive_url":null,"date":"2017-09-06T19:04:08","subject":"Re: [Qemu-devel] [PATCH v7 06/22] migration: Improve migration\n\tthread error handling","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* Juan Quintela (quintela@redhat.com) wrote:\n> We now report errors also when we finish migration, not only on info\n> migrate. We plan to use this error from several places, and we want\n> the first error to happen to win, so we add an mutex to order it.\n> \n> Signed-off-by: Juan Quintela \n\nI think this is OK for errors from the migration code itself;\nI'd prefer not to lost any multiplelayers of errors we get\nfrom devices (e.g.we see an error about a particular bit, and then\nsee it's from a PCI device etc)\n\n> diff --git a/migration/ram.c b/migration/ram.c\n> index e18b3e2d4f..e0179fc838 100644\n> --- a/migration/ram.c\n> +++ b/migration/ram.c\n> @@ -1789,7 +1789,7 @@ int ram_discard_range(const char *rbname, uint64_t start, size_t length)\n> RAMBlock *rb = qemu_ram_block_by_name(rbname);\n> \n> if (!rb) {\n> - error_report(\"ram_discard_range: Failed to find block '%s'\", rbname);\n> + error_report(\"ram_discard_rang0e: Failed to find block '%s'\", rbname);\n\nTypo!\n\nDave\n\n> goto err;\n> }\n> \n> diff --git a/migration/tls.c b/migration/tls.c\n> index 596e8790bd..026a008667 100644\n> --- a/migration/tls.c\n> +++ b/migration/tls.c\n> @@ -119,7 +119,6 @@ static void migration_tls_outgoing_handshake(QIOTask *task,\n> if (qio_task_propagate_error(task, &err)) {\n> trace_migration_tls_outgoing_handshake_error(error_get_pretty(err));\n> migrate_fd_error(s, err);\n> - error_free(err);\n> } else {\n> trace_migration_tls_outgoing_handshake_complete();\n> migration_channel_connect(s, ioc, NULL);\n> -- \n> 2.13.5\n> \n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnY1815Yfz9sRV\n\tfor ;\n\tThu, 7 Sep 2017 05:04:44 +1000 (AEST)","from localhost ([::1]:37529 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpfcw-0005aB-Av\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 15:04:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35322)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpfca-0005Zl-CA\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 15:04:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpfcV-0004c3-F8\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 15:04:20 -0400","from mx1.redhat.com ([209.132.183.28]:52164)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpfcV-0004bc-8b\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 15:04:15 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 13EAC61468\n\tfor ; Wed, 6 Sep 2017 19:04:14 +0000 (UTC)","from work-vm (ovpn-117-207.ams2.redhat.com [10.36.117.207])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0DE2D60460;\n\tWed, 6 Sep 2017 19:04:10 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 13EAC61468","Date":"Wed, 6 Sep 2017 20:04:08 +0100","From":"\"Dr. David Alan Gilbert\" ","To":"Juan Quintela ","Message-ID":"<20170906190408.GH2215@work-vm>","References":"<20170906115143.27451-1-quintela@redhat.com>\n\t<20170906115143.27451-7-quintela@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20170906115143.27451-7-quintela@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 06 Sep 2017 19:04:14 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 06/22] migration: Improve migration\n\tthread error handling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lvivier@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]