[{"id":1764128,"web_url":"http://patchwork.ozlabs.org/comment/1764128/","msgid":"<7e71d190-8e49-ca6b-ef44-522100b27b8c@redhat.com>","list_archive_url":null,"date":"2017-09-06T14:00:51","subject":"Re: [Qemu-devel] [PATCH v7 01/22] Revert \"io: add new\n\tqio_channel_{readv, writev, read, write}_all functions\"","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/06/2017 06:51 AM, Juan Quintela wrote:\n> This reverts commit d4622e55883211072621958d39ddaa73483d201e.\n\nBut with no reason why?  What bugs are you fixing by reverting this?\n\n> \n> Signed-off-by: Juan Quintela <quintela@redhat.com>\n> ---\n>  include/io/channel.h       |  90 ---------------------------------------\n>  io/channel.c               |  94 -----------------------------------------\n>  tests/io-channel-helpers.c | 102 +++++++++++++++++++++++++++++++++++++++++----\n>  3 files changed, 93 insertions(+), 193 deletions(-)\n>\n\nLooking ahead, I see 8/22 recreates qio_channel_readv_all (but not\nqio_channel_read_all); how does that differ from this one?\n\nShould you be squashing 1/22 and 8/22 into a single non-revert patch\nthat just fixes bugs on top of what is already in the tree?\n\nAlso, have you seen my patches, that also fix bugs in the _all functions?\nhttps://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01053.html","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnQHN4TYXz9ryr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu,  7 Sep 2017 00:01:36 +1000 (AEST)","from localhost ([::1]:36261 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dpata-0004Ii-Pn\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 10:01:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49465)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dpat7-0004F4-1r\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:01:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dpat2-0007hD-7U\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:01:05 -0400","from mx1.redhat.com ([209.132.183.28]:36898)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <eblake@redhat.com>) id 1dpat1-0007gg-V2\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:01:00 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E1F8EC0587F8\n\tfor <qemu-devel@nongnu.org>; Wed,  6 Sep 2017 14:00:58 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A3DA918C5A;\n\tWed,  6 Sep 2017 14:00:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E1F8EC0587F8","To":"Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org","References":"<20170906115143.27451-1-quintela@redhat.com>\n\t<20170906115143.27451-2-quintela@redhat.com>","From":"Eric Blake <eblake@redhat.com>","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<7e71d190-8e49-ca6b-ef44-522100b27b8c@redhat.com>","Date":"Wed, 6 Sep 2017 09:00:51 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170906115143.27451-2-quintela@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"cBfd0pQsELox7cDNIqu3KOtklMJjJwXQd\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 06 Sep 2017 14:00:59 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v7 01/22] Revert \"io: add new\n\tqio_channel_{readv, writev, read, write}_all functions\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1764163,"web_url":"http://patchwork.ozlabs.org/comment/1764163/","msgid":"<87pob351o5.fsf@secure.mitica>","list_archive_url":null,"date":"2017-09-06T14:42:18","subject":"Re: [Qemu-devel] [PATCH v7 01/22] Revert \"io: add new\n\tqio_channel_{readv, writev, read, write}_all functions\"","submitter":{"id":2643,"url":"http://patchwork.ozlabs.org/api/people/2643/","name":"Juan Quintela","email":"quintela@redhat.com"},"content":"Eric Blake <eblake@redhat.com> wrote:\n> On 09/06/2017 06:51 AM, Juan Quintela wrote:\n>> This reverts commit d4622e55883211072621958d39ddaa73483d201e.\n>\n> But with no reason why?  What bugs are you fixing by reverting this?\n\nI put it on the cover letter.  I am investigating *why* it fails on me.\nIt got the thread handed.\n\n>\n>> \n>> Signed-off-by: Juan Quintela <quintela@redhat.com>\n>> ---\n>>  include/io/channel.h       |  90 ---------------------------------------\n>>  io/channel.c               |  94 -----------------------------------------\n>>  tests/io-channel-helpers.c | 102 +++++++++++++++++++++++++++++++++++++++++----\n>>  3 files changed, 93 insertions(+), 193 deletions(-)\n>>\n>\n> Looking ahead, I see 8/22 recreates qio_channel_readv_all (but not\n> qio_channel_read_all); how does that differ from this one?\n>\n> Should you be squashing 1/22 and 8/22 into a single non-revert patch\n> that just fixes bugs on top of what is already in the tree?\n\nMy plan is to fix whatever is there and see why it is failing.\n\n> Also, have you seen my patches, that also fix bugs in the _all functions?\n> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01053.html\n\nNo, I have to take a look, thanks.\n\nThanks, Juan.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=quintela@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnRCP6t7yz9t4t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu,  7 Sep 2017 00:43:13 +1000 (AEST)","from localhost ([::1]:36505 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dpbXs-0002Dj-2U\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 10:43:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37525)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1dpbX7-0001wW-6P\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:42:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1dpbX3-00047S-Vz\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:42:25 -0400","from mx1.redhat.com ([209.132.183.28]:56730)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <quintela@redhat.com>) id 1dpbX3-00045u-QI\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 10:42:21 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id ADA41C047B67\n\tfor <qemu-devel@nongnu.org>; Wed,  6 Sep 2017 14:42:20 +0000 (UTC)","from localhost (ovpn-117-188.ams2.redhat.com [10.36.117.188])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CEE99835EE;\n\tWed,  6 Sep 2017 14:42:19 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com ADA41C047B67","From":"Juan Quintela <quintela@redhat.com>","To":"Eric Blake <eblake@redhat.com>","In-Reply-To":"<7e71d190-8e49-ca6b-ef44-522100b27b8c@redhat.com> (Eric Blake's\n\tmessage of \"Wed, 6 Sep 2017 09:00:51 -0500\")","References":"<20170906115143.27451-1-quintela@redhat.com>\n\t<20170906115143.27451-2-quintela@redhat.com>\n\t<7e71d190-8e49-ca6b-ef44-522100b27b8c@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","Date":"Wed, 06 Sep 2017 16:42:18 +0200","Message-ID":"<87pob351o5.fsf@secure.mitica>","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 06 Sep 2017 14:42:20 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 01/22] Revert \"io: add new\n\tqio_channel_{readv, writev, read, write}_all functions\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Reply-To":"quintela@redhat.com","Cc":"lvivier@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com,\n\tdgilbert@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1764242,"web_url":"http://patchwork.ozlabs.org/comment/1764242/","msgid":"<38c3884d-8e05-596a-acb8-80ae0530910d@redhat.com>","list_archive_url":null,"date":"2017-09-06T16:09:12","subject":"Re: [Qemu-devel] [PATCH v7 01/22] Revert \"io: add new\n\tqio_channel_{readv, writev, read, write}_all functions\"","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/06/2017 09:42 AM, Juan Quintela wrote:\n> Eric Blake <eblake@redhat.com> wrote:\n>> On 09/06/2017 06:51 AM, Juan Quintela wrote:\n>>> This reverts commit d4622e55883211072621958d39ddaa73483d201e.\n>>\n>> But with no reason why?  What bugs are you fixing by reverting this?\n> \n> I put it on the cover letter.  I am investigating *why* it fails on me.\n> It got the thread handed.\n\nThen I think I ran into the same problems as you (NBD was hanging for me\ndue to the nested event loop being called from a coroutine context),...\n\n> \n> My plan is to fix whatever is there and see why it is failing.\n> \n>> Also, have you seen my patches, that also fix bugs in the _all functions?\n>> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01053.html\n> \n> No, I have to take a look, thanks.\n\n...and hopefully my patch helps the hang you were seeing (now in a pull\nrequest:\nhttps://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01338.html).","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnTRy4FXKz9s7c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu,  7 Sep 2017 02:24:14 +1000 (AEST)","from localhost ([::1]:37026 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dpd7c-0006G2-Gb\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 12:24:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43104)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dpctL-0002h2-2A\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:09:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dpctG-0007fi-4N\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:09:27 -0400","from mx1.redhat.com ([209.132.183.28]:47476)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <eblake@redhat.com>) id 1dpctF-0007dL-Rn\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:09:22 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F1F0781DFE\n\tfor <qemu-devel@nongnu.org>; Wed,  6 Sep 2017 16:09:20 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 224405B806;\n\tWed,  6 Sep 2017 16:09:13 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com F1F0781DFE","To":"quintela@redhat.com","References":"<20170906115143.27451-1-quintela@redhat.com>\n\t<20170906115143.27451-2-quintela@redhat.com>\n\t<7e71d190-8e49-ca6b-ef44-522100b27b8c@redhat.com>\n\t<87pob351o5.fsf@secure.mitica>","From":"Eric Blake <eblake@redhat.com>","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<38c3884d-8e05-596a-acb8-80ae0530910d@redhat.com>","Date":"Wed, 6 Sep 2017 11:09:12 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<87pob351o5.fsf@secure.mitica>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"qFbGVQfn5mKejC88lJ4tPGr7xNEeeRLo5\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tWed, 06 Sep 2017 16:09:21 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v7 01/22] Revert \"io: add new\n\tqio_channel_{readv, writev, read, write}_all functions\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"lvivier@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com,\n\tdgilbert@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1764247,"web_url":"http://patchwork.ozlabs.org/comment/1764247/","msgid":"<20170906163205.GX15510@redhat.com>","list_archive_url":null,"date":"2017-09-06T16:32:05","subject":"Re: [Qemu-devel] [PATCH v7 01/22] Revert \"io: add new\n\tqio_channel_{readv, writev, read, write}_all functions\"","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Wed, Sep 06, 2017 at 04:42:18PM +0200, Juan Quintela wrote:\n> Eric Blake <eblake@redhat.com> wrote:\n> > On 09/06/2017 06:51 AM, Juan Quintela wrote:\n> >> This reverts commit d4622e55883211072621958d39ddaa73483d201e.\n> >\n> > But with no reason why?  What bugs are you fixing by reverting this?\n> \n> I put it on the cover letter.  I am investigating *why* it fails on me.\n> It got the thread handed.\n\nYour functions return the number of bytes written. My impl only\nreturns the 0 or -1 on the basis that the caller does not need\nto know how many bytes were written - its always exactly the\namount asked for. You probably need to adjust your code to take\nthat into account.\n\nRegards,\nDaniel","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnTgy5Dd1z9s7c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu,  7 Sep 2017 02:34:38 +1000 (AEST)","from localhost ([::1]:37085 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dpdHg-0006i5-O7\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 12:34:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51064)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <berrange@redhat.com>) id 1dpdFP-0005JR-J7\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:32:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <berrange@redhat.com>) id 1dpdFL-00037K-Ec\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:32:15 -0400","from mx1.redhat.com ([209.132.183.28]:50634)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <berrange@redhat.com>) id 1dpdFL-00036Z-8z\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:32:11 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1EC18C049E31\n\tfor <qemu-devel@nongnu.org>; Wed,  6 Sep 2017 16:32:10 +0000 (UTC)","from redhat.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5DFD85DDA8;\n\tWed,  6 Sep 2017 16:32:07 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1EC18C049E31","Date":"Wed, 6 Sep 2017 17:32:05 +0100","From":"\"Daniel P. Berrange\" <berrange@redhat.com>","To":"Juan Quintela <quintela@redhat.com>","Message-ID":"<20170906163205.GX15510@redhat.com>","References":"<20170906115143.27451-1-quintela@redhat.com>\n\t<20170906115143.27451-2-quintela@redhat.com>\n\t<7e71d190-8e49-ca6b-ef44-522100b27b8c@redhat.com>\n\t<87pob351o5.fsf@secure.mitica>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<87pob351o5.fsf@secure.mitica>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 06 Sep 2017 16:32:10 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 01/22] Revert \"io: add new\n\tqio_channel_{readv, writev, read, write}_all functions\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Reply-To":"\"Daniel P. Berrange\" <berrange@redhat.com>","Cc":"lvivier@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com,\n\tdgilbert@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]