[{"id":1764208,"web_url":"http://patchwork.ozlabs.org/comment/1764208/","msgid":"","list_archive_url":null,"date":"2017-09-06T15:39:18","subject":"Re: [Qemu-devel] [PATCH v4 3/3] watchdog: Allow setting action on\n\tthe fly","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/06/2017 06:24 AM, Michal Privoznik wrote:\n> Currently, the only time that users can set watchdog action is at\n> the start as all we expose is this -watchdog-action command line\n> argument. This is suboptimal when users want to plug the device\n> later via monitor. Alternatively, they might want to change the\n> action for already existing device on the fly.\n> \n> Inspired by: https://bugzilla.redhat.com/show_bug.cgi?id=1447169\n> \n> Signed-off-by: Michal Privoznik \n> ---\n> hw/watchdog/watchdog.c | 8 +++++++-\n> qapi-schema.json | 9 +++++++++\n> 2 files changed, 16 insertions(+), 1 deletion(-)\n> \n\n> +++ b/qapi-schema.json\n> @@ -3143,3 +3143,12 @@\n> # Since 2.9\n> ##\n> { 'command': 'query-vm-generation-id', 'returns': 'GuidInfo' }\n> +\n> +##\n> +# @watchdog-set-action:\n> +#\n> +# Set watchdog action\n> +#\n> +# Since 2.11\n> +##\n> +{ 'command': 'watchdog-set-action', 'data' : {'action': 'WatchdogAction'} }\n\nMarkus went to some effort to sort the documentation output; is plopping\nthis at the end of the file the best location?\n\nOtherwise,\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnST31KWDz9s81\n\tfor ;\n\tThu, 7 Sep 2017 01:40:07 +1000 (AEST)","from localhost ([::1]:36757 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpcQv-0006jZ-6n\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 11:40:05 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60855)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpcQH-0006hm-BW\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:39:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpcQE-0002PW-GS\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:39:25 -0400","from mx1.redhat.com ([209.132.183.28]:59142)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpcQE-0002Ob-6y\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:39:22 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 40541C0587DF\n\tfor ; Wed, 6 Sep 2017 15:39:21 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0720E18C4C;\n\tWed, 6 Sep 2017 15:39:19 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 40541C0587DF","To":"Michal Privoznik , qemu-devel@nongnu.org","References":"\n\t<6f78df0d8af98d89bdae1d189c0e21ba7ca3ead9.1504696921.git.mprivozn@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Wed, 6 Sep 2017 10:39:18 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<6f78df0d8af98d89bdae1d189c0e21ba7ca3ead9.1504696921.git.mprivozn@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"E2ivF3madaae2QtsG6Kj9Gjts3PtIR4JI\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 06 Sep 2017 15:39:21 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v4 3/3] watchdog: Allow setting action on\n\tthe fly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764270,"web_url":"http://patchwork.ozlabs.org/comment/1764270/","msgid":"<8760cvsq8b.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-09-06T17:15:32","subject":"Re: [Qemu-devel] [PATCH v4 3/3] watchdog: Allow setting action on\n\tthe fly","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Eric Blake writes:\n\n> On 09/06/2017 06:24 AM, Michal Privoznik wrote:\n>> Currently, the only time that users can set watchdog action is at\n>> the start as all we expose is this -watchdog-action command line\n>> argument. This is suboptimal when users want to plug the device\n>> later via monitor. Alternatively, they might want to change the\n>> action for already existing device on the fly.\n>> \n>> Inspired by: https://bugzilla.redhat.com/show_bug.cgi?id=1447169\n>> \n>> Signed-off-by: Michal Privoznik \n>> ---\n>> hw/watchdog/watchdog.c | 8 +++++++-\n>> qapi-schema.json | 9 +++++++++\n>> 2 files changed, 16 insertions(+), 1 deletion(-)\n>> \n>\n>> +++ b/qapi-schema.json\n>> @@ -3143,3 +3143,12 @@\n>> # Since 2.9\n>> ##\n>> { 'command': 'query-vm-generation-id', 'returns': 'GuidInfo' }\n>> +\n>> +##\n>> +# @watchdog-set-action:\n>> +#\n>> +# Set watchdog action\n>> +#\n>> +# Since 2.11\n>> +##\n>> +{ 'command': 'watchdog-set-action', 'data' : {'action': 'WatchdogAction'} }\n>\n> Markus went to some effort to sort the documentation output; is plopping\n> this at the end of the file the best location?\n\nThis patch won't regress any of my work, as I only moved stuff out of\nqapi-schema-json, I didn't reorder within.\n\n> Otherwise,\n> Reviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnVbj6pP8z9t2d\n\tfor ;\n\tThu, 7 Sep 2017 03:16:01 +1000 (AEST)","from localhost ([::1]:37224 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpdvk-0004bT-3O\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 13:16:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34333)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpdvQ-0004bH-1y\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 13:15:41 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpdvL-0005vc-1y\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 13:15:39 -0400","from mx1.redhat.com ([209.132.183.28]:45334)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpdvK-0005vK-Rw\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 13:15:34 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BFBCBC049D7F\n\tfor ; Wed, 6 Sep 2017 17:15:33 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 84C21835EB;\n\tWed, 6 Sep 2017 17:15:33 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 07B871138645; Wed, 6 Sep 2017 19:15:32 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BFBCBC049D7F","From":"Markus Armbruster ","To":"Eric Blake ","References":"\n\t<6f78df0d8af98d89bdae1d189c0e21ba7ca3ead9.1504696921.git.mprivozn@redhat.com>\n\t","Date":"Wed, 06 Sep 2017 19:15:32 +0200","In-Reply-To":" (Eric Blake's\n\tmessage of \"Wed, 6 Sep 2017 10:39:18 -0500\")","Message-ID":"<8760cvsq8b.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 06 Sep 2017 17:15:33 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 3/3] watchdog: Allow setting action on\n\tthe fly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michal Privoznik , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]