[{"id":1764133,"web_url":"http://patchwork.ozlabs.org/comment/1764133/","msgid":"<20170906140605.GD11864@lunn.ch>","list_archive_url":null,"date":"2017-09-06T14:06:05","subject":"Re: [PATCH net 3/4] lan78xx: Fix for eeprom read/write when device\n\tautosuspend","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"Hi Nisar\n\n> +\telse if ((ee->magic == LAN78XX_EEPROM_MAGIC) &&\n> +\t\t (ee->offset >= 0 && ee->offset < MAX_EEPROM_SIZE) &&\n> +\t\t (ee->len > 0 && (ee->offset + ee->len) <= MAX_EEPROM_SIZE))\n> +\t\tret = lan78xx_write_raw_eeprom(dev, ee->offset, ee->len, data);\n\nThis change does not appear to have anything to do with auto suspend.\nPlease make it a separate patch.\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnQNj24TGz9s7g\n\tfor ;\n\tThu, 7 Sep 2017 00:06:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932258AbdIFOGK (ORCPT );\n\tWed, 6 Sep 2017 10:06:10 -0400","from vps0.lunn.ch ([178.209.37.122]:58702 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S932158AbdIFOGI (ORCPT );\n\tWed, 6 Sep 2017 10:06:08 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dpaxx-0003iQ-E0; Wed, 06 Sep 2017 16:06:05 +0200"],"Date":"Wed, 6 Sep 2017 16:06:05 +0200","From":"Andrew Lunn ","To":"Nisar.Sayed@microchip.com","Cc":"davem@davemloft.net, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net 3/4] lan78xx: Fix for eeprom read/write when device\n\tautosuspend","Message-ID":"<20170906140605.GD11864@lunn.ch>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764279,"web_url":"http://patchwork.ozlabs.org/comment/1764279/","msgid":"","list_archive_url":null,"date":"2017-09-06T17:34:58","subject":"RE: [PATCH net 3/4] lan78xx: Fix for eeprom read/write when device\n\tautosuspend","submitter":{"id":71648,"url":"http://patchwork.ozlabs.org/api/people/71648/","name":"Nisar Sayed","email":"Nisar.Sayed@microchip.com"},"content":"Thanks, will make separate patch.\n\n> Hi Nisar\n> \n> > +\telse if ((ee->magic == LAN78XX_EEPROM_MAGIC) &&\n> > +\t\t (ee->offset >= 0 && ee->offset < MAX_EEPROM_SIZE) &&\n> > +\t\t (ee->len > 0 && (ee->offset + ee->len) <=\n> MAX_EEPROM_SIZE))\n> > +\t\tret = lan78xx_write_raw_eeprom(dev, ee->offset, ee->len,\n> data);\n> \n> This change does not appear to have anything to do with auto suspend.\n> Please make it a separate patch.\n> \n> Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnW2g0DKZz9t3Z\n\tfor ;\n\tThu, 7 Sep 2017 03:35:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751938AbdIFRfr convert rfc822-to-8bit (ORCPT\n\t);\n\tWed, 6 Sep 2017 13:35:47 -0400","from esa3.microchip.iphmx.com ([68.232.153.233]:31678 \"EHLO\n\tesa3.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751345AbdIFRfp (ORCPT\n\t); Wed, 6 Sep 2017 13:35:45 -0400","from exsmtp03.microchip.com (HELO email.microchip.com)\n\t([198.175.253.49])\n\tby esa3.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t06 Sep 2017 10:34:59 -0700","from CHN-SV-EXMX03.mchp-main.com ([fe80::58f5:b949:4b1:3df4]) by\n\tchn-sv-exch03.mchp-main.com ([fe80::9916:1afa:df82:7a64%13]) with\n\tmapi id 14.03.0352.000; Wed, 6 Sep 2017 10:34:59 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,354,1500966000\"; d=\"scan'208\";a=\"6813387\"","From":"","To":"","CC":", ,\n\t","Subject":"RE: [PATCH net 3/4] lan78xx: Fix for eeprom read/write when device\n\tautosuspend","Thread-Topic":"[PATCH net 3/4] lan78xx: Fix for eeprom read/write when device\n\tautosuspend","Thread-Index":"AdMm/NwKvobPZ4jbS72W8IMpSqVwUQAVxfCAAAdmCcA=","Date":"Wed, 6 Sep 2017 17:34:58 +0000","Message-ID":"","References":"\n\t<20170906140605.GD11864@lunn.ch>","In-Reply-To":"<20170906140605.GD11864@lunn.ch>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.10.215.90]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]