[{"id":1764130,"web_url":"http://patchwork.ozlabs.org/comment/1764130/","msgid":"<20170906140233.GC11864@lunn.ch>","list_archive_url":null,"date":"2017-09-06T14:02:33","subject":"Re: [PATCH net 2/4] lan78xx: Add fixed_phy device support for\n\tLAN7801 device","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Wed, Sep 06, 2017 at 10:51:44AM +0000, Nisar.Sayed@microchip.com wrote:\n> From: Nisar Sayed \n> \n> Add fixed_phy device support for LAN7801 device\n> \n> When LAN7801 device connected to PHY Device which does not have\n> MDIO/MDC access, fixex_phy device will be added.\n\nPlease try to find a way to do this without all the #ifdefs. They can\nbe acceptable in header files, but should be avoided in .c files.\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnQJc0DZfz9ryr\n\tfor ;\n\tThu, 7 Sep 2017 00:02:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932308AbdIFOCi (ORCPT );\n\tWed, 6 Sep 2017 10:02:38 -0400","from vps0.lunn.ch ([178.209.37.122]:58688 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S932284AbdIFOCg (ORCPT );\n\tWed, 6 Sep 2017 10:02:36 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dpauX-0003dl-Fr; Wed, 06 Sep 2017 16:02:33 +0200"],"Date":"Wed, 6 Sep 2017 16:02:33 +0200","From":"Andrew Lunn ","To":"Nisar.Sayed@microchip.com","Cc":"davem@davemloft.net, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net 2/4] lan78xx: Add fixed_phy device support for\n\tLAN7801 device","Message-ID":"<20170906140233.GC11864@lunn.ch>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764278,"web_url":"http://patchwork.ozlabs.org/comment/1764278/","msgid":"","list_archive_url":null,"date":"2017-09-06T17:34:54","subject":"RE: [PATCH net 2/4] lan78xx: Add fixed_phy device support for\n\tLAN7801 device","submitter":{"id":71648,"url":"http://patchwork.ozlabs.org/api/people/71648/","name":"Nisar Sayed","email":"Nisar.Sayed@microchip.com"},"content":"Thanks Andrew, will try to change as suggested.\n\n> On Wed, Sep 06, 2017 at 10:51:44AM +0000, Nisar.Sayed@microchip.com\n> wrote:\n> > From: Nisar Sayed \n> >\n> > Add fixed_phy device support for LAN7801 device\n> >\n> > When LAN7801 device connected to PHY Device which does not have\n> > MDIO/MDC access, fixex_phy device will be added.\n> \n> Please try to find a way to do this without all the #ifdefs. They can be\n> acceptable in header files, but should be avoided in .c files.\n> \n> Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnW2W4sv1z9t2d\n\tfor ;\n\tThu, 7 Sep 2017 03:35:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751399AbdIFRfl convert rfc822-to-8bit (ORCPT\n\t);\n\tWed, 6 Sep 2017 13:35:41 -0400","from esa4.microchip.iphmx.com ([68.232.154.123]:38093 \"EHLO\n\tesa4.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751163AbdIFRfk (ORCPT\n\t); Wed, 6 Sep 2017 13:35:40 -0400","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa4.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t06 Sep 2017 10:34:59 -0700","from CHN-SV-EXMX03.mchp-main.com ([fe80::58f5:b949:4b1:3df4]) by\n\tCHN-SV-EXCH05.mchp-main.com ([fe80::c1bf:7679:c1f8:4560%15]) with\n\tmapi id 14.03.0352.000; Wed, 6 Sep 2017 10:34:55 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,354,1500966000\"; d=\"scan'208\";a=\"6593543\"","From":"","To":"","CC":", ,\n\t","Subject":"RE: [PATCH net 2/4] lan78xx: Add fixed_phy device support for\n\tLAN7801 device","Thread-Topic":"[PATCH net 2/4] lan78xx: Add fixed_phy device support for\n\tLAN7801 device","Thread-Index":"AdMm/LZOqnS7B9DcRRKnIfFx0SYr9gAVr8iAAAdOnoA=","Date":"Wed, 6 Sep 2017 17:34:54 +0000","Message-ID":"","References":"\n\t<20170906140233.GC11864@lunn.ch>","In-Reply-To":"<20170906140233.GC11864@lunn.ch>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.10.215.90]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]