[{"id":1764079,"web_url":"http://patchwork.ozlabs.org/comment/1764079/","msgid":"","list_archive_url":null,"date":"2017-09-06T12:50:19","subject":"Re: [PATCH] tipc: remove unnecessary call to dev_net()","submitter":{"id":15842,"url":"http://patchwork.ozlabs.org/api/people/15842/","name":"Ying Xue","email":"ying.xue@windriver.com"},"content":"On 09/06/2017 05:08 PM, Kleber Sacilotto de Souza wrote:\n> The net device is already stored in the 'net' variable, so no need to call\n> dev_net() again.\n> \n> Signed-off-by: Kleber Sacilotto de Souza \n\nAcked-by: Ying Xue \n\n> ---\n> net/tipc/bearer.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c\n> index 89cd061c4468..6d6395e0904e 100644\n> --- a/net/tipc/bearer.c\n> +++ b/net/tipc/bearer.c\n> @@ -661,7 +661,7 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt,\n> \t\tbreak;\n> \tcase NETDEV_UNREGISTER:\n> \tcase NETDEV_CHANGENAME:\n> -\t\tbearer_disable(dev_net(dev), b);\n> +\t\tbearer_disable(net, b);\n> \t\tbreak;\n> \t}\n> \treturn NOTIFY_OK;\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnNlF49YLz9sBd\n\tfor ;\n\tWed, 6 Sep 2017 22:52:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754083AbdIFMwG (ORCPT );\n\tWed, 6 Sep 2017 08:52:06 -0400","from mail1.windriver.com ([147.11.146.13]:59691 \"EHLO\n\tmail1.windriver.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754000AbdIFMwG (ORCPT\n\t); Wed, 6 Sep 2017 08:52:06 -0400","from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com\n\t[147.11.189.40])\n\tby mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id v86CpTVh023566\n\t(version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL);\n\tWed, 6 Sep 2017 05:51:29 -0700 (PDT)","from [128.224.155.110] (128.224.155.110) by ALA-HCA.corp.ad.wrs.com\n\t(147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.361.1;\n\tWed, 6 Sep 2017 05:51:28 -0700"],"Subject":"Re: [PATCH] tipc: remove unnecessary call to dev_net()","To":"Kleber Sacilotto de Souza ,\n\t","CC":"Jon Maloy ","References":"<20170906090806.20931-1-kleber.souza@canonical.com>","From":"Ying Xue ","Message-ID":"","Date":"Wed, 6 Sep 2017 20:50:19 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170906090806.20931-1-kleber.souza@canonical.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[128.224.155.110]","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764497,"web_url":"http://patchwork.ozlabs.org/comment/1764497/","msgid":"<20170906.212613.52886948289511744.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-07T04:26:13","subject":"Re: [PATCH] tipc: remove unnecessary call to dev_net()","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Kleber Sacilotto de Souza \nDate: Wed, 6 Sep 2017 11:08:06 +0200\n\n> The net device is already stored in the 'net' variable, so no need to call\n> dev_net() again.\n> \n> Signed-off-by: Kleber Sacilotto de Souza \n\nApplied, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnnT73y4Pz9sNd\n\tfor ;\n\tThu, 7 Sep 2017 14:26:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753368AbdIGE0Q (ORCPT );\n\tThu, 7 Sep 2017 00:26:16 -0400","from shards.monkeyblade.net ([184.105.139.130]:46680 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750742AbdIGE0P (ORCPT\n\t); Thu, 7 Sep 2017 00:26:15 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 405961019A684;\n\tWed, 6 Sep 2017 21:26:14 -0700 (PDT)"],"Date":"Wed, 06 Sep 2017 21:26:13 -0700 (PDT)","Message-Id":"<20170906.212613.52886948289511744.davem@davemloft.net>","To":"kleber.souza@canonical.com","Cc":"netdev@vger.kernel.org, jon.maloy@ericsson.com, ying.xue@windriver.com","Subject":"Re: [PATCH] tipc: remove unnecessary call to dev_net()","From":"David Miller ","In-Reply-To":"<20170906090806.20931-1-kleber.souza@canonical.com>","References":"<20170906090806.20931-1-kleber.souza@canonical.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Wed, 06 Sep 2017 21:26:14 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]