[{"id":1763938,"web_url":"http://patchwork.ozlabs.org/comment/1763938/","msgid":"<20170906090442.GJ15510@redhat.com>","list_archive_url":null,"date":"2017-09-06T09:04:42","subject":"Re: [Qemu-devel] [PATCH v3 2/2] watchdog: Allow setting action on\n\tthe fly","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrange","email":"berrange@redhat.com"},"content":"On Wed, Sep 06, 2017 at 10:58:54AM +0200, Michal Privoznik wrote:\n> Currently, the only time that users can set watchdog action is at\n> the start as all we expose is this -watchdog-action command line\n> argument. This is suboptimal when users want to plug the device\n> later via monitor. Alternatively, they might want to change the\n> action for already existing device on the fly.\n> \n> At the same time, drop local redefinition of the actions enum in\n> watchdog.h in favour of the ones defined in schema and thus kills\n> code duplication.\n\nNit-pick - I'd suggest 2 separat patches - one that drops the enum\nredefinition, and the second which adds the new monitor command.\nThat way you separate no-op refactoring, from new features.\n\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnHjv0x6Pz9s7c\n\tfor ;\n\tWed, 6 Sep 2017 19:05:39 +1000 (AEST)","from localhost ([::1]:35093 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpWHB-0006mJ-7J\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 05:05:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60145)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpWGO-0006cF-8Y\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 05:04:54 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpWGN-0003Vt-7d\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 05:04:48 -0400","from mx1.redhat.com ([209.132.183.28]:46792)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpWGN-0003VE-18\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 05:04:47 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 032B74E33B\n\tfor ; Wed, 6 Sep 2017 09:04:45 +0000 (UTC)","from redhat.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 4FEB719C99;\n\tWed, 6 Sep 2017 09:04:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 032B74E33B","Date":"Wed, 6 Sep 2017 10:04:42 +0100","From":"\"Daniel P. Berrange\" ","To":"Michal Privoznik ","Message-ID":"<20170906090442.GJ15510@redhat.com>","References":"\n\t<5defe9fcfacaae68ebbdb76b3ec4b565bf4e7d1c.1504688205.git.mprivozn@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<5defe9fcfacaae68ebbdb76b3ec4b565bf4e7d1c.1504688205.git.mprivozn@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 06 Sep 2017 09:04:45 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 2/2] watchdog: Allow setting action on\n\tthe fly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"qemu-devel@nongnu.org, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763947,"web_url":"http://patchwork.ozlabs.org/comment/1763947/","msgid":"","list_archive_url":null,"date":"2017-09-06T09:20:14","subject":"Re: [Qemu-devel] [PATCH v3 2/2] watchdog: Allow setting action on\n\tthe fly","submitter":{"id":11888,"url":"http://patchwork.ozlabs.org/api/people/11888/","name":"Michal Prívozník","email":"mprivozn@redhat.com"},"content":"On 09/06/2017 11:04 AM, Daniel P. Berrange wrote:\n> On Wed, Sep 06, 2017 at 10:58:54AM +0200, Michal Privoznik wrote:\n>> Currently, the only time that users can set watchdog action is at\n>> the start as all we expose is this -watchdog-action command line\n>> argument. This is suboptimal when users want to plug the device\n>> later via monitor. Alternatively, they might want to change the\n>> action for already existing device on the fly.\n>>\n>> At the same time, drop local redefinition of the actions enum in\n>> watchdog.h in favour of the ones defined in schema and thus kills\n>> code duplication.\n> \n> Nit-pick - I'd suggest 2 separat patches - one that drops the enum\n> redefinition, and the second which adds the new monitor command.\n> That way you separate no-op refactoring, from new features.\n\nSure. We prefer that in libvirt too. Let me respin v4.\n\nMichal","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mprivozn@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnJ3N0QJBz9s82\n\tfor ;\n\tWed, 6 Sep 2017 19:20:46 +1000 (AEST)","from localhost ([::1]:35133 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpWVo-0002Sd-EI\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 05:20:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38213)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpWVT-0002ST-GO\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 05:20:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpWVN-0001p4-Kc\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 05:20:23 -0400","from mx1.redhat.com ([209.132.183.28]:34714)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpWVN-0001oq-ER\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 05:20:17 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2ACE62027B\n\tfor ; Wed, 6 Sep 2017 09:20:16 +0000 (UTC)","from [10.43.2.192] (unknown [10.43.2.192])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 51BCC17BAF;\n\tWed, 6 Sep 2017 09:20:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2ACE62027B","To":"\"Daniel P. Berrange\" ","References":"\n\t<5defe9fcfacaae68ebbdb76b3ec4b565bf4e7d1c.1504688205.git.mprivozn@redhat.com>\n\t<20170906090442.GJ15510@redhat.com>","From":"Michal Privoznik ","Message-ID":"","Date":"Wed, 6 Sep 2017 11:20:14 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170906090442.GJ15510@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 06 Sep 2017 09:20:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 2/2] watchdog: Allow setting action on\n\tthe fly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]