[{"id":1763917,"web_url":"http://patchwork.ozlabs.org/comment/1763917/","msgid":"","list_archive_url":null,"date":"2017-09-06T08:42:02","subject":"Re: [U-Boot] [PATCH] rockchip: pinctrl: use fdtdec_get_int_array()\n\tto get interrupt","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"> On 6 Sep 2017, at 10:36, Kever Yang wrote:\n> \n> Not all the udevice have a available DT node, eg. rksdmmc@ff500000.blk\n> which add by mmc_bind(), if we use dev_read_u32_array(), the interface\n> will use the ofnode directly and end with:\n> \tassert(ofnode_valid(node));\n> \n> Use fdtdec_get_int_array() instead.\n\nChanging this will affect livetree (at least it broke livetree support for me in my testing).\nLooks like we will need to address the underlying issue of dynamically added nodes with the dev_* functions.\n\n> \n> Signed-off-by: Kever Yang \n> ---\n> \n> drivers/pinctrl/rockchip/pinctrl_rk3036.c | 3 ++-\n> drivers/pinctrl/rockchip/pinctrl_rk3188.c | 3 ++-\n> drivers/pinctrl/rockchip/pinctrl_rk3288.c | 3 ++-\n> drivers/pinctrl/rockchip/pinctrl_rk3328.c | 3 ++-\n> drivers/pinctrl/rockchip/pinctrl_rk3399.c | 3 ++-\n> drivers/pinctrl/rockchip/pinctrl_rv1108.c | 3 ++-\n> 6 files changed, 12 insertions(+), 6 deletions(-)\n> \n> diff --git a/drivers/pinctrl/rockchip/pinctrl_rk3036.c b/drivers/pinctrl/rockchip/pinctrl_rk3036.c\n> index 94f6d7a..9215d6c 100644\n> --- a/drivers/pinctrl/rockchip/pinctrl_rk3036.c\n> +++ b/drivers/pinctrl/rockchip/pinctrl_rk3036.c\n> @@ -193,7 +193,8 @@ static int rk3036_pinctrl_get_periph_id(struct udevice *dev,\n> \tu32 cell[3];\n> \tint ret;\n> \n> -\tret = dev_read_u32_array(periph, \"interrupts\", cell, ARRAY_SIZE(cell));\n> +\tret = fdtdec_get_int_array(gd->fdt_blob, dev_of_offset(periph),\n> +\t\t\t\t \"interrupts\", cell, ARRAY_SIZE(cell));\n> \tif (ret < 0)\n> \t\treturn -EINVAL;\n> \n> diff --git a/drivers/pinctrl/rockchip/pinctrl_rk3188.c b/drivers/pinctrl/rockchip/pinctrl_rk3188.c\n> index 692d8e2..65c1f66 100644\n> --- a/drivers/pinctrl/rockchip/pinctrl_rk3188.c\n> +++ b/drivers/pinctrl/rockchip/pinctrl_rk3188.c\n> @@ -370,7 +370,8 @@ static int rk3188_pinctrl_get_periph_id(struct udevice *dev,\n> \tu32 cell[3];\n> \tint ret;\n> \n> -\tret = dev_read_u32_array(periph, \"interrupts\", cell, ARRAY_SIZE(cell));\n> +\tret = fdtdec_get_int_array(gd->fdt_blob, dev_of_offset(periph),\n> +\t\t\t\t \"interrupts\", cell, ARRAY_SIZE(cell));\n> \tif (ret < 0)\n> \t\treturn -EINVAL;\n> \n> diff --git a/drivers/pinctrl/rockchip/pinctrl_rk3288.c b/drivers/pinctrl/rockchip/pinctrl_rk3288.c\n> index 3c9ae97..ab64056 100644\n> --- a/drivers/pinctrl/rockchip/pinctrl_rk3288.c\n> +++ b/drivers/pinctrl/rockchip/pinctrl_rk3288.c\n> @@ -595,7 +595,8 @@ static int rk3288_pinctrl_get_periph_id(struct udevice *dev,\n> \tu32 cell[3];\n> \tint ret;\n> \n> -\tret = dev_read_u32_array(periph, \"interrupts\", cell, ARRAY_SIZE(cell));\n> +\tret = fdtdec_get_int_array(gd->fdt_blob, dev_of_offset(periph),\n> +\t\t\t\t \"interrupts\", cell, ARRAY_SIZE(cell));\n> \tif (ret < 0)\n> \t\treturn -EINVAL;\n> \n> diff --git a/drivers/pinctrl/rockchip/pinctrl_rk3328.c b/drivers/pinctrl/rockchip/pinctrl_rk3328.c\n> index c74163e..f3e7eec 100644\n> --- a/drivers/pinctrl/rockchip/pinctrl_rk3328.c\n> +++ b/drivers/pinctrl/rockchip/pinctrl_rk3328.c\n> @@ -249,7 +249,8 @@ static int rk3328_pinctrl_get_periph_id(struct udevice *dev,\n> \tu32 cell[3];\n> \tint ret;\n> \n> -\tret = dev_read_u32_array(periph, \"interrupts\", cell, ARRAY_SIZE(cell));\n> +\tret = fdtdec_get_int_array(gd->fdt_blob, dev_of_offset(periph),\n> +\t\t\t\t \"interrupts\", cell, ARRAY_SIZE(cell));\n> \tif (ret < 0)\n> \t\treturn -EINVAL;\n> \n> diff --git a/drivers/pinctrl/rockchip/pinctrl_rk3399.c b/drivers/pinctrl/rockchip/pinctrl_rk3399.c\n> index cab268c..d93b903 100644\n> --- a/drivers/pinctrl/rockchip/pinctrl_rk3399.c\n> +++ b/drivers/pinctrl/rockchip/pinctrl_rk3399.c\n> @@ -350,7 +350,8 @@ static int rk3399_pinctrl_get_periph_id(struct udevice *dev,\n> \tu32 cell[3];\n> \tint ret;\n> \n> -\tret = dev_read_u32_array(periph, \"interrupts\", cell, ARRAY_SIZE(cell));\n> +\tret = fdtdec_get_int_array(gd->fdt_blob, dev_of_offset(periph),\n> +\t\t\t\t \"interrupts\", cell, ARRAY_SIZE(cell));\n> \tif (ret < 0)\n> \t\treturn -EINVAL;\n> \n> diff --git a/drivers/pinctrl/rockchip/pinctrl_rv1108.c b/drivers/pinctrl/rockchip/pinctrl_rv1108.c\n> index cda94f4..bdf3910 100644\n> --- a/drivers/pinctrl/rockchip/pinctrl_rv1108.c\n> +++ b/drivers/pinctrl/rockchip/pinctrl_rv1108.c\n> @@ -108,7 +108,8 @@ static int rv1108_pinctrl_get_periph_id(struct udevice *dev,\n> \tu32 cell[3];\n> \tint ret;\n> \n> -\tret = dev_read_u32_array(periph, \"interrupts\", cell, ARRAY_SIZE(cell));\n> +\tret = fdtdec_get_int_array(gd->fdt_blob, dev_of_offset(periph),\n> +\t\t\t\t \"interrupts\", cell, ARRAY_SIZE(cell));\n> \tif (ret < 0)\n> \t\treturn -EINVAL;\n> \n> -- \n> 1.9.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnHBs5tJhz9s9Y\n\tfor ;\n\tWed, 6 Sep 2017 18:42:13 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 84431C21E66; Wed, 6 Sep 2017 08:42:10 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1B2DFC21D55;\n\tWed, 6 Sep 2017 08:42:08 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid EFAF8C21C45; Wed, 6 Sep 2017 08:42:05 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id A9719C21C3F\n\tfor ; Wed, 6 Sep 2017 08:42:05 +0000 (UTC)","from 89-104-28-141.customer.bnet.at ([89.104.28.141]:63232\n\thelo=[192.168.2.129]) by mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from )\n\tid 1dpVuN-0002fe-C0; Wed, 06 Sep 2017 10:42:03 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"*","X-Spam-Status":"No, score=1.0 required=5.0 tests=HK_NAME_DR autolearn=no\n\tautolearn_force=no version=3.4.0","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"\"Dr. Philipp Tomsich\" ","In-Reply-To":"<1504686995-30345-1-git-send-email-kever.yang@rock-chips.com>","Date":"Wed, 6 Sep 2017 10:42:02 +0200","Message-Id":"","References":"<1504686995-30345-1-git-send-email-kever.yang@rock-chips.com>","To":"Kever Yang ","X-Mailer":"Apple Mail (2.3273)","Cc":"U-Boot Mailing List ,\n\tRomain Perier ,\n\tAndy Yan ,\n\tWilliam Zhang ","Subject":"Re: [U-Boot] [PATCH] rockchip: pinctrl: use fdtdec_get_int_array()\n\tto get interrupt","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]