[{"id":1764452,"web_url":"http://patchwork.ozlabs.org/comment/1764452/","msgid":"<1504746798.3922.80.camel@intel.com>","list_archive_url":null,"date":"2017-09-07T01:13:18","subject":"Re: [Intel-wired-lan] [PATCH net 2/2] i40e: Avoid some useless\n\tvariables and initializers in nvm functions","submitter":{"id":473,"url":"http://patchwork.ozlabs.org/api/people/473/","name":"Kirsher, Jeffrey T","email":"jeffrey.t.kirsher@intel.com"},"content":"On Wed, 2017-09-06 at 10:11 +0200, Stefano Brivio wrote:\n> Fixes: 09f79fd49d94 (\"i40e: avoid NVM acquire deadlock during NVM\n> update\")\n> Signed-off-by: Stefano Brivio \n> ---\n> drivers/net/ethernet/intel/i40e/i40e_nvm.c | 20 +++++++-------------\n> 1 file changed, 7 insertions(+), 13 deletions(-)\n\nThis is NOT a fix, it is a coding style preference whether or not you\nlike multiple returns or a single return in functions. I do not mind\npicking this up for net-next (4.15 kernel), but this does not qualify\nfor a fix for Dave's net tree.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnjBl4LvRz9sCZ\n\tfor ;\n\tThu, 7 Sep 2017 11:13:34 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 61EF089B1F;\n\tThu, 7 Sep 2017 01:13:32 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NFRbqXJVzO5d; Thu, 7 Sep 2017 01:13:31 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BA30389AF3;\n\tThu, 7 Sep 2017 01:13:31 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id B0ABA1C0021\n\tfor ;\n\tThu, 7 Sep 2017 01:13:29 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A7DF081D7E\n\tfor ;\n\tThu, 7 Sep 2017 01:13:29 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YoxhZrfOyGT2 for ;\n\tThu, 7 Sep 2017 01:13:28 +0000 (UTC)","from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 5F68C81C32\n\tfor ;\n\tThu, 7 Sep 2017 01:13:28 +0000 (UTC)","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga105.jf.intel.com with ESMTP; 06 Sep 2017 18:13:27 -0700","from nurashix-mobl1.gar.corp.intel.com ([10.254.78.137])\n\tby fmsmga002.fm.intel.com with ESMTP; 06 Sep 2017 18:13:27 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,356,1500966000\"; \n\td=\"asc'?scan'208\";a=\"1215708462\"","Message-ID":"<1504746798.3922.80.camel@intel.com>","From":"Jeff Kirsher ","To":"Stefano Brivio , netdev@vger.kernel.org, \n\tintel-wired-lan@lists.osuosl.org","Date":"Wed, 06 Sep 2017 18:13:18 -0700","In-Reply-To":"","References":"\n\t","X-Mailer":"Evolution 3.24.5 ","Mime-Version":"1.0","Cc":"\"David S . Miller\" ","Subject":"Re: [Intel-wired-lan] [PATCH net 2/2] i40e: Avoid some useless\n\tvariables and initializers in nvm functions","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1982588002302085079==\"","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1766457,"web_url":"http://patchwork.ozlabs.org/comment/1766457/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9F4D@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-11T18:43:36","subject":"Re: [Intel-wired-lan] [PATCH net 2/2] i40e: Avoid some\n\tuseless\tvariables and initializers in nvm functions","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Stefano Brivio\n> Sent: Wednesday, September 6, 2017 1:12 AM\n> To: Kirsher, Jeffrey T ;\n> netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org\n> Cc: David S . Miller \n> Subject: [Intel-wired-lan] [PATCH net 2/2] i40e: Avoid some useless variables\n> and initializers in nvm functions\n> \n> Fixes: 09f79fd49d94 (\"i40e: avoid NVM acquire deadlock during NVM\n> update\")\n> Signed-off-by: Stefano Brivio \n> ---\n> drivers/net/ethernet/intel/i40e/i40e_nvm.c | 20 +++++++-------------\n> 1 file changed, 7 insertions(+), 13 deletions(-)\n\nTested-by: Andrew Bowers ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrcJc3s7Wz9sPt\n\tfor ;\n\tTue, 12 Sep 2017 04:43:44 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 794D982A0F;\n\tMon, 11 Sep 2017 18:43:42 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6HvCNJ04JgQj; Mon, 11 Sep 2017 18:43:40 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DC1AE8284B;\n\tMon, 11 Sep 2017 18:43:40 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 038181C1539\n\tfor ;\n\tMon, 11 Sep 2017 18:43:39 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F098582601\n\tfor ;\n\tMon, 11 Sep 2017 18:43:38 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Omh8lHdQgBWK for ;\n\tMon, 11 Sep 2017 18:43:38 +0000 (UTC)","from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 64BE0825D5\n\tfor ;\n\tMon, 11 Sep 2017 18:43:38 +0000 (UTC)","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga104.jf.intel.com with ESMTP; 11 Sep 2017 11:43:37 -0700","from orsmsx110.amr.corp.intel.com ([10.22.240.8])\n\tby fmsmga001.fm.intel.com with ESMTP; 11 Sep 2017 11:43:37 -0700","from orsmsx111.amr.corp.intel.com (10.22.240.12) by\n\tORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Mon, 11 Sep 2017 11:43:37 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.142]) by\n\tORSMSX111.amr.corp.intel.com ([169.254.12.101]) with mapi id\n\t14.03.0319.002; Mon, 11 Sep 2017 11:43:36 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,379,1500966000\"; d=\"scan'208\";\n\ta=\"1193900488\"","From":"\"Bowers, AndrewX\" ","To":"\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[Intel-wired-lan] [PATCH net 2/2] i40e: Avoid some useless\n\tvariables and initializers in nvm functions","Thread-Index":"AQHTJufnUnrvxeaoKU2p9eoFPQ5k8KKwDdnA","Date":"Mon, 11 Sep 2017 18:43:36 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9F4D@ORSMSX104.amr.corp.intel.com>","References":"\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTZhODZjNWItZWRlZS00MzUxLWE0ZTItY2MyZmZlNzg0N2NjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikw1UlwvMUFSZUxCZVQ1dmdTSmUwQWxaMlVPOTlNWW5OMXNJek0xSFBnQndVPSJ9","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.138]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [PATCH net 2/2] i40e: Avoid some\n\tuseless\tvariables and initializers in nvm functions","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]