[{"id":1764451,"web_url":"http://patchwork.ozlabs.org/comment/1764451/","msgid":"<1504746798.3922.80.camel@intel.com>","list_archive_url":null,"date":"2017-09-07T01:13:18","subject":"Re: [PATCH net 2/2] i40e: Avoid some useless variables and\n\tinitializers in nvm functions","submitter":{"id":473,"url":"http://patchwork.ozlabs.org/api/people/473/","name":"Kirsher, Jeffrey T","email":"jeffrey.t.kirsher@intel.com"},"content":"On Wed, 2017-09-06 at 10:11 +0200, Stefano Brivio wrote:\n> Fixes: 09f79fd49d94 (\"i40e: avoid NVM acquire deadlock during NVM\n> update\")\n> Signed-off-by: Stefano Brivio \n> ---\n> drivers/net/ethernet/intel/i40e/i40e_nvm.c | 20 +++++++-------------\n> 1 file changed, 7 insertions(+), 13 deletions(-)\n\nThis is NOT a fix, it is a coding style preference whether or not you\nlike multiple returns or a single return in functions. I do not mind\npicking this up for net-next (4.15 kernel), but this does not qualify\nfor a fix for Dave's net tree.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnjBh59MSz9sCZ\n\tfor ;\n\tThu, 7 Sep 2017 11:13:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752856AbdIGBN2 (ORCPT );\n\tWed, 6 Sep 2017 21:13:28 -0400","from mga01.intel.com ([192.55.52.88]:18454 \"EHLO mga01.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752679AbdIGBN1 (ORCPT );\n\tWed, 6 Sep 2017 21:13:27 -0400","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Sep 2017 18:13:27 -0700","from nurashix-mobl1.gar.corp.intel.com ([10.254.78.137])\n\tby fmsmga002.fm.intel.com with ESMTP; 06 Sep 2017 18:13:27 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,356,1500966000\"; \n\td=\"asc'?scan'208\";a=\"1215708462\"","Message-ID":"<1504746798.3922.80.camel@intel.com>","Subject":"Re: [PATCH net 2/2] i40e: Avoid some useless variables and\n\tinitializers in nvm functions","From":"Jeff Kirsher ","To":"Stefano Brivio , netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org","Cc":"\"David S . Miller\" ,\n\tAnjali Singhai Jain ","Date":"Wed, 06 Sep 2017 18:13:18 -0700","In-Reply-To":"","References":"\n\t","Content-Type":"multipart/signed; micalg=\"pgp-sha256\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-5NzCaqRy8K/1Jjr9AcQS\"","X-Mailer":"Evolution 3.24.5 ","Mime-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]