[{"id":1764453,"web_url":"http://patchwork.ozlabs.org/comment/1764453/","msgid":"<1504746971.3922.83.camel@intel.com>","list_archive_url":null,"date":"2017-09-07T01:16:11","subject":"Re: [Intel-wired-lan] [PATCH net 1/2] i40e: Fix comment about\n\tlocking for __i40e_read_nvm_word()","submitter":{"id":473,"url":"http://patchwork.ozlabs.org/api/people/473/","name":"Kirsher, Jeffrey T","email":"jeffrey.t.kirsher@intel.com"},"content":"On Wed, 2017-09-06 at 10:11 +0200, Stefano Brivio wrote:\n> Caller needs to acquire the lock. Called functions will not.\n> \n> Fixes: 09f79fd49d94 (\"i40e: avoid NVM acquire deadlock during NVM\n> update\")\n> Signed-off-by: Stefano Brivio \n> ---\n> drivers/net/ethernet/intel/i40e/i40e_nvm.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nYes, this fixes the function header comment, not sure if it requires\nthe \"Fixes:\" tag. If that were the case, wonder why all the other code\ncomment changes do not have this. :-) I do agree it reads better with\nthis change, so I do not have an issue queue this up for Dave's net\ntree.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnjGB13Vvz9sCZ\n\tfor ;\n\tThu, 7 Sep 2017 11:16:34 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5D72889AFC;\n\tThu, 7 Sep 2017 01:16:32 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ctl5crzbUXLu; Thu, 7 Sep 2017 01:16:31 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1A83F89AF3;\n\tThu, 7 Sep 2017 01:16:31 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 467BE1BFB44\n\tfor ;\n\tThu, 7 Sep 2017 01:16:30 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3F47089AF3\n\tfor ;\n\tThu, 7 Sep 2017 01:16:30 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0GTbRW5MOp39 for ;\n\tThu, 7 Sep 2017 01:16:29 +0000 (UTC)","from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id B815289AF2\n\tfor ;\n\tThu, 7 Sep 2017 01:16:29 +0000 (UTC)","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Sep 2017 18:16:29 -0700","from nurashix-mobl1.gar.corp.intel.com ([10.254.78.137])\n\tby FMSMGA003.fm.intel.com with ESMTP; 06 Sep 2017 18:16:11 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,356,1500966000\"; \n\td=\"asc'?scan'208\";a=\"897846751\"","Message-ID":"<1504746971.3922.83.camel@intel.com>","From":"Jeff Kirsher ","To":"Stefano Brivio , netdev@vger.kernel.org, \n\tintel-wired-lan@lists.osuosl.org","Date":"Wed, 06 Sep 2017 18:16:11 -0700","In-Reply-To":"<4d27bbb33031ac1489fe6d969edd74d44155136c.1504684488.git.sbrivio@redhat.com>","References":"\n\t<4d27bbb33031ac1489fe6d969edd74d44155136c.1504684488.git.sbrivio@redhat.com>","X-Mailer":"Evolution 3.24.5 ","Mime-Version":"1.0","Cc":"\"David S . Miller\" ","Subject":"Re: [Intel-wired-lan] [PATCH net 1/2] i40e: Fix comment about\n\tlocking for __i40e_read_nvm_word()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1261231766662659444==\"","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1766455,"web_url":"http://patchwork.ozlabs.org/comment/1766455/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9F3D@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-11T18:42:46","subject":"Re: [Intel-wired-lan] [PATCH net 1/2] i40e: Fix comment about\n\tlocking\tfor __i40e_read_nvm_word()","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Stefano Brivio\n> Sent: Wednesday, September 6, 2017 1:12 AM\n> To: Kirsher, Jeffrey T ;\n> netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org\n> Cc: David S . Miller \n> Subject: [Intel-wired-lan] [PATCH net 1/2] i40e: Fix comment about locking\n> for __i40e_read_nvm_word()\n> \n> Caller needs to acquire the lock. Called functions will not.\n> \n> Fixes: 09f79fd49d94 (\"i40e: avoid NVM acquire deadlock during NVM\n> update\")\n> Signed-off-by: Stefano Brivio \n> ---\n> drivers/net/ethernet/intel/i40e/i40e_nvm.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nTested-by: Andrew Bowers ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrcHg5p0tz9sPm\n\tfor ;\n\tTue, 12 Sep 2017 04:42:54 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2F99B88B72;\n\tMon, 11 Sep 2017 18:42:53 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zm+0j7KtLf6w; Mon, 11 Sep 2017 18:42:49 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DD82188B6C;\n\tMon, 11 Sep 2017 18:42:49 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id F1FAC1C1539\n\tfor ;\n\tMon, 11 Sep 2017 18:42:48 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E3B4586CE2\n\tfor ;\n\tMon, 11 Sep 2017 18:42:48 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id l4nMiv9joirv for ;\n\tMon, 11 Sep 2017 18:42:47 +0000 (UTC)","from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id C38EA86D8A\n\tfor ;\n\tMon, 11 Sep 2017 18:42:47 +0000 (UTC)","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga104.jf.intel.com with ESMTP; 11 Sep 2017 11:42:47 -0700","from orsmsx109.amr.corp.intel.com ([10.22.240.7])\n\tby fmsmga002.fm.intel.com with ESMTP; 11 Sep 2017 11:42:46 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.142]) by\n\tORSMSX109.amr.corp.intel.com ([169.254.11.104]) with mapi id\n\t14.03.0319.002; Mon, 11 Sep 2017 11:42:46 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,379,1500966000\"; d=\"scan'208\";\n\ta=\"1217377049\"","From":"\"Bowers, AndrewX\" ","To":"\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[Intel-wired-lan] [PATCH net 1/2] i40e: Fix comment about\n\tlocking\tfor __i40e_read_nvm_word()","Thread-Index":"AQHTJufyS49lRhy6FEi9RpZLsJuuuqKwDZ/Q","Date":"Mon, 11 Sep 2017 18:42:46 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9F3D@ORSMSX104.amr.corp.intel.com>","References":"\n\t<4d27bbb33031ac1489fe6d969edd74d44155136c.1504684488.git.sbrivio@redhat.com>","In-Reply-To":"<4d27bbb33031ac1489fe6d969edd74d44155136c.1504684488.git.sbrivio@redhat.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmY1ZjMzYTEtYTI4OS00ODA4LWI3ZGItYTA1MWFiMjQzZmIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZPVkcxb2g3Y283eHhmYVg0b2s5Tk4xNEYxcnNWaXdkYTQ2dHRpdkNhMTA9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.138]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [PATCH net 1/2] i40e: Fix comment about\n\tlocking\tfor __i40e_read_nvm_word()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]