[{"id":1764454,"web_url":"http://patchwork.ozlabs.org/comment/1764454/","msgid":"<1504746971.3922.83.camel@intel.com>","list_archive_url":null,"date":"2017-09-07T01:16:11","subject":"Re: [PATCH net 1/2] i40e: Fix comment about locking for\n\t__i40e_read_nvm_word()","submitter":{"id":473,"url":"http://patchwork.ozlabs.org/api/people/473/","name":"Kirsher, Jeffrey T","email":"jeffrey.t.kirsher@intel.com"},"content":"On Wed, 2017-09-06 at 10:11 +0200, Stefano Brivio wrote:\n> Caller needs to acquire the lock. Called functions will not.\n> \n> Fixes: 09f79fd49d94 (\"i40e: avoid NVM acquire deadlock during NVM\n> update\")\n> Signed-off-by: Stefano Brivio \n> ---\n> drivers/net/ethernet/intel/i40e/i40e_nvm.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nYes, this fixes the function header comment, not sure if it requires\nthe \"Fixes:\" tag. If that were the case, wonder why all the other code\ncomment changes do not have this. :-) I do agree it reads better with\nthis change, so I do not have an issue queue this up for Dave's net\ntree.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnjGC174fz9t2r\n\tfor ;\n\tThu, 7 Sep 2017 11:16:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752968AbdIGBQa (ORCPT );\n\tWed, 6 Sep 2017 21:16:30 -0400","from mga11.intel.com ([192.55.52.93]:9801 \"EHLO mga11.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751267AbdIGBQ3 (ORCPT );\n\tWed, 6 Sep 2017 21:16:29 -0400","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Sep 2017 18:16:29 -0700","from nurashix-mobl1.gar.corp.intel.com ([10.254.78.137])\n\tby FMSMGA003.fm.intel.com with ESMTP; 06 Sep 2017 18:16:11 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,356,1500966000\"; \n\td=\"asc'?scan'208\";a=\"897846751\"","Message-ID":"<1504746971.3922.83.camel@intel.com>","Subject":"Re: [PATCH net 1/2] i40e: Fix comment about locking for\n\t__i40e_read_nvm_word()","From":"Jeff Kirsher ","To":"Stefano Brivio , netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org","Cc":"\"David S . Miller\" ,\n\tAnjali Singhai Jain ","Date":"Wed, 06 Sep 2017 18:16:11 -0700","In-Reply-To":"<4d27bbb33031ac1489fe6d969edd74d44155136c.1504684488.git.sbrivio@redhat.com>","References":"\n\t<4d27bbb33031ac1489fe6d969edd74d44155136c.1504684488.git.sbrivio@redhat.com>","Content-Type":"multipart/signed; micalg=\"pgp-sha256\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-ZCtMd78DIHK3LyweDoqg\"","X-Mailer":"Evolution 3.24.5 ","Mime-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]