[{"id":1764065,"web_url":"http://patchwork.ozlabs.org/comment/1764065/","msgid":"<20170906123602.GA96631@largo.jsg.id.au>","list_archive_url":null,"date":"2017-09-06T12:36:02","subject":"Re: [U-Boot] [PATCH] Revert \"dm: arm: rpi: Drop CONFIG_OF_EMBED\"","submitter":{"id":69816,"url":"http://patchwork.ozlabs.org/api/people/69816/","name":"Jonathan Gray","email":"jsg@jsg.id.au"},"content":"On Wed, Sep 06, 2017 at 08:35:19AM +0100, Paul Barker wrote:\n> This reverts commit 25877d4e4c45451c5398aec3de50e0d5befe0e9f.\n> \n> This is a workaround for Raspberry Pi boot failures seen when passing on\n> the device tree provided by the Raspberry Pi firmware at boot. Without\n> CONFIG_OF_EMBED, we just get stuck at \"Starting kernel ...\" when we try\n> to boot Linux with this device tree.\n> \n> Signed-off-by: Paul Barker \n> Cc: Simon Glass \n\nSame problem booting OpenBSD since 2017.07. We've been building U-Boot\nwith CONFIG_OF_EMBED=y on rpi* since Mark Kettenis tracked it down\nto that commit.\n\nTested-by: Jonathan Gray \n\n> ---\n> configs/rpi_2_defconfig | 1 +\n> configs/rpi_3_32b_defconfig | 1 +\n> configs/rpi_3_defconfig | 1 +\n> configs/rpi_defconfig | 1 +\n> 4 files changed, 4 insertions(+)\n> \n> diff --git a/configs/rpi_2_defconfig b/configs/rpi_2_defconfig\n> index 10e83186c1..848aeb73aa 100644\n> --- a/configs/rpi_2_defconfig\n> +++ b/configs/rpi_2_defconfig\n> @@ -16,6 +16,7 @@ CONFIG_CMD_USB=y\n> CONFIG_ENV_FAT_INTERFACE=\"mmc\"\n> CONFIG_ENV_FAT_DEVICE_AND_PART=\"0:1\"\n> CONFIG_DM_KEYBOARD=y\n> +CONFIG_OF_EMBED=y\n> CONFIG_DM_MMC=y\n> CONFIG_MMC_SDHCI=y\n> CONFIG_MMC_SDHCI_BCM2835=y\n> diff --git a/configs/rpi_3_32b_defconfig b/configs/rpi_3_32b_defconfig\n> index d35a639630..196b619bb7 100644\n> --- a/configs/rpi_3_32b_defconfig\n> +++ b/configs/rpi_3_32b_defconfig\n> @@ -17,6 +17,7 @@ CONFIG_CMD_USB=y\n> CONFIG_ENV_FAT_INTERFACE=\"mmc\"\n> CONFIG_ENV_FAT_DEVICE_AND_PART=\"0:1\"\n> CONFIG_DM_KEYBOARD=y\n> +CONFIG_OF_EMBED=y\n> CONFIG_DM_MMC=y\n> CONFIG_MMC_SDHCI=y\n> CONFIG_MMC_SDHCI_BCM2835=y\n> diff --git a/configs/rpi_3_defconfig b/configs/rpi_3_defconfig\n> index 095a076249..f23c1e7b18 100644\n> --- a/configs/rpi_3_defconfig\n> +++ b/configs/rpi_3_defconfig\n> @@ -17,6 +17,7 @@ CONFIG_CMD_USB=y\n> CONFIG_ENV_FAT_INTERFACE=\"mmc\"\n> CONFIG_ENV_FAT_DEVICE_AND_PART=\"0:1\"\n> CONFIG_DM_KEYBOARD=y\n> +CONFIG_OF_EMBED=y\n> CONFIG_DM_MMC=y\n> CONFIG_MMC_SDHCI=y\n> CONFIG_MMC_SDHCI_BCM2835=y\n> diff --git a/configs/rpi_defconfig b/configs/rpi_defconfig\n> index 9dfdad5c1d..939870637a 100644\n> --- a/configs/rpi_defconfig\n> +++ b/configs/rpi_defconfig\n> @@ -16,6 +16,7 @@ CONFIG_CMD_USB=y\n> CONFIG_ENV_FAT_INTERFACE=\"mmc\"\n> CONFIG_ENV_FAT_DEVICE_AND_PART=\"0:1\"\n> CONFIG_DM_KEYBOARD=y\n> +CONFIG_OF_EMBED=y\n> CONFIG_DM_MMC=y\n> CONFIG_MMC_SDHCI=y\n> CONFIG_MMC_SDHCI_BCM2835=y\n> -- \n> 2.11.0\n> \n> _______________________________________________\n> U-Boot mailing list\n> U-Boot@lists.denx.de\n> https://lists.denx.de/listinfo/u-boot","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnNP05PsTz9sNc\n\tfor ;\n\tWed, 6 Sep 2017 22:36:20 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 78A16C21EE7; Wed, 6 Sep 2017 12:36:14 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 06B07C21E30;\n\tWed, 6 Sep 2017 12:36:12 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 8D16EC21E30; Wed, 6 Sep 2017 12:36:10 +0000 (UTC)","from lechuck.jsg.id.au (jsg.id.au [210.15.216.215])\n\tby lists.denx.de (Postfix) with ESMTPS id 4D6D3C21C51\n\tfor ; Wed, 6 Sep 2017 12:36:07 +0000 (UTC)","from largo.jsg.id.au (largo.jsg.id.au [192.168.1.43])\n\tby lechuck.jsg.id.au (OpenSMTPD) with ESMTP id 06a514db;\n\tWed, 6 Sep 2017 22:36:03 +1000 (AEST)","from localhost (largo.jsg.id.au [local])\n\tby largo.jsg.id.au (OpenSMTPD) with ESMTPA id 7c42620c;\n\tWed, 6 Sep 2017 22:36:03 +1000 (AEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY\n\tautolearn=unavailable autolearn_force=no version=3.4.0","Date":"Wed, 6 Sep 2017 22:36:02 +1000","From":"Jonathan Gray ","To":"Paul Barker ","Message-ID":"<20170906123602.GA96631@largo.jsg.id.au>","References":"<20170906073519.22745-1-pbarker@toganlabs.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170906073519.22745-1-pbarker@toganlabs.com>","User-Agent":"Mutt/1.8.0 (2017-02-23)","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH] Revert \"dm: arm: rpi: Drop CONFIG_OF_EMBED\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1764104,"web_url":"http://patchwork.ozlabs.org/comment/1764104/","msgid":"","list_archive_url":null,"date":"2017-09-06T13:27:03","subject":"Re: [U-Boot] [PATCH] Revert \"dm: arm: rpi: Drop CONFIG_OF_EMBED\"","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"+Tom\n\nOn 6 September 2017 at 01:35, Paul Barker wrote:\n> This reverts commit 25877d4e4c45451c5398aec3de50e0d5befe0e9f.\n>\n> This is a workaround for Raspberry Pi boot failures seen when passing on\n> the device tree provided by the Raspberry Pi firmware at boot. Without\n> CONFIG_OF_EMBED, we just get stuck at \"Starting kernel ...\" when we try\n> to boot Linux with this device tree.\n>\n> Signed-off-by: Paul Barker \n> Cc: Simon Glass \n> ---\n> configs/rpi_2_defconfig | 1 +\n> configs/rpi_3_32b_defconfig | 1 +\n> configs/rpi_3_defconfig | 1 +\n> configs/rpi_defconfig | 1 +\n> 4 files changed, 4 insertions(+)\n\nWe should apply this fix for the release in the meantime while we wait\nfor a root cause.\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"CqQdlGR7\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"iceAYkkq\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnPX729DXz9sNV\n\tfor ;\n\tWed, 6 Sep 2017 23:27:33 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3C09AC21E4B; Wed, 6 Sep 2017 13:27:29 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 16EC8C21DE6;\n\tWed, 6 Sep 2017 13:27:27 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9E3F6C21DE6; Wed, 6 Sep 2017 13:27:26 +0000 (UTC)","from mail-qt0-f173.google.com (mail-qt0-f173.google.com\n\t[209.85.216.173])\n\tby lists.denx.de (Postfix) with ESMTPS id 6F444C21C51\n\tfor ; Wed, 6 Sep 2017 13:27:25 +0000 (UTC)","by mail-qt0-f173.google.com with SMTP id i50so19710536qtf.0\n\tfor ; Wed, 06 Sep 2017 06:27:25 -0700 (PDT)","by 10.200.28.108 with HTTP; Wed, 6 Sep 2017 06:27:03 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=KYABog4q659HxXO3DA/KeeSqh8y0hmTXc9Y8eL6x4gk=;\n\tb=CqQdlGR7YsMayXuFd+b/KiI38udTsAmQ3NK43gzwusogPa9CTA524FwJ+TDeI7fc4j\n\t8TpPo4847gABVXKK8ViiYK732Sp8bGECOPfFtUjEt7WEV1J9ZIE9st4jNOsY65pDzpBg\n\tnxYp6J+6Acoe+YkJm7D01xwOiFedlv9QaOfv8pDPnN1th9pGkPss2tAbmani/BJhjaDQ\n\tT2DW+u8jEiYfMa9HSJRGmCmeNUVB803xPhgA/cUfpcEBL3oLu+FSnPCoVWctgi2WeHZj\n\tudOkt3scySQcqQ5t8xzpxz+uT5Wq/5S0DiDw5OR5YUmnFvJfuvONIJQnbHUVuVhxLKQh\n\tYaJw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=KYABog4q659HxXO3DA/KeeSqh8y0hmTXc9Y8eL6x4gk=;\n\tb=iceAYkkqtsAqFN34yMShF2w+ABtCGiwFPZTMg8/qhTjCIQJSF1qCr2K4/msHcOLvIf\n\tVzf2oYp6+JTyOJztb/7Q2y50J2oT0RIY9XhHNfaN91dAeQxqv2obm/YtPWaMPy4OLzjM\n\tkS92GUZ0+Ati2qysyrzNxW24ibbDEsPI8GA34="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=KYABog4q659HxXO3DA/KeeSqh8y0hmTXc9Y8eL6x4gk=;\n\tb=ou4TGGoJe4TFzWOs0VBsk3z+xiI6VzejFJ+BQgZ76+LYEIL8eHl3OuosgAFWITC4da\n\tjjHvxdUFPwdASCob6Vt7zkh40VqknyrjZzNQrj2C3PgE7YhFljLg4MCuG5n6pQJDgM5i\n\tTD/+r4xsnoUsIKi1gUeVStbpEglYnChjPxAgkR4ZL/QoBUwOMSHSWArJO9XwxgIflidw\n\t6Oi4IZJLxaTSMrSiYwbrxASRzlWtTOsbIz2zD3jyXsl5Y7FCMK4wj9Ceff42NBie4m+u\n\tn9P6jbhLHe/K03sEFPaUMX24p16F5gDTk7kYpNp7MjIVULPsh4yA06IBNYEJWARWKKsv\n\tJwjA==","X-Gm-Message-State":"AHPjjUiRkFaEKJuFX/0DqXrFOwUjJi2ZgFY5t0ihR2WrECQ1dAgvfxPo\n\t/RIaBsW8FHDePYwguCRyHpHBq3vK1A4b","X-Google-Smtp-Source":"ADKCNb41gCvGDwnlMoVKeELRrjobxfVsR8klTDmMb7EnFky7lIdAUsjueV6JpYuvR3KsW1x+7OwwKrr7glJN+8/u/Yo=","X-Received":"by 10.200.53.67 with SMTP id z3mr3759054qtb.145.1504704443954;\n\tWed, 06 Sep 2017 06:27:23 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170906073519.22745-1-pbarker@toganlabs.com>","References":"<20170906073519.22745-1-pbarker@toganlabs.com>","From":"Simon Glass ","Date":"Wed, 6 Sep 2017 07:27:03 -0600","X-Google-Sender-Auth":"8Lit2dHfCjl389U5QQiPkrxb9fU","Message-ID":"","To":"Paul Barker ","Cc":"U-Boot Mailing List , Tom Rini ","Subject":"Re: [U-Boot] [PATCH] Revert \"dm: arm: rpi: Drop CONFIG_OF_EMBED\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1765011,"web_url":"http://patchwork.ozlabs.org/comment/1765011/","msgid":"<20170908000223.GY17058@bill-the-cat>","list_archive_url":null,"date":"2017-09-08T00:02:23","subject":"Re: [U-Boot] Revert \"dm: arm: rpi: Drop CONFIG_OF_EMBED\"","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Wed, Sep 06, 2017 at 08:35:19AM +0100, Paul Barker wrote:\n\n> This reverts commit 25877d4e4c45451c5398aec3de50e0d5befe0e9f.\n> \n> This is a workaround for Raspberry Pi boot failures seen when passing on\n> the device tree provided by the Raspberry Pi firmware at boot. Without\n> CONFIG_OF_EMBED, we just get stuck at \"Starting kernel ...\" when we try\n> to boot Linux with this device tree.\n> \n> Signed-off-by: Paul Barker \n> Cc: Simon Glass \n> Tested-by: Jonathan Gray \n> Reviewed-by: Simon Glass \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"pfoRchb9\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpHdB4ws1z9sBW\n\tfor ;\n\tFri, 8 Sep 2017 10:05:02 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 382E4C21D88; Fri, 8 Sep 2017 00:02:32 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 7D500C21E43;\n\tFri, 8 Sep 2017 00:02:04 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid C3DB5C21EAB; Fri, 8 Sep 2017 00:01:53 +0000 (UTC)","from mail-yw0-f178.google.com (mail-yw0-f178.google.com\n\t[209.85.161.178])\n\tby lists.denx.de (Postfix) with ESMTPS id F024BC21EDB\n\tfor ; Fri, 8 Sep 2017 00:01:52 +0000 (UTC)","by mail-yw0-f178.google.com with SMTP id q80so3453042ywg.2\n\tfor ; Thu, 07 Sep 2017 17:01:52 -0700 (PDT)","from bill-the-cat ([2606:a000:140b:dc:58d5:266b:224e:9609])\n\tby smtp.gmail.com with ESMTPSA id\n\ty4sm229390ywk.59.2017.09.07.17.01.50\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 07 Sep 2017 17:01:51 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=9dyMusdTVlP24a2XTKjd2N0bmD2zQJC+0i4V7tjR4Ns=;\n\tb=pfoRchb9jH28tXqE0Vfwc/7WDlgjeEf+6aB8nuooJtUuFfwReDiDWtnC4qYtt06gJw\n\tGFmAYCbRU/fw2K2JJAhBoURdUYxkaFKn2zmoa0SlZqf34Vb1tZS37itIyZrmOeerCqon\n\tqCghbxME40BvNVDNXCojy9cy5yozVNzbkSPJg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=9dyMusdTVlP24a2XTKjd2N0bmD2zQJC+0i4V7tjR4Ns=;\n\tb=IiGL0qHnJlyxzqQ3s8bCZZXzalhs6cjljUxpl1hm5oy4ZWc8MxIbz3k11qfUEe5Si/\n\ti8RTA8yO+Ax6mVGyuHUzicKshRpYr/OlRZr85keJi9l7XaHswHPx3m+r2Otbmd9xdNxl\n\t0NVxtTyreHtJpSX/VaD2bg61faRQGrXzN4hdUUdjB3K7bVhi/K2k3KebClkZsyISON31\n\tDZNzDMTQq7njwIw/N674qN1FezK5KRGdbf9HmpE4aiBTn5X9UO5BGlOq+O78YrXVBAe4\n\t4AvDZNmzV2x1IkPXOt1XQV3G5vtC9Rqe9xhB3aORhLNy/oPmRTmBBJQS33E7vwOCm651\n\tuL+w==","X-Gm-Message-State":"AHPjjUidi7JZ8Kt2NVAdYfxb/Ff6QO/Ot/tDrGyAK+58/XDI//pfojJ9\n\tUOgMuh16Y2AuaViZ","X-Google-Smtp-Source":"ADKCNb7zMLpQQUx8eiSV5Qx7FwQHfJSjz/q5LX1HuLmtq0j15lOR+TsyHEUlHlcwO9mX9p3ErFvpnA==","X-Received":"by 10.129.153.81 with SMTP id q78mr955217ywg.133.1504828911783; \n\tThu, 07 Sep 2017 17:01:51 -0700 (PDT)","Date":"Thu, 7 Sep 2017 20:02:23 -0400","From":"Tom Rini ","To":"Paul Barker ","Message-ID":"<20170908000223.GY17058@bill-the-cat>","References":"<20170906073519.22745-1-pbarker@toganlabs.com>","MIME-Version":"1.0","In-Reply-To":"<20170906073519.22745-1-pbarker@toganlabs.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] Revert \"dm: arm: rpi: Drop CONFIG_OF_EMBED\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============7782316038717934294==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]