[{"id":1763990,"web_url":"http://patchwork.ozlabs.org/comment/1763990/","msgid":"","list_archive_url":null,"date":"2017-09-06T10:29:15","subject":"Re: [swupdate] [PATCH 2/6] socket split: adapt network_ipc","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"Hi Christian,\n\nOn 06/09/2017 09:23, Christian Storm wrote:\n> Make the solely internally used corelib/network_thread.c use\n> the kconfig setting for SOCKET_CTRL_PATH directly, which\n> defaults to /tmp/sockinstctrl in order to maintain backwards\n> compatibility.\n> \n> As include/network_ipc.h / ipc/network_ipc.c is used\n> internally as well as externally, make them use the kconfig\n> setting for SOCKET_CTRL_PATH when used internally and the\n> currently established socket path /tmp/sockinstctrl per\n> default when used externally to maintain backwards\n> compatibility.\n> When deviating from the default socket path, external\n> clients should be adapted accordingly or, preferable, be\n> made configurable via a command line parameter pointing to\n> the socket.\n\nThis is not true for the ctrl IPC. We agree that progress client should\nbe adaptewd with command line parameters. But client sending images to\nbe installed, that is the ones pushing to sockinstctr, should use the\nclient interface. That means, ipc_* functions and swupdate_image_write /\nswupdate_async_start. They should never use the socket, and we can\nenforce this if we hide the path of the socket.\n\n> \n> Signed-off-by: Christian Storm \n> ---\n> corelib/network_thread.c | 3 ++-\n> include/network_ipc.h | 2 +-\n> ipc/network_ipc.c | 6 ++++++\n> 3 files changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/corelib/network_thread.c b/corelib/network_thread.c\n> index e925360..6c34614 100644\n> --- a/corelib/network_thread.c\n> +++ b/corelib/network_thread.c\n> @@ -42,6 +42,7 @@\n> #include \"installer.h\"\n> #include \"swupdate.h\"\n> #include \"pctl.h\"\n> +#include \"generated/autoconf.h\"\n> \n> #define LISTENQ\t1024\n> \n> @@ -193,7 +194,7 @@ void *network_thread (void *data)\n> \tregister_notifier(network_notifier);\n> \n> \t/* Initialize and bind to UDS */\n> -\tctrllisten = listener_create(SOCKET_CTRL_PATH, SOCK_STREAM);\n> +\tctrllisten = listener_create((char*)CONFIG_SOCKET_CTRL_PATH, SOCK_STREAM);\n> \tif (ctrllisten < 0 ) {\n> \t\tTRACE(\"Error creating IPC sockets\");\n> \t\texit(2);\n> diff --git a/include/network_ipc.h b/include/network_ipc.h\n> index e0d6672..a969f4c 100644\n> --- a/include/network_ipc.h\n> +++ b/include/network_ipc.h\n> @@ -24,7 +24,7 @@\n> #include \"swupdate_status.h\"\n> \n> #define IPC_MAGIC\t\t0x14052001\n> -#define SOCKET_CTRL_PATH\t\"/tmp/sockinstctrl\"\n> +extern char* SOCKET_CTRL_PATH;\n> \n> typedef enum {\n> \tREQ_INSTALL,\n> diff --git a/ipc/network_ipc.c b/ipc/network_ipc.c\n> index 6629461..13554f5 100644\n> --- a/ipc/network_ipc.c\n> +++ b/ipc/network_ipc.c\n> @@ -35,6 +35,12 @@\n> \n> #include \"network_ipc.h\"\n> \n> +#ifdef CONFIG_SOCKET_CTRL_PATH\n> +char* SOCKET_CTRL_PATH = (char*)CONFIG_SOCKET_CTRL_PATH;\n> +#else\n> +char* SOCKET_CTRL_PATH = (char*)\"/tmp/sockinstctrl\";\n\nThere are two functions using the socket: network_thread (you change it)\nand prepare_ipc(). But prepare_ipc() is not exported and client must\ncall ipc_inst_start*. We can drop SOCKET_CTRL_PATH from the header and\nfix prepare_ipc() as you do for network_thread.\n\nBest regards,\nStefano","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:400c:c0c::23c;\n\thelo=mail-wr0-x23c.google.com;\n\tenvelope-from=swupdate+bncbaabbbe4x7gqkgqeqvrg5ky@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"b2voTiYP\"; dkim-atps=neutral"],"Received":["from mail-wr0-x23c.google.com (mail-wr0-x23c.google.com\n\t[IPv6:2a00:1450:400c:c0c::23c])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnKZc4Rsjz9sBd\n\tfor ;\n\tWed, 6 Sep 2017 20:29:27 +1000 (AEST)","by mail-wr0-x23c.google.com with SMTP id l39sf1254382wrl.20\n\tfor ;\n\tWed, 06 Sep 2017 03:29:27 -0700 (PDT)","by 10.28.26.132 with SMTP id a126ls1045712wma.26.gmail; Wed, 06 Sep\n\t2017 03:29:24 -0700 (PDT)","from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.10])\n\tby gmr-mx.google.com with ESMTPS id\n\ti17si76584wmh.9.2017.09.06.03.29.23 for \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 06 Sep 2017 03:29:23 -0700 (PDT)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xnKZW5hYwz1qsCt;\n\tWed, 6 Sep 2017 12:29:23 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xnKZW4dxHz3hhqc;\n\tWed, 6 Sep 2017 12:29:23 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 9zHONxgxozHo; Wed, 6 Sep 2017 12:29:22 +0200 (CEST)","from babic.homelinux.org\n\t(host-88-217-136-221.customer.m-online.net [88.217.136.221])\n\t(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tWed, 6 Sep 2017 12:29:22 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 0919145404CD;\n\tWed, 6 Sep 2017 12:29:22 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id EYbiptULbDBf; Wed, 6 Sep 2017 12:29:15 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 612B9454022A;\n\tWed, 6 Sep 2017 12:29:15 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; t=1504693764; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=iY6vKmYkFvr/yD0rfv7SPjg0MTYn1NY8s/e+9yXGnvy/9nNpzr0eggXYyel4QGN+dx\n\tPJwMAKIOpc0jlXFYtr3iPxw9o5uQzKXZNcqZj4XV+GpnLX8853sdS+o0UgKKed7+oVN+\n\tl5rS3vnFUVBSKuVfY7BGHOLZtunhEzBR2+21H32Por1iuqtrYt9fHgjpmuD+zVZM/PAE\n\tvRFIM/9auWPdThmX4YzY+c3WglBJ1gWuhlVPSYiLTKaLLeBPtB5g6jfpwe6GN4fm9pWu\n\t92Szl3JEZHH4LpwAd1vK+OSoUufMcFZq4FiqmvAXl9UkyEQGHAbsvdffzBlwsN4M403g\n\tXzPA==","i=1; a=rsa-sha256; t=1504693764; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=jD0qwJCsrSEdh+fTN9AhX/FhK5wGV0HlR0hNX+bOy1rTNZuRP6A7s9YNmzXZItSdcD\n\tQnlJ2nTrsCkBa1yND7GZnbZS41+7KFgHonVEYbntuD1e7iSFOjPssFmp57Cg28sTrgRb\n\tjJt2ZwsA1j2W6DkOSnpOHL+GvQTX2gbZDoSXOsdebvqIx19ktfN+mA2fyOGWuCABBQrO\n\tAaluXrXq9LAYWOvPz9+3G0vsa7mGKgJH7niVU+xdhcsuYzLrpupOPB245Eb1KJ1tcsXa\n\tUsxEOl/1xy7y1jn7fuHEdPJ5PFklQSO6cJhW37cW7LaA6uoU7tblem7tiItYeZh7HY6i\n\t+cSw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:content-language:in-reply-to\n\t:mime-version:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results:arc-message-signature:sender\n\t:dkim-signature:arc-authentication-results;\n\tbh=9iQ22ZHV8K2S9RaBYP6FKQ4V7w1UV2XeipJWXu0FI6I=;\n\tb=oNLwTOPWg3x7OA8mCYmBmH2IFrpKGY7teMu+2mRDsWfnLuiJhlMx5oYAZoJDdE958d\n\tsb0H9jIQfNhKDq5nxObnt6knF9hsk8UQDr62b9d0cms7/LoyVcVg6eFpHYfKH3+TVpDI\n\tF2AQwPB30+5dgknyD7XM0jcfK7QfrqqBTT9wqGYJ5IMBo9ikArnu/5DL+CBoyEvgP9Vj\n\tUXMQLIvSR1guEt567KHqhMzif0ZOy9agKDayaHvRMaUbkCMh4Ifu5E46t3Uk/buVD+Gn\n\t1TlQEyfhjHj3SlKGd4+BBHBw+RHGLCcDgJZkwDa04/9SWfB60gafB4UUgfPvtTqyWo76\n\tUAhQ==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=content-transfer-encoding:content-language:in-reply-to:mime-version\n\t:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results;\n\tbh=T9rw3f378e16909S9xd2mff4wHINLU5z/l3wNiKBl9U=;\n\tb=QbOlD3tZIQTbu3wzpH4GHKmTbrlloo3NMcDEyBFG2uRyP4KhyHlVk3+c4ar3rfM6t/\n\tqgVU0eouJw8ILS8cwn6emqzegH6e41XH++LxGl2Zi862EdaEnkbk3hnzYXjWAWk/TWoJ\n\tZfXMsa3Hnd8cX9+H3U7BcyfSCUMCS48NNbNsyTYQ1LBFmzO6T0hhBJ5wFgjxdaHfMw+s\n\tTbYOm0T7aNc8o6tmQYuxBdRa2+UyprZagQWtR/plFzG1FIs692T9U5O8duGcsHYeULD9\n\tBVpN3oCSYYoxhg3+Rqi0wMY+/M16CL7atkfXykaWtbl0h5Wm56ca60ZJ/nTY+mXZl94r\n\tFaww=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 212.18.0.10 is neither permitted nor denied\n\tby best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 212.18.0.10 is neither permitted nor denied\n\tby best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:subject:to:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=9iQ22ZHV8K2S9RaBYP6FKQ4V7w1UV2XeipJWXu0FI6I=;\n\tb=b2voTiYPW9XesU49GPb7CUMMyqMZeR6P9Yyryf8MKjk9S41O1X9I+SdrcMpUX1yn4r\n\tVg8QVIShXKls/EBglEfeRitcRrYA3nfmGv63ACmEy/qzVVh/tF00ScSsTAie8TDxPHqV\n\tQdccbC4F6WQ08ld88UEpLS9ByHaT9RRc9xNWiKnQFywo1lztHmGHiPQyc0O45eP4hj0O\n\tcKR1f7140NlFDqX6mpW+W2QBOmNHL6WKQsOtadpYyruSV/VpHywcOvwX0oymX4DqdYcP\n\thPCBoBrWAnZvbpv45Fqcr4sBiARQs3k3oa+GJJrzeJnWCAVwsRkwkQ7DF975qZaR3ekV\n\tNnlA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:subject:to:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:x-original-sender:x-original-authentication-results:precedence\n\t:mailing-list:list-id:x-spam-checked-in-group:list-post:list-help\n\t:list-archive:list-subscribe:list-unsubscribe;\n\tbh=9iQ22ZHV8K2S9RaBYP6FKQ4V7w1UV2XeipJWXu0FI6I=;\n\tb=PPAtUYSrHADhKbqs3v0AalfuSVcCgnzVEjZVpAMrxbhcWw26NFkkDOgf+XA/LNHZDD\n\to2UzjP2OCDmoC0RhRR7rYbsRLYECYDu8RFxEdA4QaohocD+1LgKzlYCMJy0n/VSmOb5b\n\tH9pT+8053WSM4AW5pioMQVNc/9sT592AAZ3i5EkLQn2zOdD8via2bNVU0s9GBgc7pILL\n\tNHB7z+TpPvVp0mbox1hakv+WiUgzcMJyVXD4PJVo67xiaJibWpMCM4bCoEfee9UG+2r3\n\tukhcmg/kBTsqfHhQi7gAUqKYoR7Kl7P+8jtW2rxE063aDIYf6HfQrYemYcIdZVrdLf5J\n\tpxcQ==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHPjjUgsidDFItn9ocwPpinyA+eJX+mTKXO03hYlpYA8ffBC9paOSq+N\n\tB2lv62AJ8xo6fA==","X-Google-Smtp-Source":"ADKCNb78Zo/uxCzDCW+eFtP/0w59qlaL8Mk9lK1ZSguq3XpUyq+4yXyVydEaTkMikxoJT5A68qqIIQ==","X-Received":["by 10.28.181.82 with SMTP id e79mr4128wmf.30.1504693764557;\n\tWed, 06 Sep 2017 03:29:24 -0700 (PDT)","by 10.28.54.30 with SMTP id d30mr161412wma.6.1504693764106;\n\tWed, 06 Sep 2017 03:29:24 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 212.18.0.10 is neither permitted nor\n\tdenied by best guess record for domain of sbabic@denx.de)\n\tclient-ip=212.18.0.10; ","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"Subject":"Re: [swupdate] [PATCH 2/6] socket split: adapt network_ipc","To":"Christian Storm , swupdate@googlegroups.com","References":"<20170906072324.15734-1-christian.storm@siemens.com>\n\t<20170906072324.15734-2-christian.storm@siemens.com>","From":"Stefano Babic ","Message-ID":"","Date":"Wed, 6 Sep 2017 12:29:15 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170906072324.15734-2-christian.storm@siemens.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Language":"en-US","X-Original-Sender":"sbabic@denx.de","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 212.18.0.10 is neither permitted nor denied by best\n\tguess record\n\tfor domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}},{"id":1764178,"web_url":"http://patchwork.ozlabs.org/comment/1764178/","msgid":"<20170906145907.irlaugnu6eytnejh@MD1KR9XC.ww002.siemens.net>","list_archive_url":null,"date":"2017-09-06T14:59:07","subject":"Re: [swupdate] [PATCH 2/6] socket split: adapt network_ipc","submitter":{"id":72180,"url":"http://patchwork.ozlabs.org/api/people/72180/","name":"Storm, Christian","email":"christian.storm@siemens.com"},"content":"Hi Stefano,\n\n> On 06/09/2017 09:23, Christian Storm wrote:\n> > Make the solely internally used corelib/network_thread.c use\n> > the kconfig setting for SOCKET_CTRL_PATH directly, which\n> > defaults to /tmp/sockinstctrl in order to maintain backwards\n> > compatibility.\n> > \n> > As include/network_ipc.h / ipc/network_ipc.c is used\n> > internally as well as externally, make them use the kconfig\n> > setting for SOCKET_CTRL_PATH when used internally and the\n> > currently established socket path /tmp/sockinstctrl per\n> > default when used externally to maintain backwards\n> > compatibility.\n> > When deviating from the default socket path, external\n> > clients should be adapted accordingly or, preferable, be\n> > made configurable via a command line parameter pointing to\n> > the socket.\n> \n> This is not true for the ctrl IPC. We agree that progress client should\n> be adaptewd with command line parameters. But client sending images to\n> be installed, that is the ones pushing to sockinstctr, should use the\n> client interface. That means, ipc_* functions and swupdate_image_write /\n> swupdate_async_start. They should never use the socket, \n\nAgreed, they shouldn't use it but nevertheless maybe need to set the\nsocket path -- e.g. if the configuration is not the default one.\nPlease see the rationale at then end.\n\n> and we can enforce this if we hide the path of the socket.\n\nHm, I think you cannot really enforce one not to use the socket directly\nby simply hiding its location as this information is either well-known\n(/tmp/sockinstctrl), in the .config, or a $ strings swupdate away :)\nIn essence, one should be urged to use the methods provided for\nsanity's sake but there's nothing that hinders you from talking to the\nsocket directly...\n\n\n> > Signed-off-by: Christian Storm \n> > ---\n> > corelib/network_thread.c | 3 ++-\n> > include/network_ipc.h | 2 +-\n> > ipc/network_ipc.c | 6 ++++++\n> > 3 files changed, 9 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/corelib/network_thread.c b/corelib/network_thread.c\n> > index e925360..6c34614 100644\n> > --- a/corelib/network_thread.c\n> > +++ b/corelib/network_thread.c\n> > @@ -42,6 +42,7 @@\n> > #include \"installer.h\"\n> > #include \"swupdate.h\"\n> > #include \"pctl.h\"\n> > +#include \"generated/autoconf.h\"\n> > \n> > #define LISTENQ\t1024\n> > \n> > @@ -193,7 +194,7 @@ void *network_thread (void *data)\n> > \tregister_notifier(network_notifier);\n> > \n> > \t/* Initialize and bind to UDS */\n> > -\tctrllisten = listener_create(SOCKET_CTRL_PATH, SOCK_STREAM);\n> > +\tctrllisten = listener_create((char*)CONFIG_SOCKET_CTRL_PATH, SOCK_STREAM);\n> > \tif (ctrllisten < 0 ) {\n> > \t\tTRACE(\"Error creating IPC sockets\");\n> > \t\texit(2);\n> > diff --git a/include/network_ipc.h b/include/network_ipc.h\n> > index e0d6672..a969f4c 100644\n> > --- a/include/network_ipc.h\n> > +++ b/include/network_ipc.h\n> > @@ -24,7 +24,7 @@\n> > #include \"swupdate_status.h\"\n> > \n> > #define IPC_MAGIC\t\t0x14052001\n> > -#define SOCKET_CTRL_PATH\t\"/tmp/sockinstctrl\"\n> > +extern char* SOCKET_CTRL_PATH;\n> > \n> > typedef enum {\n> > \tREQ_INSTALL,\n> > diff --git a/ipc/network_ipc.c b/ipc/network_ipc.c\n> > index 6629461..13554f5 100644\n> > --- a/ipc/network_ipc.c\n> > +++ b/ipc/network_ipc.c\n> > @@ -35,6 +35,12 @@\n> > \n> > #include \"network_ipc.h\"\n> > \n> > +#ifdef CONFIG_SOCKET_CTRL_PATH\n> > +char* SOCKET_CTRL_PATH = (char*)CONFIG_SOCKET_CTRL_PATH;\n> > +#else\n> > +char* SOCKET_CTRL_PATH = (char*)\"/tmp/sockinstctrl\";\n> \n> There are two functions using the socket: network_thread (you change it)\n> and prepare_ipc(). But prepare_ipc() is not exported and client must\n> call ipc_inst_start*. We can drop SOCKET_CTRL_PATH from the header and\n> fix prepare_ipc() as you do for network_thread.\n\nThat means, e.g., dropping `extern char* SOCKET_CTRL_PATH;` in\ninclude/network_ipc.h and making it `static char* SOCKET_CTRL_PATH = ...`\nin ipc/network_ipc. Or moving the `SOCKET_CTRL_PATH` directly into\n`prepare_ipc()`, either way serves the illustration.\nAs a result, `SOCKET_CTRL_PATH` is hidden from the interface consumers\n(as it's now private within the .o) and they're left with calling\n`ipc_inst_*`, which they should have done in the first place, right.\n\nConsider having done this, ipc/network_ipc.c sets `SOCKET_CTRL_PATH` to\n`CONFIG_SOCKET_CTRL_PATH` if compiled within SWUpdate\n(include/generated/autoconf.h available) or to `/tmp/sockinstctrl`\notherwise. As a result, the client rightfully calling the `ipc_inst_*`\nmethods always has to be linked with the .o files reflecting the correct\nsocket path location. So, if you configure SWUpdate to use, say,\nCONFIG_SOCKET_CTRL_PATH=/tmp/XXXControl, then calling the `ipc_inst_*`\nmethods only works if the client is linked against the .o files having\nthis location configured, i.e., you cannot extract network_ipc.{c,h}\netc. from the SWUpdate sources and compile clients outside of SWUpdate\nwithout having the means to configure the socket location.\n\nTL;DR: Just because you have the means to \"see\" the socket doesn't mean\nthat it's encouraged to talk to it directly :)\n\n\nThat said, I'm fine with either way. What do you think how we should\nproceed on this?\n\n\n\nKind regards,\n Christian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:4010:c07::23a;\n\thelo=mail-lf0-x23a.google.com;\n\tenvelope-from=swupdate+bncbdd6bwv65qpbbxe3ydgqkgqev43lgsa@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"iOURK06e\"; dkim-atps=neutral"],"Received":["from mail-lf0-x23a.google.com (mail-lf0-x23a.google.com\n\t[IPv6:2a00:1450:4010:c07::23a])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnRcv6Rrjz9s7C\n\tfor ;\n\tThu, 7 Sep 2017 01:01:50 +1000 (AEST)","by mail-lf0-x23a.google.com with SMTP id l196sf334583lfl.10\n\tfor ;\n\tWed, 06 Sep 2017 08:01:50 -0700 (PDT)","by 10.46.64.146 with SMTP id r18ls268580lje.34.gmail; Wed, 06 Sep\n\t2017 08:01:47 -0700 (PDT)","from goliath.siemens.de (goliath.siemens.de. [192.35.17.28])\n\tby gmr-mx.google.com with ESMTPS id\n\tt142si133005wmt.2.2017.09.06.08.01.32\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 06 Sep 2017 08:01:32 -0700 (PDT)","from mail2.siemens.de (mail2.siemens.de [139.25.208.11])\n\tby goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v86F1W9n030521\n\t(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)\n\tfor ; Wed, 6 Sep 2017 17:01:32 +0200","from localhost ([139.25.69.251])\n\tby mail2.siemens.de (8.15.2/8.15.2) with ESMTPS id v86F1WiN005894\n\t(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO)\n\tfor ; Wed, 6 Sep 2017 17:01:32 +0200"],"ARC-Seal":["i=2; a=rsa-sha256; t=1504710108; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=lsy+u9pLkA7mhFHhgMCRSrxQppZrcoXIZX7i5latajdLT7Wt36zQB6xjNoaDJCtA+9\n\tcexvixYrJ++Lp36dShcZRfrajjy4x+WEfPOvWmorldKxQ/g+Cq1KobohHfFcj69Tiew9\n\tZdV+HbHJRsiXpUCJK3CBUgKgTYlG84sHZSu0IsM2MabtWUiHdnly/kxd6a+PCOd0bkL9\n\t8orXYNPFWcRbFr4laAMAPCHkuYzDWgMCizIK13cLG+/VbxJM6TV9xW1G+9YQMfC7zKNK\n\tpJHoLRKKFRx2mgXtkucHa2Xgbccl0MEgFVtm589pA2h6Ah4CI+bCP2Ba13pPev6LCguV\n\thmBw==","i=1; a=rsa-sha256; t=1504710092; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=PPEzkpxx2cfaV/Dp5A7mGeIQaLt6X4CBYkww7japDUpotOA/GRIFwlUfnkAGvjL7c/\n\tbrlr2hZlJ0opL9eCU5TxALpg47utUF2pSTpLc7ximtyimM+7wJdu75O5iZMvEDiWRaJC\n\ttSBq5C0KdhGcSfP+ceyI7M1nKziUbs/yPNfwykCIeRY62aV4OQ1SC70JD5TpuFE77nFX\n\tO7Y0EZB28EmdhsP3ZWdDdkGNSB1d8n13sW0Sdj/GFmQsRmlv9wK23lZZtuWnmq8pi9gL\n\ter03GrNzrEN3AzZT3WuzcT2A0ryDvuwdFRImkpPUr8vdzyUtsY6FuJLRmwxlfQvSMvrM\n\ta/YQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:user-agent:in-reply-to\n\t:content-transfer-encoding:content-disposition:mime-version\n\t:mail-followup-to:message-id:subject:to:from:date\n\t:arc-authentication-results:arc-message-signature:sender\n\t:dkim-signature:arc-authentication-results;\n\tbh=P4VLaqQXBj63swJpPtWPBXzotFGRGQ3xFXV/4jNT2MI=;\n\tb=L8Q/HwGydxr2ccmWVrFzIBjDuoKzSGZHxi8hTqyH0Z++PVRA/BSqtefgKyf3mkLafn\n\t8/AkH4ivPqISRN25LogKNQRkgwcrazxx8ypv8y0fHS/4vhlD4nMR2s5uoXnI0Uy/OlYG\n\tGR1tTHNXjX/D3RoUEfLmHY5IRk+uQcq1gS7CD8qCfMr1Q6FE1SjHP+gvbXGRZeJPzIW6\n\tXy1TaWouCUX+xfLZIQJgHbcu2z35+0bIh4znSBiYFUtyo0utHAXj6VqamFlRczAad4ft\n\t9eNfeHrdHaBlRN15qRLBWMHW9QmjeYrvGY5f+0H5BNZzi6WmhNQojVK4KPLaUN+bxpSK\n\tfciw==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=user-agent:in-reply-to:content-transfer-encoding\n\t:content-disposition:mime-version:mail-followup-to:message-id\n\t:subject:to:from:date:arc-authentication-results;\n\tbh=Ba49jNGixGXia7pMgYtTWP4xug8ZD4DNgQyRTfffyZI=;\n\tb=Df7QvtvzX4Us99HtX9opoLju7YhFlduPZGj6ZFv8ZelsnNCSQShXBC14SepgfxhPPE\n\tlGR2sIFsLvi0HZckx2zx6O/uePPhSu8Z7N/JBcU/+PqkG1s+h0bFJrZ2AFEmsaUFQu8Z\n\tuRTN20e1GK6l5fxPDx8JOP/XwsbjRcvxJn00WavCagOULKseayeF/MbxWipKvcbO4flo\n\t3/WWh/cMGsiJutweDLUAMXZx3hF+YFFKU79CrNu9SiSXfOQVF514kxedCCWTqH31M2k0\n\tl3IO+hhXoeLxJymJf8ipFzdenmbITTCch9iJ36qV3quD+shObFg1Lr1MOTGUcR//O/SN\n\t4mFg=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 192.35.17.28 is neither permitted nor denied\n\tby best guess record for domain of\n\tchristian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 192.35.17.28 is neither permitted nor denied\n\tby best guess record for domain of\n\tchristian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:date:from:to:subject:message-id:mail-followup-to\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=P4VLaqQXBj63swJpPtWPBXzotFGRGQ3xFXV/4jNT2MI=;\n\tb=iOURK06eeA9ZJbvXiJsmZTidqoS6fc61Xv0cTsSOnDXeR7kWfjmPbd7JmQnae4+aI7\n\t7GXKtBBhb21Xnat2cx+eSfzHzQU9I93zZipyouGeaMvKxKWZu1E4Uc/OL75GXXHUva+w\n\tt3fDAluXkwktA0ns+ooqY7auFuyaLY4DVr5CLage8uMIq9w8RNUSpuRNFUNodBuK3Dq0\n\trhW+CUp55a8BO1ofw3vcEp8UtoAjpdd4LrKQt1wRdm/advNefBnjMttq2Z/jvDnLVlmi\n\tnx3vCgNJJ8bHs6WQQL0Ih1mwZbN/94L/fmHUpI01u5EtQv+xxglUbZMoxBhPMa5QGYHF\n\tt64A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:date:from:to:subject:message-id\n\t:mail-followup-to:mime-version:content-disposition\n\t:content-transfer-encoding:in-reply-to:user-agent:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=P4VLaqQXBj63swJpPtWPBXzotFGRGQ3xFXV/4jNT2MI=;\n\tb=P4beDVVRFxk8vBeu0Pi76qT0e0TOLVR+pbMYKewH2/tbbbwYjMUluCy4BBgAHC1EyW\n\toRLGJDsTMcCbXCF2dm6hBzLOVkBnheBNShMMrLb3qQRlP9hJx6DnetWtWB+7sbeKZIxd\n\tpoQAHaMxGTR3oHUh/JbdP9T2rCtWXv1iukNpk8lFsCBVNUsufESASFGGbn29M5ai2b+4\n\tQMCTXPtVgIdHCIML6rBuTGIQXP/5cD8xEREgas2hUig7mQIg4hnw0a8Glf5rmvDdkzcl\n\ti1p966p410Cltwt6kaiD7RmbnxCB+8ck9fzvnjYUFysF+X3vbDZKxEEqtCmE8Hxeq8DF\n\twLPw==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHPjjUgzqAryvHkNNOHTkyvB4mnRVanz4aaSUJ42GCCNb0fP1OPribuM\n\tZ3OUjbiPLgXIBQ==","X-Google-Smtp-Source":"ADKCNb4fsJi5Oatd031ufptWpEnSwxqQZNabsRqEtlovaIwFBDz5z2xmQu88ubMz3OLhQ2wBFk/AMw==","X-Received":["by 10.46.33.226 with SMTP id h95mr6334lji.21.1504710108256;\n\tWed, 06 Sep 2017 08:01:48 -0700 (PDT)","by 10.46.82.12 with SMTP id g12mr250556ljb.24.1504710092778;\n\tWed, 06 Sep 2017 08:01:32 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 192.35.17.28 is neither permitted nor\n\tdenied by best guess record for domain of\n\tchristian.storm@siemens.com) client-ip=192.35.17.28; ","Date":"Wed, 6 Sep 2017 16:59:07 +0200","From":"Christian Storm ","To":"swupdate@googlegroups.com","Subject":"Re: [swupdate] [PATCH 2/6] socket split: adapt network_ipc","Message-ID":"<20170906145907.irlaugnu6eytnejh@MD1KR9XC.ww002.siemens.net>","Mail-Followup-To":"swupdate@googlegroups.com","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Disposition":"inline","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","User-Agent":"Mutt/20170113 (1.7.2)","X-Original-Sender":"christian.storm@siemens.com","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 192.35.17.28 is neither permitted nor denied by best\n\tguess\n\trecord for domain of christian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}},{"id":1764287,"web_url":"http://patchwork.ozlabs.org/comment/1764287/","msgid":"","list_archive_url":null,"date":"2017-09-06T17:51:27","subject":"Re: [swupdate] [PATCH 2/6] socket split: adapt network_ipc","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"Hi Christian,\n\nOn 06/09/2017 16:59, Christian Storm wrote:\n> Hi Stefano,\n> \n>> On 06/09/2017 09:23, Christian Storm wrote:\n>>> Make the solely internally used corelib/network_thread.c use\n>>> the kconfig setting for SOCKET_CTRL_PATH directly, which\n>>> defaults to /tmp/sockinstctrl in order to maintain backwards\n>>> compatibility.\n>>>\n>>> As include/network_ipc.h / ipc/network_ipc.c is used\n>>> internally as well as externally, make them use the kconfig\n>>> setting for SOCKET_CTRL_PATH when used internally and the\n>>> currently established socket path /tmp/sockinstctrl per\n>>> default when used externally to maintain backwards\n>>> compatibility.\n>>> When deviating from the default socket path, external\n>>> clients should be adapted accordingly or, preferable, be\n>>> made configurable via a command line parameter pointing to\n>>> the socket.\n>>\n>> This is not true for the ctrl IPC. We agree that progress client should\n>> be adaptewd with command line parameters. But client sending images to\n>> be installed, that is the ones pushing to sockinstctr, should use the\n>> client interface. That means, ipc_* functions and swupdate_image_write /\n>> swupdate_async_start. They should never use the socket, \n> \n> Agreed, they shouldn't use it but nevertheless maybe need to set the\n> socket path -- e.g. if the configuration is not the default one.\n> Please see the rationale at then end.\n> \n>> and we can enforce this if we hide the path of the socket.\n> \n> Hm, I think you cannot really enforce one not to use the socket directly\n> by simply hiding its location as this information is either well-known\n> (/tmp/sockinstctrl),\n\nLet me explain better: we do not guarantee that still works if they do\nnot use. The path for the socket is not exported, this does not mean\nthat someone tries to do on his own.\n\n> in the .config, or a $ strings swupdate away :)\n> In essence, one should be urged to use the methods provided for\n> sanity's sake but there's nothing that hinders you from talking to the\n> socket directly...\n\nOf course\n\n> \n> \n>>> Signed-off-by: Christian Storm \n>>> ---\n>>> corelib/network_thread.c | 3 ++-\n>>> include/network_ipc.h | 2 +-\n>>> ipc/network_ipc.c | 6 ++++++\n>>> 3 files changed, 9 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/corelib/network_thread.c b/corelib/network_thread.c\n>>> index e925360..6c34614 100644\n>>> --- a/corelib/network_thread.c\n>>> +++ b/corelib/network_thread.c\n>>> @@ -42,6 +42,7 @@\n>>> #include \"installer.h\"\n>>> #include \"swupdate.h\"\n>>> #include \"pctl.h\"\n>>> +#include \"generated/autoconf.h\"\n>>> \n>>> #define LISTENQ\t1024\n>>> \n>>> @@ -193,7 +194,7 @@ void *network_thread (void *data)\n>>> \tregister_notifier(network_notifier);\n>>> \n>>> \t/* Initialize and bind to UDS */\n>>> -\tctrllisten = listener_create(SOCKET_CTRL_PATH, SOCK_STREAM);\n>>> +\tctrllisten = listener_create((char*)CONFIG_SOCKET_CTRL_PATH, SOCK_STREAM);\n>>> \tif (ctrllisten < 0 ) {\n>>> \t\tTRACE(\"Error creating IPC sockets\");\n>>> \t\texit(2);\n>>> diff --git a/include/network_ipc.h b/include/network_ipc.h\n>>> index e0d6672..a969f4c 100644\n>>> --- a/include/network_ipc.h\n>>> +++ b/include/network_ipc.h\n>>> @@ -24,7 +24,7 @@\n>>> #include \"swupdate_status.h\"\n>>> \n>>> #define IPC_MAGIC\t\t0x14052001\n>>> -#define SOCKET_CTRL_PATH\t\"/tmp/sockinstctrl\"\n>>> +extern char* SOCKET_CTRL_PATH;\n>>> \n>>> typedef enum {\n>>> \tREQ_INSTALL,\n>>> diff --git a/ipc/network_ipc.c b/ipc/network_ipc.c\n>>> index 6629461..13554f5 100644\n>>> --- a/ipc/network_ipc.c\n>>> +++ b/ipc/network_ipc.c\n>>> @@ -35,6 +35,12 @@\n>>> \n>>> #include \"network_ipc.h\"\n>>> \n>>> +#ifdef CONFIG_SOCKET_CTRL_PATH\n>>> +char* SOCKET_CTRL_PATH = (char*)CONFIG_SOCKET_CTRL_PATH;\n>>> +#else\n>>> +char* SOCKET_CTRL_PATH = (char*)\"/tmp/sockinstctrl\";\n>>\n>> There are two functions using the socket: network_thread (you change it)\n>> and prepare_ipc(). But prepare_ipc() is not exported and client must\n>> call ipc_inst_start*. We can drop SOCKET_CTRL_PATH from the header and\n>> fix prepare_ipc() as you do for network_thread.\n> \n> That means, e.g., dropping `extern char* SOCKET_CTRL_PATH;` in\n> include/network_ipc.h and making it `static char* SOCKET_CTRL_PATH = ...`\n> in ipc/network_ipc. Or moving the `SOCKET_CTRL_PATH` directly into\n> `prepare_ipc()`, either way serves the illustration.\n\nRight.\n\n> As a result, `SOCKET_CTRL_PATH` is hidden from the interface consumers\n> (as it's now private within the .o) and they're left with calling\n> `ipc_inst_*`, which they should have done in the first place, right.\n\nRight.\n\n> \n> Consider having done this, ipc/network_ipc.c sets `SOCKET_CTRL_PATH` to\n> `CONFIG_SOCKET_CTRL_PATH` if compiled within SWUpdate\n> (include/generated/autoconf.h available) or to `/tmp/sockinstctrl`\n> otherwise.\n\nI guess that in future the ipc library should be exported in sysroots\n(-dev package). Like a \"libswupdate.a\". Clients should link with it.\n\n> As a result, the client rightfully calling the `ipc_inst_*`\n> methods always has to be linked with the .o files reflecting the correct\n> socket path location.\n\nIf someone does on his own, it should take care of it, right. In Yocto\nwe can ensure that everything is consistent.\n\n> So, if you configure SWUpdate to use, say,\n> CONFIG_SOCKET_CTRL_PATH=/tmp/XXXControl, then calling the `ipc_inst_*`\n> methods only works if the client is linked against the .o files having\n> this location configured, i.e., you cannot extract network_ipc.{c,h}\n> etc. from the SWUpdate sources and compile clients outside of SWUpdate\n> without having the means to configure the socket location.\n\nRight - but again, it is not good practise to get sources from a project\nand to compile / link with the own application. The originatin project\n(here SWUpdate) should export headers / libraries that other part of\nsoftware can simply use.\n\n> \n> TL;DR: Just because you have the means to \"see\" the socket doesn't mean\n> that it's encouraged to talk to it directly :)\n\nExactly.\n\n> \n> \n> That said, I'm fine with either way. What do you think how we should\n> proceed on this?\n\nI should drop completely SOCKET_CTRL_PATH (useless), replacing it with\nCONFIG_SOCKET_CTRL_PATH.\n\nBest regards,\nStefano","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:400c:c09::237;\n\thelo=mail-wm0-x237.google.com;\n\tenvelope-from=swupdate+bncbaabbjhlydgqkgqe7y32qhi@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"DkK/XSD/\"; dkim-atps=neutral"],"Received":["from mail-wm0-x237.google.com (mail-wm0-x237.google.com\n\t[IPv6:2a00:1450:400c:c09::237])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnWNm3hWdz9s81\n\tfor ;\n\tThu, 7 Sep 2017 03:51:35 +1000 (AEST)","by mail-wm0-x237.google.com with SMTP id s76sf54039wma.8\n\tfor ;\n\tWed, 06 Sep 2017 10:51:35 -0700 (PDT)","by 10.28.229.14 with SMTP id c14ls2489791wmh.3.canary-gmail;\n\tWed, 06 Sep 2017 10:51:32 -0700 (PDT)","from mail-out.m-online.net (mail-out.m-online.net.\n\t[2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id\n\t74si155473wmf.8.2017.09.06.10.51.31 for \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 06 Sep 2017 10:51:31 -0700 (PDT)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xnWNg5Mh3z1qsDX;\n\tWed, 6 Sep 2017 19:51:31 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xnWNg4xP7z3hj0Z;\n\tWed, 6 Sep 2017 19:51:31 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id QvbeD0TZL2Eq; Wed, 6 Sep 2017 19:51:30 +0200 (CEST)","from babic.homelinux.org\n\t(host-88-217-136-221.customer.m-online.net [88.217.136.221])\n\t(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tWed, 6 Sep 2017 19:51:30 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 11A5F45404CD;\n\tWed, 6 Sep 2017 19:51:30 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id Xjed12LeSKLC; Wed, 6 Sep 2017 19:51:27 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 3F217454022A;\n\tWed, 6 Sep 2017 19:51:27 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; t=1504720292; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=mHWwAI7fR15+9Vrd/sHtHywWYfpUE8v399ldpPAV48j86dVsf3WfyTtkozvHo8xgj8\n\tgGJbLbFufQ2KDKfEeeIsTQKJ3xOxNt2PJ+nE3hQSrdfexQ5VrrV2Fn9sqfJFii/PQlXZ\n\tpYGWo0/cwYyN9do//SCec0F1VlgT4PkRFk+d5a+Fgxu5rkKW/p0z4pDddoLrFNpYek6a\n\tonuf/3Rh0TxOgcizKNtZNvK3lMiA+wVLUkJ8/osgO5TVCK6B9/bhNgR4U1sT2yRc92dm\n\tBWc/1872PCGKQnXulr4xOWqllMF7yRgr7QCGXYbVVsdgQUosN/hXM9CpA+Bdh/b2vmtN\n\tM/aQ==","i=1; a=rsa-sha256; t=1504720291; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=qF/x2ouwplfBmfkenBy89Pc4BwnMYJkqhiK1fKj2+XycMHxxVLzBBkxXbiuHxH2f1t\n\tkP1xwarS/m/+Kpj6fIwaU0YkRQIvOji/WWYmlJMXMm86iH/XNdHdm3DPiVrtfyRf1282\n\t7mmOIQs1B48YHoiWjKfKAbrkyZuFwu22AfwVOy+zmExBHtJ0+Kvgk2CQQfKAxk0Yv8yD\n\tbPh3AaopNZLfMkIycD0TpcDA138tBF8tHsu7w3nHFpXfk6E2j0+SWDfKvYhB1/CJGoPH\n\tSdffzcI8lgRDCOD7AXrLf048/WcDVC305Waid/YMJj66PBCCbS71XRDBm99pypRR4Ifu\n\tfffQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:content-language:in-reply-to\n\t:mime-version:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results:arc-message-signature:sender\n\t:dkim-signature:arc-authentication-results;\n\tbh=Imu8Zc5fpvO76P5BQIHME8RwHFiGi8yQwuKmTxLOUPM=;\n\tb=xYGiMaXKMVyZ+rdclANt42mK1jhgIlBvDk4Uc0c+e2OzPbNXeeRBd26Ncp0/mICDwS\n\tYU5WJ00Vymn7+yG9MZejZJS0B/zKD8JeXSfvjwl4kglIYqQB7mC5zyUOX2FC9zezIiIU\n\tPw+4o3dqJAr3Clco3BOsGl6QznfrrriPE6vAoTc+Bdkb4hiorU8BINkjeX2xNkNGsfQ0\n\tUuTuEC3H1XIvFluJBrzbKdsJSEIuZOQai9jbBWSVHoJb6jGzJotFf83Zs06f+jM+JgB4\n\tqCTI8157lbRZd5fZt8DvjjG3ZCddTHaAX9JUD99CO9nEfQgDEixKyKaGT7A43hrFOdfS\n\twWFQ==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=content-transfer-encoding:content-language:in-reply-to:mime-version\n\t:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results;\n\tbh=J/esianz8B582cALzHH1vWeKz2ssSXRAc8NKoikGuHA=;\n\tb=eLydNytHwEhUoiOvZ1bn5FNrWk7kh/84ceABRADTrjfzorHYIVCqlCgfAi+SGcmqS8\n\tfSXgNj+66OqkCG7mrpsNz7KBPFmOw1N3MYWtU4XuZxhssvKzl4yDpGdTOv7FU1XbCRPo\n\tH1ByVwWyLOtMVfktqH3ieH1qQqMK1P/R87bN6Q0x2BCU3hb6qPEECmo5LPNj9dWLH1L/\n\tHrwDEeD2iHCXzRKWDEMgUTneSwvMuM/ICUp2YT+Khe8B2i6GEBAGZEEPRYig1oeH0O3y\n\ti4QhxPT0fV+4wfEYyC1ZR7qQ/sIAosnXu0gRCSpH47WZ9tXUob1A68j2Iuy6d/sWllTt\n\tHmSA=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted\n\tnor denied by best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted\n\tnor denied by best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:subject:to:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=Imu8Zc5fpvO76P5BQIHME8RwHFiGi8yQwuKmTxLOUPM=;\n\tb=DkK/XSD/EYEiJanngUbuIikk4CvrOo5IIB2IiSkYY40LKLoltbFB5TGSANqE+p6YK7\n\tOPLK/lIhuPLq+OMe3vcm5DBcPS9yKZrap0RZufFeCexMM+nz1DduE58F6S+PbGvHrFcG\n\tDePZxX7CPHLEktEZ4fJj2RzrWwoajcMSVA440a62poouCVpBGeDs277U+j5pTPnCYLpa\n\t49h8SE5lO2L42SZr9sCymvHxSWU7fSq4ad95zyaxpdmlYAwyQXRtI8mSPGmMtMO3Xy+K\n\t9bB7HdgWh2+EBatjXXCSKRb8FaaBoLn5gIyNPxjPgko97OqDnFx7y+KiuwLs93p1cmEA\n\tTRdg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:subject:to:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:x-original-sender:x-original-authentication-results:precedence\n\t:mailing-list:list-id:x-spam-checked-in-group:list-post:list-help\n\t:list-archive:list-subscribe:list-unsubscribe;\n\tbh=Imu8Zc5fpvO76P5BQIHME8RwHFiGi8yQwuKmTxLOUPM=;\n\tb=U1ogOsxBPW6TCNzm8owUokNlU6Cx25eqRLVh3OW+DmO5qXuWwSQPD3qOM8dZejrLhB\n\tYS/BQV+znWF1Yp2MlypKnkFYxeC9wogl6ICc8qtxW4BfCzdLtxRPYCgbi+N4TKUoKStd\n\tkqJ9AQyTsjnfyI4pH0gN7m93I4MjKl3WbmIjtz1Vzn+oIW7TIuELBtfdMaruvQSi3n8m\n\tTPrmcDrkfRR7MNmeeW72Zdl9DRm7rvx/CH7C0NyO/8DFDM9/2ZEK2wrQhlDG90eZaOnL\n\tH9jq7f0FnXLRBoEsTLWHpO3LhgxqDTWluu/2gwjyhM3ENV6zIyORZTHehiWkhEUJzNvh\n\tgt0g==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHPjjUjGECbY6AcqkY7ovaRvP6RJBiwvyoNBASkFUF+G+65TQqbKceJ0\n\tZtCMEOMK0ev63g==","X-Google-Smtp-Source":"ADKCNb4KpcUDRsVELvOlkGosV5YW7ZdSWqIdWY2tpZub1nGSV+nIMl1u52+69QCHznNcXTQFgoFoog==","X-Received":["by 10.28.199.194 with SMTP id x185mr750wmf.2.1504720292495;\n\tWed, 06 Sep 2017 10:51:32 -0700 (PDT)","by 10.223.160.75 with SMTP id l11mr207137wrl.28.1504720292021;\n\tWed, 06 Sep 2017 10:51:32 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither\n\tpermitted nor denied by best guess record for domain of\n\tsbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; ","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"Subject":"Re: [swupdate] [PATCH 2/6] socket split: adapt network_ipc","To":"swupdate@googlegroups.com, Christian Storm ","References":"<20170906145907.irlaugnu6eytnejh@MD1KR9XC.ww002.siemens.net>","From":"Stefano Babic ","Message-ID":"","Date":"Wed, 6 Sep 2017 19:51:27 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170906145907.irlaugnu6eytnejh@MD1KR9XC.ww002.siemens.net>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Language":"de-DE","X-Original-Sender":"sbabic@denx.de","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied\n\tby best\n\tguess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}},{"id":1764538,"web_url":"http://patchwork.ozlabs.org/comment/1764538/","msgid":"<20170907065547.g4qvqn3hswk7jhry@MD1KR9XC.ww002.siemens.net>","list_archive_url":null,"date":"2017-09-07T06:55:47","subject":"Re: [swupdate] [PATCH 2/6] socket split: adapt network_ipc","submitter":{"id":72180,"url":"http://patchwork.ozlabs.org/api/people/72180/","name":"Storm, Christian","email":"christian.storm@siemens.com"},"content":"Hi Stefano,\n\n> [...]\n> \n> I guess that in future the ipc library should be exported in sysroots\n> (-dev package). Like a \"libswupdate.a\". Clients should link with it.\n> \n> > As a result, the client rightfully calling the `ipc_inst_*`\n> > methods always has to be linked with the .o files reflecting the correct\n> > socket path location.\n> \n> If someone does on his own, it should take care of it, right. In Yocto\n> we can ensure that everything is consistent.\n> \n> > So, if you configure SWUpdate to use, say,\n> > CONFIG_SOCKET_CTRL_PATH=/tmp/XXXControl, then calling the `ipc_inst_*`\n> > methods only works if the client is linked against the .o files having\n> > this location configured, i.e., you cannot extract network_ipc.{c,h}\n> > etc. from the SWUpdate sources and compile clients outside of SWUpdate\n> > without having the means to configure the socket location.\n> \n> Right - but again, it is not good practise to get sources from a project\n> and to compile / link with the own application. The originatin project\n> (here SWUpdate) should export headers / libraries that other part of\n> software can simply use.\n>\n> [...]\n> \n> > \n> > That said, I'm fine with either way. What do you think how we should\n> > proceed on this?\n> \n> I should drop completely SOCKET_CTRL_PATH (useless), replacing it with\n> CONFIG_SOCKET_CTRL_PATH.\n\nThanks, agreed. I'll send a v2 of the patch series..\n\n\nKind regards,\n Christian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:4010:c07::23a;\n\thelo=mail-lf0-x23a.google.com;\n\tenvelope-from=swupdate+bncbdd6bwv65qpbbbo4ypgqkgqes2bvyqi@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"UF1UAc80\"; dkim-atps=neutral"],"Received":["from mail-lf0-x23a.google.com (mail-lf0-x23a.google.com\n\t[IPv6:2a00:1450:4010:c07::23a])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnrrT3Mccz9sCZ\n\tfor ;\n\tThu, 7 Sep 2017 16:58:16 +1000 (AEST)","by mail-lf0-x23a.google.com with SMTP id p195sf583135lfd.18\n\tfor ;\n\tWed, 06 Sep 2017 23:58:16 -0700 (PDT)","by 10.25.72.138 with SMTP id v132ls26381lfa.5.gmail; Wed, 06 Sep\n\t2017 23:58:13 -0700 (PDT)","from goliath.siemens.de (goliath.siemens.de. [192.35.17.28])\n\tby gmr-mx.google.com with ESMTPS id\n\tr8si49219wma.4.2017.09.06.23.58.13 for \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 06 Sep 2017 23:58:13 -0700 (PDT)","from mail3.siemens.de (mail3.siemens.de [139.25.208.14])\n\tby goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v876wCLV001674\n\t(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)\n\tfor ; Thu, 7 Sep 2017 08:58:13 +0200","from localhost ([139.25.69.251])\n\tby mail3.siemens.de (8.15.2/8.15.2) with ESMTPS id v876wCkV016785\n\t(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO)\n\tfor ; Thu, 7 Sep 2017 08:58:12 +0200"],"ARC-Seal":["i=2; a=rsa-sha256; t=1504767493; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=zojQrjchQPBwSnucwmZPZCZy6xgGVgkEG3GKagrN7Sl1LYlgEQu6sr1nNq9trs9d0P\n\tWZ1DWjf7foivgCg17oMt3SQAFjFt51Xg2kxlJoiIkR9q8BE1MDP+9jILFyXWmJSQH1ln\n\tXFI+7MvoZ27YRWZlcf1v5OErGE0Yg65dyS6AiyX7O2ZSBU5Ed8hwnFUD2K2CvUbJwBgi\n\tgcuX7XU/U8VWOKEFOVIRuGQdhNnaBlcirYXlz0ktKHdwLqa+gclRatZsluq36ZPB1JDX\n\tPZOhOufwAp5+dwpTCfUkKu5WmW7CK6IdSk+oDP7OPBs7rGTKa2Eq6agWDsQBFwfM/vZp\n\te/6w==","i=1; a=rsa-sha256; t=1504767493; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=waH8UIJbXtGcFbjm0S5+OcdBpjm2UNyDzz1XWFaQntVlrFVUgUqxKysh9SFZ/MSpFZ\n\tL3Bhv96UlUMvxS5F+P1T0ypBKDyWsx9gmwKvKMcK0vW/oGa+8aV6MjFy3xexCOMACKM3\n\treuCL5Pp15gJrlh2WXKq8GHcHcXRE9ZkCsZ9tRrvEJCoJ6/ZsiygCGcfC54k1emj8Dlw\n\t0KTyj08/5Lzc2Fi9xKGfdrh1yPsBKRdiG11u390OfWnVLfTm5F+j7KykV+vVhWxRsj1L\n\t65ArkUTXLcVAyGAoGyFzPGj/Ras+q/eLY0WM6D44vBYCFnd2XBw10dwOUxE57+D/f8mW\n\tRePw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:user-agent:in-reply-to\n\t:content-transfer-encoding:content-disposition:mime-version\n\t:mail-followup-to:message-id:subject:to:from:date\n\t:arc-authentication-results:arc-message-signature:sender\n\t:dkim-signature:arc-authentication-results;\n\tbh=BlBQ/NUmLGcXdsvG9tdnw/d9R2mKBzxuqAYoV+FPMrg=;\n\tb=so5p/5U0ncsY3Y6WbeFxMAvBfL92yZ6XcT9BiD9ZPrXqzjR1GPFTIlYdNHOkbyF4GQ\n\tj9fmOeMQCy+8ALW2oQlOUpSUbcg0FDU+xFvjGzCZi228G3Hn54AZLtXiiGiyh99mVBGP\n\tns6zNRA+pqSFCjlD843xSJ3+bzpIiUw8GxHnUCEyveLGHscteCGO2hxVxMpX+Vzfprpb\n\tDEOeIP4ixWAJt3dbTMMmVVbidj5MbyLZvASZ3xkkZvKb7KXKfHYGZ2psLrEXcHoc6Qj8\n\tK+gSJQ3hD4+PmNJmNg+px1N8MW6xGLwncEk73WMjaSe0sUqdmIRqyjE7eyOFspL2KIi3\n\tMerA==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=user-agent:in-reply-to:content-transfer-encoding\n\t:content-disposition:mime-version:mail-followup-to:message-id\n\t:subject:to:from:date:arc-authentication-results;\n\tbh=cxy6iOh5mLbVBdiJZs267Muu2q6dpL+Co0SnAllt5V0=;\n\tb=FhO7omY3R7ieDfjxN00/L2YPdW7xMLWXpn6dvcV0FjdJEecRuHRGbR3v7Epkw+f0Br\n\toNqCXood1H2GP+Tosa51w4Glnais2K/ZVx70PLBCVcyb3sJbq3vzriwr9dcyaspG5RMK\n\tMJUzr0Vc/ZUY9HWfZg1MVUZj0H9Tw6OFjMbxEY7etrTEadAKju3m1QcmXI6SF7CWO/Ue\n\tqxHMaQkIqH+FZua4Ma90HrdF5KX5m4EkJFSgqi5AWLdo2r8+BP8A16J7TTY2fWoeXhoN\n\tBLbm3BAywMWmr/RAgDJomIe43j9zAzVD5FLyfB3MTeQ/sWcdG/ZxnHn6VsAcRutl6T+t\n\tOTRg=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 192.35.17.28 is neither permitted nor denied\n\tby best guess record for domain of\n\tchristian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 192.35.17.28 is neither permitted nor denied\n\tby best guess record for domain of\n\tchristian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:date:from:to:subject:message-id:mail-followup-to\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=BlBQ/NUmLGcXdsvG9tdnw/d9R2mKBzxuqAYoV+FPMrg=;\n\tb=UF1UAc80OsPuJWyaVPDJdj76AcD7Qj0iFZSHEzPN1f+DjmecLGCq46uB9rCkvqOn4p\n\t/pCJPWXm0L4AEtGH7to64vCOyjNrNC3CMIlhxpN4k/0wpHn9zWaartAdR0jgbjwG81qR\n\tuYcmNN+g1zY3Be99yEdn7Dq+nL2feB/Y9DQ9OCjQ9CAdXqYOPEgLog6jf9BHJ1JUjAQB\n\tCPvSYCu0/udtzzo/1EJvz8+tZvixQTqFw0oFSsZpkPfDkOG08+T9PCPgL72pccpKZRqa\n\tCYzkBUQSDplwZx3uqwLDlcV9swUM/ArC4Av9eYlQjj7FoYjxp7LsI/ZKRLd7P6i4o2w2\n\trtXA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:date:from:to:subject:message-id\n\t:mail-followup-to:mime-version:content-disposition\n\t:content-transfer-encoding:in-reply-to:user-agent:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=BlBQ/NUmLGcXdsvG9tdnw/d9R2mKBzxuqAYoV+FPMrg=;\n\tb=WVFp5DBOvv3AZOX3mZsNA8xgO6m0uvFxEYWwNtNBffzk8b9PadUI2qZ397XcmkRSHQ\n\tLi/1gbzdOu07vCyWwFHGPiHTE3p4vNVXLJ5g6YJ1nREed/vckn333/SpQK4nNOiLVgk0\n\t+VOCIrR3LFIHNW1C7MsNzEHQ0BZfVbhwY9nIW8a/B4IlGBBtwZVVYcoAmRfybD3m3DJB\n\t6rqfkllS4AG3SxI3OP2Kk9mJY2L0GW3AdrBYfgnZZi3mNxyJX6Er9L/5mrOetT7WzWq5\n\tZBTlV81STBgpp1OpWfBDUyY5Bs14tBkkRb5D6x12Aw4Om6w5gGg0fpvxQ6bpYJyjhd8A\n\tI1+g==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHPjjUhdeKCFGl5XJDc8rBSR7gl8MkhF4Wd+V/f41EyNS5XtPpHEG96n\n\t8opYK9MLgEUHZQ==","X-Google-Smtp-Source":"AOwi7QCSAa0G+a4ELYralSQT476cM8K/P9wmeiqT3F7BZw0roJZMY4W9v1OZChIH4GlehYoebaYiyg==","X-Received":["by 10.25.196.23 with SMTP id u23mr2102lff.14.1504767493746;\n\tWed, 06 Sep 2017 23:58:13 -0700 (PDT)","by 10.46.0.222 with SMTP id e91mr118009lji.21.1504767493286;\n\tWed, 06 Sep 2017 23:58:13 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 192.35.17.28 is neither permitted nor\n\tdenied by best guess record for domain of\n\tchristian.storm@siemens.com) client-ip=192.35.17.28; ","Date":"Thu, 7 Sep 2017 08:55:47 +0200","From":"Christian Storm ","To":"swupdate@googlegroups.com","Subject":"Re: [swupdate] [PATCH 2/6] socket split: adapt network_ipc","Message-ID":"<20170907065547.g4qvqn3hswk7jhry@MD1KR9XC.ww002.siemens.net>","Mail-Followup-To":"swupdate@googlegroups.com","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Disposition":"inline","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","User-Agent":"Mutt/20170113 (1.7.2)","X-Original-Sender":"christian.storm@siemens.com","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 192.35.17.28 is neither permitted nor denied by best\n\tguess\n\trecord for domain of christian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}}]