[{"id":1764432,"web_url":"http://patchwork.ozlabs.org/comment/1764432/","msgid":"<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>","list_archive_url":null,"date":"2017-09-06T23:27:15","subject":"Re: [GIT] Networking","submitter":{"id":97,"url":"http://patchwork.ozlabs.org/api/people/97/","name":"Linus Torvalds","email":"torvalds@linux-foundation.org"},"content":"This pull request completely breaks Intel wireless for me.\n\nThis is my trusty old XPS 13 (9350), using Intel Wireless 8260 (rev 3a).\n\nThat remains a very standard Intel machine with absolutely zero odd\nthings going on.\n\nThe firmware is iwlwifi-8000C-28.ucode from\niwl7260-firmware-25.30.13.0-75.fc26.noarch, and the kernel reports\n\n  iwlwifi 0000:3a:00.0: loaded firmware version 27.455470.0 op_mode iwlmvm\n\nthe thing starts acting badly with this:\n\n  iwlwifi 0000:3a:00.0: FW Error notification: type 0x00000000 cmd_id 0x04\n  iwlwifi 0000:3a:00.0: FW Error notification: seq 0x0000 service 0x00000004\n  iwlwifi 0000:3a:00.0: FW Error notification: timestamp 0x            5D84\n  iwlwifi 0000:3a:00.0: Microcode SW error detected.  Restarting 0x2000000.\n  iwlwifi 0000:3a:00.0: Start IWL Error Log Dump:\n  iwlwifi 0000:3a:00.0: Status: 0x00000100, count: 6\n  iwlwifi 0000:3a:00.0: Loaded firmware version: 27.455470.0\n  iwlwifi 0000:3a:00.0: 0x00000038 | BAD_COMMAND\n  iwlwifi 0000:3a:00.0: 0x00A002F0 | trm_hw_status0\n  ...\n  iwlwifi 0000:3a:00.0: 0x00000000 | isr status reg\n  ieee80211 phy0: Hardware restart was requested\n  iwlwifi 0000:3a:00.0: FW error in SYNC CMD MAC_CONTEXT_CMD\n  CPU: 2 PID: 993 Comm: NetworkManager Not tainted 4.13.0-06466-g80cee03bf1d6 #4\n  Hardware name: Dell Inc. XPS 13 9350/09JHRY, BIOS 1.4.17 05/10/2017\n  Call Trace:\n   dump_stack+0x4d/0x70\n   iwl_trans_pcie_send_hcmd+0x4e7/0x530 [iwlwifi]\n   ? wait_woken+0x80/0x80\n   iwl_trans_send_cmd+0x5c/0xc0 [iwlwifi]\n   iwl_mvm_send_cmd+0x32/0x90 [iwlmvm]\n   iwl_mvm_send_cmd_pdu+0x58/0x80 [iwlmvm]\n   iwl_mvm_mac_ctxt_send_cmd+0x2a/0x60 [iwlmvm]\n   ? iwl_mvm_mac_ctxt_send_cmd+0x2a/0x60 [iwlmvm]\n   iwl_mvm_mac_ctxt_cmd_sta+0x140/0x1e0 [iwlmvm]\n   iwl_mvm_mac_ctx_send+0x2d/0x60 [iwlmvm]\n   iwl_mvm_mac_ctxt_add+0x43/0xc0 [iwlmvm]\n   iwl_mvm_mac_add_interface+0x139/0x2b0 [iwlmvm]\n   ? iwl_led_brightness_set+0x1f/0x30 [iwlmvm]\n   drv_add_interface+0x4a/0x120 [mac80211]\n   ieee80211_do_open+0x33d/0x820 [mac80211]\n   ieee80211_open+0x52/0x60 [mac80211]\n   __dev_open+0xae/0x120\n   __dev_change_flags+0x17b/0x1c0\n   dev_change_flags+0x29/0x60\n   do_setlink+0x2f7/0xe60\n   ? __nla_put+0x20/0x30\n   ? _raw_read_unlock_bh+0x20/0x30\n   ? inet6_fill_ifla6_attrs+0x4be/0x4e0\n   ? __kmalloc_node_track_caller+0x35/0x2b0\n   ? nla_parse+0x35/0x100\n   rtnl_newlink+0x5d2/0x8f0\n   ? __netlink_sendskb+0x3b/0x60\n   ? security_capset+0x40/0x80\n   ? ns_capable_common+0x68/0x80\n   ? ns_capable+0x13/0x20\n   rtnetlink_rcv_msg+0x1f9/0x280\n   ? rtnl_calcit.isra.26+0x110/0x110\n   netlink_rcv_skb+0x8e/0x130\n   rtnetlink_rcv+0x15/0x20\n   netlink_unicast+0x18b/0x220\n   netlink_sendmsg+0x2ad/0x3a0\n   sock_sendmsg+0x38/0x50\n   ___sys_sendmsg+0x269/0x2c0\n   ? addrconf_sysctl_forward+0x114/0x280\n   ? dev_forward_change+0x140/0x140\n   ? sysctl_head_finish.part.22+0x32/0x40\n   ? lockref_put_or_lock+0x5e/0x80\n   ? dput.part.22+0x13e/0x1c0\n   ? mntput+0x24/0x40\n   __sys_sendmsg+0x54/0x90\n   ? __sys_sendmsg+0x54/0x90\n   SyS_sendmsg+0x12/0x20\n   entry_SYSCALL_64_fastpath+0x13/0x94\n  RIP: 0033:0x7ff1f9933134\n  RSP: 002b:00007ffe7419b460 EFLAGS: 00000293 ORIG_RAX: 000000000000002e\n  RAX: ffffffffffffffda RBX: 000055604b6d82b9 RCX: 00007ff1f9933134\n  RDX: 0000000000000000 RSI: 00007ffe7419b4b0 RDI: 0000000000000007\n  RBP: 00007ffe7419b940 R08: 0000000000000000 R09: 000055604d16b400\n  R10: 00007ff1f7cf8b38 R11: 0000000000000293 R12: 0000000000000001\n  R13: 0000000000000001 R14: 00007ffe7419b670 R15: 000055604b9515a0\n  iwlwifi 0000:3a:00.0: Failed to send MAC context (action:1): -5\n\nand it doesn't get any better from there. The next error seems to be\n\n  Timeout waiting for hardware access (CSR_GP_CNTRL 0x08000008)\n  ------------[ cut here ]------------\n  WARNING: CPU: 3 PID: 1075 at\ndrivers/net/wireless/intel/iwlwifi/pcie/trans.c:1874\niwl_trans_pcie_grab_nic_access+0xdf/0xf0 [iwlwifi]\n\nand it will continue with those microcode failure errors and various\nother warnigns about how nothing is working.\n\nAnd no, nothing works.  A lot of log output, no actual network access..\n\n              Linus","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nf9tUM/A\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnfrN6TtPz9t2r\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 09:27:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753598AbdIFX1S (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 6 Sep 2017 19:27:18 -0400","from mail-io0-f194.google.com ([209.85.223.194]:33769 \"EHLO\n\tmail-io0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750786AbdIFX1Q (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 6 Sep 2017 19:27:16 -0400","by mail-io0-f194.google.com with SMTP id y123so159381iod.0;\n\tWed, 06 Sep 2017 16:27:16 -0700 (PDT)","by 10.107.147.86 with HTTP; Wed, 6 Sep 2017 16:27:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=4un+7yGxU6Tl2f8xlmy72qv5z4E80IVqTeb0cVAaBhg=;\n\tb=nf9tUM/AsA3Y0oOtgk+yQJce0/9qZ47OBmF5QICh17MVvWjHgZD3rW9QT70mShM+ck\n\tuyhve4YnIVq7dqSXdOV7Mg8ooMXFHZKxXwKrLyqx9tErikVtN2Gqq/apcj4Lb1jFi7CQ\n\tDZ/XSx7H0yniUsLtselKpzaDR7Fe6e3JkSHx6hH4mqDf4g6QG1iaYXaiLGH+EHlQ+iiW\n\tMt7KnVPpfWPViKfED2B2KmDUB+gk59VvW3bnUkN45HI7KVZQ2Eyv/O+3pA3EgF4HYlnx\n\tMVZAd9aRSkbS5+adR1CtAaidBw6/0gDIY9XEWTNC2+IUq3W9fDoRAJ43ZIz+llkWh5h+\n\tY6Ww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=4un+7yGxU6Tl2f8xlmy72qv5z4E80IVqTeb0cVAaBhg=;\n\tb=B5LuIpyusM/3ECHHcraO7zRK2Lx6osxqDjIgWuriyAqj0UqaGCijik2hz3exOO2uP3\n\tZbUkieppjNEnbJE9F7hjZt862USjbSmvrquI95/rr1kwyi1B8jaeuMaonxfuTLnHzV5H\n\tlD91Fh4IShNKJB2pZ38X+EUOhONS3BUDyHv8wq9aYf65JV9JGUvOZN4AuyAIKh1pue4d\n\tUgnKpxv3wKS3ElZZjR/o/RiJrCe2T0Fr8SRBapQZnVt2AqKUE7EfAyQBEgoI42bXXDnF\n\tFkP6s5eXaOh+FrYkkGKtNZeAnjYSU7mqdW7+w2IkKTMA7zIzHqa2DexXVeIKU6OvouZZ\n\tAcxA==","X-Gm-Message-State":"AHPjjUiFrPHhAayJzBWsAqzKpxveUfb3JxSKfZ5WYSmP/T7Qgne0dTYy\n\teuiIVXVH5uU/uxW44SEoDr8OY64+LQ==","X-Google-Smtp-Source":"ADKCNb7KlKipYqULHt5L06S+3sTOt9TblDhF/T+cnT7kpwyITGcs5jTF6uCb2sydDzShCxCIV+iOQdAkXLI87YQEy4g=","X-Received":"by 10.107.183.23 with SMTP id h23mr1063416iof.246.1504740435871; \n\tWed, 06 Sep 2017 16:27:15 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170905.214143.826912481689443792.davem@davemloft.net>","References":"<20170905.214143.826912481689443792.davem@davemloft.net>","From":"Linus Torvalds <torvalds@linux-foundation.org>","Date":"Wed, 6 Sep 2017 16:27:15 -0700","X-Google-Sender-Auth":"c4CnspM9PugZHQds7TVGFULarOg","Message-ID":"<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>","Subject":"Re: [GIT] Networking","To":"David Miller <davem@davemloft.net>,\n\tJohannes Berg <johannes.berg@intel.com>,\n\tEmmanuel Grumbach <emmanuel.grumbach@intel.com>,\n\tLuca Coelho <luciano.coelho@intel.com>, Kalle Valo <kvalo@codeaurora.org>","Cc":"Andrew Morton <akpm@linux-foundation.org>,\n\tNetwork Development <netdev@vger.kernel.org>,\n\tLinux Kernel Mailing List <linux-kernel@vger.kernel.org>,\n\tIntel Linux Wireless <linuxwifi@intel.com>,\n\tLinux Wireless List <linux-wireless@vger.kernel.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764434,"web_url":"http://patchwork.ozlabs.org/comment/1764434/","msgid":"<20170906.163111.1134793014413389479.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-06T23:31:11","subject":"Re: [GIT] Networking","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Linus Torvalds <torvalds@linux-foundation.org>\nDate: Wed, 6 Sep 2017 16:27:15 -0700\n\n> This pull request completely breaks Intel wireless for me.\n> \n> This is my trusty old XPS 13 (9350), using Intel Wireless 8260 (rev 3a).\n> \n> That remains a very standard Intel machine with absolutely zero odd\n> things going on.\n> \n> The firmware is iwlwifi-8000C-28.ucode from\n> iwl7260-firmware-25.30.13.0-75.fc26.noarch, and the kernel reports\n ...\n\nJohannes and other Intel folks please look into this.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnfws12tYz9s4s\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 09:31:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753053AbdIFXbN (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 6 Sep 2017 19:31:13 -0400","from shards.monkeyblade.net ([184.105.139.130]:42180 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750800AbdIFXbM (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 6 Sep 2017 19:31:12 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id E96AF1018A0E5;\n\tWed,  6 Sep 2017 16:31:11 -0700 (PDT)"],"Date":"Wed, 06 Sep 2017 16:31:11 -0700 (PDT)","Message-Id":"<20170906.163111.1134793014413389479.davem@davemloft.net>","To":"torvalds@linux-foundation.org","Cc":"johannes.berg@intel.com, emmanuel.grumbach@intel.com,\n\tluciano.coelho@intel.com, kvalo@codeaurora.org,\n\takpm@linux-foundation.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linuxwifi@intel.com,\n\tlinux-wireless@vger.kernel.org","Subject":"Re: [GIT] Networking","From":"David Miller <davem@davemloft.net>","In-Reply-To":"<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>","References":"<20170905.214143.826912481689443792.davem@davemloft.net>\n\t<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Wed, 06 Sep 2017 16:31:12 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764436,"web_url":"http://patchwork.ozlabs.org/comment/1764436/","msgid":"<CA+55aFwzYm5o98ZpbC1hOGfkcbYQaucuqZN6qB1f7_qW2CjVpQ@mail.gmail.com>","list_archive_url":null,"date":"2017-09-06T23:37:07","subject":"Re: [GIT] Networking","submitter":{"id":97,"url":"http://patchwork.ozlabs.org/api/people/97/","name":"Linus Torvalds","email":"torvalds@linux-foundation.org"},"content":"On Wed, Sep 6, 2017 at 4:27 PM, Linus Torvalds\n<torvalds@linux-foundation.org> wrote:\n>\n> The firmware is iwlwifi-8000C-28.ucode from\n> iwl7260-firmware-25.30.13.0-75.fc26.noarch, and the kernel reports\n>\n>   iwlwifi 0000:3a:00.0: loaded firmware version 27.455470.0 op_mode iwlmvm\n\nAnd when I said \"iwlwifi-8000C-28.ucode\" I obviously meant\n\"iwlwifi-8000C-27.ucode\".\n\nAt least it was _hopefully_ obvious from that \"27\" in the actual\nversion number it reports.\n\n            Linus","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UaAAHit5\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xng3j5fyGz9s7h\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 09:37:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752428AbdIFXhK (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 6 Sep 2017 19:37:10 -0400","from mail-it0-f47.google.com ([209.85.214.47]:37098 \"EHLO\n\tmail-it0-f47.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750968AbdIFXhI (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 6 Sep 2017 19:37:08 -0400","by mail-it0-f47.google.com with SMTP id o200so154364itg.0;\n\tWed, 06 Sep 2017 16:37:08 -0700 (PDT)","by 10.107.147.86 with HTTP; Wed, 6 Sep 2017 16:37:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=k7628waPDhYUxqS4zaaGgQOrgBNIRLU5dv3kXHHR8cw=;\n\tb=UaAAHit5JXoctcaxZqhgBCooQ3bA4oKnjJ7arWMLAJJNH/jx57jGxE0XRjIBSvsQUN\n\tBp9gKF3/psvaQVqqsWNI0eI8y61N5Ha2pQYIFcUewLl3X5+hTQ+qVa0NPt3vCmbEqSLS\n\tCC3BDAHSAWr5XeAPOzR336yFrqUSHyYYmBmNYGyDouKkLJ5+/7xhKnhkv40FaNifSgLW\n\tHOnHu9duRTSg98rHkfLKTvQkUj5rpazNf1XJRoZRdn1GI0k6QGaw5PZcutjdX3sfedQ3\n\tgv7nt3kUWe5iZfrT627ii/Nffoh4CllLRhtvxbj/i/VHEVZKp0faoaB4zcSx/Z5e6UJF\n\tvbTA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=k7628waPDhYUxqS4zaaGgQOrgBNIRLU5dv3kXHHR8cw=;\n\tb=cpOK7I277zMzmGVgPGVqiLtr/sfKnJTz1V/n08RNBtXn0u3YJLxo9yGxbHC1mqdjFC\n\tiyFr1NpKdzbI0B1PKnW17bH7+wgfECtVQt/0nP4/AL0GF1MIfS2W/i5d+aM/Yp9twBh4\n\t32B0M7yTz6XwbJfOC1R9vS3zEy8hoKztiX6HXxbRzyn0QiD2+nxOrG4Ch19rmzy2IAPP\n\tlvKQVnLtWGHhuq0pV2T5b53WeEhPI96NlEa8Y67tg+rnUq+iKsn86YcnCNnJSQqTZmQB\n\tUNpDBSNCm9PVn635va/2gH3oDDUR3JpQUsj/Bc64xfdYk1V9Ejm/J8D2GBmn3E6P9F/E\n\tCLKw==","X-Gm-Message-State":"AHPjjUjNPMZATnzGi7yuvAHRVColWaXJFaLUAfMBG94+DhfrQ0axpgMJ\n\tQWFkmdji9ccRut2NLwSn3nVFuHRE3w==","X-Google-Smtp-Source":"ADKCNb65C7Yc104d/Ys0V80fmVA5CYXkh4fbpHKyi+PKqtjGsyZa+AQ56mkInsFpv8sD1Sq6gSZ2Ib3VevDB7aBH460=","X-Received":"by 10.36.227.143 with SMTP id d137mr1531537ith.168.1504741028065;\n\tWed, 06 Sep 2017 16:37:08 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>","References":"<20170905.214143.826912481689443792.davem@davemloft.net>\n\t<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>","From":"Linus Torvalds <torvalds@linux-foundation.org>","Date":"Wed, 6 Sep 2017 16:37:07 -0700","X-Google-Sender-Auth":"SyiD0xpIcaaBxVzQ695k1s4-lJI","Message-ID":"<CA+55aFwzYm5o98ZpbC1hOGfkcbYQaucuqZN6qB1f7_qW2CjVpQ@mail.gmail.com>","Subject":"Re: [GIT] Networking","To":"David Miller <davem@davemloft.net>,\n\tJohannes Berg <johannes.berg@intel.com>,\n\tEmmanuel Grumbach <emmanuel.grumbach@intel.com>,\n\tLuca Coelho <luciano.coelho@intel.com>, Kalle Valo <kvalo@codeaurora.org>","Cc":"Andrew Morton <akpm@linux-foundation.org>,\n\tNetwork Development <netdev@vger.kernel.org>,\n\tLinux Kernel Mailing List <linux-kernel@vger.kernel.org>,\n\tIntel Linux Wireless <linuxwifi@intel.com>,\n\tLinux Wireless List <linux-wireless@vger.kernel.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764493,"web_url":"http://patchwork.ozlabs.org/comment/1764493/","msgid":"<1504757495.5400.89.camel@intel.com>","list_archive_url":null,"date":"2017-09-07T04:11:36","subject":"Re: [GIT] Networking","submitter":{"id":64023,"url":"http://patchwork.ozlabs.org/api/people/64023/","name":"Coelho, Luciano","email":"luciano.coelho@intel.com"},"content":"On Wed, 2017-09-06 at 16:27 -0700, Linus Torvalds wrote:\r\n> This pull request completely breaks Intel wireless for me.\r\n> \r\n> This is my trusty old XPS 13 (9350), using Intel Wireless 8260 (rev 3a).\r\n> \r\n> That remains a very standard Intel machine with absolutely zero odd\r\n> things going on.\r\n> \r\n> The firmware is iwlwifi-8000C-28.ucode from\r\n> iwl7260-firmware-25.30.13.0-75.fc26.noarch, and the kernel reports\r\n> \r\n>   iwlwifi 0000:3a:00.0: loaded firmware version 27.455470.0 op_mode iwlmvm\r\n> \r\n> the thing starts acting badly with this:\r\n> \r\n>   iwlwifi 0000:3a:00.0: FW Error notification: type 0x00000000 cmd_id 0x04\r\n>   iwlwifi 0000:3a:00.0: FW Error notification: seq 0x0000 service 0x00000004\r\n>   iwlwifi 0000:3a:00.0: FW Error notification: timestamp 0x            5D84\r\n>   iwlwifi 0000:3a:00.0: Microcode SW error detected.  Restarting 0x2000000.\r\n>   iwlwifi 0000:3a:00.0: Start IWL Error Log Dump:\r\n>   iwlwifi 0000:3a:00.0: Status: 0x00000100, count: 6\r\n>   iwlwifi 0000:3a:00.0: Loaded firmware version: 27.455470.0\r\n>   iwlwifi 0000:3a:00.0: 0x00000038 | BAD_COMMAND\r\n>   iwlwifi 0000:3a:00.0: 0x00A002F0 | trm_hw_status0\r\n>   ...\r\n>   iwlwifi 0000:3a:00.0: 0x00000000 | isr status reg\r\n>   ieee80211 phy0: Hardware restart was requested\r\n>   iwlwifi 0000:3a:00.0: FW error in SYNC CMD MAC_CONTEXT_CMD\r\n\r\nThis seems to be a problem with backwards-compatibility with FW version\r\n27.  We are now in version 31[1] and upgrading will probably fix that.\r\n\r\nBut obviously the driver should not fail miserably like this with\r\nversion 27, because it claims to support it still.\r\n\r\nI'm looking into this now and will provide a fix asap.\r\n\r\n[1] https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/iwlwifi-8000C-31.ucode\r\n\r\n\r\n--\r\nCheers,\r\nLuca.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnn8V0MDWz9sCZ\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 14:11:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752910AbdIGELm (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 00:11:42 -0400","from mga05.intel.com ([192.55.52.43]:9381 \"EHLO mga05.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750742AbdIGELl (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 7 Sep 2017 00:11:41 -0400","from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga105.fm.intel.com with ESMTP; 06 Sep 2017 21:11:40 -0700","from irsmsx109.ger.corp.intel.com ([163.33.3.23])\n\tby fmsmga004.fm.intel.com with ESMTP; 06 Sep 2017 21:11:39 -0700","from irsmsx155.ger.corp.intel.com (163.33.192.3) by\n\tIRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Thu, 7 Sep 2017 05:11:37 +0100","from irsmsx105.ger.corp.intel.com ([169.254.7.75]) by\n\tirsmsx155.ger.corp.intel.com ([169.254.14.70]) with mapi id\n\t14.03.0319.002; Thu, 7 Sep 2017 05:11:37 +0100"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,356,1500966000\"; d=\"scan'208\";a=\"308894093\"","From":"\"Coelho, Luciano\" <luciano.coelho@intel.com>","To":"\"torvalds@linux-foundation.org\" <torvalds@linux-foundation.org>,\n\t\"davem@davemloft.net\" <davem@davemloft.net>,\n\t\"kvalo@codeaurora.org\" <kvalo@codeaurora.org>,\n\t\"Berg, Johannes\" <johannes.berg@intel.com>,\n\t\"Grumbach, Emmanuel\" <emmanuel.grumbach@intel.com>","CC":"linuxwifi <linuxwifi@intel.com>,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\t\"linux-wireless@vger.kernel.org\" <linux-wireless@vger.kernel.org>,\n\t\"akpm@linux-foundation.org\" <akpm@linux-foundation.org>","Subject":"Re: [GIT] Networking","Thread-Topic":"[GIT] Networking","Thread-Index":"AQHTJ2e1r+p5kKpHi0+CCZ9Rdj3td6KovzaA","Date":"Thu, 7 Sep 2017 04:11:36 +0000","Message-ID":"<1504757495.5400.89.camel@intel.com>","References":"<20170905.214143.826912481689443792.davem@davemloft.net>\n\t<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>","In-Reply-To":"<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.252.30.157]","Content-Type":"text/plain; charset=\"utf-8\"","Content-ID":"<D107796AD8A08B4B9F4D134EDA1582D0@intel.com>","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764499,"web_url":"http://patchwork.ozlabs.org/comment/1764499/","msgid":"<CA+55aFzECjnpFWo_ZfbV+vE-5zRst7JfDC0hxnoitCGN0rmE3Q@mail.gmail.com>","list_archive_url":null,"date":"2017-09-07T04:57:48","subject":"Re: [GIT] Networking","submitter":{"id":97,"url":"http://patchwork.ozlabs.org/api/people/97/","name":"Linus Torvalds","email":"torvalds@linux-foundation.org"},"content":"On Wed, Sep 6, 2017 at 9:11 PM, Coelho, Luciano\n<luciano.coelho@intel.com> wrote:\n>\n> This seems to be a problem with backwards-compatibility with FW version\n> 27.  We are now in version 31[1] and upgrading will probably fix that.\n\nI can confirm that fw version 31 works.\n\n> But obviously the driver should not fail miserably like this with\n> version 27, because it claims to support it still.\n\nNot just \"claims to support it\", but if it's what is shipped with a\nfairly recent distro like an up-to-date version of F26, I would really\nhope that the driver can still work with it.\n\n> I'm looking into this now and will provide a fix asap.\n\nThanks,\n\n                  Linus","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"l3EhyuJG\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnp9n2hsXz9s82\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 14:58:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753118AbdIGE5v (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 00:57:51 -0400","from mail-io0-f171.google.com ([209.85.223.171]:35515 \"EHLO\n\tmail-io0-f171.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750742AbdIGE5u (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 7 Sep 2017 00:57:50 -0400","by mail-io0-f171.google.com with SMTP id i14so1652296ioe.2;\n\tWed, 06 Sep 2017 21:57:49 -0700 (PDT)","by 10.107.147.86 with HTTP; Wed, 6 Sep 2017 21:57:48 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=Rbqb8+TjuF+I2ahIPK8atYNPAFm9w9Xqi4U7uNTJGmI=;\n\tb=l3EhyuJGzJXDH6kt7zF8rioMF/hYyfiazjQdGGcC9X5WxvD9cOki3uI43H9whtR4VT\n\t7TT4gQeXu2CqTxj5lRyHMzZlAyKxUr3mdsszM1eolOgKlYB7CnlW/ddl7h8sDn3Kw/zp\n\tlB9GT/re2INFyW+PGvrqoFpPmneyLFFOuwDEYNRk9HX0en5P86QgtjfXRoVIs9m1ayXB\n\t/DvFnQDSGjgkdvtacQlXJ9PwTbqkfRpeS8tgsQiebLXPLp6+Uxm2Rqujs0h/oWz6mLyz\n\tSJw27+mihE9PpR4g7proSSejQwoxFbtJle+HkWcw/RJhxrthT1RlOzxlcA9meScNVbi8\n\tLu8w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=Rbqb8+TjuF+I2ahIPK8atYNPAFm9w9Xqi4U7uNTJGmI=;\n\tb=AnajPbD1WnC9DBJBwgUFRZkLEVkiSFGl784tgNAnkJo9DXqs4senkuPwbrjZVwscK6\n\tiiDGEPl7ufFFn912zjoRET+ri/1oamOzXl9Ga+HGgn1TBxpWORXT/ahS2oUoMfwujp+E\n\tKF8JGXGzrK4IBTX86NLTuxZJ5o9ZpAIxt5ZzWWpO/a2FeWqU/X+Qh4qgJ/FOeFSuvy9Z\n\toRC3kmF4L5MjJ2wNX0n8SWDxobOkRj4MC1QBx9wUpcq6Mz40IC0SotQ0lch2TXI+zqnF\n\t6dRh6prGAeDeqzfjW8KrQU5QboSM52O1X7V4rko139tR6J3RLZm5ECFyId3GY41j0J0U\n\t/wrQ==","X-Gm-Message-State":"AHPjjUhpRGOhW72irdx/d7PPTAygdweZpFzlwqCpe9HYsm4EHOxy15T3\n\tb7y6Gq0hXdkO74RqHkzec47ISOt1hg==","X-Google-Smtp-Source":"AOwi7QB3vVCY3YdmMppkXS16MPlf25dWlF84mCTG7KQYQU6qyIDb7iCvacXXF23uYS636zivvsq82hbeZXk/U5/wuz8=","X-Received":"by 10.107.165.212 with SMTP id\n\to203mr1590641ioe.271.1504760269151; \n\tWed, 06 Sep 2017 21:57:49 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504757495.5400.89.camel@intel.com>","References":"<20170905.214143.826912481689443792.davem@davemloft.net>\n\t<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>\n\t<1504757495.5400.89.camel@intel.com>","From":"Linus Torvalds <torvalds@linux-foundation.org>","Date":"Wed, 6 Sep 2017 21:57:48 -0700","X-Google-Sender-Auth":"vhO02ou7LPAG5-6al9JEadQeOfQ","Message-ID":"<CA+55aFzECjnpFWo_ZfbV+vE-5zRst7JfDC0hxnoitCGN0rmE3Q@mail.gmail.com>","Subject":"Re: [GIT] Networking","To":"\"Coelho, Luciano\" <luciano.coelho@intel.com>","Cc":"\"davem@davemloft.net\" <davem@davemloft.net>,\n\t\"kvalo@codeaurora.org\" <kvalo@codeaurora.org>,\n\t\"Berg, Johannes\" <johannes.berg@intel.com>,\n\t\"Grumbach, Emmanuel\" <emmanuel.grumbach@intel.com>,\n\tlinuxwifi <linuxwifi@intel.com>,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\t\"linux-wireless@vger.kernel.org\" <linux-wireless@vger.kernel.org>,\n\t\"akpm@linux-foundation.org\" <akpm@linux-foundation.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764500,"web_url":"http://patchwork.ozlabs.org/comment/1764500/","msgid":"<1504760688.5400.91.camel@intel.com>","list_archive_url":null,"date":"2017-09-07T05:04:49","subject":"Re: [GIT] Networking","submitter":{"id":64023,"url":"http://patchwork.ozlabs.org/api/people/64023/","name":"Coelho, Luciano","email":"luciano.coelho@intel.com"},"content":"On Wed, 2017-09-06 at 21:57 -0700, Linus Torvalds wrote:\r\n> On Wed, Sep 6, 2017 at 9:11 PM, Coelho, Luciano\r\n> <luciano.coelho@intel.com> wrote:\r\n> > \r\n> > This seems to be a problem with backwards-compatibility with FW version\r\n> > 27.  We are now in version 31[1] and upgrading will probably fix that.\r\n> \r\n> I can confirm that fw version 31 works.\r\n\r\nGreat, so I know for sure that this is a backwards-compatibility issue\r\nwith the FW API.\r\n\r\n\r\n> > But obviously the driver should not fail miserably like this with\r\n> > version 27, because it claims to support it still.\r\n> \r\n> Not just \"claims to support it\", but if it's what is shipped with a\r\n> fairly recent distro like an up-to-date version of F26, I would really\r\n> hope that the driver can still work with it.\r\n\r\nI totally agree, we support a bunch of older versions for that exact\r\nreason.  We just don't really test all the supported versions very\r\noften.  We should probably change that.\r\n\r\nI'll make sure it still works with version 27.\r\n\r\n--\r\nCheers,\r\nLuca.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnpL31T5Mz9s82\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 15:05:15 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752808AbdIGFE4 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 01:04:56 -0400","from mga01.intel.com ([192.55.52.88]:58304 \"EHLO mga01.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750742AbdIGFEz (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 7 Sep 2017 01:04:55 -0400","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Sep 2017 22:04:54 -0700","from irsmsx106.ger.corp.intel.com ([163.33.3.31])\n\tby fmsmga002.fm.intel.com with ESMTP; 06 Sep 2017 22:04:53 -0700","from irsmsx105.ger.corp.intel.com ([169.254.7.75]) by\n\tIRSMSX106.ger.corp.intel.com ([169.254.8.36]) with mapi id\n\t14.03.0319.002; Thu, 7 Sep 2017 06:04:49 +0100"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,356,1500966000\"; d=\"scan'208\";a=\"1215772961\"","From":"\"Coelho, Luciano\" <luciano.coelho@intel.com>","To":"\"torvalds@linux-foundation.org\" <torvalds@linux-foundation.org>","CC":"\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tlinuxwifi <linuxwifi@intel.com>,\n\t\"Berg, Johannes\" <johannes.berg@intel.com>,\n\t\"akpm@linux-foundation.org\" <akpm@linux-foundation.org>,\n\t\"kvalo@codeaurora.org\" <kvalo@codeaurora.org>,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"davem@davemloft.net\" <davem@davemloft.net>,\n\t\"linux-wireless@vger.kernel.org\" <linux-wireless@vger.kernel.org>,\n\t\"Grumbach, Emmanuel\" <emmanuel.grumbach@intel.com>","Subject":"Re: [GIT] Networking","Thread-Topic":"[GIT] Networking","Thread-Index":"AQHTJ2e1r+p5kKpHi0+CCZ9Rdj3td6KovzaAgAAM6gCAAAH1AA==","Date":"Thu, 7 Sep 2017 05:04:49 +0000","Message-ID":"<1504760688.5400.91.camel@intel.com>","References":"<20170905.214143.826912481689443792.davem@davemloft.net>\n\t<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>\n\t<1504757495.5400.89.camel@intel.com>\n\t<CA+55aFzECjnpFWo_ZfbV+vE-5zRst7JfDC0hxnoitCGN0rmE3Q@mail.gmail.com>","In-Reply-To":"<CA+55aFzECjnpFWo_ZfbV+vE-5zRst7JfDC0hxnoitCGN0rmE3Q@mail.gmail.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.252.30.157]","Content-Type":"text/plain; charset=\"utf-8\"","Content-ID":"<68CC818954C9E64192F6272D7C480C10@intel.com>","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764512,"web_url":"http://patchwork.ozlabs.org/comment/1764512/","msgid":"<1504762851.5400.93.camel@coelho.fi>","list_archive_url":null,"date":"2017-09-07T05:40:51","subject":"Re: [GIT] Networking","submitter":{"id":17042,"url":"http://patchwork.ozlabs.org/api/people/17042/","name":"Luca Coelho","email":"luca@coelho.fi"},"content":"On Thu, 2017-09-07 at 05:04 +0000, Coelho, Luciano wrote:\n> On Wed, 2017-09-06 at 21:57 -0700, Linus Torvalds wrote:\n> > On Wed, Sep 6, 2017 at 9:11 PM, Coelho, Luciano\n> > <luciano.coelho@intel.com> wrote:\n> > > \n> > > This seems to be a problem with backwards-compatibility with FW version\n> > > 27.  We are now in version 31[1] and upgrading will probably fix that.\n> > \n> > I can confirm that fw version 31 works.\n> \n> Great, so I know for sure that this is a backwards-compatibility issue\n> with the FW API.\n> \n> \n> > > But obviously the driver should not fail miserably like this with\n> > > version 27, because it claims to support it still.\n> > \n> > Not just \"claims to support it\", but if it's what is shipped with a\n> > fairly recent distro like an up-to-date version of F26, I would really\n> > hope that the driver can still work with it.\n> \n> I totally agree, we support a bunch of older versions for that exact\n> reason.  We just don't really test all the supported versions very\n> often.  We should probably change that.\n> \n> I'll make sure it still works with version 27.\n\nOkay, I found the offending patch:\n\ncommit 7089ae634c50544b29b31faf1a751e8765c8de3b\nAuthor:     Johannes Berg <johannes.berg@intel.com>\nAuthorDate: Wed Jun 28 16:19:49 2017 +0200\nCommit:     Luca Coelho <luciano.coelho@intel.com>\nCommitDate: Wed Aug 9 09:15:32 2017 +0300\n\n    iwlwifi: mvm: use firmware LED command where applicable\n    \n    On devices starting from 8000 series, the host can no longer toggle\n    the LED through the CSR_LED_REG register, but must do it via the\n    firmware instead. Add support for this. Note that this means that\n    the LED cannot be turned on while the firmware is off, so using an\n    arbitrary LED trigger may not work as expected.\n    \n    Fixes: 503ab8c56ca0 (\"iwlwifi: Add 8000 HW family support\")\n    Signed-off-by: Johannes Berg <johannes.berg@intel.com>\n    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>\n\nReverting it solves the problem.  We introduced a new command to control\nthe LED lights and assumed it was available in older FW versions as\nwell, which turned out not to be the case.\n\nThis patch is not very important (unless you really like blinking lights\n-- maybe I'll change my mind when the holidays approach :P). so it is\nfine if you just want to revert it for now.\n\nIn any case, I'll send a patch fixing this problem soon.\n\n\n--\nCheers,\nLuca.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnq7Y523zz9sPm\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 15:41:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753801AbdIGFlC (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 01:41:02 -0400","from paleale.coelho.fi ([176.9.41.70]:48502 \"EHLO\n\tfarmhouse.coelho.fi\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1752775AbdIGFlA (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 7 Sep 2017 01:41:00 -0400","from a91-156-4-241.elisa-laajakaista.fi ([91.156.4.241]\n\thelo=dubbel) by farmhouse.coelho.fi with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)\n\t(envelope-from <luca@coelho.fi>)\n\tid 1dppYa-0002Xp-Nx; Thu, 07 Sep 2017 08:40:54 +0300"],"Message-ID":"<1504762851.5400.93.camel@coelho.fi>","From":"Luca Coelho <luca@coelho.fi>","To":"\"torvalds@linux-foundation.org\" <torvalds@linux-foundation.org>","Cc":"\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tlinuxwifi <linuxwifi@intel.com>,\n\t\"Berg, Johannes\" <johannes.berg@intel.com>,\n\t\"akpm@linux-foundation.org\" <akpm@linux-foundation.org>,\n\t\"kvalo@codeaurora.org\" <kvalo@codeaurora.org>,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"davem@davemloft.net\" <davem@davemloft.net>,\n\t\"linux-wireless@vger.kernel.org\" <linux-wireless@vger.kernel.org>,\n\t\"Grumbach, Emmanuel\" <emmanuel.grumbach@intel.com>","Date":"Thu, 07 Sep 2017 08:40:51 +0300","In-Reply-To":"<1504760688.5400.91.camel@intel.com>","References":"<20170905.214143.826912481689443792.davem@davemloft.net>\n\t<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>\n\t<1504757495.5400.89.camel@intel.com>\n\t<CA+55aFzECjnpFWo_ZfbV+vE-5zRst7JfDC0hxnoitCGN0rmE3Q@mail.gmail.com>\n\t<1504760688.5400.91.camel@intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.22.6-1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","X-SA-Exim-Connect-IP":"91.156.4.241","X-SA-Exim-Mail-From":"luca@coelho.fi","Subject":"Re: [GIT] Networking","X-SA-Exim-Version":"4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)","X-SA-Exim-Scanned":"No (on farmhouse.coelho.fi); Unknown failure","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764513,"web_url":"http://patchwork.ozlabs.org/comment/1764513/","msgid":"<CA+55aFxjHSW7v4Ttu7mGPkxdGpR-WtVoxDT5qtwxUC-Dge5a5A@mail.gmail.com>","list_archive_url":null,"date":"2017-09-07T05:46:39","subject":"Re: [GIT] Networking","submitter":{"id":97,"url":"http://patchwork.ozlabs.org/api/people/97/","name":"Linus Torvalds","email":"torvalds@linux-foundation.org"},"content":"On Wed, Sep 6, 2017 at 10:40 PM, Luca Coelho <luca@coelho.fi> wrote:\n>\n> This patch is not very important (unless you really like blinking lights\n> -- maybe I'll change my mind when the holidays approach :P). so it is\n> fine if you just want to revert it for now.\n>\n> In any case, I'll send a patch fixing this problem soon.\n\nNo need to revert if we can get this fixed quickly enough.\n\nI'll leave the fw-31 on my laptop, so that I can continue to use it for now.\n\nThanks,\n\n               Linus","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IyXB+bGp\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnqG75w7xz9s83\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 15:46:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753468AbdIGFqm (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 01:46:42 -0400","from mail-it0-f42.google.com ([209.85.214.42]:37615 \"EHLO\n\tmail-it0-f42.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752146AbdIGFqk (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 7 Sep 2017 01:46:40 -0400","by mail-it0-f42.google.com with SMTP id o200so1633911itg.0;\n\tWed, 06 Sep 2017 22:46:40 -0700 (PDT)","by 10.107.147.86 with HTTP; Wed, 6 Sep 2017 22:46:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=AYHWa5NiSBjfOWBsxPIL0qUvr8ZXetppFy1hsFkuXVE=;\n\tb=IyXB+bGpVeB06MzbBjrQemCy/9Iao6IkepUQnvcPyHZTMlJISclh4XEiZ+/IPQWSO3\n\tPx1absVzhyv3EDUKwnVoomBmAIpftIghgKpnIFhKpBUL3sGwDScUwHFe/2Cfm7q9Z6lf\n\tAEKrddAWqOP6jKsH//UK0hC4M0TnGAYvCL3amwZ8+WeyeLOW3nwB8OeXwM9/p5OsvlKB\n\tQnXP4U8J+UySUOs6O7IX+df/No+BZpvivLQOmC1PMZlcTU7GUwqi/2nEGKYUIlU86LFJ\n\t5OxbisnkiXZNIGha5Ujpf2kE+x1MSPU2jOiRrmYqWievVjDS0/+CWC8VMhCfRCJxW8sX\n\tj87Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=AYHWa5NiSBjfOWBsxPIL0qUvr8ZXetppFy1hsFkuXVE=;\n\tb=tj5DY6ZPbKCk74Req5nvqyCteBCx1hDS5IIZYXOLBS4Sr9PUBoxjpPPlHrUSsydbbh\n\tX1jeklOSBi+8yLOQ9WrjhJKPuq5aJTLAWLZ/Hb4e7OEXJJuWpD9iGuGf16WbjFHsxoR3\n\tEwtupkFBeL0WRBvAxMAhI1s9VgrUyuuutIrZBr7GhNwM3T3WrVlkePotDCXaTMruev39\n\t06t7xAXCCSI1WPdTrRQ7Dg4QZpjkNasdOEdGxC7laodkoiEQLzGOdEPWVaxrS1q8LIdG\n\tjmJgjWt+LDRh6cpYl0cPmyyrCdI4y087B+jZ/FQpCS2LCh7Hbnd5Aa/ulwag8vh9lFOV\n\tpvsA==","X-Gm-Message-State":"AHPjjUg6P+o3e0cRi+D6QujBDu3U0cn8THaXHD6/wewHeHMJEIvx3DOX\n\tLmRA+n5Nw1xzKN3hKCU1TutWYkLU1w==","X-Google-Smtp-Source":"ADKCNb5NkV6x6NscHQyfWlz5GpvdEMLtPmJEJgYgaXTOWRPmVCY3x6/uG+u1RSZ+1Gic6RIFvMLFMCdilEBPjPbeRB8=","X-Received":"by 10.36.227.143 with SMTP id d137mr2286439ith.168.1504763199931;\n\tWed, 06 Sep 2017 22:46:39 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504762851.5400.93.camel@coelho.fi>","References":"<20170905.214143.826912481689443792.davem@davemloft.net>\n\t<CA+55aFw0KNTKFrRHk5hthDGTGgL9BGt9G=x_m9Tz7m_-pN+NoA@mail.gmail.com>\n\t<1504757495.5400.89.camel@intel.com>\n\t<CA+55aFzECjnpFWo_ZfbV+vE-5zRst7JfDC0hxnoitCGN0rmE3Q@mail.gmail.com>\n\t<1504760688.5400.91.camel@intel.com>\n\t<1504762851.5400.93.camel@coelho.fi>","From":"Linus Torvalds <torvalds@linux-foundation.org>","Date":"Wed, 6 Sep 2017 22:46:39 -0700","X-Google-Sender-Auth":"5kjebnwhukt7P-sAb7DLKvsjaY8","Message-ID":"<CA+55aFxjHSW7v4Ttu7mGPkxdGpR-WtVoxDT5qtwxUC-Dge5a5A@mail.gmail.com>","Subject":"Re: [GIT] Networking","To":"Luca Coelho <luca@coelho.fi>","Cc":"\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tlinuxwifi <linuxwifi@intel.com>,\n\t\"Berg, Johannes\" <johannes.berg@intel.com>,\n\t\"akpm@linux-foundation.org\" <akpm@linux-foundation.org>,\n\t\"kvalo@codeaurora.org\" <kvalo@codeaurora.org>,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"davem@davemloft.net\" <davem@davemloft.net>,\n\t\"linux-wireless@vger.kernel.org\" <linux-wireless@vger.kernel.org>,\n\t\"Grumbach, Emmanuel\" <emmanuel.grumbach@intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]