[{"id":1765330,"web_url":"http://patchwork.ozlabs.org/comment/1765330/","msgid":"<20170908130633.acqrwpgtvb5osvdc@ubuntu-hedt>","list_archive_url":null,"date":"2017-09-08T13:06:33","subject":"ACK: [PATCH 1/1] [SRU Xenial/Zesty] Input: trackpoint - assume 3\n\tbuttons when buttons detection fails","submitter":{"id":6957,"url":"http://patchwork.ozlabs.org/api/people/6957/","name":"Seth Forshee","email":"seth.forshee@canonical.com"},"content":"On Wed, Sep 06, 2017 at 12:29:35PM +0800, Aaron Ma wrote:\n> From: Oscar Campos \n> \n> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1715271\n> \n> Trackpoint buttons detection fails on ThinkPad 570 and 470 series,\n> this makes the middle button of the trackpoint to not being recogized.\n> As I don't believe there is any trackpoint with less than 3 buttons this\n> patch just assumes three buttons when the extended button information\n> read fails.\n> \n> Signed-off-by: Oscar Campos \n> Acked-by: Peter Hutterer \n> Signed-off-by: Dmitry Torokhov \n> (backported from commit 293b915fd9bebf33cdc906516fb28d54649a25ac)\n> Signed-off-by: Aaron Ma \n\nSimple patch, backport from upstream looks good.\n\nAcked-by: Seth Forshee ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpcz46f1Jz9ryk;\n\tFri, 8 Sep 2017 23:06:40 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dqIzV-0007zU-Ma; Fri, 08 Sep 2017 13:06:37 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dqIzU-0007zD-MJ\n\tfor kernel-team@lists.ubuntu.com; Fri, 08 Sep 2017 13:06:36 +0000","from mail-it0-f72.google.com ([209.85.214.72])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dqIzU-0003eF-Bu\n\tfor kernel-team@lists.ubuntu.com; Fri, 08 Sep 2017 13:06:36 +0000","by mail-it0-f72.google.com with SMTP id f64so2801047itf.4\n\tfor ;\n\tFri, 08 Sep 2017 06:06:36 -0700 (PDT)","from localhost ([2605:a601:aa7:8920:cd91:46c8:eacd:8f61])\n\tby smtp.gmail.com with ESMTPSA id\n\te79sm984068iof.13.2017.09.08.06.06.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 08 Sep 2017 06:06:34 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=ehcDvm7NNwL96axfDx37km++dSPBIyBXwDUBf1KO5Kk=;\n\tb=cftyjuvrQvIc/Z8AVs68hXDI0T30ilvsaUGz7GNwzqmyg1Ul0V789W/ZiVWMkjG7iw\n\tWfHwvxE5Qd3Tt0vjsvI2sQQjhXREH2NxcLGXnPJCKJPvnzcvMZ3qEgm/AzmHSCctoZo/\n\t8EZFlxSy1ukVvNZq9a3zmmgQbZughd2kkL+XWrECWw/odD/Fz2wH2aN1Tw7QmhSqwagd\n\tgLtThRZUPY1+vinXvNhBHdy7eyvYo0aDi21fI3xLWDKeuo6fq/qKUKAus/AtrCV22vC/\n\tXY2l7xR+t85m5oBf50ZlXMd3+stfcw5G2QQbQr05YXSb6N7aZWcaXcmP5e3xSUjvS7LU\n\tUgOA==","X-Gm-Message-State":"AHPjjUiT0J1B7jV3wDnx1cY0RhzrRrBxZkBdF0JLzYRdvVpeOBJNFpH4\n\tH5g1f/T+rgwzTLg18MQG/iNZYrSaB59YiRbdDB0FfpgUbsYMkqcfVhM+3zfON6rFHZVP9dW4Uu7\n\teyyWZ/SJ1pjjCakr8juAD8tHcT58DH36X","X-Received":["by 10.36.92.10 with SMTP id q10mr913125itb.145.1504875995378;\n\tFri, 08 Sep 2017 06:06:35 -0700 (PDT)","by 10.36.92.10 with SMTP id q10mr913101itb.145.1504875995095;\n\tFri, 08 Sep 2017 06:06:35 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb7PEvKW3TyfXR1ntRgketAKklj/WGrfxvPMYPjFzyXV6W+nhYMWbYvorQnQ7gSZWY1TRYzL/g==","Date":"Fri, 8 Sep 2017 08:06:33 -0500","From":"Seth Forshee ","To":"Aaron Ma ","Subject":"ACK: [PATCH 1/1] [SRU Xenial/Zesty] Input: trackpoint - assume 3\n\tbuttons when buttons detection fails","Message-ID":"<20170908130633.acqrwpgtvb5osvdc@ubuntu-hedt>","References":"<20170906042935.23586-1-aaron.ma@canonical.com>\n\t<20170906042935.23586-3-aaron.ma@canonical.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170906042935.23586-3-aaron.ma@canonical.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel-team@lists.ubuntu.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1769178,"web_url":"http://patchwork.ozlabs.org/comment/1769178/","msgid":"<86f3136a-282a-7085-7a40-f40fe5e4f40b@canonical.com>","list_archive_url":null,"date":"2017-09-15T13:19:38","subject":"APPLIED X/Z: [PATCH 1/1] [SRU Xenial/Zesty] Input: trackpoint -\n\tassume 3 buttons when buttons detection fails","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 06.09.2017 06:29, Aaron Ma wrote:\n> From: Oscar Campos \n> \n> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1715271\n> \n> Trackpoint buttons detection fails on ThinkPad 570 and 470 series,\n> this makes the middle button of the trackpoint to not being recogized.\n> As I don't believe there is any trackpoint with less than 3 buttons this\n> patch just assumes three buttons when the extended button information\n> read fails.\n> \n> Signed-off-by: Oscar Campos \n> Acked-by: Peter Hutterer \n> Signed-off-by: Dmitry Torokhov \n> (backported from commit 293b915fd9bebf33cdc906516fb28d54649a25ac)\n> Signed-off-by: Aaron Ma \n> ---\n> drivers/input/mouse/trackpoint.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c\n> index 354d47ecd66a..83a919f9cd4e 100644\n> --- a/drivers/input/mouse/trackpoint.c\n> +++ b/drivers/input/mouse/trackpoint.c\n> @@ -380,8 +380,8 @@ int trackpoint_detect(struct psmouse *psmouse, bool set_properties)\n> \t\treturn 0;\n> \n> \tif (trackpoint_read(&psmouse->ps2dev, TP_EXT_BTN, &button_info)) {\n> -\t\tpsmouse_warn(psmouse, \"failed to get extended button data\\n\");\n> -\t\tbutton_info = 0;\n> +\t\tpsmouse_warn(psmouse, \"failed to get extended button data, assuming 3 buttons\\n\");\n> +\t\tbutton_info = 0x33;\n> \t}\n> \n> \tpsmouse->private = kzalloc(sizeof(struct trackpoint_data), GFP_KERNEL);\n> \nApplied to Xenial and Zesty master-next","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtwww6wwcz9s7M;\n\tFri, 15 Sep 2017 23:19:44 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dsqWy-00051T-Ms; Fri, 15 Sep 2017 13:19:40 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dsqWx-00050d-AK\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 13:19:39 +0000","from 1.general.smb.uk.vpn ([10.172.193.28])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dsqWx-0004OY-2S\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 13:19:39 +0000"],"Subject":"APPLIED X/Z: [PATCH 1/1] [SRU Xenial/Zesty] Input: trackpoint -\n\tassume 3 buttons when buttons detection fails","To":"kernel-team@lists.ubuntu.com","References":"<20170906042935.23586-1-aaron.ma@canonical.com>\n\t<20170906042935.23586-3-aaron.ma@canonical.com>","From":"Stefan Bader ","Message-ID":"<86f3136a-282a-7085-7a40-f40fe5e4f40b@canonical.com>","Date":"Fri, 15 Sep 2017 15:19:38 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170906042935.23586-3-aaron.ma@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============0504644574043776164==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]