[{"id":1767052,"web_url":"http://patchwork.ozlabs.org/comment/1767052/","msgid":"","list_archive_url":null,"date":"2017-09-12T13:30:47","subject":"Re: [U-Boot] [PATCH v3 1/6] board_f: Drop the timer after relocation","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"On Wed, Sep 6, 2017 at 9:49 AM, Simon Glass wrote:\n> Once U-Boot relocates itself the existing driver-model timer (if any) is\n> no-longer valid until the device is reinitialised. Any use of the device\n> may cause a crash. To handle this, set the timer to NULL after relocation.\n>\n> Signed-off-by: Simon Glass \n> ---\n>\n> Changes in v3:\n> - Bracket access to gd->timer with an #ifdef\n>\n> Changes in v2: None\n>\n> common/board_f.c | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n\nReviewed-by: Bin Meng ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"riLD/1OZ\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs5TN06Fcz9s4s\n\tfor ;\n\tTue, 12 Sep 2017 23:37:59 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid ADF97C221A6; Tue, 12 Sep 2017 13:33:31 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 42EA7C220D8;\n\tTue, 12 Sep 2017 13:33:02 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 3EFB2C220FD; Tue, 12 Sep 2017 13:30:52 +0000 (UTC)","from mail-wr0-f194.google.com (mail-wr0-f194.google.com\n\t[209.85.128.194])\n\tby lists.denx.de (Postfix) with ESMTPS id 09C8EC21ED4\n\tfor ; Tue, 12 Sep 2017 13:30:49 +0000 (UTC)","by mail-wr0-f194.google.com with SMTP id k20so6175954wre.1\n\tfor ; Tue, 12 Sep 2017 06:30:49 -0700 (PDT)","by 10.223.135.121 with HTTP; Tue, 12 Sep 2017 06:30:47 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=ltwYTtotP/AjBhLjl+4avkPuM1JBJ1UePntmRmmYozk=;\n\tb=riLD/1OZPcOXqdy4e6OmLH2BXIm61VKuq4zujZCa+BmEeyEeVIZjtSA7IZWJScWNlC\n\txqCuS8nRLjrYtFFuR6RqmPSBpCpVT/TMkDLw4/2LCvaWlsMBkU09fKCVcbVSZBQub4Ya\n\tT40wfSg4OAs7UmbL+Rg7CD83aTDoEYCPzbgc54al/1mT5M0Uy4ogHL200rI4PwBqNnjm\n\ttDRiQTPVCehbAe9LY5mhmrJgj8PZBwm7EUbPMiHmRdMJRpp3fdI0EoLRfhcbywrFCR/5\n\tnTERrYXqdZU6ILsPgwBAtp7YexuAGhKorrx/xCC16682RFyLHZsZrU1fyRdjJS05W8Aq\n\tIwKg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ltwYTtotP/AjBhLjl+4avkPuM1JBJ1UePntmRmmYozk=;\n\tb=GIYFynbHZsxl798Zc79JUqBuePSLjxuTKnuXMfjxdla4Cnbwo3exO3CfmkKjqmksav\n\tfhg+i+IYUYIoq4rctK0oJ2GcasypVIy7aCyHhtorNSdPTFPS39m/G7su1bNP7hxJd6Gv\n\trQJrqmNy/iTgQNm3mPlB0LzRpctTmSV321h4+FfrzGrL1UrcoebwP6JZt5gkAhnghDy5\n\tyuPm0SM+biORxJ4pktixm2Lo+KwpJbqLWOMgOhCoKiRgGYl6G2jKTEYOGDroz+6x6pWb\n\tgFDk4QTfRFN9swVOysEfCgHapP4SlQ2Td9omPOlBDavFLw7InsTN1f+KIJrE2GE1sNci\n\t8oNw==","X-Gm-Message-State":"AHPjjUjB4pL9TCOm0w7AOF6Nw7+gn1VLyfLe64lug+hA5SsPZ2+MFHY9\n\tj3goGwZYXBXw8wFUquhuLUxmusQj+vRF","X-Google-Smtp-Source":"ADKCNb7eEDitB/ADhmpw77ngeO+MZ1tiYmOLyZ5JyL3BbQwK3IdRskqXjK44TAfFIoPIDyxDN/E8047s5X9VUOr+QlU=","X-Received":"by 10.223.166.196 with SMTP id\n\tt62mr11899958wrc.251.1505223048203; \n\tTue, 12 Sep 2017 06:30:48 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170906014950.132960-2-sjg@chromium.org>","References":"<20170906014950.132960-1-sjg@chromium.org>\n\t<20170906014950.132960-2-sjg@chromium.org>","From":"Bin Meng ","Date":"Tue, 12 Sep 2017 21:30:47 +0800","Message-ID":"","To":"Simon Glass ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v3 1/6] board_f: Drop the timer after relocation","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769564,"web_url":"http://patchwork.ozlabs.org/comment/1769564/","msgid":"","list_archive_url":null,"date":"2017-09-16T06:29:10","subject":"Re: [U-Boot] [PATCH v3 1/6] board_f: Drop the timer after relocation","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"On Tue, Sep 12, 2017 at 9:30 PM, Bin Meng wrote:\n> On Wed, Sep 6, 2017 at 9:49 AM, Simon Glass wrote:\n>> Once U-Boot relocates itself the existing driver-model timer (if any) is\n>> no-longer valid until the device is reinitialised. Any use of the device\n>> may cause a crash. To handle this, set the timer to NULL after relocation.\n>>\n>> Signed-off-by: Simon Glass \n>> ---\n>>\n>> Changes in v3:\n>> - Bracket access to gd->timer with an #ifdef\n>>\n>> Changes in v2: None\n>>\n>> common/board_f.c | 3 +++\n>> 1 file changed, 3 insertions(+)\n>>\n>\n> Reviewed-by: Bin Meng \n\napplied to u-boot-x86, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"dFwgW+uy\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvMmz001yz9t2c\n\tfor ;\n\tSat, 16 Sep 2017 16:29:21 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 62044C21F5B; Sat, 16 Sep 2017 06:29:15 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 19357C21DA4;\n\tSat, 16 Sep 2017 06:29:13 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid E7F6EC21DA4; Sat, 16 Sep 2017 06:29:11 +0000 (UTC)","from mail-wr0-f195.google.com (mail-wr0-f195.google.com\n\t[209.85.128.195])\n\tby lists.denx.de (Postfix) with ESMTPS id 8ED39C21C8F\n\tfor ; Sat, 16 Sep 2017 06:29:11 +0000 (UTC)","by mail-wr0-f195.google.com with SMTP id p37so2282338wrb.5\n\tfor ; Fri, 15 Sep 2017 23:29:11 -0700 (PDT)","by 10.223.145.3 with HTTP; Fri, 15 Sep 2017 23:29:10 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=jjUxdoYSwTTb4n4LNg6We2C2gdG61PBjUrOhp1HVdhc=;\n\tb=dFwgW+uysvdVvheNmaMFg6DKxryssXXx4bW0OXwnZW5f91pAVS7AC66o/PC7oGN8Ck\n\tBbaz5LHqjTfKpLbs/U0roMumcYjMzFnRT4WMEY2Z9Zx0njUK0Y4HhqJ1wEGlarjk3u0W\n\tiFezwNQpM621ZHKY+Qi+iAVy6FK+G5fJeemZnJESzDP5ZGm0Hr/YkYZA0uJoDSIjb2lL\n\tFcfTwqpXwHfFIEzXeiH/1Rq08oLyWGicuBJB0elayEf07RQLb4VSX+X2BTQlEYvV8cEP\n\tfz11eN8KXy4+fM71GWnbn39+dI1BhnT3BaJXbSH7sAer5oJSy4EbADqFs33I/+6W+tUF\n\tY0bw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=jjUxdoYSwTTb4n4LNg6We2C2gdG61PBjUrOhp1HVdhc=;\n\tb=LHeXgJPke0MQpvy63W/+P0AGbkE19+dUl3EEAWudevz32SvJBWV76I7Uiq5muFhKqt\n\tc3TmqO6Eu0B7C9AvFP8+j8brBs1nu/UFaLAa1cjlBKTB5sgg3fCqL86xZlh++c7AEeTP\n\tjJI5C8QO7kKCG/MPhMLfO6zfGMbXSejIlhsw+fE/So+mgmIxbeC0qknZWmnRR01GnrZG\n\tmMP7sC6wj8d+fXHVSEFNAV/R3MLg4Z3azeX9g9Me9y2Cf4erfZ4+DpyUm+r6UbP4g6yM\n\t0OyqHkYMdOAHbgPCuhI4CkA7ohBm107nKclCMzhZkHeco3H3bHo+FIn+bcddVRpabtM4\n\tVbkA==","X-Gm-Message-State":"AHPjjUgoPtC8PL1u8JoLr8cncaYm0XZjPNGx5rokNweMls44C/iCNUs9\n\tqEuBs3AdOUI3H7rxtoGG5090ZMuqRQCRW5PWhKk=","X-Google-Smtp-Source":"ADKCNb4yPYK2KfFkUZWF5w+psbEsgIvF7THiCuK4ZMv4D0C/45P8abiBPxdy2XNM9rW0qnrpfF6eYNdo5UcBGiSEI3A=","X-Received":"by 10.223.176.46 with SMTP id f43mr23811919wra.206.1505543351127;\n\tFri, 15 Sep 2017 23:29:11 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170906014950.132960-1-sjg@chromium.org>\n\t<20170906014950.132960-2-sjg@chromium.org>\n\t","From":"Bin Meng ","Date":"Sat, 16 Sep 2017 14:29:10 +0800","Message-ID":"","To":"Simon Glass ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v3 1/6] board_f: Drop the timer after relocation","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]