[{"id":1765084,"web_url":"http://patchwork.ozlabs.org/comment/1765084/","msgid":"<201709081331.hWxY6OJ5%fengguang.wu@intel.com>","date":"2017-09-08T05:38:47","subject":"Re: [PATCH v2 1/2] powerpc/npu: Use flush_all_mm() instead of\n\tflush_tlb_mm()","submitter":{"id":67315,"url":"http://patchwork.ozlabs.org/api/people/67315/","name":"kernel test robot","email":"lkp@intel.com"},"content":"Hi Alistair,\n\n[auto build test ERROR on powerpc/next]\n[also build test ERROR on next-20170907]\n[cannot apply to v4.13]\n[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]\n\nurl: https://github.com/0day-ci/linux/commits/Alistair-Popple/powerpc-npu-Use-flush_all_mm-instead-of-flush_tlb_mm/20170908-080828\nbase: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next\nconfig: powerpc-allmodconfig (attached as .config)\ncompiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705\nreproduce:\n wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross\n chmod +x ~/bin/make.cross\n # save the attached .config to linux build tree\n make.cross ARCH=powerpc \n\nAll errors (new ones prefixed by >>):\n\n arch/powerpc/platforms/powernv/npu-dma.c: In function 'mmio_invalidate':\n>> arch/powerpc/platforms/powernv/npu-dma.c:552:2: error: implicit declaration of function 'flush_all_mm' [-Werror=implicit-function-declaration]\n flush_all_mm(npu_context->mm);\n ^~~~~~~~~~~~\n cc1: some warnings being treated as errors\n\nvim +/flush_all_mm +552 arch/powerpc/platforms/powernv/npu-dma.c\n\n 533\t\n 534\t/*\n 535\t * Invalidate either a single address or an entire PID depending on\n 536\t * the value of va.\n 537\t */\n 538\tstatic void mmio_invalidate(struct npu_context *npu_context, int va,\n 539\t\t\t\tunsigned long address, bool flush)\n 540\t{\n 541\t\tint i, j;\n 542\t\tstruct npu *npu;\n 543\t\tstruct pnv_phb *nphb;\n 544\t\tstruct pci_dev *npdev;\n 545\t\tstruct mmio_atsd_reg mmio_atsd_reg[NV_MAX_NPUS];\n 546\t\tunsigned long pid = npu_context->mm->context.id;\n 547\t\n 548\t\t/*\n 549\t\t * Unfortunately the nest mmu does not support flushing specific\n 550\t\t * addresses so we have to flush the whole mm.\n 551\t\t */\n > 552\t\tflush_all_mm(npu_context->mm);\n 553\t\n 554\t\t/*\n 555\t\t * Loop over all the NPUs this process is active on and launch\n 556\t\t * an invalidate.\n 557\t\t */\n 558\t\tfor (i = 0; i <= max_npu2_index; i++) {\n 559\t\t\tmmio_atsd_reg[i].reg = -1;\n 560\t\t\tfor (j = 0; j < NV_MAX_LINKS; j++) {\n 561\t\t\t\tnpdev = npu_context->npdev[i][j];\n 562\t\t\t\tif (!npdev)\n 563\t\t\t\t\tcontinue;\n 564\t\n 565\t\t\t\tnphb = pci_bus_to_host(npdev->bus)->private_data;\n 566\t\t\t\tnpu = &nphb->npu;\n 567\t\t\t\tmmio_atsd_reg[i].npu = npu;\n 568\t\n 569\t\t\t\tif (va)\n 570\t\t\t\t\tmmio_atsd_reg[i].reg =\n 571\t\t\t\t\t\tmmio_invalidate_va(npu, address, pid,\n 572\t\t\t\t\t\t\t\tflush);\n 573\t\t\t\telse\n 574\t\t\t\t\tmmio_atsd_reg[i].reg =\n 575\t\t\t\t\t\tmmio_invalidate_pid(npu, pid, flush);\n 576\t\n 577\t\t\t\t/*\n 578\t\t\t\t * The NPU hardware forwards the shootdown to all GPUs\n 579\t\t\t\t * so we only have to launch one shootdown per NPU.\n 580\t\t\t\t */\n 581\t\t\t\tbreak;\n 582\t\t\t}\n 583\t\t}\n 584\t\n 585\t\tmmio_invalidate_wait(mmio_atsd_reg, flush);\n 586\t\tif (flush)\n 587\t\t\t/* Wait for the flush to complete */\n 588\t\t\tmmio_invalidate_wait(mmio_atsd_reg, false);\n 589\t}\n 590\t\n\n---\n0-DAY kernel test infrastructure Open Source Technology Center\nhttps://lists.01.org/pipermail/kbuild-all Intel Corporation","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpR4h1cQRz9sCZ\n\tfor ;\n\tFri, 8 Sep 2017 15:40:52 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xpR4h0ZHqzDrYg\n\tfor ;\n\tFri, 8 Sep 2017 15:40:52 +1000 (AEST)","from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xpR3J6nRCzDrVk\n\tfor ;\n\tFri, 8 Sep 2017 15:39:40 +1000 (AEST)","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP; 07 Sep 2017 22:39:37 -0700","from bee.sh.intel.com (HELO bee) ([10.239.97.14])\n\tby FMSMGA003.fm.intel.com with ESMTP; 07 Sep 2017 22:39:35 -0700","from kbuild by bee with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dqC5k-000BD9-Be; Fri, 08 Sep 2017 13:44:36 +0800"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=intel.com\n\t(client-ip=134.134.136.31; helo=mga06.intel.com;\n\tenvelope-from=fengguang.wu@intel.com; receiver=)","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,360,1500966000\"; \n\td=\"gz'50?scan'50,208,50\";a=\"898275824\"","Date":"Fri, 8 Sep 2017 13:38:47 +0800","From":"kbuild test robot ","To":"Alistair Popple ","Subject":"Re: [PATCH v2 1/2] powerpc/npu: Use flush_all_mm() instead of\n\tflush_tlb_mm()","Message-ID":"<201709081331.hWxY6OJ5%fengguang.wu@intel.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"bg08WKrSYDhXBjb5\"","Content-Disposition":"inline","In-Reply-To":"<1504662540-27527-1-git-send-email-alistair@popple.id.au>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-SA-Exim-Connect-IP":"","X-SA-Exim-Mail-From":"fengguang.wu@intel.com","X-SA-Exim-Scanned":"No (on bee); SAEximRunCond expanded to false","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alistair Popple , arbab@linux.vnet.ibm.com,\n\tfbarrat@linux.vnet.ibm.com, andrew.donnellan@au1.ibm.com,\n\tlinuxppc-dev@lists.ozlabs.org, kbuild-all@01.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1804242,"web_url":"http://patchwork.ozlabs.org/comment/1804242/","msgid":"<3yblFt3LDkz9t2Q@ozlabs.org>","date":"2017-11-14T11:12:02","subject":"Re: [v2,\n\t1/2] powerpc/npu: Use flush_all_mm() instead of flush_tlb_mm()","submitter":{"id":69509,"url":"http://patchwork.ozlabs.org/api/people/69509/","name":"Michael Ellerman","email":"patch-notifications@ellerman.id.au"},"content":"On Wed, 2017-09-06 at 01:48:59 UTC, Alistair Popple wrote:\n> With the optimisations introduced by commit a46cc7a908 (\"powerpc/mm/radix:\n> Improve TLB/PWC flushes\"), flush_tlb_mm() no longer flushes the page walk\n> cache with radix. Switch to using flush_all_mm() to ensure the pwc and tlb\n> are properly flushed on the nmmu.\n> \n> Signed-off-by: Alistair Popple \n\nSeries applied to powerpc next, thanks.\n\nhttps://git.kernel.org/powerpc/c/2a31ad093bb1b8c1f1e04cbe222ad1\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yblRz7303z9s5L\n\tfor ;\n\tTue, 14 Nov 2017 22:20:47 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yblRz6GWjzDrLn\n\tfor ;\n\tTue, 14 Nov 2017 22:20:47 +1100 (AEDT)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yblFt5rhzzDqpR\n\tfor ;\n\tTue, 14 Nov 2017 22:12:02 +1100 (AEDT)","by ozlabs.org (Postfix, from userid 1034)\n\tid 3yblFt3LDkz9t2Q; Tue, 14 Nov 2017 22:12:02 +1100 (AEDT)"],"X-powerpc-patch-notification":"thanks","X-powerpc-patch-commit":"2a31ad093bb1b8c1f1e04cbe222ad17bc09c4534","In-Reply-To":"<1504662540-27527-1-git-send-email-alistair@popple.id.au>","To":"Alistair Popple , linuxppc-dev@lists.ozlabs.org","From":"Michael Ellerman ","Subject":"Re: [v2,\n\t1/2] powerpc/npu: Use flush_all_mm() instead of flush_tlb_mm()","Message-Id":"<3yblFt3LDkz9t2Q@ozlabs.org>","Date":"Tue, 14 Nov 2017 22:12:02 +1100 (AEDT)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alistair Popple , fbarrat@linux.vnet.ibm.com,\n\tarbab@linux.vnet.ibm.com, andrew.donnellan@au1.ibm.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]